Page MenuHomePhabricator
Feed All Stories

Nov 5 2024

PiRK updated the diff for D17037: [chronik] index scripts by scripthashes in the mempool.

rebase

Nov 5 2024, 13:16
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Nov 5 2024, 10:01
PiRK accepted D17076: [avalanche] Fix the getavaaddr functional test.
Nov 5 2024, 09:57
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Nov 5 2024, 09:24
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Nov 5 2024, 08:58
Fabien updated the diff for D17071: [avalanche] Cleanup the logs.

Make sure the spam is processed after sending, otherwise it can be processed after the mocktime is increased and cause the getavaaddr test to fail.

Nov 5 2024, 08:30
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Love token.
Nov 5 2024, 08:16
emack accepted D17072: [ecash-agora] Update linter settings for monorepo consistency.
Nov 5 2024, 06:24
bytesofman updated the diff for D17072: [ecash-agora] Update linter settings for monorepo consistency.

fix lingering eslint error

Nov 5 2024, 04:38
emack requested changes to D17072: [ecash-agora] Update linter settings for monorepo consistency.
Nov 5 2024, 04:18
roqqit closed D17075: [avalanche] Only allow contender cache cleanup up to the height of the last promoted block.
Nov 5 2024, 00:05
roqqit committed rABCa66b32711df2: [avalanche] Only allow contender cache cleanup up to the height of the last… (authored by roqqit).
[avalanche] Only allow contender cache cleanup up to the height of the last…
Nov 5 2024, 00:05

Nov 4 2024

roqqit updated the diff for D17075: [avalanche] Only allow contender cache cleanup up to the height of the last promoted block.

Fix style nit

Nov 4 2024, 21:47
teamcity added a comment to D17071: [avalanche] Cleanup the logs.
Nov 4 2024, 21:34
teamcity added a comment to D17071: [avalanche] Cleanup the logs.
Nov 4 2024, 21:30
Fabien accepted D17075: [avalanche] Only allow contender cache cleanup up to the height of the last promoted block.
Nov 4 2024, 21:26
Fabien updated the summary of D17071: [avalanche] Cleanup the logs.
Nov 4 2024, 21:15
Fabien updated the diff for D17071: [avalanche] Cleanup the logs.

Rebase on top of D17076 to fix the test

Nov 4 2024, 21:15
Fabien updated the diff for D17076: [avalanche] Fix the getavaaddr functional test.

Uncomment tests

Nov 4 2024, 21:11
Fabien planned changes to D17076: [avalanche] Fix the getavaaddr functional test.
Nov 4 2024, 21:09
Fabien requested review of D17076: [avalanche] Fix the getavaaddr functional test.
Nov 4 2024, 21:08
roqqit requested review of D17075: [avalanche] Only allow contender cache cleanup up to the height of the last promoted block.
Nov 4 2024, 20:35
Fabien added a comment to D17071: [avalanche] Cleanup the logs.

I will split out the test fix

Nov 4 2024, 19:28
Fabien closed D17068: [avalanche] Always print the finalization messages.
Nov 4 2024, 19:26
Fabien committed rABC5e91e0989f8b: [avalanche] Always print the finalization messages (authored by Fabien).
[avalanche] Always print the finalization messages
Nov 4 2024, 19:26
bytesofman published D17072: [ecash-agora] Update linter settings for monorepo consistency for review.
Nov 4 2024, 19:01
roqqit accepted D17068: [avalanche] Always print the finalization messages.
Nov 4 2024, 17:41
bytesofman closed D17063: [Cashtab] Patch bug in manage agora offers.
Nov 4 2024, 17:24
bytesofman committed rABC5b9ca8ccad18: [Cashtab] Patch bug in manage agora offers (authored by bytesofman).
[Cashtab] Patch bug in manage agora offers
Nov 4 2024, 17:24
roqqit requested changes to D17071: [avalanche] Cleanup the logs.

Back to you for the test failure

Nov 4 2024, 17:21
roqqit accepted D17071: [avalanche] Cleanup the logs.
Nov 4 2024, 17:20
teamcity added a comment to D17071: [avalanche] Cleanup the logs.
Nov 4 2024, 17:14
Fabien requested review of D17071: [avalanche] Cleanup the logs.
Nov 4 2024, 16:35
bytesofman closed D17065: [ecash-herald + token-server] Update typescript and docker build settings.
Nov 4 2024, 16:30
bytesofman committed rABCba63229e2b34: [ecash-herald + token-server] Update typescript and docker build settings (authored by bytesofman).
[ecash-herald + token-server] Update typescript and docker build settings
Nov 4 2024, 16:30
Fabien closed D17070: [CI] Fix the wasm build in the container.
Nov 4 2024, 15:33
Fabien committed rABC600fa4f562d8: [CI] Fix the wasm build in the container (authored by Fabien).
[CI] Fix the wasm build in the container
Nov 4 2024, 15:33
bytesofman accepted D17070: [CI] Fix the wasm build in the container.
Nov 4 2024, 15:32
Fabien requested review of D17070: [CI] Fix the wasm build in the container.
Nov 4 2024, 15:14
Fabien requested review of D17068: [avalanche] Always print the finalization messages.
Nov 4 2024, 14:06
tobias_ruck added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 4 2024, 12:45
PiRK added inline comments to D17037: [chronik] index scripts by scripthashes in the mempool.
Nov 4 2024, 11:34
Fabien closed D17067: Deprecate the address_type field of the getnewaddress RPC.
Nov 4 2024, 10:06
Fabien committed rABC346ecaef2c58: Deprecate the address_type field of the getnewaddress RPC (authored by Fabien).
Deprecate the address_type field of the getnewaddress RPC
Nov 4 2024, 10:06
Fabien closed D17066: Bump version to 0.30.4.
Nov 4 2024, 10:06
Fabien committed rABC486094e3a645: Bump version to 0.30.4 (authored by Fabien).
Bump version to 0.30.4
Nov 4 2024, 10:06
PiRK accepted D17067: Deprecate the address_type field of the getnewaddress RPC.
Nov 4 2024, 09:47
PiRK accepted D17066: Bump version to 0.30.4.
Nov 4 2024, 09:46
Fabien updated the summary of D17067: Deprecate the address_type field of the getnewaddress RPC.
Nov 4 2024, 09:40
Fabien requested review of D17067: Deprecate the address_type field of the getnewaddress RPC.
Nov 4 2024, 09:30
Fabien requested review of D17066: Bump version to 0.30.4.
Nov 4 2024, 08:58
emack accepted D17065: [ecash-herald + token-server] Update typescript and docker build settings.
Nov 4 2024, 00:51
emack accepted D17063: [Cashtab] Patch bug in manage agora offers.
Nov 4 2024, 00:43

Nov 3 2024

abc-bot committed rABC5e8317de7248: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Nov 3 2024, 22:21
abc-bot committed rABC4c23df8830e8: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Nov 3 2024, 22:10
abc-bot committed rABCfc88d7f529f6: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Nov 3 2024, 21:42
bytesofman closed D17064: [Cashtab] Add OrderBook (with no icon) to token info page.
Nov 3 2024, 12:58
bytesofman committed rABCbd14420258ca: [Cashtab] Add OrderBook (with no icon) to token info page (authored by bytesofman).
[Cashtab] Add OrderBook (with no icon) to token info page
Nov 3 2024, 12:58
bytesofman published D17065: [ecash-herald + token-server] Update typescript and docker build settings for review.
Nov 3 2024, 12:53
bytesofman requested review of D17063: [Cashtab] Patch bug in manage agora offers.

actually, after you've listed two offers, verified they render as one merged orderbook, then I've noticed:

  • you need to cancel twice on the same orderbook, is this because it's representative of 2 offers?
Nov 3 2024, 12:52
teamcity closed T3673: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Nov 3 2024, 12:22
bytesofman closed D17060: [ecash-herald] Implement typescript.
Nov 3 2024, 12:08
bytesofman committed rABC5bdba03f6cbc: [ecash-herald] Implement typescript (authored by bytesofman).
[ecash-herald] Implement typescript
Nov 3 2024, 12:08
teamcity triaged T3673: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Nov 3 2024, 12:07
bytesofman closed D17062: [token-server] Improve organization of test files.
Nov 3 2024, 11:52
bytesofman committed rABC1fed704a0a8d: [token-server] Improve organization of test files (authored by bytesofman).
[token-server] Improve organization of test files
Nov 3 2024, 11:52
emack accepted D17064: [Cashtab] Add OrderBook (with no icon) to token info page.
Nov 3 2024, 11:52
emack requested changes to D17063: [Cashtab] Patch bug in manage agora offers.

actually, after you've listed two offers, verified they render as one merged orderbook, then I've noticed:

  • you need to cancel twice on the same orderbook, is this because it's representative of 2 offers?
  • the orderbook in manage listings become a "Buy token", which makes sense since you no longer have any offers left, but shouldn't it not be displayed at all?
Nov 3 2024, 11:24
emack accepted D17063: [Cashtab] Patch bug in manage agora offers.

Have verified the merging of orderbooks for the same token offer, though I wasn't getting a duplicate key error in the first place on master (v2.49.1).

Nov 3 2024, 11:18
emack accepted D17060: [ecash-herald] Implement typescript.
Nov 3 2024, 11:03
emack accepted D17062: [token-server] Improve organization of test files.
Nov 3 2024, 10:53
bytesofman updated the diff for D17064: [Cashtab] Add OrderBook (with no icon) to token info page.

patch unintended css shift (make sure offers stay 100% width on Agora page and landing page)

Nov 3 2024, 04:54
bytesofman published D17064: [Cashtab] Add OrderBook (with no icon) to token info page for review.
Nov 3 2024, 04:24
bytesofman abandoned D17005: [Cashtab] Upgrade existing token page to show trading info and display tokens the user does not hold.

superseded by D17064

Nov 3 2024, 04:15

Nov 2 2024

PiRK committed rABCbf00137a339a: [chronik] add scripthash option to the various script endpoints (authored by PiRK).
[chronik] add scripthash option to the various script endpoints
Nov 2 2024, 22:43
PiRK closed D16937: [chronik] add scripthash option to the various script endpoints.
Nov 2 2024, 22:43
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

merge imports

Nov 2 2024, 19:36
PiRK abandoned D17056: [electrum] remove outdated error message.
Nov 2 2024, 19:28
bytesofman published D17063: [Cashtab] Patch bug in manage agora offers for review.
Nov 2 2024, 14:46
bytesofman closed D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 2 2024, 14:39
bytesofman committed rABC7a59b64e4ccc: [new lokad] Add spec for onchain trollbox for tokens (authored by bytesofman).
[new lokad] Add spec for onchain trollbox for tokens
Nov 2 2024, 14:39
tobias_ruck added inline comments to D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 2 2024, 08:18
tobias_ruck accepted D17046: [new lokad] Add spec for onchain trollbox for tokens.
Nov 2 2024, 05:05
bytesofman closed D17053: [Cashtab] Implement typescript.
Nov 2 2024, 03:11
bytesofman committed rABCabacec78b2a7: [Cashtab] Implement typescript (authored by bytesofman).
[Cashtab] Implement typescript
Nov 2 2024, 03:11
emack accepted D17053: [Cashtab] Implement typescript.
Nov 2 2024, 00:54

Nov 1 2024

bytesofman published D17062: [token-server] Improve organization of test files for review.
Nov 1 2024, 23:28
bytesofman updated the diff for D17046: [new lokad] Add spec for onchain trollbox for tokens.

specy little-endian for tokenId push

Nov 1 2024, 23:15
bytesofman closed D16944: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of unspendable offers.
Nov 1 2024, 23:08
bytesofman committed rABCb27c743f6c10: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of… (authored by bytesofman).
[ecash-agora] Add validation to _acceptTxBuilder to prevent creation of…
Nov 1 2024, 23:08
bytesofman updated the diff for D16944: [ecash-agora] Add validation to _acceptTxBuilder to prevent creation of unspendable offers.

rebase, fix antipattern in validation (return if we have no remainder instead of only check if we do), make sure to validate if allowUnspendable is undefined, confirm with test

Nov 1 2024, 22:56
bytesofman published D17060: [ecash-herald] Implement typescript for review.
Nov 1 2024, 22:48
teamcity closed T3672: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Nov 1 2024, 22:28
roqqit closed D17058: Fix lock order inversion in promoteStakeContendersToTip.
Nov 1 2024, 22:12
roqqit committed rABC88a5faa04223: Fix lock order inversion in promoteStakeContendersToTip (authored by roqqit).
Fix lock order inversion in promoteStakeContendersToTip
Nov 1 2024, 22:12
Fabien accepted D17058: Fix lock order inversion in promoteStakeContendersToTip.
Nov 1 2024, 21:59
roqqit added a comment to D17058: Fix lock order inversion in promoteStakeContendersToTip.

https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/845463?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&hideProblemsFromDependencies=false

Nov 1 2024, 21:58
teamcity awarded D17058: Fix lock order inversion in promoteStakeContendersToTip a Haypence token.
Nov 1 2024, 21:18
Fabien added a comment to D17058: Fix lock order inversion in promoteStakeContendersToTip.

@bot build-tsan

Nov 1 2024, 21:18
roqqit abandoned D17059: Revert "[avalanche] Promote stake contenders when the chain tip updates".
Nov 1 2024, 21:17