rebase, addressed feedback in parent diffs, fixed more instances of amount_e being accessed in main_window
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jul 5 2025
Jul 5 2025
PiRK requested review of D18329: [electrum] remove shortcut reference to InvoiceStore in MainWindow.
[electrum] move format_fee_rate to amount.py
Jul 4 2025
Jul 4 2025
remove uneeded import
PiRK committed rABC3295e196b74a: [electrum] remove more dynamic fee related dead code (authored by PiRK).
[electrum] remove more dynamic fee related dead code
Jul 3 2025
Jul 3 2025
PiRK committed rABCfede0f2728a6: [electrum] move format_amount* functions from main_window to amount.py (authored by PiRK).
[electrum] move format_amount* functions from main_window to amount.py
PiRK committed rABC372b032bfb11: [electrum] move-only: move amount formatting functions from util to amount.py (authored by PiRK).
[electrum] move-only: move amount formatting functions from util to amount.py
PiRK updated the diff for D18316: [electrum] move-only: move amount formatting functions from util to amount.py.
import the correct _ (the other one is going away in D18319)
PiRK added inline comments to D18316: [electrum] move-only: move amount formatting functions from util to amount.py.
PiRK updated the diff for D18317: [electrum] move format_amount* functions from main_window to amount.py.
fix more occurences of subwidgets calling the main_window to format amounts
PiRK planned changes to D18317: [electrum] move format_amount* functions from main_window to amount.py.
i'm missing someting in transaction_dialog
PiRK requested review of D18317: [electrum] move format_amount* functions from main_window to amount.py.
PiRK committed rABCb9f45c11da7c: [electrum] remove a few unused instance attributes for menus and actions (authored by PiRK).
[electrum] remove a few unused instance attributes for menus and actions
PiRK committed rABC4057da0bea9d: [electrum] Qt6 transition, step 2: minimal changes to make the app start with… (authored by PiRK).
[electrum] Qt6 transition, step 2: minimal changes to make the app start with…
Jul 2 2025
Jul 2 2025
PiRK requested review of D18315: [electrum] remove a few unused instance attributes for menus and actions.
PiRK updated the diff for D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.
apply feedback
PiRK added inline comments to D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.
PiRK added inline comments to D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.
PiRK updated the diff for D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.
fix camera (tested by succesfully scanning a CashTab QRCode via a webcam)
PiRK updated the summary of D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.
PiRK committed rABCaa1da7a665b8: qt gui __init__: rm deprecated QApplication attr AA_X11InitThreads (authored by SomberNight <somber.night@protonmail.com>).
qt gui __init__: rm deprecated QApplication attr AA_X11InitThreads
PiRK added a comment to D18311: [electrum] Qt6 transition, step 2: minimal changes to make the app start with PyQt6.
I didn't properly test the scanning of QR codes via the webcam with Qt6, there is still some work left on that front
PiRK requested review of D18309: qt gui __init__: rm deprecated QApplication attr AA_X11InitThreads.
PiRK committed rABC2eb505151119: [electrum] Qt6 transition, step 1: wrap PyQt5 with qtpy (authored by PiRK).
[electrum] Qt6 transition, step 1: wrap PyQt5 with qtpy
Jul 1 2025
Jul 1 2025
Jun 30 2025
Jun 30 2025
PiRK committed rABC7296bc8788b8: [electrum] provide a test framework for Electrum ABC functional tests (authored by PiRK).
[electrum] provide a test framework for Electrum ABC functional tests
teamcity awarded D18293: [electrum] provide a test framework for Electrum ABC functional tests a Mountain of Wealth token.
Jun 29 2025
Jun 29 2025
teamcity awarded D18293: [electrum] provide a test framework for Electrum ABC functional tests a Doubloon token.
PiRK added a comment to D18293: [electrum] provide a test framework for Electrum ABC functional tests.
@bot electrum-functional-tests
PiRK updated the diff for D18293: [electrum] provide a test framework for Electrum ABC functional tests.
print error to stderr
In the future it would be an improvement to use a proper logger.
PiRK updated the summary of D18293: [electrum] provide a test framework for Electrum ABC functional tests.
PiRK committed rABCa8368330e72b: [electrum] exclude the regtest directory from the unit test discovery (authored by PiRK).
[electrum] exclude the regtest directory from the unit test discovery
Jun 27 2025
Jun 27 2025
PiRK published D18293: [electrum] provide a test framework for Electrum ABC functional tests for review.
teamcity awarded D18293: [electrum] provide a test framework for Electrum ABC functional tests a Piece of Eight token.
teamcity awarded D18293: [electrum] provide a test framework for Electrum ABC functional tests a Haypence token.
Jun 26 2025
Jun 26 2025
PiRK added inline comments to D18295: [electrum] exclude the regtest directory from the unit test discovery.
PiRK added inline comments to D18295: [electrum] exclude the regtest directory from the unit test discovery.
PiRK updated the summary of D18295: [electrum] exclude the regtest directory from the unit test discovery.
PiRK updated the diff for D18295: [electrum] exclude the regtest directory from the unit test discovery.
remove irrelevant commments from a previous iteration
PiRK requested review of D18295: [electrum] exclude the regtest directory from the unit test discovery.
Jun 25 2025
Jun 25 2025
Jun 24 2025
Jun 24 2025
PiRK added inline comments to D18286: [chronik] Electrum: send the tip header upon block disconnection.
Jun 23 2025
Jun 23 2025
teamcity awarded D17305: [electrum] try to use modern docker compose command a Mountain of Wealth token.
Jun 20 2025
Jun 20 2025
logging: Replace uses of LogPrintfCategory
PiRK committed rABC8bfb3c69708c: logging: add LogError, LogWarning, LogInfo, LogDebug, LogTrace (authored by Anthony Towns <aj@erisian.com.au>).
logging: add LogError, LogWarning, LogInfo, LogDebug, LogTrace
PiRK committed rABC17e3f6172685: logging: add -loglevelalways=1 option (authored by Anthony Towns <aj@erisian.com.au>).
logging: add -loglevelalways=1 option
PiRK committed rABC77368aacdc15: logging: treat BCLog::ALL like BCLog::NONE (authored by Anthony Towns <aj@erisian.com.au>).
logging: treat BCLog::ALL like BCLog::NONE
PiRK committed rABCfeb3b5d4eede: logging: Drop BCLog::Level::None (authored by Anthony Towns <aj@erisian.com.au>).
logging: Drop BCLog::Level::None
PiRK committed rABC9069de4e2080: logging: Log Info messages unconditionally (authored by Anthony Towns <aj@erisian.com.au>).
logging: Log Info messages unconditionally
PiRK committed rABC2f0e990a9d70: logging: make [cat:debug] and [info] implicit (authored by Anthony Towns <aj@erisian.com.au>).
logging: make [cat:debug] and [info] implicit