Page MenuHomePhabricator
Feed Advanced Search

May 11 2020

jasonbcox updated the diff for D6017: [land-bot] Only operate on trusted patches.

Make the review checking more similar to arc land's implementation so
as not to have to check for the ABC reviewer group specifically.

May 11 2020, 21:11
jasonbcox planned changes to D6036: Bump misbehaving factor for unexpected version message behavior.
May 11 2020, 20:34
jasonbcox requested review of D6036: Bump misbehaving factor for unexpected version message behavior.
May 11 2020, 20:34
jasonbcox updated the diff for D6024: [net] Ignore unlikely timestamps in version messages.

Rebase on the right stack so tests pass

May 11 2020, 19:29
jasonbcox added inline comments to D6024: [net] Ignore unlikely timestamps in version messages.
May 11 2020, 19:18
jasonbcox updated the diff for D6024: [net] Ignore unlikely timestamps in version messages.

Bump misbehaving factor to 20

May 11 2020, 18:56
jasonbcox updated the diff for D6025: Fix potential timedata overflow.

Fix median calculation when both elements are odd

May 11 2020, 18:30
jasonbcox committed rSTAGING1a3b614d3952: Bump version to 0.21.7 (authored by jasonbcox).
Bump version to 0.21.7
May 11 2020, 18:15
jasonbcox committed rABC1a3b614d3952: Bump version to 0.21.7 (authored by jasonbcox).
Bump version to 0.21.7
May 11 2020, 18:14
jasonbcox closed D6033: Bump version to 0.21.7.
May 11 2020, 18:14
jasonbcox requested review of D6033: Bump version to 0.21.7.
May 11 2020, 17:43
jasonbcox added a comment to D6017: [land-bot] Only operate on trusted patches.

I don't understand why you need to do the check in this script. Isn't it already checked by arc land ?

May 11 2020, 17:21
jasonbcox updated the diff for D6024: [net] Ignore unlikely timestamps in version messages.
  • Use genesis time from chainparams
  • Use Misbehaving() instead of just logging
May 11 2020, 17:17
jasonbcox committed rSTAGING6bd6615b8135: Restrict setmocktime to non-negative integers (authored by jasonbcox).
Restrict setmocktime to non-negative integers
May 11 2020, 17:05
jasonbcox committed rABC6bd6615b8135: Restrict setmocktime to non-negative integers (authored by jasonbcox).
Restrict setmocktime to non-negative integers
May 11 2020, 17:03
jasonbcox closed D6022: Restrict setmocktime to non-negative integers.
May 11 2020, 17:03
jasonbcox retitled D6023: [tests] Remove ctime() call which may be unreliable on some systems from [tests] Limit timestamps passed to ctime() which may be unreliable on some systems to [tests] Remove ctime() call which may be unreliable on some systems.
May 11 2020, 16:59
jasonbcox updated the diff for D6023: [tests] Remove ctime() call which may be unreliable on some systems.

Just remove the pretty printing entirely

May 11 2020, 16:58
jasonbcox added inline comments to D6023: [tests] Remove ctime() call which may be unreliable on some systems.
May 11 2020, 16:57
jasonbcox updated the diff for D6022: Restrict setmocktime to non-negative integers.

Tweaked error message text

May 11 2020, 16:53
jasonbcox added inline comments to D6024: [net] Ignore unlikely timestamps in version messages.
May 11 2020, 16:48
jasonbcox requested review of D6025: Fix potential timedata overflow.
May 11 2020, 16:23
jasonbcox added a comment to D6018: [land-bot] Ensure changes to the land bot script do not modify its execution in-flight.

I have no problem with this per se now that it is done, but you got to wonder how that became a problem worth fixing in the first place. Why not run these scripts from master to begin with instead of using the version of the patch?

May 11 2020, 15:35
jasonbcox requested review of D6025: Fix potential timedata overflow.
May 11 2020, 03:04
jasonbcox requested review of D6024: [net] Ignore unlikely timestamps in version messages.
May 11 2020, 02:52

May 10 2020

jasonbcox requested review of D6023: [tests] Remove ctime() call which may be unreliable on some systems.
May 10 2020, 21:50
jasonbcox requested review of D6022: Restrict setmocktime to non-negative integers.
May 10 2020, 20:19
jasonbcox accepted D6020: Properly handle LONG_MIN in timedata.cpp.
May 10 2020, 17:58

May 8 2020

jasonbcox requested review of D6018: [land-bot] Ensure changes to the land bot script do not modify its execution in-flight.
May 8 2020, 23:48
jasonbcox updated the diff for D6017: [land-bot] Only operate on trusted patches.

Fix lint issue

May 8 2020, 23:16
jasonbcox requested review of D6017: [land-bot] Only operate on trusted patches.
May 8 2020, 23:13
jasonbcox planned changes to D6016: Test patch; please do NOT review.
May 8 2020, 23:09
jasonbcox requested review of D6016: Test patch; please do NOT review.
May 8 2020, 23:09
jasonbcox committed rSTAGING310321ec95c0: Merge #12764: doc: Remove field in getblocktemplate help that has never been… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12764: doc: Remove field in getblocktemplate help that has never been…
May 8 2020, 22:05
jasonbcox committed rABC310321ec95c0: Merge #12764: doc: Remove field in getblocktemplate help that has never been… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12764: doc: Remove field in getblocktemplate help that has never been…
May 8 2020, 22:05
jasonbcox closed D6015: Merge #12764: doc: Remove field in getblocktemplate help that has never been used..
May 8 2020, 22:04
jasonbcox requested review of D6015: Merge #12764: doc: Remove field in getblocktemplate help that has never been used..
May 8 2020, 21:46
jasonbcox closed T846: Build Bitcoin-ABC / Master / Bitcoin-ABC Master is broken. as Resolved.
May 8 2020, 18:25
jasonbcox reopened T846: Build Bitcoin-ABC / Master / Bitcoin-ABC Master is broken. as "Open".
May 8 2020, 18:24
jasonbcox abandoned D5975: [univalue] Add a path for ignoring duplicate key checks.
May 8 2020, 18:21
jasonbcox closed T846: Build Bitcoin-ABC / Master / Bitcoin-ABC Master is broken. as Resolved.
May 8 2020, 17:20
jasonbcox committed rSTAGINGe217d0e4cfbb: Merge #14984: rpc: Speedup getrawmempool when verbose=true (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14984: rpc: Speedup getrawmempool when verbose=true
May 8 2020, 14:50
jasonbcox committed rSTAGING54c6eab4e0b8: Merge #15463: rpc: Speedup getaddressesbylabel (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15463: rpc: Speedup getaddressesbylabel
May 8 2020, 14:50
jasonbcox committed rABCe217d0e4cfbb: Merge #14984: rpc: Speedup getrawmempool when verbose=true (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14984: rpc: Speedup getrawmempool when verbose=true
May 8 2020, 14:49
jasonbcox closed D6007: Merge #14984: rpc: Speedup getrawmempool when verbose=true.
May 8 2020, 14:49
jasonbcox committed rABC54c6eab4e0b8: Merge #15463: rpc: Speedup getaddressesbylabel (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15463: rpc: Speedup getaddressesbylabel
May 8 2020, 14:49
jasonbcox closed D6008: Merge #15463: rpc: Speedup getaddressesbylabel.
May 8 2020, 14:49
jasonbcox requested review of D6008: Merge #15463: rpc: Speedup getaddressesbylabel.
May 8 2020, 00:28
jasonbcox updated the test plan for D6007: Merge #14984: rpc: Speedup getrawmempool when verbose=true.
May 8 2020, 00:18
jasonbcox updated the test plan for D6007: Merge #14984: rpc: Speedup getrawmempool when verbose=true.
May 8 2020, 00:17
jasonbcox updated the test plan for D6007: Merge #14984: rpc: Speedup getrawmempool when verbose=true.
May 8 2020, 00:15
jasonbcox requested review of D6007: Merge #14984: rpc: Speedup getrawmempool when verbose=true.
May 8 2020, 00:14

May 7 2020

jasonbcox committed rSTAGING4f8d6e19114b: Added some release notes (authored by jasonbcox).
Added some release notes
May 7 2020, 20:15
jasonbcox committed rABC4f8d6e19114b: Added some release notes (authored by jasonbcox).
Added some release notes
May 7 2020, 20:10
jasonbcox closed D5998: Added some release notes.
May 7 2020, 20:10
jasonbcox updated the diff for D5998: Added some release notes.

Fix errant newlines

May 7 2020, 19:30
jasonbcox accepted D6002: refactoring: FlushStateToDisk -> CChainState.
May 7 2020, 19:27
jasonbcox accepted D6001: refactoring: introduce ChainstateActive().
May 7 2020, 19:13
jasonbcox added a comment to D5982: UniValue performance speedups for .write().

Submitted upstream: https://github.com/jgarzik/univalue/pull/70

May 7 2020, 19:00
jasonbcox committed rSTAGING4812274977f5: UniValue performance speedups for .write() (authored by jasonbcox).
UniValue performance speedups for .write()
May 7 2020, 18:40
jasonbcox requested review of D5998: Added some release notes.
May 7 2020, 18:36
jasonbcox committed rABC4812274977f5: UniValue performance speedups for .write() (authored by jasonbcox).
UniValue performance speedups for .write()
May 7 2020, 18:35
jasonbcox closed D5982: UniValue performance speedups for .write().
May 7 2020, 18:35
jasonbcox accepted D5996: move-only: make the CChainState interface public.
May 7 2020, 18:30
jasonbcox updated the test plan for D5982: UniValue performance speedups for .write().
May 7 2020, 17:38
jasonbcox updated the diff for D5982: UniValue performance speedups for .write().
  • UniValueStream -> UniValueStreamWriter
  • Use getter instead of direct access to str
May 7 2020, 17:37
jasonbcox accepted D5995: Move DisconnectResult in its own header and make it an enum class.

I assume this work is related to https://github.com/bitcoin/bitcoin/pull/15976/commits/d7c97edeea8cee10ad9da1f940d39d5073ac142d
We already own this part of the code due to D364 and that commit on Core appears to be shuffling DisconnectResult into validation.h which is not a good long-term solution.
This looks like the right approach, but the naming should change now that it sits on its own at the src level.

May 7 2020, 16:45
jasonbcox planned changes to D5988: Fallback on buster-backports if LLVM packages are not available.
May 7 2020, 06:42
jasonbcox requested review of D5988: Fallback on buster-backports if LLVM packages are not available.
May 7 2020, 06:42
jasonbcox closed T843: Build Automated Deployments / Bitcoin ABC Developer Tools / Bitcoin ABC Master Base Image is broken. as Invalid.
May 7 2020, 02:55
jasonbcox added inline comments to D5982: UniValue performance speedups for .write().
May 7 2020, 01:07
jasonbcox updated the diff for D5982: UniValue performance speedups for .write().
  • Fix anonymous namespace
  • Use move semantic to simplify UniValueStream init API.
  • Fix various names
  • Remove operator<< functions as they apparently do not serve a purpose for this class.
  • Various cleanup
May 7 2020, 01:05

May 6 2020

jasonbcox accepted D5984: qa: Always refresh cache to be out of ibd.
May 6 2020, 23:07
jasonbcox updated the test plan for D5982: UniValue performance speedups for .write().
May 6 2020, 22:46
jasonbcox updated the test plan for D5982: UniValue performance speedups for .write().
May 6 2020, 22:46
jasonbcox requested review of D5982: UniValue performance speedups for .write().
May 6 2020, 22:46
jasonbcox updated the summary of D5982: UniValue performance speedups for .write().
May 6 2020, 22:43
jasonbcox planned changes to D5982: UniValue performance speedups for .write().
May 6 2020, 22:40
jasonbcox updated the diff for D5982: UniValue performance speedups for .write().
  • Remove useless inlines
  • Move helper functions to Stream (now called UniValueStream)
  • Fix some internal linkage
May 6 2020, 22:40
jasonbcox committed rSTAGING2e7115ee284e: Merge #16267: bench: Benchmark blockToJSON (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #16267: bench: Benchmark blockToJSON
May 6 2020, 19:05
jasonbcox committed rABC2e7115ee284e: Merge #16267: bench: Benchmark blockToJSON (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #16267: bench: Benchmark blockToJSON
May 6 2020, 19:00
jasonbcox closed D5981: Merge #16267: bench: Benchmark blockToJSON.
May 6 2020, 19:00
jasonbcox committed rSTAGING33b30bc21b60: Merge #16299: bench: Move generated data to a dedicated translation unit (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #16299: bench: Move generated data to a dedicated translation unit
May 6 2020, 17:40
jasonbcox committed rABC33b30bc21b60: Merge #16299: bench: Move generated data to a dedicated translation unit (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #16299: bench: Move generated data to a dedicated translation unit
May 6 2020, 17:39
jasonbcox closed D5980: Merge #16299: bench: Move generated data to a dedicated translation unit.
May 6 2020, 17:39
jasonbcox requested review of D5982: UniValue performance speedups for .write().
May 6 2020, 17:37
jasonbcox requested review of D5981: Merge #16267: bench: Benchmark blockToJSON.
May 6 2020, 17:30
jasonbcox requested review of D5980: Merge #16299: bench: Move generated data to a dedicated translation unit.
May 6 2020, 17:22
jasonbcox updated the diff for D5968: [build-configurations] Add build and tests without wallet to build-diff.
  • Call build-configurations.sh recursively to execute disabled wallet tests
  • Ensure logs are retained between the multiple runs of tests in build-diff
May 6 2020, 15:46
jasonbcox accepted D5952: [backport#15680] [wallet] Remove ResendWalletTransactionsBefore.
May 6 2020, 13:05
jasonbcox updated the summary of D5975: [univalue] Add a path for ignoring duplicate key checks.
May 6 2020, 05:50
jasonbcox requested review of D5975: [univalue] Add a path for ignoring duplicate key checks.
May 6 2020, 05:49
jasonbcox requested review of D5974: Tweak RPC mempool benchmark so that perf improvements are more noticeable.
May 6 2020, 05:38

May 5 2020

jasonbcox removed a reviewer for D5930: Test diff; please ignore: Restricted Project.
May 5 2020, 23:24
jasonbcox committed rSTAGING6417e4a81988: [land-bot] Fix a bug where the unencrypted CONDUIT_TOKEN could be logged by… (authored by jasonbcox).
[land-bot] Fix a bug where the unencrypted CONDUIT_TOKEN could be logged by…
May 5 2020, 19:18
jasonbcox committed rSTAGING7f499516ee02: Add a land bot script for running smoke tests before landing patches (authored by jasonbcox).
Add a land bot script for running smoke tests before landing patches
May 5 2020, 19:12
jasonbcox committed rSTAGINGc9574f16e779: Bump tool_wallet timeout (authored by jasonbcox).
Bump tool_wallet timeout
May 5 2020, 19:11
jasonbcox committed rSTAGING6f2ca9ddb3b4: Make sure we're using the same version of clang tools for everything (authored by jasonbcox).
Make sure we're using the same version of clang tools for everything
May 5 2020, 19:10
jasonbcox committed rSTAGINGa2715122edec: Merge #15947: Install bitcoin-wallet manpage (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15947: Install bitcoin-wallet manpage
May 5 2020, 19:10
jasonbcox committed rSTAGINGeef109b8e565: Merge #15354: doc: Add missing bitcoin-wallet tool manpages (authored by jasonbcox).
Merge #15354: doc: Add missing bitcoin-wallet tool manpages
May 5 2020, 19:10