Make the review checking more similar to arc land's implementation so
as not to have to check for the ABC reviewer group specifically.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 11 2020
Rebase on the right stack so tests pass
Bump misbehaving factor to 20
Fix median calculation when both elements are odd
In D6017#147418, @Fabien wrote:I don't understand why you need to do the check in this script. Isn't it already checked by arc land ?
- Use genesis time from chainparams
- Use Misbehaving() instead of just logging
Just remove the pretty printing entirely
Tweaked error message text
In D6018#147472, @deadalnix wrote:I have no problem with this per se now that it is done, but you got to wonder how that became a problem worth fixing in the first place. Why not run these scripts from master to begin with instead of using the version of the patch?
May 10 2020
May 8 2020
Fix lint issue
May 7 2020
Submitted upstream: https://github.com/jgarzik/univalue/pull/70
- UniValueStream -> UniValueStreamWriter
- Use getter instead of direct access to str
I assume this work is related to https://github.com/bitcoin/bitcoin/pull/15976/commits/d7c97edeea8cee10ad9da1f940d39d5073ac142d
We already own this part of the code due to D364 and that commit on Core appears to be shuffling DisconnectResult into validation.h which is not a good long-term solution.
This looks like the right approach, but the naming should change now that it sits on its own at the src level.
- Fix anonymous namespace
- Use move semantic to simplify UniValueStream init API.
- Fix various names
- Remove operator<< functions as they apparently do not serve a purpose for this class.
- Various cleanup
May 6 2020
- Remove useless inlines
- Move helper functions to Stream (now called UniValueStream)
- Fix some internal linkage
- Call build-configurations.sh recursively to execute disabled wallet tests
- Ensure logs are retained between the multiple runs of tests in build-diff