Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Oct 3 2019

deadalnix created D4209: Inline Sign1 and SignN.

Oct 3 2019, 22:51

deadalnix requested review of D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.

Oct 3 2019, 22:11

jasonbcox closed T416: October backport session as Resolved.

Oct 3 2019, 22:02 · Backport

jasonbcox closed T445: December backports as Resolved.

Oct 3 2019, 22:01 · Restricted Project

jasonbcox closed T569: Backport PR12843, a subtask of T446: Backport Core PR 12904, as Resolved.

Oct 3 2019, 22:01 · Restricted Project

jasonbcox closed T569: Backport PR12843 as Resolved.

Oct 3 2019, 22:01

jasonbcox closed T446: Backport Core PR 12904, a subtask of T445: December backports, as Resolved.

Oct 3 2019, 22:00 · Restricted Project

jasonbcox closed T446: Backport Core PR 12904 as Resolved.

Oct 3 2019, 22:00 · Restricted Project

jasonbcox closed T623: Backport Core PR 13023 as Resolved.

Oct 3 2019, 21:59

jasonbcox closed T663: Automate updating assume valid chainparams, a subtask of T646: Release Automation, as Resolved.

Oct 3 2019, 21:58 · Restricted Project, Restricted Project

jasonbcox closed T663: Automate updating assume valid chainparams as Resolved.

Oct 3 2019, 21:58 · Restricted Project, Restricted Project

teamcity added a comment to D4199: Introduce Span type and use it instead of FLATDATA.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 3 2019, 21:56

jasonbcox accepted D4208: Added translations for new send coins dialog box.

Oct 3 2019, 21:55

teamcity added a comment to D4199: Introduce Span type and use it instead of FLATDATA.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 3 2019, 21:41

deadalnix updated the diff for D4199: Introduce Span type and use it instead of FLATDATA.

Add header guard comment

Oct 3 2019, 21:41

nakihito updated the summary of D4208: Added translations for new send coins dialog box.

Oct 3 2019, 21:12

teamcity added a comment to D4208: Added translations for new send coins dialog box.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 3 2019, 21:03

Nico Guiton <nico@bitframe.org> committed rABC613514e7d0ef: Separate HaveKey function that checks whether a key is in a keystore (authored by Andrew Chow <achow101-github@achow101.com>).

Separate HaveKey function that checks whether a key is in a keystore

Oct 3 2019, 20:58

Nico Guiton <nico@bitframe.org> closed D4201: Separate HaveKey function that checks whether a key is in a keystore.

Oct 3 2019, 20:58

nakihito requested review of D4208: Added translations for new send coins dialog box.

Added to summary source of translations.

Oct 3 2019, 20:57

nakihito updated the summary of D4208: Added translations for new send coins dialog box.

Oct 3 2019, 20:57

jasonbcox requested changes to D4208: Added translations for new send coins dialog box.

Where did these translations come from? (should be in summary)

Oct 3 2019, 20:55

nakihito updated the summary of D4208: Added translations for new send coins dialog box.

Oct 3 2019, 20:54

jasonbcox accepted D4201: Separate HaveKey function that checks whether a key is in a keystore.

Oct 3 2019, 20:51

nakihito updated the summary of D4166: Merge #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety.

Oct 3 2019, 20:51

nakihito updated the summary of D4201: Separate HaveKey function that checks whether a key is in a keystore.

Oct 3 2019, 20:49

nakihito requested review of D4154: Merge #13158: [Qt]: Improve sendcoinsdialog readability.

Translations added in a separate diff. See D4208.

Oct 3 2019, 20:47

teamcity added a comment to D4208: Added translations for new send coins dialog box.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 3 2019, 20:47

nakihito created D4208: Added translations for new send coins dialog box.

Oct 3 2019, 20:47

Fabien requested changes to D4195: Added a land bot script.

Should anything fail the script errors out immediately, but the user working tree may have been modified in between.
I think you should trap the error and restore the previous state to avoid confusing the user.

Oct 3 2019, 20:28

Fabien accepted D4203: Drop UpdateTransaction in favor of UpdateInput.

Oct 3 2019, 20:10

Fabien requested changes to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.

I'm sure you didn't run the test from the summary. Please make it clear that you are quoting core PR description.

Oct 3 2019, 19:59

Fabien requested changes to D4199: Introduce Span type and use it instead of FLATDATA.

Oct 3 2019, 19:50

teamcity added a comment to D4207: Bump wallet version for pre split keypool.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 3 2019, 19:44

nakihito requested review of D4207: Bump wallet version for pre split keypool.

Oct 3 2019, 19:37

nakihito requested review of D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Oct 3 2019, 19:37

nakihito requested review of D4202: Add 'sethdseed' RPC to initialize or replace HD seed and test.

Oct 3 2019, 19:36

nakihito updated the summary of D4202: Add 'sethdseed' RPC to initialize or replace HD seed and test.

Oct 3 2019, 19:36

nakihito requested review of D4201: Separate HaveKey function that checks whether a key is in a keystore.

Oct 3 2019, 19:36

nakihito abandoned D4171: Merge #12560: [wallet] Upgrade path for non-HD wallets to HD.

Split into smaller parts. See D4201, D4202, D4206, D4207.

Oct 3 2019, 19:35

teamcity added a comment to D4207: Bump wallet version for pre split keypool.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 3 2019, 19:34

nakihito planned changes to D4207: Bump wallet version for pre split keypool.

Oct 3 2019, 19:34

nakihito created D4207: Bump wallet version for pre split keypool.

Oct 3 2019, 19:34

nakihito updated the test plan for D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Oct 3 2019, 18:52

nakihito updated the test plan for D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Oct 3 2019, 18:49

teamcity added a comment to D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 3 2019, 18:48

nakihito updated the summary of D4201: Separate HaveKey function that checks whether a key is in a keystore.

Oct 3 2019, 18:42

nakihito updated the summary of D4202: Add 'sethdseed' RPC to initialize or replace HD seed and test.

Oct 3 2019, 18:42

nakihito updated the summary of D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Oct 3 2019, 18:39

nakihito retitled D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split from Allow -upgradewallet to upgradewallets to HD to Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Oct 3 2019, 18:38

teamcity added a comment to D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 3 2019, 18:38

nakihito planned changes to D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Oct 3 2019, 18:37

nakihito updated the diff for D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Squashed together with this commit: https://github.com/bitcoin/bitcoin/pull/12560/commits/dfcd9f3e6abf3d53903227a085ff4cfecbfeb07f because the squashed commit's changes to behavior is prefered to the previous behavior.

Oct 3 2019, 18:37

nakihito updated the test plan for D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Oct 3 2019, 18:25

teamcity added a comment to D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 3 2019, 17:50

nakihito updated the test plan for D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Oct 3 2019, 17:50

nakihito updated the test plan for D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Oct 3 2019, 17:41

teamcity added a comment to D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 3 2019, 17:39

nakihito planned changes to D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Oct 3 2019, 17:39

nakihito created D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.

Oct 3 2019, 17:39

nakihito requested review of D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Oct 3 2019, 17:24

Nico Guiton <nico@bitframe.org> committed rABC1872dec7136d: Merge #13176: Improve CRollingBloomFilter performance: replace modulus with… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #13176: Improve CRollingBloomFilter performance: replace modulus with…

Oct 3 2019, 17:17

Nico Guiton <nico@bitframe.org> closed D4160: Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod.

Oct 3 2019, 17:17

teamcity added a comment to D4205: [cmake] Create a lib specifically for script related components.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 3 2019, 16:05

teamcity added a comment to D4205: [cmake] Create a lib specifically for script related components.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 3 2019, 15:49

teamcity added a comment to D4205: [cmake] Create a lib specifically for script related components.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 3 2019, 15:47

teamcity added a comment to D4205: [cmake] Create a lib specifically for script related components.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 3 2019, 15:47

deadalnix created D4205: [cmake] Create a lib specifically for script related components.

Oct 3 2019, 15:47

deadalnix accepted D4160: Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod.

Oct 3 2019, 15:44

deadalnix requested changes to D4189: Remove redundant assignments (dead stores).

The test plan doesn't run.

Oct 3 2019, 15:44

deadalnix requested changes to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

In D4191#100826, @fpelliccioni wrote:

In D4191#100495, @deadalnix wrote:

Part of the PR are missing.

It is a partial application of the PR, I forgot to clarify it, sorry. (summary edited).
I didn't apply the rule for built-in types, because it makes no sense:
for (int x : seq)
is preferred over
for (int const& x : seq).
Have I missed anything else?

Oct 3 2019, 15:41

deadalnix committed rABC290f3a73f004: Add native support for serializing char arrays without FLATDATA (authored by Pieter Wuille <pieter.wuille@gmail.com>).

Add native support for serializing char arrays without FLATDATA

Oct 3 2019, 15:35

deadalnix closed D4188: Add native support for serializing char arrays without FLATDATA.

Oct 3 2019, 15:35

deadalnix updated the test plan for D4188: Add native support for serializing char arrays without FLATDATA.

Oct 3 2019, 15:26

Fabien accepted D4188: Add native support for serializing char arrays without FLATDATA.

Oct 3 2019, 13:52

fpelliccioni committed rABC5822a6e6efca: refactor: Avoid locking tx pool cs thrice (authored by MarcoFalke <falke.marco@gmail.com>).

refactor: Avoid locking tx pool cs thrice

Oct 3 2019, 13:44

fpelliccioni closed D4186: refactor: Avoid locking tx pool cs thrice.

Oct 3 2019, 13:44

teamcity added a comment to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 3 2019, 13:38

fpelliccioni committed rABCa0dd249c1862: Return void instead of bool for functions that cannot fail (authored by practicalswift <practicalswift@users.noreply.github.com>).

Return void instead of bool for functions that cannot fail

Oct 3 2019, 13:34

fpelliccioni closed D4179: Return void instead of bool for functions that cannot fail.

Oct 3 2019, 13:33

fpelliccioni added a comment to D4179: Return void instead of bool for functions that cannot fail.

In D4179#100740, @deadalnix wrote:

The test plan is meant to actually be ran.

Oct 3 2019, 13:32

fpelliccioni added a comment to D4179: Return void instead of bool for functions that cannot fail.

In D4179#100728, @deadalnix wrote:

I see that you use make check-all in many tests. If you are using cmake, you should use ninja as it is faster. But right now, cmake is only a secondary option, so make sure the autotool build works.

Oct 3 2019, 13:31

Fabien accepted D4186: refactor: Avoid locking tx pool cs thrice.

Oct 3 2019, 13:26

teamcity added a comment to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 3 2019, 13:24

fpelliccioni updated the diff for D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

update the summary to clarify that it is a partial application of the PR.

Oct 3 2019, 13:24

fpelliccioni updated the summary of D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Oct 3 2019, 13:19

fpelliccioni added a comment to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

In D4191#100495, @deadalnix wrote:

Part of the PR are missing.

Oct 3 2019, 13:19

teamcity added a comment to D4189: Remove redundant assignments (dead stores).

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 3 2019, 12:57

teamcity added a comment to D4189: Remove redundant assignments (dead stores).

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 3 2019, 12:44

fpelliccioni updated the diff for D4189: Remove redundant assignments (dead stores).

updated test plan.

Oct 3 2019, 12:44

teamcity added a comment to D4186: refactor: Avoid locking tx pool cs thrice.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 3 2019, 12:01

deadalnix committed rABC1e49b73342dc: Relayout comment in sign.h (authored by deadalnix).

Relayout comment in sign.h

Oct 3 2019, 11:55

deadalnix closed D4204: Relayout comment in sign.h.

Oct 3 2019, 11:55

deadalnix requested review of D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.

Oct 3 2019, 11:54

teamcity added a comment to D4186: refactor: Avoid locking tx pool cs thrice.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 3 2019, 11:52

fpelliccioni updated the diff for D4186: refactor: Avoid locking tx pool cs thrice.

fixes test plan.

Oct 3 2019, 11:52

fpelliccioni updated the test plan for D4189: Remove redundant assignments (dead stores).

Oct 3 2019, 11:51

jasonbcox requested changes to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.

Oct 3 2019, 00:39

jasonbcox accepted D4179: Return void instead of bool for functions that cannot fail.

Oct 3 2019, 00:24

Oct 2 2019

teamcity added a comment to D3464: [rpc] Add logging RPC.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 23:52