Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Oct 2 2019

jasonbcox accepted D4204: Relayout comment in sign.h.

Oct 2 2019, 23:50

jasonbcox accepted D3464: [rpc] Add logging RPC.

Oct 2 2019, 23:49

teamcity added a comment to D3464: [rpc] Add logging RPC.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 23:38

nakihito updated the diff for D3464: [rpc] Add logging RPC.

Fixed comment formatting.

Oct 2 2019, 23:38

Nico Guiton <nico@bitframe.org> committed rABC2e257a9218a3: Merge #11411: script: Change SignatureHash input index check to an assert. (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #11411: script: Change SignatureHash input index check to an assert.

Oct 2 2019, 23:37

Nico Guiton <nico@bitframe.org> closed D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

Oct 2 2019, 23:36

teamcity added a comment to D4204: Relayout comment in sign.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 23:04

teamcity added a comment to D4204: Relayout comment in sign.h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 22:53

deadalnix created D4204: Relayout comment in sign.h.

Oct 2 2019, 22:53

teamcity added a comment to D4203: Drop UpdateTransaction in favor of UpdateInput.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 22:19

teamcity added a comment to D4203: Drop UpdateTransaction in favor of UpdateInput.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 22:08

deadalnix created D4203: Drop UpdateTransaction in favor of UpdateInput.

Oct 2 2019, 22:08

nakihito requested review of D4160: Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod.

In D4160#100755, @deadalnix wrote:

And what was the result of the comparison?

Oct 2 2019, 22:05

nakihito updated the summary of D4160: Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod.

Oct 2 2019, 22:04

nakihito updated the test plan for D4160: Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod.

Oct 2 2019, 21:31

teamcity added a comment to D4202: Add 'sethdseed' RPC to initialize or replace HD seed and test.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 21:23

teamcity added a comment to D4201: Separate HaveKey function that checks whether a key is in a keystore.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 21:14

deadalnix accepted D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

Oct 2 2019, 21:11

deadalnix requested changes to D4160: Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod.

And what was the result of the comparison?

Oct 2 2019, 21:09

nakihito updated the summary of D4202: Add 'sethdseed' RPC to initialize or replace HD seed and test.

Oct 2 2019, 21:09

teamcity added a comment to D4202: Add 'sethdseed' RPC to initialize or replace HD seed and test.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 21:09

nakihito planned changes to D4202: Add 'sethdseed' RPC to initialize or replace HD seed and test.

Oct 2 2019, 21:09

nakihito created D4202: Add 'sethdseed' RPC to initialize or replace HD seed and test.

Oct 2 2019, 21:09

deadalnix accepted D4179: Return void instead of bool for functions that cannot fail.

The test plan is meant to actually be ran.

Oct 2 2019, 21:08

teamcity added a comment to D4201: Separate HaveKey function that checks whether a key is in a keystore.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 21:03

nakihito planned changes to D4201: Separate HaveKey function that checks whether a key is in a keystore.

Oct 2 2019, 21:02

nakihito created D4201: Separate HaveKey function that checks whether a key is in a keystore.

Oct 2 2019, 21:02

deadalnix added inline comments to D4179: Return void instead of bool for functions that cannot fail.

Oct 2 2019, 21:00

deadalnix added a comment to D4179: Return void instead of bool for functions that cannot fail.

I see that you use make check-all in many tests. If you are using cmake, you should use ninja as it is faster. But right now, cmake is only a secondary option, so make sure the autotool build works.

Oct 2 2019, 20:58

deadalnix accepted D4186: refactor: Avoid locking tx pool cs thrice.

Oct 2 2019, 20:57

teamcity added a comment to D4186: refactor: Avoid locking tx pool cs thrice.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 18:25

teamcity added a comment to D4186: refactor: Avoid locking tx pool cs thrice.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 18:09

fpelliccioni updated the diff for D4186: refactor: Avoid locking tx pool cs thrice.

fixes building error.

Oct 2 2019, 18:08

nakihito updated the summary of D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Oct 2 2019, 17:29

nakihito updated the summary of D4175: Merge #12924: Fix hdmaster-key / seed-key confusion.

Oct 2 2019, 17:22

fpelliccioni updated the test plan for D4186: refactor: Avoid locking tx pool cs thrice.

Oct 2 2019, 16:51

teamcity added a comment to D4195: Added a land bot script.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 16:47

jasonbcox updated the test plan for D4195: Added a land bot script.

Oct 2 2019, 16:35

teamcity added a comment to D4195: Added a land bot script.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 16:32

jasonbcox updated the diff for D4195: Added a land bot script.

Minor fixes

Oct 2 2019, 16:32

jasonbcox committed rABC54cbf5636d1b: Minor improvements to github-release script (authored by jasonbcox).

Minor improvements to github-release script

Oct 2 2019, 16:29

jasonbcox closed D4196: Minor improvements to github-release script.

Oct 2 2019, 16:29

teamcity added a comment to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 16:19

teamcity added a comment to D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 16:04

deadalnix created D4200: Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction.

Oct 2 2019, 16:04

teamcity added a comment to D4196: Minor improvements to github-release script.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 16:01

teamcity added a comment to D4196: Minor improvements to github-release script.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 15:52

jasonbcox updated the diff for D4196: Minor improvements to github-release script.

Fix nit

Oct 2 2019, 15:51

teamcity added a comment to D4179: Return void instead of bool for functions that cannot fail.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 14:32

teamcity added a comment to D4199: Introduce Span type and use it instead of FLATDATA.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 14:26

teamcity added a comment to D4179: Return void instead of bool for functions that cannot fail.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 14:15

fpelliccioni updated the diff for D4179: Return void instead of bool for functions that cannot fail.

fixes building errors.

Oct 2 2019, 14:15

teamcity added a comment to D4199: Introduce Span type and use it instead of FLATDATA.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 14:10

deadalnix created D4199: Introduce Span type and use it instead of FLATDATA.

Oct 2 2019, 14:10

fpelliccioni abandoned D4192: validation: Pass tx pool reference into CheckSequenceLocks.

Duplicated: D4178

Oct 2 2019, 13:05

fpelliccioni committed rABC6518f3585e5e: validation: Pass tx pool reference into CheckSequenceLocks (authored by MarcoFalke <falke.marco@gmail.com>).

validation: Pass tx pool reference into CheckSequenceLocks

Oct 2 2019, 13:04

fpelliccioni closed D4178: validation: Pass tx pool reference into CheckSequenceLocks.

Oct 2 2019, 13:04

deadalnix requested changes to D4197: [CMAKE] Rename bitcoinconsensus target to avoid collision.

There is no name collision, because this is what it is.

Oct 2 2019, 12:15

deadalnix requested changes to D4198: [CMAKE] Add the bitcoinconsensus library.

Oct 2 2019, 12:15

deadalnix added inline comments to D4198: [CMAKE] Add the bitcoinconsensus library.

Oct 2 2019, 12:15

Fabien accepted D4196: Minor improvements to github-release script.

Oct 2 2019, 12:08

teamcity added a comment to D4198: [CMAKE] Add the bitcoinconsensus library.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 10:23

teamcity added a comment to D4197: [CMAKE] Rename bitcoinconsensus target to avoid collision.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 10:14

teamcity added a comment to D4198: [CMAKE] Add the bitcoinconsensus library.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 10:07

Fabien created D4198: [CMAKE] Add the bitcoinconsensus library.

Oct 2 2019, 10:06

teamcity added a comment to D4197: [CMAKE] Rename bitcoinconsensus target to avoid collision.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 10:05

Fabien created D4197: [CMAKE] Rename bitcoinconsensus target to avoid collision.

Oct 2 2019, 10:04

teamcity added a comment to D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 05:28

teamcity added a comment to D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 05:18

nakihito updated the diff for D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

Moved assert to beginning of function.

Oct 2 2019, 05:18

nakihito updated the summary of D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

Oct 2 2019, 05:09

nakihito updated the summary of D3935: Merge #11411: script: Change SignatureHash input index check to an assert..

Oct 2 2019, 05:09

nakihito requested review of D4160: Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod.

Oct 2 2019, 03:56

nakihito updated the summary of D4160: Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod.

Oct 2 2019, 03:54

nakihito updated the summary of D4160: Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod.

Oct 2 2019, 03:54

nakihito updated the summary of D4160: Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod.

Oct 2 2019, 03:53

nakihito requested review of D4190: Rename master key to seed.

Oct 2 2019, 01:38

teamcity added a comment to D4196: Minor improvements to github-release script.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 00:49

teamcity added a comment to D4196: Minor improvements to github-release script.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 00:39

jasonbcox created D4196: Minor improvements to github-release script.

Oct 2 2019, 00:39

teamcity added a comment to D4195: Added a land bot script.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 2 2019, 00:35

deadalnix committed rABCc57daa89273c: utils: Convert Windows args to utf-8 string (authored by Chun Kuan Lee <ken2812221@gmail.com>).

utils: Convert Windows args to utf-8 string

Oct 2 2019, 00:28

deadalnix closed D4174: utils: Convert Windows args to utf-8 string.

Oct 2 2019, 00:28

jasonbcox planned changes to D4195: Added a land bot script.

Oct 2 2019, 00:25

teamcity added a comment to D4195: Added a land bot script.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 2 2019, 00:25

jasonbcox created D4195: Added a land bot script.

Oct 2 2019, 00:25

Oct 1 2019

teamcity added a comment to D4194: Add a build-make-check config for testing and sanity checks.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 1 2019, 23:46

jasonbcox abandoned D4194: Add a build-make-check config for testing and sanity checks.

Oct 1 2019, 23:35

teamcity added a comment to D4194: Add a build-make-check config for testing and sanity checks.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 1 2019, 23:35

jasonbcox created D4194: Add a build-make-check config for testing and sanity checks.

Oct 1 2019, 23:34

Nico Guiton <nico@bitframe.org> committed rABCa6851819dd55: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).

Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub…

Oct 1 2019, 22:33

Nico Guiton <nico@bitframe.org> closed D4151: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.

Oct 1 2019, 22:33

teamcity added a comment to D4151: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 1 2019, 22:15

jasonbcox accepted D4151: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.

Oct 1 2019, 22:07

teamcity added a comment to D4151: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 1 2019, 22:05

nakihito updated the diff for D4151: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.

Further release-notes formatting.

Oct 1 2019, 22:05

jasonbcox requested changes to D4151: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.

Oct 1 2019, 21:26

nakihito added inline comments to D3464: [rpc] Add logging RPC.

Oct 1 2019, 21:15

teamcity added a comment to D4151: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 1 2019, 21:14

teamcity added a comment to D4151: Merge #12240: [rpc] Introduced a new `fees` structure that aggregates all sub-field fee types denominated in BCH.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 1 2019, 20:58