Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Nov 14 2019

jasonbcox added inline comments to D4436: Add unit tests for CSeederNode::ProcessMessage().

Nov 14 2019, 18:25

jasonbcox requested changes to D4418: Add simple unit tests for parse_name().

Splitting up the tests made a big difference. This is getting better.

Nov 14 2019, 17:59

jasonbcox requested changes to D4436: Add unit tests for CSeederNode::ProcessMessage().

Nov 14 2019, 17:35

jasonbcox accepted D4443: [CI] Rename build.sh to build_autotools.sh.

Nov 14 2019, 17:12

teamcity added a comment to D4447: RPC: Add new getzmqnotifications method..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 16:31

teamcity added a comment to D4447: RPC: Add new getzmqnotifications method..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 16:22

Fabien created D4447: RPC: Add new getzmqnotifications method..

Nov 14 2019, 16:22

Fabien requested changes to D4424: Add outputtype module.

Nov 14 2019, 15:58

deadalnix requested changes to D4439: Allow Seeder to handle receiving HEADER messages.

The iff description doesn't match what this does, because it clearly does more than simply receiving and processing the headers messages, it also filter/ban nodes based on it.

Nov 14 2019, 15:33

Fabien accepted D4446: Various nits in the ChainParams code..

Nov 14 2019, 14:57

deadalnix requested changes to D4442: Seeder bans nodes not following the correct chain.

I don't see any filtering going on anywhere is that patch.

Nov 14 2019, 14:57

teamcity added a comment to D4446: Various nits in the ChainParams code..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 14:52

teamcity added a comment to D4444: [CI] Add a new build configuration to run tests with cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 14:49

deadalnix requested changes to D4300: Integrate gArgs and chainparams into the Seeder.

Nov 14 2019, 14:45

teamcity added a comment to D4446: Various nits in the ChainParams code..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 14:43

deadalnix created D4446: Various nits in the ChainParams code..

Nov 14 2019, 14:43

teamcity added a comment to D4444: [CI] Add a new build configuration to run tests with cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 14:40

Fabien updated the diff for D4444: [CI] Add a new build configuration to run tests with cmake and ninja.

Use git clean to cleanup to build directory.

Nov 14 2019, 14:39

Fabien planned changes to D4444: [CI] Add a new build configuration to run tests with cmake and ninja.

Nov 14 2019, 14:31

deadalnix added inline comments to D4444: [CI] Add a new build configuration to run tests with cmake and ninja.

Nov 14 2019, 14:21

deadalnix accepted D4443: [CI] Rename build.sh to build_autotools.sh.

Nov 14 2019, 14:18

Fabien retitled D4445: [CMAKE] Use a NSIS custom template from [WIP][CMAKE] Use a NSIS custom template to [CMAKE] Use a NSIS custom template.

Nov 14 2019, 13:41

Fabien requested review of D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

The rebase fixed the determinism issue.

Nov 14 2019, 10:54

Fabien requested review of D4445: [CMAKE] Use a NSIS custom template.

Note to reviewers: this fixes the determinism issue on windows installer as expected (see builds #5027 and 5028)

Nov 14 2019, 10:54

teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 10:49

teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Nov 14 2019, 10:49

teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Nov 14 2019, 10:48

teamcity added a comment to D4445: [CMAKE] Use a NSIS custom template.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 10:45

teamcity added a comment to D4444: [CI] Add a new build configuration to run tests with cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 10:44

teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Nov 14 2019, 10:40

teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Nov 14 2019, 10:40

Fabien planned changes to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Nov 14 2019, 10:39

teamcity added a comment to D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 10:39

Fabien updated the diff for D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Rebase on top of D4445.

Nov 14 2019, 10:39

Fabien updated the summary of D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.

Nov 14 2019, 10:38

Fabien planned changes to D4445: [CMAKE] Use a NSIS custom template.

This diff is complete, working and ready to review, but I want to check first is the output of the gitian build is deterministic on CI

Nov 14 2019, 10:37

teamcity added a comment to D4445: [CMAKE] Use a NSIS custom template.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 10:36

Fabien created D4445: [CMAKE] Use a NSIS custom template.

Nov 14 2019, 10:36

teamcity added a comment to D4444: [CI] Add a new build configuration to run tests with cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 10:34

Fabien created D4444: [CI] Add a new build configuration to run tests with cmake and ninja.

Nov 14 2019, 10:34

teamcity added a comment to D4443: [CI] Rename build.sh to build_autotools.sh.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 09:49

teamcity added a comment to D4443: [CI] Rename build.sh to build_autotools.sh.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 09:40

Fabien created D4443: [CI] Rename build.sh to build_autotools.sh.

Nov 14 2019, 09:40

Fabien accepted D4435: Added missing instructions for OSX gitian building.

Nov 14 2019, 07:23

teamcity added a comment to D4442: Seeder bans nodes not following the correct chain.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 04:49

teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 04:47

nakihito requested review of D4442: Seeder bans nodes not following the correct chain.

Nov 14 2019, 04:42

nakihito requested review of D4439: Allow Seeder to handle receiving HEADER messages.

Nov 14 2019, 04:41

nakihito requested review of D4436: Add unit tests for CSeederNode::ProcessMessage().

Nov 14 2019, 04:41

nakihito requested review of D4418: Add simple unit tests for parse_name().

Nov 14 2019, 04:41

teamcity added a comment to D4442: Seeder bans nodes not following the correct chain.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 04:40

nakihito planned changes to D4442: Seeder bans nodes not following the correct chain.

Nov 14 2019, 04:40

nakihito created D4442: Seeder bans nodes not following the correct chain.

Nov 14 2019, 04:40

teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 04:38

nakihito planned changes to D4439: Allow Seeder to handle receiving HEADER messages.

Nov 14 2019, 04:38

nakihito updated the diff for D4439: Allow Seeder to handle receiving HEADER messages.

Squashed some missed changed.

Nov 14 2019, 04:37

teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 04:36

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 04:30

nakihito retitled D4439: Allow Seeder to handle receiving HEADER messages from Allow Seeder to handle receiving NOTFOUND and HEADER messages to Allow Seeder to handle receiving HEADER messages.

Nov 14 2019, 04:25

teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 04:25

nakihito planned changes to D4439: Allow Seeder to handle receiving HEADER messages.

Nov 14 2019, 04:24

nakihito updated the diff for D4439: Allow Seeder to handle receiving HEADER messages.

Rebase, split test into two different tests, removed NOTFOUND message functionality because it is not necessary, added differentiating logic for an empty HEADERS message and a non-empty HEADERS message. Also added some more constants.

Nov 14 2019, 04:24

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 04:21

nakihito planned changes to D4436: Add unit tests for CSeederNode::ProcessMessage().

Nov 14 2019, 04:21

nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Changed static_cast into a functional cast.

Nov 14 2019, 04:21

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 04:07

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 03:58

nakihito planned changes to D4436: Add unit tests for CSeederNode::ProcessMessage().

Nov 14 2019, 03:58

nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Split tests into smaller parts and added more constants.

Nov 14 2019, 03:58

teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 03:20

teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 03:11

nakihito planned changes to D4418: Add simple unit tests for parse_name().

Nov 14 2019, 03:11

nakihito updated the diff for D4418: Add simple unit tests for parse_name().

Broken tests into smaller parts, made names more explicit, added more constants.

Nov 14 2019, 03:11

teamcity added a comment to D4415: [CI] Allow to pass addditional arguments to bitcoind.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing passed.

Nov 14 2019, 02:33

deadalnix committed rABC2ca660ddcf75: Various nits in cuckoocache.h (authored by deadalnix).

Various nits in cuckoocache.h

Nov 14 2019, 02:18

deadalnix closed D4440: Various nits in cuckoocache.h.

Nov 14 2019, 02:18

teamcity added a comment to D4300: Integrate gArgs and chainparams into the Seeder.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 14 2019, 01:52

nakihito requested review of D4300: Integrate gArgs and chainparams into the Seeder.

Nov 14 2019, 01:44

teamcity added a comment to D4300: Integrate gArgs and chainparams into the Seeder.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 14 2019, 01:43

nakihito planned changes to D4300: Integrate gArgs and chainparams into the Seeder.

Nov 14 2019, 01:43

nakihito updated the diff for D4300: Integrate gArgs and chainparams into the Seeder.

Came up with a better solution for the return value of ParseCommandLine(). Changed handling of -testnet option to mirror bitcoin-cli.cpp.

Nov 14 2019, 01:43

nakihito planned changes to D4300: Integrate gArgs and chainparams into the Seeder.

Nov 14 2019, 01:10

nakihito planned changes to D4418: Add simple unit tests for parse_name().

Nov 14 2019, 00:56

nakihito planned changes to D4436: Add unit tests for CSeederNode::ProcessMessage().

Nov 14 2019, 00:52

jasonbcox accepted D4440: Various nits in cuckoocache.h.

Nov 14 2019, 00:33

jasonbcox retitled D4440: Various nits in cuckoocache.h from Various nits un cuckoocache.h to Various nits in cuckoocache.h.

Nov 14 2019, 00:32

Nov 13 2019

teamcity added a comment to D4440: Various nits in cuckoocache.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 23:16

teamcity added a comment to D4440: Various nits in cuckoocache.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 23:11

teamcity added a comment to D4440: Various nits in cuckoocache.h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 23:06

deadalnix updated the diff for D4440: Various nits in cuckoocache.h.

Add fogoten brace

Nov 13 2019, 23:06

teamcity added a comment to D4440: Various nits in cuckoocache.h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 23:02

deadalnix created D4440: Various nits in cuckoocache.h.

Nov 13 2019, 23:01

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 21:58

teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 21:49

teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 21:43

teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 21:34

teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 13 2019, 21:05

teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 13 2019, 20:56

nakihito planned changes to D4439: Allow Seeder to handle receiving HEADER messages.

Nov 13 2019, 20:56

nakihito created D4439: Allow Seeder to handle receiving HEADER messages.

Nov 13 2019, 20:56