Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Jan 13 2020

teamcity added a comment to D4917: more optimal virtualsize accounting with increments.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 13 2020, 05:08
markblundeberg created D4917: more optimal virtualsize accounting with increments.
Jan 13 2020, 05:08
teamcity added a comment to D4915: scripted-diff: Remove unused first argument to addUnchecked.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 13 2020, 02:05
teamcity added a comment to D4916: test: add "diamond" unit test to MempoolAncestryTests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 13 2020, 01:56
teamcity added a comment to D4916: test: add "diamond" unit test to MempoolAncestryTests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 13 2020, 01:48
teamcity added a comment to D4915: scripted-diff: Remove unused first argument to addUnchecked.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 13 2020, 01:48
deadalnix updated the diff for D4916: test: add "diamond" unit test to MempoolAncestryTests.

rebase

Jan 13 2020, 01:47
deadalnix updated the diff for D4915: scripted-diff: Remove unused first argument to addUnchecked.

rebase and merge conflict. Run the benchmarks

Jan 13 2020, 01:45
deadalnix committed rABCdbc0fc6462a4: Mark CTxMemPoolEntry members that should not be modified const (authored by MarcoFalke <falke.marco@gmail.com>).
Mark CTxMemPoolEntry members that should not be modified const
Jan 13 2020, 01:31
deadalnix closed D4914: Mark CTxMemPoolEntry members that should not be modified const.
Jan 13 2020, 01:30
teamcity added a comment to D4913: Merge #13142: Separate IsMine from solvability.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 13 2020, 01:28
teamcity added a comment to D4913: Merge #13142: Separate IsMine from solvability.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 13 2020, 01:20
markblundeberg requested changes to D4915: scripted-diff: Remove unused first argument to addUnchecked.

Ah fantastic, I was planning to do this at some point. Please fix rebase conflict (D4898 landed) but otherwise looks good, also include make bench-bitcoin (or whatever) in the test plan just to make sure that compiles too.

Jan 13 2020, 01:17
markblundeberg accepted D4914: Mark CTxMemPoolEntry members that should not be modified const.
Jan 13 2020, 01:13
markblundeberg accepted D4916: test: add "diamond" unit test to MempoolAncestryTests.
Jan 13 2020, 01:12
markblundeberg updated the diff for D4913: Merge #13142: Separate IsMine from solvability.

rebase

Jan 13 2020, 01:07
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC6ea0656db130: fix misc places that refer to virtual transaction size (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
fix misc places that refer to virtual transaction size
Jan 13 2020, 01:05
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4910: fix misc places that refer to virtual transaction size.
Jan 13 2020, 01:05
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC9dda12ee9286: Reintroduce IsSolvable (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
Reintroduce IsSolvable
Jan 13 2020, 00:59
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4912: Reintroduce IsSolvable.
Jan 13 2020, 00:59
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC4311ffc54de3: Merge #13002: Do not treat bare multisig outputs as IsMine unless watched (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13002: Do not treat bare multisig outputs as IsMine unless watched
Jan 13 2020, 00:53
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4911: Merge #13002: Do not treat bare multisig outputs as IsMine unless watched.
Jan 13 2020, 00:52
teamcity added a comment to D4903: Use virtualsize for mining/mempool priority.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 13 2020, 00:49
teamcity added a comment to D4906: Add virtualsize computation to mempool.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 13 2020, 00:48
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC8e73d9061359: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
document MANDATORY_SCRIPT_VERIFY_FLAGS accurately
Jan 13 2020, 00:40
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4672: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately.
Jan 13 2020, 00:40
markblundeberg added inline comments to D4912: Reintroduce IsSolvable.
Jan 13 2020, 00:39
teamcity added a comment to D4905: track descendant sigops count in mempool.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 13 2020, 00:29
teamcity added a comment to D4903: Use virtualsize for mining/mempool priority.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 13 2020, 00:27
teamcity added a comment to D4906: Add virtualsize computation to mempool.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 13 2020, 00:26
teamcity added a comment to D4905: track descendant sigops count in mempool.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 13 2020, 00:22
markblundeberg added inline comments to D4913: Merge #13142: Separate IsMine from solvability.
Jan 13 2020, 00:17
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABCcd346ed09ac9: simplify checkdatasig_tests (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
simplify checkdatasig_tests
Jan 13 2020, 00:17
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4908: simplify checkdatasig_tests.
Jan 13 2020, 00:17
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABCc95c9b9fa75c: fix scriptSig analysis in sign.cpp (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
fix scriptSig analysis in sign.cpp
Jan 13 2020, 00:15
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4907: fix scriptSig analysis in sign.cpp.
Jan 13 2020, 00:15
markblundeberg planned changes to D4903: Use virtualsize for mining/mempool priority.
Jan 13 2020, 00:14
markblundeberg updated the diff for D4903: Use virtualsize for mining/mempool priority.

rebase onto D4906 for CI

Jan 13 2020, 00:12
markblundeberg updated the diff for D4906: Add virtualsize computation to mempool.

rebase

Jan 13 2020, 00:09
markblundeberg retitled D4907: fix scriptSig analysis in sign.cpp from fic scriptSig analysis in sign.cpp to fix scriptSig analysis in sign.cpp.
Jan 13 2020, 00:08
markblundeberg updated the diff for D4905: track descendant sigops count in mempool.

rebase

Jan 13 2020, 00:06
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC0306d7c919d7: [mempool_tests] add sigop counting check in TestPackageAccounting (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
[mempool_tests] add sigop counting check in TestPackageAccounting
Jan 13 2020, 00:01
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4904: [mempool_tests] add sigop counting check in TestPackageAccounting.
Jan 13 2020, 00:01
Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABCddbfa3d06958: redefine virtual transaction size to something useful (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
redefine virtual transaction size to something useful
Jan 13 2020, 00:00
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4896: redefine virtual transaction size to something useful.
Jan 13 2020, 00:00

Jan 12 2020

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABCe4a435d58f82: remove segwit 'sigops cost' leftovers (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
remove segwit 'sigops cost' leftovers
Jan 12 2020, 23:56
Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4898: remove segwit 'sigops cost' leftovers.
Jan 12 2020, 23:55
markblundeberg requested review of D4903: Use virtualsize for mining/mempool priority.
Jan 12 2020, 23:48
jasonbcox committed rABC67412d1ef956: Add keys to source package (authored by jasonbcox).
Add keys to source package
Jan 12 2020, 17:54
jasonbcox closed D4828: Add keys to source package.
Jan 12 2020, 17:54
teamcity added a comment to D4916: test: add "diamond" unit test to MempoolAncestryTests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 16:51
teamcity added a comment to D4915: scripted-diff: Remove unused first argument to addUnchecked.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 16:48
teamcity added a comment to D4914: Mark CTxMemPoolEntry members that should not be modified const.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 16:34
teamcity added a comment to D4916: test: add "diamond" unit test to MempoolAncestryTests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 16:34
deadalnix created D4916: test: add "diamond" unit test to MempoolAncestryTests.
Jan 12 2020, 16:33
teamcity added a comment to D4915: scripted-diff: Remove unused first argument to addUnchecked.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 16:31
deadalnix created D4915: scripted-diff: Remove unused first argument to addUnchecked.
Jan 12 2020, 16:31
teamcity added a comment to D4914: Mark CTxMemPoolEntry members that should not be modified const.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 16:27
deadalnix created D4914: Mark CTxMemPoolEntry members that should not be modified const.
Jan 12 2020, 16:27
deadalnix accepted D4828: Add keys to source package.
Jan 12 2020, 15:59
deadalnix accepted D4907: fix scriptSig analysis in sign.cpp.
Jan 12 2020, 15:13
deadalnix accepted D4910: fix misc places that refer to virtual transaction size.
Jan 12 2020, 15:11
deadalnix requested changes to D4903: Use virtualsize for mining/mempool priority.
Jan 12 2020, 15:08
deadalnix requested changes to D4897: Add virtualsize tracking to mempool.

It seems like this is now obsolete.

Jan 12 2020, 14:57
deadalnix accepted D4906: Add virtualsize computation to mempool.
Jan 12 2020, 14:56
deadalnix accepted D4904: [mempool_tests] add sigop counting check in TestPackageAccounting.
Jan 12 2020, 14:37
deadalnix accepted D4908: simplify checkdatasig_tests.
Jan 12 2020, 14:36
deadalnix requested changes to D4913: Merge #13142: Separate IsMine from solvability.
Jan 12 2020, 14:35
deadalnix accepted D4911: Merge #13002: Do not treat bare multisig outputs as IsMine unless watched.
Jan 12 2020, 14:28
deadalnix requested review of D4900: parameterize ecmult_const over input size.

https://github.com/bitcoin-core/secp256k1/pull/522

Jan 12 2020, 14:03
deadalnix accepted D4672: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately.
Jan 12 2020, 14:02
deadalnix accepted D4912: Reintroduce IsSolvable.
Jan 12 2020, 14:01
deadalnix accepted D4898: remove segwit 'sigops cost' leftovers.
Jan 12 2020, 13:58
deadalnix accepted D4905: track descendant sigops count in mempool.
Jan 12 2020, 13:19
teamcity added a comment to D4913: Merge #13142: Separate IsMine from solvability.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 13:01
teamcity added a comment to D4913: Merge #13142: Separate IsMine from solvability.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 12:55
markblundeberg created D4913: Merge #13142: Separate IsMine from solvability.
Jan 12 2020, 12:55
teamcity added a comment to D4912: Reintroduce IsSolvable.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 12:54
markblundeberg added inline comments to D4912: Reintroduce IsSolvable.
Jan 12 2020, 12:50
teamcity added a comment to D4912: Reintroduce IsSolvable.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 12:48
markblundeberg created D4912: Reintroduce IsSolvable.
Jan 12 2020, 12:48
markblundeberg added a comment to D3888: Merge #12714: Introduce interface for signing providers.

note: this is missing IsSolvable changes (function did not exist at this time)

Jan 12 2020, 11:37
markblundeberg added a comment to D3121: Abstract out IsSolvable from Witnessifier.

(removed again in D3136)

Jan 12 2020, 11:32
teamcity added a comment to D4911: Merge #13002: Do not treat bare multisig outputs as IsMine unless watched.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 11:07
markblundeberg updated the test plan for D4911: Merge #13002: Do not treat bare multisig outputs as IsMine unless watched.
Jan 12 2020, 11:01
teamcity added a comment to D4911: Merge #13002: Do not treat bare multisig outputs as IsMine unless watched.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 11:01
markblundeberg created D4911: Merge #13002: Do not treat bare multisig outputs as IsMine unless watched.
Jan 12 2020, 11:01
teamcity added a comment to D4910: fix misc places that refer to virtual transaction size.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 08:52
teamcity added a comment to D4910: fix misc places that refer to virtual transaction size.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 08:47
markblundeberg created D4910: fix misc places that refer to virtual transaction size.
Jan 12 2020, 08:47
markblundeberg added a comment to D4828: Add keys to source package.

I agree with that rationale, in short "if you have any trusted copy of ABC, it contains the keys to verify any new version".

Jan 12 2020, 08:33
teamcity added a comment to D4672: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 08:32
markblundeberg requested changes to D4900: parameterize ecmult_const over input size.

link to PR please

Jan 12 2020, 08:29
teamcity added a comment to D4672: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 08:26
markblundeberg updated the diff for D4672: document MANDATORY_SCRIPT_VERIFY_FLAGS accurately.

smaller comment

Jan 12 2020, 08:26
markblundeberg added a comment to D4834: add sigChecks value to script cache.

Hmm weird I just noticed a bunch of these comments now (the first block) ... is it possible they didn't show up before? Anyway... back to work...

Jan 12 2020, 06:45
teamcity added a comment to D4908: simplify checkdatasig_tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 05:57
teamcity added a comment to D4908: simplify checkdatasig_tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 05:52
markblundeberg created D4908: simplify checkdatasig_tests.
Jan 12 2020, 05:52
teamcity added a comment to D4907: fix scriptSig analysis in sign.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 05:52
First
Prev
Next