Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

	Include stories about projects I am a member of.

Jan 12 2020

teamcity added a comment to D4907: fix scriptSig analysis in sign.cpp.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 05:45

markblundeberg created D4907: fix scriptSig analysis in sign.cpp.

Jan 12 2020, 05:45

teamcity added a comment to D4903: Use virtualsize for mining/mempool priority.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 05:29

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC3340ff368183: VerifyScript: accumulate ScriptExecutionMetrics and return them (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).

VerifyScript: accumulate ScriptExecutionMetrics and return them

Jan 12 2020, 05:26

Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4835: VerifyScript: accumulate ScriptExecutionMetrics and return them.

Jan 12 2020, 05:26

teamcity added a comment to D4903: Use virtualsize for mining/mempool priority.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 05:22

markblundeberg updated the diff for D4903: Use virtualsize for mining/mempool priority.

Update for changes in ancestor, add note that this functions
equally well from two possible parents (one or the other).

Jan 12 2020, 05:22

teamcity added a comment to D4906: Add virtualsize computation to mempool.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 05:14

markblundeberg updated the summary of D4905: track descendant sigops count in mempool.

Jan 12 2020, 05:09

markblundeberg added a comment to D4897: Add virtualsize tracking to mempool.

Alternative: D4905 and D4906

Jan 12 2020, 05:08

teamcity added a comment to D4906: Add virtualsize computation to mempool.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 05:07

markblundeberg created D4906: Add virtualsize computation to mempool.

Jan 12 2020, 05:07

teamcity added a comment to D4905: track descendant sigops count in mempool.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 04:39

teamcity added a comment to D4905: track descendant sigops count in mempool.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 04:32

markblundeberg created D4905: track descendant sigops count in mempool.

Jan 12 2020, 04:32

teamcity added a comment to D4904: [mempool_tests] add sigop counting check in TestPackageAccounting.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 04:30

teamcity added a comment to D4904: [mempool_tests] add sigop counting check in TestPackageAccounting.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 04:25

markblundeberg updated the diff for D4904: [mempool_tests] add sigop counting check in TestPackageAccounting.

drop totalsigops (unused)

Jan 12 2020, 04:25

teamcity added a comment to D4897: Add virtualsize tracking to mempool.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 03:41

teamcity added a comment to D4904: [mempool_tests] add sigop counting check in TestPackageAccounting.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 03:27

teamcity added a comment to D4897: Add virtualsize tracking to mempool.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 03:26

markblundeberg updated the diff for D4897: Add virtualsize tracking to mempool.

update ; split off sigops mempool test additions to D4904

Jan 12 2020, 03:26

teamcity added a comment to D4904: [mempool_tests] add sigop counting check in TestPackageAccounting.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 03:22

markblundeberg created D4904: [mempool_tests] add sigop counting check in TestPackageAccounting.

Jan 12 2020, 03:22

teamcity added a comment to D4896: redefine virtual transaction size to something useful.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 02:55

teamcity added a comment to D4896: redefine virtual transaction size to something useful.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 02:48

markblundeberg updated the diff for D4896: redefine virtual transaction size to something useful.

rebase, SigOps->SigOpCount

Jan 12 2020, 02:48

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABC1196ec83ae81: fix inappropriate uses of virtual size (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).

fix inappropriate uses of virtual size

Jan 12 2020, 02:43

Mark Lundeberg <markblundeberg@users.noreply.github.com> closed D4895: fix inappropriate uses of virtual size.

Jan 12 2020, 02:43

markblundeberg added a comment to D4902: change default -blockmintxfee to 0.

In D4902#118339, @deadalnix wrote:

In general, you'd want to patch to solve a problem. It is unclear here what that problem is.

Jan 12 2020, 02:34

markblundeberg added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

In D4871#118376, @Mengerian wrote:

I'm not a fan of the new name... "Endian" to me seems hardware specific, and usually implies some power-of-2 number of bytes....

Jan 12 2020, 02:12

markblundeberg added inline comments to D4896: redefine virtual transaction size to something useful.

Jan 12 2020, 02:09

teamcity added a comment to D4898: remove segwit 'sigops cost' leftovers.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 12 2020, 01:12

teamcity added a comment to D4898: remove segwit 'sigops cost' leftovers.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 12 2020, 01:05

markblundeberg updated the diff for D4898: remove segwit 'sigops cost' leftovers.

prefer name like 'sig op count'; caught a few more mentions of 'cost'

Jan 12 2020, 01:05

markblundeberg added inline comments to D4897: Add virtualsize tracking to mempool.

Jan 12 2020, 00:03

Jan 11 2020

deadalnix added inline comments to D4897: Add virtualsize tracking to mempool.

Jan 11 2020, 23:22

tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

In D4871#118376, @Mengerian wrote:

In D4871#117783, @tobias_ruck wrote:

Renamed to OP_ENDIAN_REVERSE, reasons can be found in the PR:

In a previous proposal, this opcode has been named OP_REVERSE. After that, it has been renamed to OP_BSWAP, as that is a more technically accurate term, which is commonly used for reversing the byteorder of integers [14] [15]. However, after some more consideration, it has been renamed to OP_ENDIAN_REVERSE following Boost‘s nomenclature [16]. This is because OP_BSWAP is lexically very similar to the already existing OP_SWAP and would make Script harder to read. Also, while the technical term for the instruction is indeed bswap, it isn‘t well known for developers of higher level languages and could thus spark confusion that would be avoided by using the name OP_ENDIAN_REVERSE, which is more self-descriptive.

Also added tests for unexecuted branches, clarified tests for not yet activated case.

Merged D4859 into this diff.

I'm not a fan of the new name... "Endian" to me seems hardware specific, and usually implies some power-of-2 number of bytes.... If you're worried about confusion, using the word "Endian" to me seems more confusing. It's possible people may use for things other than endian conversion, since it can reverse the byte order for any arbitrary-length string.

How about "OP_REVERSE_BYTES", or "OP_BYTE_SWAP"?

In any case, I guess this is a bit bike-sheddy, so not super-important either way.

Jan 11 2020, 22:40

Mengerian added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

In D4871#117783, @tobias_ruck wrote:

Renamed to OP_ENDIAN_REVERSE, reasons can be found in the PR:

In a previous proposal, this opcode has been named OP_REVERSE. After that, it has been renamed to OP_BSWAP, as that is a more technically accurate term, which is commonly used for reversing the byteorder of integers [14] [15]. However, after some more consideration, it has been renamed to OP_ENDIAN_REVERSE following Boost‘s nomenclature [16]. This is because OP_BSWAP is lexically very similar to the already existing OP_SWAP and would make Script harder to read. Also, while the technical term for the instruction is indeed bswap, it isn‘t well known for developers of higher level languages and could thus spark confusion that would be avoided by using the name OP_ENDIAN_REVERSE, which is more self-descriptive.

Also added tests for unexecuted branches, clarified tests for not yet activated case.

Merged D4859 into this diff.

Jan 11 2020, 21:39

Vjteuro awarded rABC5c61837cc260: Wrap paths in codeblocks in release-process.md a Like token.

Jan 11 2020, 20:53

deadalnix requested changes to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Jan 11 2020, 17:26

deadalnix accepted D4617: add a flag that restricts sigChecks per-input.

Jan 11 2020, 17:06

deadalnix requested changes to D4804: Optimization: don't add txn back to mempool after 10 invalidates.

Jan 11 2020, 16:58

teamcity added a comment to D4893: Add a script to generate sha256sums from Gitian output.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 11 2020, 16:54

deadalnix requested changes to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

This clearly includes a lot of code that isn't in the original PR. Where does the clocking mechanism changes come from?

Jan 11 2020, 16:53

jasonbcox accepted D4891: Free BerkeleyEnvironment instances when not in use.

Jan 11 2020, 16:50

jasonbcox committed rABC5c61837cc260: Wrap paths in codeblocks in release-process.md (authored by jasonbcox).

Wrap paths in codeblocks in release-process.md

Jan 11 2020, 16:50

jasonbcox closed D4890: Wrap paths in codeblocks in release-process.md.

Jan 11 2020, 16:50

teamcity added a comment to D4893: Add a script to generate sha256sums from Gitian output.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 11 2020, 16:49

jasonbcox updated the diff for D4893: Add a script to generate sha256sums from Gitian output.

Make the patterns less greedy by including a weak requirement for version number

Jan 11 2020, 16:49

deadalnix added a comment to D4893: Add a script to generate sha256sums from Gitian output.

While I don't have anything against that patch per se, it seems somewhat questionable that the signing process that core used was ditched in favor of something that clearly requires work.

Jan 11 2020, 16:48

jasonbcox added inline comments to D4893: Add a script to generate sha256sums from Gitian output.

Jan 11 2020, 16:44

jasonbcox added inline comments to D4893: Add a script to generate sha256sums from Gitian output.

Jan 11 2020, 16:39

deadalnix accepted D4894: Merge #13988: Add checks for settxfee reasonableness.

Jan 11 2020, 16:35

deadalnix accepted D4896: redefine virtual transaction size to something useful.

Jan 11 2020, 16:33

deadalnix requested changes to D4902: change default -blockmintxfee to 0.

Over the 4 reasons given, 2 are vry clearly bogus:

Jan 11 2020, 16:27