I suspect that the if (!g_avalanche) test will never be true. In init.cpp, g_avalanche is set in step 7 before the node actually starts connecting to peers (step 12).

move & add comments

address most of the review items

rename "Challenge" -> "Sighash" to keep the c++ and python code consistent

fix typo: I accidentaly turned MSG_CMPCT_BLOCK into a tuple by appending a comma to the line

must fix another test broken by change to CInv

@bot build-ibd

Handle unconfirmed txs, remove redundant txHistory prop and instead only use parsedTxHistory to check if wallet is new

add a basic test

Resolving comments. Keeping explorer.be.cash for now though because it parses token txs.

I just noticed that buildRemoteChallenge is already implemented in the test framework and is called get_sighash: https://reviews.bitcoinabc.org/source/bitcoin-abc/browse/master/test/functional/test_framework/messages.py$998

add a test (contributed by @Fabien)

rebase on top of D9329 to factor out the remote challenge generation

rebase after merging D9306

Add missing formatting changes + improve layout

implement missing step in the avalanche handshake:
after receiving a avahello message, a node requests the proof corresponding to the proofid in the delegation,
and now the other node responds to this request with its proof.