What about bool hasDustStake(Proof p);?

Don't acquire mininode_lock twice in abc_p2p_avalanche.py.
on_avahello, on_avapoll and on_avaresponse are called indirectly via mininode.P2PInterface.on_message, which does the call with the lock already acquired.

Note to reviewers: the lint errors are false positive from a cppcheck bug introduced in a recent version. There is no such issue if you run arc lint against this patch on Debian.

wrong summary link, this is the right one: https://github.com/bitcoin/bitcoin/pull/19109/commits/c4626bcd211af08c85b6567ef07eeae333edba47

built and tested locally ok

I think the deleted blank line is a result of linting. If I try to restore it, it tells me it's a code style violation

In D9430#214040, @deadalnix wrote:

This is breaking the test suite, back to your queue. Please make sure you run it, this is happening way too often.

This is breaking the test suite, back to your queue. Please make sure you run it, this is happening way too often.

I note that you often submit patches that break everything. You should make sure that you compile/run what you submit.

fix the renaming issues.

Implementing isValidStoredWallet in useWallet.js

In D9424#213950, @Fabien wrote:

So the previous content of the if statement was not a bool ?

address review:

So the previous content of the if statement was not a bool ?

This is pretty much good to go. Make sure isProofStateDustThreshold has a descriptive name.

This will allow for initializing the PeerData from the ArgsManager and make it independent from the Processor.

This kinda have the right idea, but the execution is a problem. For as long as you do these in the various constructors, you must have objects at the end, and therefore you end up constructing possibly invalid objects, which is just bad design.