Page MenuHomePhabricator
Feed All Stories

Jun 11 2021

majcosta updated the diff for D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

corrections to wallet_txn_clone.py

Jun 11 2021, 08:44
Fabien added inline comments to D9660: [avalanche] Don't request orphaned proofs.
Jun 11 2021, 08:04
teamcity awarded D9663: [eCash] adapt functional tests to the XEC base unit and test it by default a Haypence token.
Jun 11 2021, 08:01
Fabien added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

@bot build-master

Jun 11 2021, 08:01
PiRK requested changes to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 11 2021, 07:37

Jun 10 2021

deadalnix added inline comments to D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 22:14
PiRK added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

OK up to rpc_txoutproof.py

Jun 10 2021, 20:45
majcosta added inline comments to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 10 2021, 19:36
majcosta updated the diff for D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

thank you for the corrections.

  • updated mempool_limit.py, mempool_packages.py and mempool_unbroadcast.py
  • I've also ditched zeroes after the decimal where they aren't needed in the new unit.
Jun 10 2021, 19:34
PiRK added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

For now I reviewed up-to and including rpc_estimatefee.py

Jun 10 2021, 18:54
majcosta updated the diff for D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

a few new tests were added since I worked on the diff. their Amounts have been multiplied by a million as well.

Jun 10 2021, 18:43
majcosta planned changes to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.

fixing failure

Jun 10 2021, 17:59
teamcity added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 10 2021, 17:57
teamcity added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 10 2021, 17:51
teamcity added a comment to D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 10 2021, 17:51
PiRK accepted D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 17:45
majcosta requested review of D9663: [eCash] adapt functional tests to the XEC base unit and test it by default.
Jun 10 2021, 17:38
majcosta committed rABC6668fc39897a: [eCash] add the XEC base unit and test it by default (authored by majcosta).
[eCash] add the XEC base unit and test it by default
Jun 10 2021, 17:17
Fabien added a comment to D9662: [avalanche] Manage proof reception.

Unrelated failure

Jun 10 2021, 15:46
teamcity added a comment to D9662: [avalanche] Manage proof reception.
Jun 10 2021, 15:41
Fabien requested review of D9662: [avalanche] Manage proof reception.
Jun 10 2021, 15:33
Fabien updated the diff for D9660: [avalanche] Don't request orphaned proofs.

Introduce wait_for_proof to deal with RPC exception when a proof is not found

Jun 10 2021, 14:57
Fabien planned changes to D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 14:42
teamcity closed T1646: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Jun 10 2021, 13:30
Fabien updated the summary of D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 13:29
Fabien updated the diff for D9660: [avalanche] Don't request orphaned proofs.

Rebase

Jun 10 2021, 13:23
Fabien updated the summary of D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 13:22
Fabien abandoned D9493: [avalanche] Prevent sending proof invs multiple times to the same peer.
Jun 10 2021, 13:18
Fabien closed D9659: [avalanche] Add a getrawproof RPC.
Jun 10 2021, 13:18
Fabien abandoned D9489: [avalanche] Annouce our proofs to our peers.
Jun 10 2021, 13:18
Fabien committed rABC5f50f33f0910: [avalanche] Add a getrawproof RPC (authored by Fabien).
[avalanche] Add a getrawproof RPC
Jun 10 2021, 13:18
Fabien closed D9658: [avalanche] Improve proof verification test coverage.
Jun 10 2021, 13:17
Fabien committed rABC6ad142f004a9: [avalanche] Improve proof verification test coverage (authored by Fabien).
[avalanche] Improve proof verification test coverage
Jun 10 2021, 13:16
Fabien closed D9650: [avalanche] Send proof inventories.
Jun 10 2021, 13:16
Fabien committed rABC5794e8338bb8: [avalanche] Send proof inventories (authored by Fabien).
[avalanche] Send proof inventories
Jun 10 2021, 13:16
Fabien closed D9654: Extract out the next inventory send time computation.
Jun 10 2021, 13:15
Fabien committed rABC1aa72ef2ae5d: Extract out the next inventory send time computation (authored by Fabien).
Extract out the next inventory send time computation
Jun 10 2021, 13:15
Fabien requested review of D9660: [avalanche] Don't request orphaned proofs.
Jun 10 2021, 12:50
PiRK accepted D9658: [avalanche] Improve proof verification test coverage.
Jun 10 2021, 12:17
PiRK accepted D9659: [avalanche] Add a getrawproof RPC.
Jun 10 2021, 12:15
Fabien requested review of D9659: [avalanche] Add a getrawproof RPC.
Jun 10 2021, 12:09
Fabien requested review of D9658: [avalanche] Improve proof verification test coverage.
Jun 10 2021, 12:05
teamcity triaged T1646: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Jun 10 2021, 10:09
PiRK planned changes to D9478: [avalanche] make avalanche peer discovery in a simple case.
Jun 10 2021, 09:52
PiRK updated the diff for D9478: [avalanche] make avalanche peer discovery in a simple case.

rebase on current master
Now this review does not need to implement GetData for proofs any longer. The proof needs to be verified by a local node before it can be requested. There is now a Processor::addProof method, so we can use in in the code handling NetMsgType::AVAPROOF messages to store proofs even if they don't belong to the node sending it (for now we are not looking for the owner to add it, in such a case).

Jun 10 2021, 09:51
majcosta closed D9656: [refactor] encapsulate a unit's denomination in a class.
Jun 10 2021, 09:47
majcosta committed rABC23dc845e6077: [refactor] encapsulate a unit's denomination in a class (authored by majcosta).
[refactor] encapsulate a unit's denomination in a class
Jun 10 2021, 09:47
Fabien accepted D9656: [refactor] encapsulate a unit's denomination in a class.
Jun 10 2021, 09:24
majcosta updated the diff for D9656: [refactor] encapsulate a unit's denomination in a class.

POD'ified Currency, renamed 'unit' to 'baseunit' for clarity

Jun 10 2021, 09:12
majcosta closed D9655: [refactor] set the -ecash CLI argument earlier in startup.
Jun 10 2021, 09:09
majcosta committed rABCb48da90d1e72: [refactor] set the -ecash CLI argument earlier in startup (authored by majcosta).
[refactor] set the -ecash CLI argument earlier in startup
Jun 10 2021, 09:08
Fabien accepted D9655: [refactor] set the -ecash CLI argument earlier in startup.
Jun 10 2021, 09:05
majcosta updated the diff for D9655: [refactor] set the -ecash CLI argument earlier in startup.

addressed feedback

Jun 10 2021, 08:56
Fabien requested changes to D9655: [refactor] set the -ecash CLI argument earlier in startup.
Jun 10 2021, 08:31
majcosta updated the diff for D9655: [refactor] set the -ecash CLI argument earlier in startup.

missing newline at end of file

Jun 10 2021, 07:49
Ichessuinc updated Ichessuinc.
Jun 10 2021, 07:41
majcosta updated the diff for D9655: [refactor] set the -ecash CLI argument earlier in startup.

do not set the parameter in an inappropriate function, create a compilation unit for currency unit related code

Jun 10 2021, 07:20
Fabien requested changes to D9656: [refactor] encapsulate a unit's denomination in a class.

You need to add some unit tests for this new Currency object

Jun 10 2021, 07:15
Fabien requested changes to D9655: [refactor] set the -ecash CLI argument earlier in startup.
Jun 10 2021, 06:56
teamcity closed T1645: Build Bitcoin-ABC / Master / Make Generator is broken. as Resolved.
Jun 10 2021, 03:41
majcosta updated the diff for D9656: [refactor] encapsulate a unit's denomination in a class.

ValueFromAmount function still had the decimal places magical number code

Jun 10 2021, 03:21
abc-bot committed rABC3cc7c730e397: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Jun 10 2021, 03:20
teamcity triaged T1645: Build Bitcoin-ABC / Master / Make Generator is broken. as Unbreak Now! priority.
Jun 10 2021, 02:46
abc-bot committed rABC12d3cae43646: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Jun 10 2021, 02:16
abc-bot committed rABC253e2dbe8709: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Jun 10 2021, 02:08
majcosta requested review of D9656: [refactor] encapsulate a unit's denomination in a class.
Jun 10 2021, 01:12

Jun 9 2021

majcosta requested review of D9655: [refactor] set the -ecash CLI argument earlier in startup.
Jun 9 2021, 20:09
Mengerian added a task to D9654: Extract out the next inventory send time computation: Unknown Object (Maniphest Task).
Jun 9 2021, 18:49
PiRK accepted D9650: [avalanche] Send proof inventories.
Jun 9 2021, 17:28
teamcity closed T1643: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Resolved.
Jun 9 2021, 14:07
PiRK accepted D9654: Extract out the next inventory send time computation.
Jun 9 2021, 14:01
Fabien updated the diff for D9650: [avalanche] Send proof inventories.

Rebase on top of D9654.

Jun 9 2021, 14:01
Fabien updated the summary of D9650: [avalanche] Send proof inventories.
Jun 9 2021, 14:00
Fabien requested review of D9654: Extract out the next inventory send time computation.
Jun 9 2021, 13:58
teamcity closed T1644: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
Jun 9 2021, 13:51
Fabien closed D9653: [avalanche] Fix the avalanche test on slow machines.
Jun 9 2021, 13:42
Fabien committed rABC2467b6cfa6a6: [avalanche] Fix the avalanche test on slow machines (authored by Fabien).
[avalanche] Fix the avalanche test on slow machines
Jun 9 2021, 13:42
Fabien updated the summary of D9653: [avalanche] Fix the avalanche test on slow machines.
Jun 9 2021, 13:38
PiRK accepted D9653: [avalanche] Fix the avalanche test on slow machines.
Jun 9 2021, 13:29
teamcity awarded D9653: [avalanche] Fix the avalanche test on slow machines a Haypence token.
Jun 9 2021, 13:07
Fabien added a comment to D9653: [avalanche] Fix the avalanche test on slow machines.

@bot build-linux-arm build-linux-aarch64

Jun 9 2021, 13:07
Fabien requested review of D9653: [avalanche] Fix the avalanche test on slow machines.
Jun 9 2021, 13:06
Fabien planned changes to D9650: [avalanche] Send proof inventories.

I should probably manage the loop delay first before enabling all this, will update/rebase once done

Jun 9 2021, 10:05
PiRK added inline comments to D9650: [avalanche] Send proof inventories.
Jun 9 2021, 10:01
PiRK added inline comments to D9650: [avalanche] Send proof inventories.
Jun 9 2021, 09:49
teamcity triaged T1644: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
Jun 9 2021, 08:34
teamcity triaged T1643: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Unbreak Now! priority.
Jun 9 2021, 08:33
Fabien updated the diff for D9650: [avalanche] Send proof inventories.

Rebase

Jun 9 2021, 07:56
Fabien closed D9492: [avalanche] Add a sendavalancheproof RPC shell.
Jun 9 2021, 07:53
Fabien committed rABC2e4bc27105b7: [avalanche] Add a sendavalancheproof RPC shell (authored by Fabien).
[avalanche] Add a sendavalancheproof RPC shell
Jun 9 2021, 07:53
Fabien closed D9646: [avalanche] Extract a proof verification facility from the RPC.
Jun 9 2021, 07:52
Fabien committed rABC10b624ffb4f5: [avalanche] Extract a proof verification facility from the RPC (authored by Fabien).
[avalanche] Extract a proof verification facility from the RPC
Jun 9 2021, 07:52
Fabien closed D9649: [avalanche] Make the deserialization error code consistent between RPCs.
Jun 9 2021, 07:51
Fabien committed rABC350aba92a742: [avalanche] Make the deserialization error code consistent between RPCs (authored by Fabien).
[avalanche] Make the deserialization error code consistent between RPCs
Jun 9 2021, 07:50
Fabien closed D9648: [avalanche] Add a facility to check if avalanche is enabled.
Jun 9 2021, 07:50
Fabien committed rABCe9fc5f21799a: [avalanche] Add a facility to check if avalanche is enabled (authored by Fabien).
[avalanche] Add a facility to check if avalanche is enabled
Jun 9 2021, 07:49
Fabien closed D9647: [avalanche] Move the global definitions into their own header.
Jun 9 2021, 07:49
Fabien committed rABC478f68235d39: [avalanche] Move the global definitions into their own header (authored by Fabien).
[avalanche] Move the global definitions into their own header
Jun 9 2021, 07:48
Fabien closed D9644: [avalanche] Send avalanche proofs upon request.
Jun 9 2021, 07:47
Fabien committed rABCf5468cdd8454: [avalanche] Send avalanche proofs upon request (authored by Fabien).
[avalanche] Send avalanche proofs upon request
Jun 9 2021, 07:47