Page MenuHomePhabricator
Feed All Stories

Jul 12 2021

majcosta accepted D9767: [avalanche] Move the proof accessor tests to the peer manager tests.
Jul 12 2021, 13:50
PiRK accepted D9767: [avalanche] Move the proof accessor tests to the peer manager tests.
Jul 12 2021, 13:47
PiRK accepted D9765: [LINTER] Work around a cppcheck false positive.
Jul 12 2021, 13:41
Fabien requested review of D9767: [avalanche] Move the proof accessor tests to the peer manager tests.
Jul 12 2021, 13:04
PiRK updated the diff for D9742: [avalanche] register local proof at first tip update.

sync the nodes with sync_all

Jul 12 2021, 12:42
PiRK accepted D9766: [avalanche] Remove the unused processor addNode() method.
Jul 12 2021, 12:39
Fabien requested review of D9766: [avalanche] Remove the unused processor addNode() method.
Jul 12 2021, 12:33
Fabien requested review of D9765: [LINTER] Work around a cppcheck false positive.
Jul 12 2021, 12:30
deadalnix closed D9763: [avalanche] Do not bucket brigade broadcast handling.
Jul 12 2021, 11:53
deadalnix committed rABCcfe13e06ec0b: [avalanche] Do not bucket brigade broadcast handling (authored by deadalnix).
[avalanche] Do not bucket brigade broadcast handling
Jul 12 2021, 11:53
Fabien requested changes to D9742: [avalanche] register local proof at first tip update.
Jul 12 2021, 09:25
PiRK abandoned D9762: [avalanche] add a test for a node started with an orphan proof.

merged with D9742

Jul 12 2021, 07:35
PiRK updated the diff for D9742: [avalanche] register local proof at first tip update.

merge D9762 and D9742

Jul 12 2021, 07:34
weleanord removed Slack Username on weleanord.
Jul 12 2021, 05:13
weleanord set Slack Username to https://icomputer.repair on weleanord.
Jul 12 2021, 05:13

Jul 11 2021

deadalnix closed D9764: Remove Processor::forNode.
Jul 11 2021, 22:53
deadalnix committed rABCa6e531901d68: Remove Processor::forNode (authored by deadalnix).
Remove Processor::forNode
Jul 11 2021, 22:53

Jul 10 2021

majcosta accepted D9763: [avalanche] Do not bucket brigade broadcast handling.
Jul 10 2021, 14:33
majcosta accepted D9764: Remove Processor::forNode.
Jul 10 2021, 14:22
deadalnix requested review of D9764: Remove Processor::forNode.
Jul 10 2021, 14:03
deadalnix requested review of D9763: [avalanche] Do not bucket brigade broadcast handling.
Jul 10 2021, 13:59
deadalnix requested changes to D9762: [avalanche] add a test for a node started with an orphan proof.

I think that should be merged in D9742 . it doesn't make much sense to separate the code and the tests.

Jul 10 2021, 13:34

Jul 9 2021

PiRK updated the diff for D9762: [avalanche] add a test for a node started with an orphan proof.

address linter error

Jul 9 2021, 16:08
PiRK requested review of D9762: [avalanche] add a test for a node started with an orphan proof.
Jul 9 2021, 16:06
deadalnix closed D9761: TDOD -> TODO.
Jul 9 2021, 14:38
deadalnix committed rABC0eff3b268791: TDOD -> TODO (authored by deadalnix).
TDOD -> TODO
Jul 9 2021, 14:38
Fabien accepted D9761: TDOD -> TODO.
Jul 9 2021, 13:18
deadalnix requested review of D9761: TDOD -> TODO.
Jul 9 2021, 13:10
PiRK updated the diff for D9742: [avalanche] register local proof at first tip update.

register the proof at tip update rather than init, like before. We just no longer to need to wait for IBD to finish. And we don't need a flag, as we can just call registerProof which returns immediateley if the proof exists.

Jul 9 2021, 13:05
majcosta requested changes to D9760: [cashtab] Internationalization: Switch from fbt to react-intl.
  • extension/src/components/App.js still has fbt imports and tags
  • .gitignore still has an fbt related file section
  • test plan doesn't test all changes
Jul 9 2021, 12:40
PiRK updated the diff for D9686: [avalanche] add a lock to CNode::AvalancheState.

add the lock also when using the key in AVARESPONSE (fixes clang error)

Jul 9 2021, 09:51
teamcity added a comment to D9686: [avalanche] add a lock to CNode::AvalancheState.
Jul 9 2021, 09:31
PiRK updated the diff for D9686: [avalanche] add a lock to CNode::AvalancheState.

move Mutex next to the data it is guarding, use lock in addavalanchenode (rebase on D9719), remove need for lock in processor.cpp by moving the buildRemoteSighash code to the AvaHello processing code (already locked) in net_processing.cpp (rebase on D9708).

Jul 9 2021, 09:28
alcipir requested review of D9760: [cashtab] Internationalization: Switch from fbt to react-intl.
Jul 9 2021, 03:52

Jul 8 2021

PiRK planned changes to D9742: [avalanche] register local proof at first tip update.

Need to work on the error message and if possible figure out how to not duplicate all the stateless proof verification tests again (already done in Processor::MakeProcessor)

Jul 8 2021, 20:45
PiRK closed D9759: functional tests: Remove portseed_offset from test runner.
Jul 8 2021, 16:06
PiRK committed rABC3ba5cf0a5e6c: functional tests: Remove portseed_offset from test runner (authored by MarcoFalke <falke.marco@gmail.com>).
functional tests: Remove portseed_offset from test runner
Jul 8 2021, 16:05
deadalnix added inline comments to D9742: [avalanche] register local proof at first tip update.
Jul 8 2021, 16:05
majcosta accepted D9759: functional tests: Remove portseed_offset from test runner.
Jul 8 2021, 15:21
PiRK retitled D9759: functional tests: Remove portseed_offset from test runner from qa: Remove portseed_offset from test runner to functional tests: Remove portseed_offset from test runner.
Jul 8 2021, 15:14
PiRK closed D9758: Pass mempool pointer to GetCoinsCacheSizeState.
Jul 8 2021, 15:11
PiRK committed rABCaf4f4249e653: Pass mempool pointer to GetCoinsCacheSizeState (authored by MarcoFalke <falke.marco@gmail.com>).
Pass mempool pointer to GetCoinsCacheSizeState
Jul 8 2021, 15:11
PiRK closed D9757: Pass mempool pointer to UnloadBlockIndex.
Jul 8 2021, 15:09
PiRK committed rABCeb2796952096: Pass mempool pointer to UnloadBlockIndex (authored by MarcoFalke <falke.marco@gmail.com>).
Pass mempool pointer to UnloadBlockIndex
Jul 8 2021, 15:09
PiRK closed D9756: test: Simplify cs_main locks.
Jul 8 2021, 15:08
PiRK committed rABC881afbd7aab9: test: Simplify cs_main locks (authored by MarcoFalke <falke.marco@gmail.com>).
test: Simplify cs_main locks
Jul 8 2021, 15:08
PiRK updated the summary of D9757: Pass mempool pointer to UnloadBlockIndex.
Jul 8 2021, 15:05
PiRK updated the summary of D9758: Pass mempool pointer to GetCoinsCacheSizeState.
Jul 8 2021, 15:04
teamcity updated the summary of D9759: functional tests: Remove portseed_offset from test runner.
Jul 8 2021, 15:03
PiRK requested review of D9759: functional tests: Remove portseed_offset from test runner.
Jul 8 2021, 15:03
majcosta accepted D9758: Pass mempool pointer to GetCoinsCacheSizeState.
Jul 8 2021, 14:32
Mengerian closed D9752: [website] Update services listed on eCash page.
Jul 8 2021, 14:00
Mengerian committed rABCWEB4a988f75d498: [website] Update services listed on eCash page (authored by Mengerian).
[website] Update services listed on eCash page
Jul 8 2021, 14:00
majcosta accepted D9757: Pass mempool pointer to UnloadBlockIndex.
Jul 8 2021, 13:57
deadalnix accepted D9756: test: Simplify cs_main locks.
Jul 8 2021, 13:54
PiRK published D9742: [avalanche] register local proof at first tip update for review.

We have established that the failures I'm seeing are unrelated to this diff, as I can reproduce them on master.
It is most likely a port collision with some other daemon running on my machine.

Jul 8 2021, 13:52
teamcity updated the summary of D9758: Pass mempool pointer to GetCoinsCacheSizeState.
Jul 8 2021, 13:38
PiRK requested review of D9758: Pass mempool pointer to GetCoinsCacheSizeState.
Jul 8 2021, 13:37
PiRK updated the summary of D9757: Pass mempool pointer to UnloadBlockIndex.
Jul 8 2021, 13:36
teamcity updated the summary of D9757: Pass mempool pointer to UnloadBlockIndex.
Jul 8 2021, 13:35
PiRK requested review of D9757: Pass mempool pointer to UnloadBlockIndex.
Jul 8 2021, 13:35
teamcity updated the summary of D9756: test: Simplify cs_main locks.
Jul 8 2021, 13:32
PiRK requested review of D9756: test: Simplify cs_main locks.
Jul 8 2021, 13:32
Fabien closed D9754: [avalanche] Fix an edge case that can assert when updating a node.
Jul 8 2021, 13:04
Fabien committed rABC7bcc423b2c59: [avalanche] Fix an edge case that can assert when updating a node (authored by Fabien).
[avalanche] Fix an edge case that can assert when updating a node
Jul 8 2021, 13:04
deadalnix accepted D9754: [avalanche] Fix an edge case that can assert when updating a node.
Jul 8 2021, 13:03
Fabien updated the diff for D9754: [avalanche] Fix an edge case that can assert when updating a node.

Check the nodes are not removed with the peer in the test

Jul 8 2021, 13:00
PiRK accepted D9754: [avalanche] Fix an edge case that can assert when updating a node.

New test produces error as expected, patch fixes it as expected.

Jul 8 2021, 12:58
deadalnix added inline comments to D9754: [avalanche] Fix an edge case that can assert when updating a node.
Jul 8 2021, 12:56
Fabien closed D9755: [avalanche] Minor simplification in the fetchOrCreatePeer method.
Jul 8 2021, 12:53
Fabien committed rABC49317e5958f8: [avalanche] Minor simplification in the fetchOrCreatePeer method (authored by Fabien).
[avalanche] Minor simplification in the fetchOrCreatePeer method
Jul 8 2021, 12:53
Fabien updated the diff for D9754: [avalanche] Fix an edge case that can assert when updating a node.

Make removeNodeFromPeer valid when the peer no longer exist.
Add a test case for removeNode as well.

Jul 8 2021, 12:52
PiRK accepted D9754: [avalanche] Fix an edge case that can assert when updating a node.

Reviewed and tested, with and without the patch.

Jul 8 2021, 12:45
deadalnix accepted D9755: [avalanche] Minor simplification in the fetchOrCreatePeer method.
Jul 8 2021, 12:43
deadalnix added inline comments to D9754: [avalanche] Fix an edge case that can assert when updating a node.
Jul 8 2021, 12:42
Fabien requested review of D9755: [avalanche] Minor simplification in the fetchOrCreatePeer method.
Jul 8 2021, 11:57
Fabien requested review of D9754: [avalanche] Fix an edge case that can assert when updating a node.
Jul 8 2021, 11:33
• baby636 updated • baby636.
Jul 8 2021, 11:11
deadalnix closed D9753: Simple cleanup in net_processing.cpp.
Jul 8 2021, 10:07
deadalnix committed rABCe90d70657293: Simple cleanup in net_processing.cpp (authored by deadalnix).
Simple cleanup in net_processing.cpp
Jul 8 2021, 10:07
deadalnix closed D9749: [avalanche] More bucket brigading removal in the Processor.
Jul 8 2021, 10:03
deadalnix committed rABC5f1a6c2150fd: [avalanche] More bucket brigading removal in the Processor (authored by deadalnix).
[avalanche] More bucket brigading removal in the Processor
Jul 8 2021, 10:03
Fabien added inline comments to D9749: [avalanche] More bucket brigading removal in the Processor.
Jul 8 2021, 10:02
Fabien accepted D9753: Simple cleanup in net_processing.cpp.
Jul 8 2021, 09:44
deadalnix added inline comments to D9749: [avalanche] More bucket brigading removal in the Processor.
Jul 8 2021, 09:42
deadalnix closed D9751: Broadcast proofs from the network layer.
Jul 8 2021, 09:37
deadalnix committed rABC38a9c81fc963: Broadcast proofs from the network layer (authored by deadalnix).
Broadcast proofs from the network layer
Jul 8 2021, 09:37
deadalnix requested review of D9753: Simple cleanup in net_processing.cpp.
Jul 8 2021, 09:34
Fabien accepted D9748: [Cashtab] icon improvements for PWA.

I have no way to test

Jul 8 2021, 09:13
Fabien accepted D9751: Broadcast proofs from the network layer.
Jul 8 2021, 09:11
Fabien accepted D9749: [avalanche] More bucket brigading removal in the Processor.
Jul 8 2021, 08:57
deadalnix closed D9747: [avalanche] Remove some bucket brigading in the Processor.
Jul 8 2021, 08:51
deadalnix committed rABC972eb4ed8ce2: [avalanche] Remove some bucket brigading in the Processor (authored by deadalnix).
[avalanche] Remove some bucket brigading in the Processor
Jul 8 2021, 08:51
deadalnix closed D9750: [avalanche] Move code around in the peer manager.
Jul 8 2021, 08:49
deadalnix committed rABC69125012b6ac: [avalanche] Move code around in the peer manager (authored by deadalnix).
[avalanche] Move code around in the peer manager
Jul 8 2021, 08:48
PiRK accepted D9752: [website] Update services listed on eCash page.
Jul 8 2021, 08:08
PiRK accepted D9750: [avalanche] Move code around in the peer manager.
Jul 8 2021, 08:07
PiRK accepted D9747: [avalanche] Remove some bucket brigading in the Processor.
Jul 8 2021, 07:55
Mengerian requested review of D9752: [website] Update services listed on eCash page.
Jul 8 2021, 04:21
abc-bot committed rABC67cb8c71d219: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Jul 8 2021, 03:19