Page MenuHomePhabricator
Feed All Stories

Tue, Jul 20

PiRK closed D9817: copyright-header: add two expected holder names.
Tue, Jul 20, 10:13
PiRK committed rABC3db7a09feb5c: copyright-header: add two expected holder names (authored by PiRK).
copyright-header: add two expected holder names
Tue, Jul 20, 10:12
deadalnix added a comment to D9760: [cashtab] Internationalization: Switch from fbt to react-intl.

If this solves the fbt issues, it's a step in the right direction.

Tue, Jul 20, 10:12
PiRK closed D9815: scripted-diff: Add missed copyright headers.
Tue, Jul 20, 10:11
PiRK committed rABC8f12ff4b1e31: scripted-diff: Add missed copyright headers (authored by PiRK).
scripted-diff: Add missed copyright headers
Tue, Jul 20, 10:11
Fabien accepted D9817: copyright-header: add two expected holder names.
Tue, Jul 20, 10:06
Fabien added a comment to D9816: make copyright headers more consistent.

I don't think you have the right to change the copyright from previous contributors, but I'm no expert and maybe a small case change like this is OK.

Tue, Jul 20, 10:05
PiRK updated the test plan for D9817: copyright-header: add two expected holder names.
Tue, Jul 20, 09:56
PiRK updated the diff for D9816: make copyright headers more consistent.

fix also sighastype.h (missing "The")

Tue, Jul 20, 09:56
PiRK updated the summary of D9815: scripted-diff: Add missed copyright headers.
Tue, Jul 20, 09:52
Fabien accepted D9815: scripted-diff: Add missed copyright headers.
Tue, Jul 20, 09:52
PiRK closed D9814: doc: Add missed copyright headers.
Tue, Jul 20, 09:44
PiRK committed rABCd23d7fee22c0: doc: Add missed copyright headers (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
doc: Add missed copyright headers
Tue, Jul 20, 09:44
PiRK closed D9813: scripts: update copyright_header script to include additional files.
Tue, Jul 20, 09:43
PiRK committed rABCf1430bb4289d: scripts: update copyright_header script to include additional files (authored by gchuf <gasper.cefarin@gmail.com>).
scripts: update copyright_header script to include additional files
Tue, Jul 20, 09:42
Fabien accepted D9814: doc: Add missed copyright headers.
Tue, Jul 20, 09:42
PiRK closed D9812: Include Objective-C source files.
Tue, Jul 20, 09:41
PiRK committed rABC9e2e1625dec6: Include Objective-C source files (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
Include Objective-C source files
Tue, Jul 20, 09:41
PiRK closed D9811: Scripts and tools: Drop no-longer-relevant copyright holder names.
Tue, Jul 20, 09:40
PiRK committed rABCcf7fcac26cc0: Scripts and tools: Drop no-longer-relevant copyright holder names (authored by Ben Woosley <ben.woosley@gmail.com>).
Scripts and tools: Drop no-longer-relevant copyright holder names
Tue, Jul 20, 09:40
PiRK closed D9810: Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions.
Tue, Jul 20, 09:39
PiRK committed rABC8de4a6bfaab1: Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions (authored by Ben Woosley <ben.woosley@gmail.com>).
Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions
Tue, Jul 20, 09:39
Fabien accepted D9813: scripts: update copyright_header script to include additional files.
Tue, Jul 20, 09:35
Fabien accepted D9812: Include Objective-C source files.
Tue, Jul 20, 09:34
PiRK updated the test plan for D9817: copyright-header: add two expected holder names.
Tue, Jul 20, 09:33
Fabien accepted D9811: Scripts and tools: Drop no-longer-relevant copyright holder names.
Tue, Jul 20, 09:33
PiRK requested review of D9817: copyright-header: add two expected holder names.
Tue, Jul 20, 09:33
PiRK updated the diff for D9816: make copyright headers more consistent.

fix another discrepency with an extra dash

Tue, Jul 20, 09:28
Fabien accepted D9810: Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions.
Tue, Jul 20, 09:24
PiRK updated the diff for D9816: make copyright headers more consistent.

remove also a "-" that the copyright headers script cannot handle

Tue, Jul 20, 09:24
PiRK requested review of D9816: make copyright headers more consistent.
Tue, Jul 20, 09:21
teamcity updated the summary of D9815: scripted-diff: Add missed copyright headers.
Tue, Jul 20, 09:19
PiRK requested review of D9815: scripted-diff: Add missed copyright headers.
Tue, Jul 20, 09:18
PiRK updated the summary of D9814: doc: Add missed copyright headers.
Tue, Jul 20, 09:17
teamcity updated the summary of D9814: doc: Add missed copyright headers.
Tue, Jul 20, 09:16
PiRK requested review of D9814: doc: Add missed copyright headers.
Tue, Jul 20, 09:16
teamcity updated the summary of D9813: scripts: update copyright_header script to include additional files.
Tue, Jul 20, 09:14
PiRK requested review of D9813: scripts: update copyright_header script to include additional files.
Tue, Jul 20, 09:14
teamcity updated the summary of D9812: Include Objective-C source files.
Tue, Jul 20, 09:12
PiRK requested review of D9812: Include Objective-C source files.
Tue, Jul 20, 09:12
teamcity updated the summary of D9811: Scripts and tools: Drop no-longer-relevant copyright holder names.
Tue, Jul 20, 09:11
PiRK requested review of D9811: Scripts and tools: Drop no-longer-relevant copyright holder names.
Tue, Jul 20, 09:11
teamcity updated the summary of D9810: Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions.
Tue, Jul 20, 09:09
PiRK requested review of D9810: Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions.
Tue, Jul 20, 09:09
Fabien updated the diff for D9805: Rebrand the comments in wallet_avoidreuse.py.

Use MM for millions

Tue, Jul 20, 07:27
Fabien updated the diff for D9804: Rebrand comments from C++ source files.

Feedback

Tue, Jul 20, 07:01
Fabien closed D9808: Rename the test unspendable address.
Tue, Jul 20, 06:53
Fabien committed rABC84140bbf25f8: Rename the test unspendable address (authored by Fabien).
Rename the test unspendable address
Tue, Jul 20, 06:53
Fabien closed D9807: Rebrand miscellaneous comments.
Tue, Jul 20, 06:52
Fabien committed rABC4dab0b5d04a5: Rebrand miscellaneous comments (authored by Fabien).
Rebrand miscellaneous comments
Tue, Jul 20, 06:52
Fabien closed D9806: Rebrand comments in functional tests.
Tue, Jul 20, 06:51
Fabien committed rABC364a26e8eb3b: Rebrand comments in functional tests (authored by Fabien).
Rebrand comments in functional tests
Tue, Jul 20, 06:51

Mon, Jul 19

majcosta requested changes to D9805: Rebrand the comments in wallet_avoidreuse.py.

what about abbreviating the million? I read that 'MM' is most common than 'm' or 'mil' so, use 1MM XEC instead of 1,000,000 seems to nicely avoid unnecessary zeroes

Mon, Jul 19, 18:37
majcosta requested changes to D9804: Rebrand comments from C++ source files.
Mon, Jul 19, 18:17
PiRK accepted D9806: Rebrand comments in functional tests.
Mon, Jul 19, 16:41
PiRK accepted D9807: Rebrand miscellaneous comments.
Mon, Jul 19, 16:38
PiRK accepted D9808: Rename the test unspendable address.
Mon, Jul 19, 16:37
Joey King <joseph.roy.king@gmail.com> closed D9803: [cashtab-components] disable token send from badge and button.
Mon, Jul 19, 16:14
Joey King <joseph.roy.king@gmail.com> committed rABCe01a52fb4f19: [cashtab-components] disable token send from badge and button (authored by Joey King <joseph.roy.king@gmail.com>).
[cashtab-components] disable token send from badge and button
Mon, Jul 19, 16:14
josephroyking added a comment to D9760: [cashtab] Internationalization: Switch from fbt to react-intl.

Please apply changes to the non-extension version of App.js as well

Mon, Jul 19, 16:06
Fabien requested review of D9808: Rename the test unspendable address.
Mon, Jul 19, 15:47
Fabien requested review of D9807: Rebrand miscellaneous comments.
Mon, Jul 19, 15:26
Fabien requested review of D9806: Rebrand comments in functional tests.
Mon, Jul 19, 15:23
Fabien requested review of D9805: Rebrand the comments in wallet_avoidreuse.py.
Mon, Jul 19, 15:20
Fabien requested review of D9804: Rebrand comments from C++ source files.
Mon, Jul 19, 15:17
PiRK abandoned D9478: [avalanche] make avalanche peer discovery in a simple case.

D9739

Mon, Jul 19, 12:43
Fabien closed D9739: [avalanche] Activate automated peer discovery.
Mon, Jul 19, 11:44
Fabien committed rABC203162c4df4e: [avalanche] Activate automated peer discovery (authored by Fabien).
[avalanche] Activate automated peer discovery
Mon, Jul 19, 11:44
Fabien updated the diff for D9739: [avalanche] Activate automated peer discovery.

Rebase

Mon, Jul 19, 11:09
Fabien closed D9703: [avalanche] Remember nodes pending a proof and bind them when available.
Mon, Jul 19, 11:03
Fabien committed rABCfb5cc4cd497d: [avalanche] Remember nodes pending a proof and bind them when available (authored by Fabien).
[avalanche] Remember nodes pending a proof and bind them when available
Mon, Jul 19, 11:03
deadalnix added a comment to D9760: [cashtab] Internationalization: Switch from fbt to react-intl.

Looking at react-intl, it seems to me like it is a significant step backward.

Mon, Jul 19, 10:46
deadalnix accepted D9703: [avalanche] Remember nodes pending a proof and bind them when available.
Mon, Jul 19, 10:26
Fabien updated the diff for D9703: [avalanche] Remember nodes pending a proof and bind them when available.

Move the erasure to addOrUpdateNode. This makes the code easier to reason about but causes requires a double loop in the fetchOrUpdatePeer() method to deal with invalidated iterators.

Mon, Jul 19, 10:16
Fabien accepted D9803: [cashtab-components] disable token send from badge and button.
Mon, Jul 19, 08:43
midisgroup updated midisgroup.
Mon, Jul 19, 07:54
Fabien commandeered D9739: [avalanche] Activate automated peer discovery.
Mon, Jul 19, 05:56
teamcity added a comment to D9760: [cashtab] Internationalization: Switch from fbt to react-intl.
Mon, Jul 19, 05:28
alcipir updated the diff for D9760: [cashtab] Internationalization: Switch from fbt to react-intl.

Fixing overwritten files from extension script.

Mon, Jul 19, 05:25

Sun, Jul 18

baby636 commandeered D9739: [avalanche] Activate automated peer discovery from Fabien.
Sun, Jul 18, 18:50

Sat, Jul 17

deadalnix requested changes to D9703: [avalanche] Remember nodes pending a proof and bind them when available.

A couple of questions, but this looks much better now.

Sat, Jul 17, 09:45

Fri, Jul 16

Fabien closed D9800: Update the seed pattern to accept 0.23 or 0.24 version.
Fri, Jul 16, 19:28
Fabien committed rABCcc237eee4af3: Update the seed pattern to accept 0.23 or 0.24 version (authored by Fabien).
Update the seed pattern to accept 0.23 or 0.24 version
Fri, Jul 16, 19:28
Fabien closed D9801: Remove the 1s timeouts in p2p_inv_download.
Fri, Jul 16, 19:20
Fabien committed rABCa1d89c232954: Remove the 1s timeouts in p2p_inv_download (authored by Fabien).
Remove the 1s timeouts in p2p_inv_download
Fri, Jul 16, 19:20
majcosta closed D9781: [avalanche] create an avalanche log category and use it.
Fri, Jul 16, 18:37
majcosta committed rABC8918cb8d71c4: [avalanche] create an avalanche log category and use it (authored by majcosta).
[avalanche] create an avalanche log category and use it
Fri, Jul 16, 18:37
majcosta requested changes to D9760: [cashtab] Internationalization: Switch from fbt to react-intl.
Fri, Jul 16, 18:15
majcosta added a comment to D9760: [cashtab] Internationalization: Switch from fbt to react-intl.

looks like something broke the tests, back to your queue

Fri, Jul 16, 18:14
majcosta closed D9795: Bump version to 0.23.9.
Fri, Jul 16, 18:05
majcosta committed rABC865eae92881f: Bump version to 0.23.9 (authored by majcosta).
Bump version to 0.23.9
Fri, Jul 16, 18:05
josephroyking requested review of D9803: [cashtab-components] disable token send from badge and button.
Fri, Jul 16, 16:33
josephroyking abandoned D9802: [cashtab-components] remove obsolete comment thread.
Fri, Jul 16, 16:28
josephroyking requested review of D9802: [cashtab-components] remove obsolete comment thread.
Fri, Jul 16, 16:27
Joey King <joseph.roy.king@gmail.com> closed D9782: [cashtab-components] rebrand support.
Fri, Jul 16, 16:26
Joey King <joseph.roy.king@gmail.com> committed rABCe982001851d6: [cashtab-components] rebrand support (authored by Joey King <joseph.roy.king@gmail.com>).
[cashtab-components] rebrand support
Fri, Jul 16, 16:25
PiRK accepted D9800: Update the seed pattern to accept 0.23 or 0.24 version.
Fri, Jul 16, 13:27
PiRK accepted D9801: Remove the 1s timeouts in p2p_inv_download.
Fri, Jul 16, 13:26
teamcity awarded D9800: Update the seed pattern to accept 0.23 or 0.24 version a Haypence token.
Fri, Jul 16, 13:25
Fabien added a comment to D9800: Update the seed pattern to accept 0.23 or 0.24 version.

@bot check-seeds

Fri, Jul 16, 13:24