- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jul 20 2021
In D9760#222098, @josephroyking wrote:If this solves the fbt issues, it's a step in the right direction.
I don't think you have the right to change the copyright from previous contributors, but I'm no expert and maybe a small case change like this is OK.
fix also sighastype.h (missing "The")
fix another discrepency with an extra dash
remove also a "-" that the copyright headers script cannot handle
Use MM for millions
Feedback
Jul 19 2021
what about abbreviating the million? I read that 'MM' is most common than 'm' or 'mil' so, use 1MM XEC instead of 1,000,000 seems to nicely avoid unnecessary zeroes
Please apply changes to the non-extension version of App.js as well
Rebase
Looking at react-intl, it seems to me like it is a significant step backward.
Move the erasure to addOrUpdateNode. This makes the code easier to reason about but requires a double loop in the fetchOrUpdatePeer() method to deal with invalidated iterators.
Fixing overwritten files from extension script.
Jul 18 2021
Jul 17 2021
A couple of questions, but this looks much better now.
Jul 16 2021
looks like something broke the tests, back to your queue