Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 9 2021
Sep 9 2021
Fabien planned changes to D10077: [avalanche] Use an ordered container for stakes in the proof builder.
teamcity added a comment to D10077: [avalanche] Use an ordered container for stakes in the proof builder.
teamcity added a comment to D10077: [avalanche] Use an ordered container for stakes in the proof builder.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
teamcity added a comment to D10077: [avalanche] Use an ordered container for stakes in the proof builder.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
teamcity added a comment to D10077: [avalanche] Use an ordered container for stakes in the proof builder.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Fabien requested review of D10077: [avalanche] Use an ordered container for stakes in the proof builder.
Using a set in the proof builder is a better solution but it breaks tests for duplicated inputs, since it's no longer possible to build them with the proof builder and so it requires a bit more test tooling. This is going to happen in a follow-up diff, for now I moved the TestProofBuilder structure to avalanche/test/util.h (will be expanded for duplicate inputs) and added a comment regarding the sorting function that needs to be removed from getProofId().
Going to use a std::set of stakes to keep them sorted all the time. This is more complicated to implement (and test) but more robust in the end since it enforces consistency.
update TX_NOT_STANDARD comment
it was missing an important line: add Check(request); in HandleRequest
[Automated] Update timing.json
teamcity triaged T1839: Build Bitcoin-ABC / Nightly Builds / Health Checks / Check Seeds is broken. as Unbreak Now! priority.
[Automated] Update seeds
[Automated] Update chainparams
Sep 8 2021
Sep 8 2021
teamcity triaged T1837: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
PiRK committed rABC6bbc85dcd3e9: rpc: Improve addnode remove command error message (authored by Fabian Jahr <fjahr@protonmail.com>).
rpc: Improve addnode remove command error message
PiRK committed rABCae4f7c1674cf: Cap listsinceblock target_confirmations param (authored by Adam Stein <adaminsky@gmail.com>).
Cap listsinceblock target_confirmations param
PiRK committed rABC95d394f4a6e7: [net] Add addpeeraddress RPC method (authored by John Newbery <john@johnnewbery.com>).
[net] Add addpeeraddress RPC method
PiRK committed rABC6d3b92de8b9a: [test] Test that getnodeaddresses() can return all known addresses (authored by John Newbery <john@johnnewbery.com>).
[test] Test that getnodeaddresses() can return all known addresses
PiRK committed rABCdf5400977f87: [addrman] Specify max addresses and pct when calling GetAddresses() (authored by John Newbery <john@johnnewbery.com>).
[addrman] Specify max addresses and pct when calling GetAddresses()
PiRK updated the summary of D10070: [test] Test that getnodeaddresses() can return all known addresses.
add parentheses
PiRK updated the test plan for D10075: remove argName nBlocks from estimatefee RPC command registration.
remove the arg also from vRPCConvertParams
majcosta requested changes to D10075: remove argName nBlocks from estimatefee RPC command registration.
linter be mad
majcosta requested changes to D10074: rpc: document returned error fields as optional if applicable.
nit: link to the specific commit in the summary is wrong, points to 3/3 rather than 2/3
teamcity updated the summary of D10074: rpc: document returned error fields as optional if applicable.
PiRK updated the summary of D10069: [addrman] Specify max addresses and pct when calling GetAddresses().
teamcity updated the summary of D10070: [test] Test that getnodeaddresses() can return all known addresses.
PiRK requested review of D10070: [test] Test that getnodeaddresses() can return all known addresses.
PiRK updated the test plan for D10069: [addrman] Specify max addresses and pct when calling GetAddresses().
teamcity updated the summary of D10069: [addrman] Specify max addresses and pct when calling GetAddresses().
PiRK requested review of D10069: [addrman] Specify max addresses and pct when calling GetAddresses().
teamcity triaged T1834: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
PiRK committed rABC7b81a4a8aac4: refactor: test: use _ variable for unused loop counters (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
refactor: test: use _ variable for unused loop counters
Klakurka moved T1695: Bump extension version and advertise it from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 8 2021, 06:01 · Restricted Project
Sep 7 2021
Sep 7 2021
Additional note: I had a quick look to see if there is an automated linter solution (autopep8...) for this. I couldn't find any.
teamcity triaged T1830: Build Bitcoin-ABC / Master / Build without ZMQ is broken. as Unbreak Now! priority.
teamcity triaged T1829: Build Bitcoin-ABC / Master / Build without BIP70 is broken. as Unbreak Now! priority.
PiRK committed rABCbec895ada9fc: Deduplicate missing parents of orphan transactions (authored by Suhas Daftuar <sdaftuar@gmail.com>).
Deduplicate missing parents of orphan transactions
PiRK committed rABC009a334cb208: Rewrite parent txid loop of requested transactions (authored by Suhas Daftuar <sdaftuar@gmail.com>).
Rewrite parent txid loop of requested transactions
PiRK committed rABC0a4beac5f0e8: test: Wait for 'cmpctblock' in p2p_compactblocks when it is expected (authored by Ben Woosley <ben.woosley@gmail.com>).
test: Wait for 'cmpctblock' in p2p_compactblocks when it is expected
PiRK committed rABC85f7e0cf3f71: test: Wait until is_connected in add_p2p_connection (authored by MarcoFalke <falke.marco@gmail.com>).
test: Wait until is_connected in add_p2p_connection
test: use the correct DISCOURAGEMENT_THRESHOLD
PiRK committed rABC636042be375f: doc: Replace `hidden service` with `onion service` (authored by Riccardo Masutti <46527252+RiccardoMasutti@users.noreply.github.com>).
doc: Replace `hidden service` with `onion service`
PiRK committed rABC89fed9b66d97: util: use HAVE_FDATASYNC to determine fdatasync() use (authored by fanquake <fanquake@gmail.com>).
util: use HAVE_FDATASYNC to determine fdatasync() use
PiRK committed rABC100e3ff738e9: Preserve the LockData initial state if "potential deadlock detected" exception… (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
Preserve the LockData initial state if "potential deadlock detected" exception…
PiRK committed rABC650a45afbcac: rpc: Document getwalletinfo's unlocked_until field as optional (authored by Justin Moon <mail@justinmoon.com>).
rpc: Document getwalletinfo's unlocked_until field as optional