Page MenuHomePhabricator
Feed All Stories

Oct 30 2023

Fabien requested review of D14706: Bump version to 0.28.2.
Oct 30 2023, 18:55
Fabien updated the diff for D14704: [avalanche] Make sure the finalization status is maintained when a proof is promoted from dangling.

Simplify the assert is True

Oct 30 2023, 18:53
Fabien added inline comments to D14704: [avalanche] Make sure the finalization status is maintained when a proof is promoted from dangling.
Oct 30 2023, 18:51
johnkuney requested review of D14705: [e.cash] getScores edit.
Oct 30 2023, 18:48
PiRK added inline comments to D14704: [avalanche] Make sure the finalization status is maintained when a proof is promoted from dangling.
Oct 30 2023, 18:15
bytesofman added a comment to D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).

looks good

Oct 30 2023, 18:11
PiRK added inline comments to D14704: [avalanche] Make sure the finalization status is maintained when a proof is promoted from dangling.
Oct 30 2023, 18:06
bytesofman accepted D14702: [electrum] Fix various strings that were wrong, inconsistent or not translatable.
Oct 30 2023, 17:55
bytesofman added a comment to D14701: [electrum] secp256k1: Improve warning message by adding path and exception details.

code here looks good. i'm not getting the expected output from this test plan, though:

Oct 30 2023, 17:53
bytesofman added inline comments to D14704: [avalanche] Make sure the finalization status is maintained when a proof is promoted from dangling.
Oct 30 2023, 17:47
bytesofman accepted D14699: [e.cash] Open external links in new tab - mining page.
Oct 30 2023, 17:17
Fabien requested review of D14704: [avalanche] Make sure the finalization status is maintained when a proof is promoted from dangling.
Oct 30 2023, 17:15
teamcity added a comment to D14699: [e.cash] Open external links in new tab - mining page.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.220.62:41611 for the next 60 minutes.

Oct 30 2023, 17:10
teamcity awarded D14699: [e.cash] Open external links in new tab - mining page a Haypence token.
Oct 30 2023, 17:01
bytesofman added a comment to D14699: [e.cash] Open external links in new tab - mining page.

@bot preview-e.cash

Oct 30 2023, 17:01
bytesofman closed D14696: [Cashtab Extension] Close open pop-ups before opening a new one.
Oct 30 2023, 16:54
bytesofman committed rABCee8caf2fb3e7: [Cashtab Extension] Close open pop-ups before opening a new one (authored by bytesofman).
[Cashtab Extension] Close open pop-ups before opening a new one
Oct 30 2023, 16:54
bytesofman closed D14692: [Cashtab Extension] Migrate to v3 manifest.
Oct 30 2023, 16:54
bytesofman committed rABCf3e86163c920: [Cashtab Extension] Migrate to v3 manifest (authored by bytesofman).
[Cashtab Extension] Migrate to v3 manifest
Oct 30 2023, 16:54
bytesofman closed D14695: [chronik] Add new endpoint to check chronik version.
Oct 30 2023, 16:52
bytesofman committed rABC423262c39829: [chronik] Add new endpoint to check chronik version (authored by bytesofman).
[chronik] Add new endpoint to check chronik version
Oct 30 2023, 16:52
PiRK retitled D14702: [electrum] Fix various strings that were wrong, inconsistent or not translatable from Fix various strings that were wrong, inconsistent or not translatable to [electrum] Fix various strings that were wrong, inconsistent or not translatable.
Oct 30 2023, 12:07
teamcity updated the summary of D14702: [electrum] Fix various strings that were wrong, inconsistent or not translatable.
Oct 30 2023, 11:03
PiRK requested review of D14702: [electrum] Fix various strings that were wrong, inconsistent or not translatable.
Oct 30 2023, 11:03
PiRK retitled D14701: [electrum] secp256k1: Improve warning message by adding path and exception details from secp256k1: Improve warning message by adding path and exception details to [electrum] secp256k1: Improve warning message by adding path and exception details.
Oct 30 2023, 10:51
teamcity updated the summary of D14701: [electrum] secp256k1: Improve warning message by adding path and exception details.
Oct 30 2023, 10:50
PiRK requested review of D14701: [electrum] secp256k1: Improve warning message by adding path and exception details.
Oct 30 2023, 10:50

Oct 29 2023

johnkuney abandoned D14700: [e.cash] Add check for null value in scores.js.
Oct 29 2023, 23:23
johnkuney requested review of D14700: [e.cash] Add check for null value in scores.js.
Oct 29 2023, 23:21
johnkuney requested review of D14699: [e.cash] Open external links in new tab - mining page.
Oct 29 2023, 22:48
abc-bot committed rABC4777fa9e0a5d: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Oct 29 2023, 22:20
abc-bot committed rABC2a0c4b63f28a: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Oct 29 2023, 22:09
emack retitled D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC) from [Cashtab][Swap] Sideshift integration (POC) to [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 29 2023, 01:28
emack updated the diff for D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).

Updated the Swap component to be a central portal for all Swap widgets rather than SideShift specific. It now houses both ChangeNow and SideShift.

Oct 29 2023, 01:18
emack retitled D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC) from [Cashtab][Swap] Sideshift integration (POC) to [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 29 2023, 01:18

Oct 28 2023

emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 23:56
emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 23:39
emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 23:39
emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 14:04
emack updated the summary of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 14:00
emack requested review of D14698: [Cashtab][Swap] Sideshift & ChangeNow integration (POC).
Oct 28 2023, 13:57
emack added a comment to D14269: [Chronik-client] - Cycle through backup instances on outage.

On a separate note, I've also carried out localized usage of this diff in /apps/examples and it tested fine.
i.e.

  1. Refreshed the dist folder within /modules/chronik-client repo via npm run build
  2. Go into /apps/examples and removed current client npm uninstall chronik-client
  3. Installed this diff via npm i ../../modules/chronik-client
  4. Go into /apps/examples/getDetailsFromTxid.js, import the client via the relative path above and instantiated ChronikClient constructor with an array of 1 mispelt url (simulated outage) and 1 correctly spelt url
  5. Executed the example via npm run getDetailsFromTxid <txid> and it should cycle past the 1st url and connects successfully on the 2nd url to return the transaction details.
Oct 28 2023, 09:06
Fabien accepted D14696: [Cashtab Extension] Close open pop-ups before opening a new one.
Oct 28 2023, 08:14
Fabien accepted D14695: [chronik] Add new endpoint to check chronik version.
Oct 28 2023, 08:13
emack added inline comments to D14269: [Chronik-client] - Cycle through backup instances on outage.
Oct 28 2023, 08:01
emack updated the diff for D14269: [Chronik-client] - Cycle through backup instances on outage.

Responding to feedback

Oct 28 2023, 08:00
emack updated the diff for D14611: [Cashtab][Alias] Pending Aliases.

Full onchain pending alias check is now implemented in the post-registration-button-click logic (preparePreviewModal), which renders an additional sentence in the registration confirmation modal, depending on whether pending.length is > 0. The local pending check per keystroke is now removed due to low value.

Oct 28 2023, 05:11
teamcity triaged T3328: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Windows 64-bit is broken. as Unbreak Now! priority.
Oct 28 2023, 03:53
PiRK closed D14690: net: fix GetListenPort() to derive the proper port.
Oct 28 2023, 03:13
PiRK committed rABC50401c4ab752: net: fix GetListenPort() to derive the proper port (authored by Vasil Dimov <vd@FreeBSD.org>).
net: fix GetListenPort() to derive the proper port
Oct 28 2023, 03:13

Oct 27 2023

emack planned changes to D14611: [Cashtab][Alias] Pending Aliases.
Oct 27 2023, 21:37
Fabien accepted D14690: net: fix GetListenPort() to derive the proper port.
Oct 27 2023, 18:30
tobias_ruck added a comment to D14269: [Chronik-client] - Cycle through backup instances on outage.

Re the XPI instances: Good idea anyway. I was reindexing them yesteday, that's why the tests failed.

Oct 27 2023, 17:32
bytesofman updated the diff for D14696: [Cashtab Extension] Close open pop-ups before opening a new one.

rebase

Oct 27 2023, 16:54
bytesofman updated the diff for D14692: [Cashtab Extension] Migrate to v3 manifest.

rebase

Oct 27 2023, 16:54
bytesofman added inline comments to D14696: [Cashtab Extension] Close open pop-ups before opening a new one.
Oct 27 2023, 16:45
Mengerian closed D14694: [e.cash] Remove mention of bits for the denomination.
Oct 27 2023, 16:38
Mengerian committed rABC7ea1e609a913: [e.cash] Remove mention of bits for the denomination (authored by Mengerian).
[e.cash] Remove mention of bits for the denomination
Oct 27 2023, 16:38
PiRK accepted D14695: [chronik] Add new endpoint to check chronik version.
Oct 27 2023, 16:21
bytesofman updated the diff for D14695: [chronik] Add new endpoint to check chronik version.

Move chronik version grab to a function to avoid global var

Oct 27 2023, 16:20
PiRK updated the diff for D14690: net: fix GetListenPort() to derive the proper port.

use config to derive chainparams

Oct 27 2023, 15:06
PiRK added inline comments to D14690: net: fix GetListenPort() to derive the proper port.
Oct 27 2023, 14:52
PiRK added inline comments to D14690: net: fix GetListenPort() to derive the proper port.
Oct 27 2023, 14:52
emack requested review of D14666: [Cashtab][Alias] Alias lookup facility.

Why do you have a search button if you're having the lookup at every key stroke ?

Pending the pending discussion in D14611 before evaluating whether this search is redundant.

Oct 27 2023, 14:14
Fabien requested changes to D14695: [chronik] Add new endpoint to check chronik version.
Oct 27 2023, 13:53
Fabien added a comment to D14611: [Cashtab][Alias] Pending Aliases.

otherwise you'll have one area of the component checking for pending specific to this wallet, and the other checking across chain.

There are very different use cases: the per address is how you fill your pending and registered aliases lists, the the "full" alias check is to instruct the user of a conflict

Oct 27 2023, 13:50
Fabien added inline comments to D14696: [Cashtab Extension] Close open pop-ups before opening a new one.
Oct 27 2023, 13:46
Fabien requested changes to D14690: net: fix GetListenPort() to derive the proper port.

This is unfortunate but these tests will always be skipped on CI

Oct 27 2023, 13:41
johnkuney closed D14697: [e.cash] Add code block component.
Oct 27 2023, 13:36
johnkuney committed rABC99a3f89eae3e: [e.cash] Add code block component (authored by johnkuney).
[e.cash] Add code block component
Oct 27 2023, 13:36
bytesofman added inline comments to D14696: [Cashtab Extension] Close open pop-ups before opening a new one.
Oct 27 2023, 13:22
PiRK updated the test plan for D14690: net: fix GetListenPort() to derive the proper port.
Oct 27 2023, 12:47
bytesofman updated the diff for D14695: [chronik] Add new endpoint to check chronik version.

More robust methods for path handling per review suggestions

Oct 27 2023, 12:34
bytesofman closed D14693: [Prettier] Use prettier on Cashtab extension files.
Oct 27 2023, 12:24
bytesofman committed rABC435ac4a02139: [Prettier] Use prettier on Cashtab extension files (authored by bytesofman).
[Prettier] Use prettier on Cashtab extension files
Oct 27 2023, 12:24
PiRK updated the diff for D14690: net: fix GetListenPort() to derive the proper port.

fix argument name in comment

Oct 27 2023, 11:49
emack added a comment to D14666: [Cashtab][Alias] Alias lookup facility.

Why do you have a search button if you're having the lookup at every key stroke ?

Oct 27 2023, 11:43
emack requested review of D14611: [Cashtab][Alias] Pending Aliases.
Oct 27 2023, 11:39
PiRK planned changes to D14690: net: fix GetListenPort() to derive the proper port.
Oct 27 2023, 11:37
emack planned changes to D14666: [Cashtab][Alias] Alias lookup facility.
Oct 27 2023, 11:29
emack added a comment to D14666: [Cashtab][Alias] Alias lookup facility.
Oct 27 2023, 09:58
Fabien accepted D14697: [e.cash] Add code block component.
Oct 27 2023, 08:41
teamcity added a comment to D14697: [e.cash] Add code block component.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41765 for the next 60 minutes.

Oct 27 2023, 08:39
teamcity awarded D14697: [e.cash] Add code block component a Haypence token.
Oct 27 2023, 08:37
Fabien added a comment to D14697: [e.cash] Add code block component.

@bot preview-e.cash

Oct 27 2023, 08:37
Fabien added inline comments to D14696: [Cashtab Extension] Close open pop-ups before opening a new one.
Oct 27 2023, 08:31
teamcity added a comment to D14690: net: fix GetListenPort() to derive the proper port.
Oct 27 2023, 08:12
PiRK published D14690: net: fix GetListenPort() to derive the proper port for review.
Oct 27 2023, 08:07
Fabien added a comment to D14666: [Cashtab][Alias] Alias lookup facility.

Why do you have a search button if you're having the lookup at every key stroke ?

Oct 27 2023, 07:53
PiRK requested changes to D14695: [chronik] Add new endpoint to check chronik version.
Oct 27 2023, 06:45
PiRK accepted D14693: [Prettier] Use prettier on Cashtab extension files.
Oct 27 2023, 06:26
PiRK accepted D14692: [Cashtab Extension] Migrate to v3 manifest.
Oct 27 2023, 06:25
PiRK closed D14689: refactor: Treat CDataStream bytes as uint8_t.
Oct 27 2023, 06:19
PiRK committed rABC5e862abc23cc: refactor: Treat CDataStream bytes as uint8_t (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Treat CDataStream bytes as uint8_t
Oct 27 2023, 06:19
johnkuney requested review of D14697: [e.cash] Add code block component.
Oct 27 2023, 02:24

Oct 26 2023

emack updated the diff for D14666: [Cashtab][Alias] Alias lookup facility.
  • Initialized aliasLookupName in formData
  • Using the newest pending prop in the /alias endpoint to distinguish between unregistered or pending confirmation aliases
  • Screenshots below:
Oct 26 2023, 23:27
bytesofman updated the diff for D14695: [chronik] Add new endpoint to check chronik version.

do not use relative path to read cargo toml

Oct 26 2023, 22:48
bytesofman planned changes to D14695: [chronik] Add new endpoint to check chronik version.

don't use relative path

Oct 26 2023, 22:45
bytesofman requested review of D14696: [Cashtab Extension] Close open pop-ups before opening a new one.
Oct 26 2023, 22:37
teamcity added a comment to D14695: [chronik] Add new endpoint to check chronik version.
Oct 26 2023, 22:33