Simplify the assert is True
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Oct 30 2023
looks good
code here looks good. i'm not getting the expected output from this test plan, though:
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.220.62:41611 for the next 60 minutes.
@bot preview-e.cash
Oct 29 2023
Updated the Swap component to be a central portal for all Swap widgets rather than SideShift specific. It now houses both ChangeNow and SideShift.
Oct 28 2023
On a separate note, I've also carried out localized usage of this diff in /apps/examples and it tested fine.
i.e.
- Refreshed the dist folder within /modules/chronik-client repo via npm run build
- Go into /apps/examples and removed current client npm uninstall chronik-client
- Installed this diff via npm i ../../modules/chronik-client
- Go into /apps/examples/getDetailsFromTxid.js, import the client via the relative path above and instantiated ChronikClient constructor with an array of 1 mispelt url (simulated outage) and 1 correctly spelt url
- Executed the example via npm run getDetailsFromTxid <txid> and it should cycle past the 1st url and connects successfully on the 2nd url to return the transaction details.
Responding to feedback
Full onchain pending alias check is now implemented in the post-registration-button-click logic (preparePreviewModal), which renders an additional sentence in the registration confirmation modal, depending on whether pending.length is > 0. The local pending check per keystroke is now removed due to low value.
Oct 27 2023
Re the XPI instances: Good idea anyway. I was reindexing them yesteday, that's why the tests failed.
rebase
rebase
Move chronik version grab to a function to avoid global var
use config to derive chainparams
In D14666#330192, @emack wrote:In D14666#330165, @Fabien wrote:Why do you have a search button if you're having the lookup at every key stroke ?
Pending the pending discussion in D14611 before evaluating whether this search is redundant.
otherwise you'll have one area of the component checking for pending specific to this wallet, and the other checking across chain.
There are very different use cases: the per address is how you fill your pending and registered aliases lists, the the "full" alias check is to instruct the user of a conflict
This is unfortunate but these tests will always be skipped on CI
More robust methods for path handling per review suggestions
fix argument name in comment
In D14666#330165, @Fabien wrote:Why do you have a search button if you're having the lookup at every key stroke ?
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41765 for the next 60 minutes.
@bot preview-e.cash
Why do you have a search button if you're having the lookup at every key stroke ?
Oct 26 2023
- Initialized aliasLookupName in formData
- Using the newest pending prop in the /alias endpoint to distinguish between unregistered or pending confirmation aliases
- Screenshots below:
do not use relative path to read cargo toml
don't use relative path