Setting the IFP address as the settlement address.

Added isValidSideshiftObj() along with unit tests to validation.js to check that the instantiated sideshift object contains the expected APIs. If not valid, an error is displayed in place of the button in Swap.js. This can be verified by malforming the sidieshift library url in /public/index.html header.

Rejigged UI for reference:

Re-arranged UI per feedback, updated label for active wallet registration checkbox.

Improved pending array filter and variable names.

rebase

Provide overlay override as the default layout positions the close (X) button above the top browser bar

Seems like this is as good as we can get with the widget implementation.

Rebase, remove deprecation notice

We're not going to deprecate this, will be added to chronik

forgot this was a stacked diff and pushed changes to the wrong place

Rebase to latest master, remove deprecation notice

fix RelayProof and RelayTransaction: don't bail out for the first peer that does not want txs relayed

And as far as that other test change in getScoreCardData, I added it here because the sort change was causing that test to fail as it was

Okay added, I couldnt think of a better place to put the scoreThreshold than at the top of scores.js, but open to suggestions

edit comments, add scorethreshold as a parameter and update tests

UI remark: the ordering of the elements is not the best imo. Here is what I would do:
Input field
Alias length
Check button
Register using the wallet address checkbox
Register button

Will re-use the existing registration field with a check button as a separate diff.

Added pendingAliasCounter to tally count of certain aliases within the pending array for the current address.

Added conditional substring to the pending alias warning which indicates number of pending registrations for this wallet address.

make AddKnownProof static, add fuzzer compiling to test plan

In D14666#330225, @emack wrote:

In D14666#330192, @emack wrote:

In D14666#330165, @Fabien wrote:

Why do you have a search button if you're having the lookup at every key stroke ?

Pending the pending discussion in D14611 before evaluating whether this search is redundant.

As per discussion in D14611, now that we've decided the "check all pending instances of this alias" API call is made after the registration button is pressed and that check per keystroke is to be removed, then I think this search has a place here otherwise the only way the user can check the status of an alias is to almost go through to the end of a registration process. When millions of XEC in registration fees are involved, this can be scary for the user if they are just after info with no intention of registering yet.

Having said that, users CAN technically input an alias into the address field on the send XEC screen to see if it renders an address or not but it kinda feels hacky from a UX pov and involves navigating back and forth with the Alias screen if you're checking multiple aliases. I'm ok either way so if leaving lookups it to the Send screen is feasible then I can abandon this diff.

Can you tell if the pending aliases are from this wallet ? Like message in screenshot 2 would tell "there are 6 pending registrations for this alias, including 2 for this wallet address"

Updated test snapshot for Home

Looks good on the preview

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41686 for the next 60 minutes.

@bot preview-e.cash

@bot build-e.cash

In D14701#330378, @bytesofman wrote:

code here looks good. i'm not getting the expected output from this test plan, though:

./electrum-abc -v

-> Electrum opens, lots of output, nothing about [secp256k1] warning

mb not following this correctly / need to be running it in some special condition?

I will edit the test plan to clarify that this output is printed only if the application fails to find any secp256k1 lib, which happens when running from source when contrib/make_secp256k1 was never executed (or its output is deleted) and the lib is not installed via a package manager