- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Nov 3 2023
@bot build-tsan
Updated processChronikWsMsg() to refresh pricing every 90 blocks rather than every block
Updated UI as follows
Nov 2 2023
are these proof editor improvements driven by user stories?
Is this diff in response to user complaints? what's the root cause of wanting to add this functionality?
In D14713#330950, @bytesofman wrote:You should do an API call on each block and store the value locally, obviously a lookup for each keystroke is the wrong design.
this is a good idea but imo should be it's own diff. not necessarily related to just this UI change, easy enough to add into this UI -- but does require some new logic.
see inline comments. potentially i'm just misunderstanding a normal pything / electrum thing. if so, please let me know what's going on 🙏
nice, buttons look way better now
add more robust unit test
In the case there are pending alias you should not have the green "everything is fine" register confirmation text, but rather something purple like "Continue the registration anyway ?"
The unit test needs to give confidence the code is working, not only testing the happy path (as per telegram discussion)
I don't see the registration fee in the snapshots ? Otherwise the last one LGTM
In D14713#330683, @emack wrote:Re-arranged UI per feedback, updated label for active wallet registration checkbox.
The register button could show the registration fee, like "Register alias for 556 XEC".
This was a design decision to not show the price here because it would be an API call per keystroke to get the price for current length. Even though the price is not expected to change frequently we felt it was better to have a single source of truth on the server side, which is called only once at the registration confirmation dialogue. Alternatively I can keep a copy of the pricing array in Cashtab so it can achieve pricing reads on the fly without calling the API but I'll need to manually keep it in sync with any pricing changes on the server.
code OK, i fixed the summary
@bot build-win64
This was the last diff for which the windows crossbuild succeeded, so I'm running it to check if it still works at this commit, or if the failure is not related to a change in code (change in CI hardware?)
@bot build-win64
Updated checkbox logic to toggle between showing and hiding the seed phrase in addition to the updated static warning message.
Updated UI per feedback.
Nov 1 2023
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41659 for the next 60 minutes.
@bot preview-e.cash
I raised with the SideShift team yesterday via tg and they fixed it along with the cancel order bug.
- add some space between the alias length and the check button
- the check and register buttons should not look identical. maybe include a magnifying glass ("search") icon on the check button, and a dollar sign or some other appropriate icon on the register button. Also different colors.
actually -- seeing how these are implemented, I don't think my previous feedback needs to be handled in this diff. Should have separate diffs to get better modal appearance.
let's make the fact that there are pending aliases here a little scarier
Use camel case
Add space
For next time could move the version number to a variable so you only have to change it in one place
@bot preview e.cash
We should still show the warning when the seed phrase is displayed.