Page MenuHomePhabricator
Feed All Stories

Jan 11 2025

bytesofman published D17515: [Cashtab] Prevent creation of unacceptable agora offers for review.
Jan 11 2025, 20:47
bytesofman closed D17512: [Cashtab] Patch agora token switch issue.
Jan 11 2025, 20:23
bytesofman committed rABCb94164d65fdf: [Cashtab] Patch agora token switch issue (authored by bytesofman).
[Cashtab] Patch agora token switch issue
Jan 11 2025, 20:23
bytesofman closed D17513: [Cashtab] [bugfix] Do not bring back old state on wallet change.
Jan 11 2025, 20:20
bytesofman committed rABC02f6a143cd87: [Cashtab] [bugfix] Do not bring back old state on wallet change (authored by bytesofman).
[Cashtab] [bugfix] Do not bring back old state on wallet change
Jan 11 2025, 20:20
Fabien accepted D17513: [Cashtab] [bugfix] Do not bring back old state on wallet change.
Jan 11 2025, 19:56
Fabien accepted D17512: [Cashtab] Patch agora token switch issue.
Jan 11 2025, 19:54
bytesofman added inline comments to D17513: [Cashtab] [bugfix] Do not bring back old state on wallet change.
Jan 11 2025, 15:38
bytesofman published D17513: [Cashtab] [bugfix] Do not bring back old state on wallet change for review.
Jan 11 2025, 15:16
bytesofman published D17512: [Cashtab] Patch agora token switch issue for review.
Jan 11 2025, 14:59
bytesofman closed D17508: [Cashtab] Do not load ALL agora offers unless the user asks for it.
Jan 11 2025, 14:06
bytesofman committed rABCf4da4c7e9df0: [Cashtab] Do not load ALL agora offers unless the user asks for it (authored by bytesofman).
[Cashtab] Do not load ALL agora offers unless the user asks for it
Jan 11 2025, 14:06
bytesofman closed D17511: [Cashtab] Make agora screen more polite.
Jan 11 2025, 13:20
bytesofman committed rABCd32dcc48d1dd: [Cashtab] Make agora screen more polite (authored by bytesofman).
[Cashtab] Make agora screen more polite
Jan 11 2025, 13:20
johnkuney accepted D17511: [Cashtab] Make agora screen more polite.
Jan 11 2025, 07:01
johnkuney accepted D17508: [Cashtab] Do not load ALL agora offers unless the user asks for it.

Cool, works for me and is good interim solution. The polite loading is nice
Only suggestion is move the button below the initial listings for subjective reasons

Jan 11 2025, 07:01
bytesofman updated the diff for D17511: [Cashtab] Make agora screen more polite.

better handling of timeout issue on tests

Jan 11 2025, 00:58
Mengerian closed D17509: Update Copyright year to 2025.
Jan 11 2025, 00:19
Mengerian committed rABCdc90cfdb30bf: Update Copyright year to 2025 (authored by Mengerian).
Update Copyright year to 2025
Jan 11 2025, 00:19

Jan 10 2025

teamcity added a comment to D17511: [Cashtab] Make agora screen more polite.
Jan 10 2025, 23:59
bytesofman published D17511: [Cashtab] Make agora screen more polite for review.
Jan 10 2025, 23:55
bytesofman updated the diff for D17508: [Cashtab] Do not load ALL agora offers unless the user asks for it.

rebase, make styles fit in new design, update tests

Jan 10 2025, 23:48
bytesofman closed D17510: [Cashtab] Hide sort switches on mange my offers option as they do not work there.
Jan 10 2025, 23:27
bytesofman committed rABC46157ebe45a3: [Cashtab] Hide sort switches on mange my offers option as they do not work there (authored by bytesofman).
[Cashtab] Hide sort switches on mange my offers option as they do not work there
Jan 10 2025, 23:27
johnkuney accepted D17510: [Cashtab] Hide sort switches on mange my offers option as they do not work there.
Jan 10 2025, 23:24
bytesofman published D17510: [Cashtab] Hide sort switches on mange my offers option as they do not work there for review.
Jan 10 2025, 23:19
bytesofman published D17508: [Cashtab] Do not load ALL agora offers unless the user asks for it for review.
Jan 10 2025, 23:16
johnkuney closed D17502: [cashtab] Agora UI updates.
Jan 10 2025, 22:54
johnkuney committed rABC27e92083c795: [cashtab] Agora UI updates (authored by johnkuney).
[cashtab] Agora UI updates
Jan 10 2025, 22:54
bytesofman accepted D17502: [cashtab] Agora UI updates.
Jan 10 2025, 22:52
johnkuney added a comment to D17502: [cashtab] Agora UI updates.

Cool, added

Jan 10 2025, 22:27
johnkuney updated the diff for D17502: [cashtab] Agora UI updates.

remove css class and make it a styled component

Jan 10 2025, 22:26
bytesofman requested changes to D17502: [cashtab] Agora UI updates.

Looks much better. Also much better sorting UI vs the switches would love a similar UI lift on the Token page.

Jan 10 2025, 21:48
bytesofman accepted D17509: Update Copyright year to 2025.
Jan 10 2025, 21:31
Mengerian requested review of D17509: Update Copyright year to 2025.
Jan 10 2025, 21:14
johnkuney updated the diff for D17502: [cashtab] Agora UI updates.

rebase

Jan 10 2025, 18:47
roqqit closed D17503: [avalanche] Set all local stake winners as accepted contenders.
Jan 10 2025, 16:46
roqqit committed rABCe9b4cbef3b43: [avalanche] Set all local stake winners as accepted contenders (authored by roqqit).
[avalanche] Set all local stake winners as accepted contenders
Jan 10 2025, 16:46
bytesofman closed D17504: [Cashtab] Show XECX balance.
Jan 10 2025, 15:49
bytesofman committed rABCf6a1d08dc55a: [Cashtab] Show XECX balance (authored by bytesofman).
[Cashtab] Show XECX balance
Jan 10 2025, 15:49
johnkuney updated the summary of D17502: [cashtab] Agora UI updates.
Jan 10 2025, 15:30
johnkuney published D17502: [cashtab] Agora UI updates for review.
Jan 10 2025, 15:29
PiRK closed D17507: [chronik] cleanup of json_to_u31 helper function.
Jan 10 2025, 14:39
PiRK committed rABCf3dfa6c485fe: [chronik] cleanup of json_to_u31 helper function (authored by PiRK).
[chronik] cleanup of json_to_u31 helper function
Jan 10 2025, 14:39
PiRK closed D17501: [chronik] implement electrum RPC blockchain.block.headers.
Jan 10 2025, 14:39
PiRK committed rABC98839217de42: [chronik] implement electrum RPC blockchain.block.headers (authored by PiRK).
[chronik] implement electrum RPC blockchain.block.headers
Jan 10 2025, 14:39
emack accepted D17504: [Cashtab] Show XECX balance.
Jan 10 2025, 13:59
PiRK updated the diff for D17501: [chronik] implement electrum RPC blockchain.block.headers.

collect the headers_hex

Jan 10 2025, 13:31
Fabien accepted D17501: [chronik] implement electrum RPC blockchain.block.headers.
Jan 10 2025, 13:11
bytesofman updated the diff for D17504: [Cashtab] Show XECX balance.

comment on balanceXecx getter

Jan 10 2025, 13:06
bytesofman added inline comments to D17504: [Cashtab] Show XECX balance.
Jan 10 2025, 13:06
bytesofman committed rABCe5e3f1c17199: [mock-chronik-client] Update README (authored by bytesofman).
[mock-chronik-client] Update README
Jan 10 2025, 13:04
bytesofman closed D17506: [mock-chronik-client] Update README.
Jan 10 2025, 13:04
Fabien accepted D17507: [chronik] cleanup of json_to_u31 helper function.
Jan 10 2025, 12:56
Unknown Object (User) added a comment to D17507: [chronik] cleanup of json_to_u31 helper function.
Jan 10 2025, 12:42
PiRK requested review of D17507: [chronik] cleanup of json_to_u31 helper function.
Jan 10 2025, 12:17
PiRK added inline comments to D17501: [chronik] implement electrum RPC blockchain.block.headers.
Jan 10 2025, 11:56
PiRK updated the diff for D17501: [chronik] implement electrum RPC blockchain.block.headers.

use headers_by_range which simplifies the code a lot

Jan 10 2025, 11:56
Fabien accepted D17503: [avalanche] Set all local stake winners as accepted contenders.
Jan 10 2025, 10:16
Fabien requested changes to D17501: [chronik] implement electrum RPC blockchain.block.headers.

More questions than requesting changes

Jan 10 2025, 08:51
emack requested changes to D17504: [Cashtab] Show XECX balance.
Jan 10 2025, 08:31
emack accepted D17506: [mock-chronik-client] Update README.
Jan 10 2025, 08:30
bytesofman published D17506: [mock-chronik-client] Update README for review.
Jan 10 2025, 05:29
bytesofman closed D17505: [Cashtab] Patch CI by including mock-chronik-client.
Jan 10 2025, 05:08
bytesofman committed rABC4d1dc91c44b4: [Cashtab] Patch CI by including mock-chronik-client (authored by bytesofman).
[Cashtab] Patch CI by including mock-chronik-client
Jan 10 2025, 05:08
emack accepted D17505: [Cashtab] Patch CI by including mock-chronik-client.
Jan 10 2025, 05:08
bytesofman added a comment to D17505: [Cashtab] Patch CI by including mock-chronik-client.

was able to repeat the CI failure locally, failure does not occur with this patch

Jan 10 2025, 05:01
bytesofman published D17505: [Cashtab] Patch CI by including mock-chronik-client for review.
Jan 10 2025, 04:56
bytesofman closed D17500: [Cashtab] Lazy loading for agora.
Jan 10 2025, 04:24
bytesofman committed rABC99e28f1ad460: [Cashtab] Lazy loading for agora (authored by bytesofman).
[Cashtab] Lazy loading for agora
Jan 10 2025, 04:24
emack accepted D17500: [Cashtab] Lazy loading for agora.

5 tokens to load on this page by default, then have a button to "load all" with a warning about how long it will take

SGTM

Jan 10 2025, 04:20
bytesofman added a comment to D17500: [Cashtab] Lazy loading for agora.

I also did a manual test of cashtab-local-dev vs prod, on new wallets, and this diff loads slightly faster than prod, but are still taking over 2 minutes. Is that the expected behavior?

Jan 10 2025, 04:04
bytesofman published D17504: [Cashtab] Show XECX balance for review.
Jan 10 2025, 04:03
emack added a comment to D17500: [Cashtab] Lazy loading for agora.

I also did a manual test of cashtab-local-dev vs prod, on new wallets, and this diff loads slightly faster than prod, but are still taking over 2 minutes. Is that the expected behavior?

Jan 10 2025, 03:47
bytesofman closed D17499: [Cashtab] useContext in OrderBook instead of prop drilling.
Jan 10 2025, 03:41
bytesofman committed rABCdadc2ba7c3f4: [Cashtab] useContext in OrderBook instead of prop drilling (authored by bytesofman).
[Cashtab] useContext in OrderBook instead of prop drilling
Jan 10 2025, 03:41
bytesofman requested review of D17500: [Cashtab] Lazy loading for agora.
Jan 10 2025, 03:32
emack requested changes to D17500: [Cashtab] Lazy loading for agora.
Jan 10 2025, 03:18
emack accepted D17499: [Cashtab] useContext in OrderBook instead of prop drilling.
Jan 10 2025, 03:02
roqqit updated the diff for D17503: [avalanche] Set all local stake winners as accepted contenders.

Bump mocktime beyond the max registration time so there is not a bunch of flaky winners in the functional test

Jan 10 2025, 00:36
roqqit planned changes to D17503: [avalanche] Set all local stake winners as accepted contenders.
Jan 10 2025, 00:15
teamcity added a comment to D17503: [avalanche] Set all local stake winners as accepted contenders.
Jan 10 2025, 00:14
teamcity added a comment to D17503: [avalanche] Set all local stake winners as accepted contenders.
Jan 10 2025, 00:14
teamcity added a comment to D17503: [avalanche] Set all local stake winners as accepted contenders.
Jan 10 2025, 00:07
roqqit requested review of D17503: [avalanche] Set all local stake winners as accepted contenders.
Jan 10 2025, 00:02

Jan 9 2025

bytesofman added a comment to D17500: [Cashtab] Lazy loading for agora.

also added some debug logging to the test site so you can see the counts going up

Jan 9 2025, 22:40
bytesofman updated the diff for D17500: [Cashtab] Lazy loading for agora.

bail out if no promises to handle

Jan 9 2025, 22:40
roqqit closed D17498: [avalanche] Re-sort pollable contenders by reward rank.
Jan 9 2025, 21:30
roqqit committed rABC073bfa519c06: [avalanche] Re-sort pollable contenders by reward rank (authored by roqqit).
[avalanche] Re-sort pollable contenders by reward rank
Jan 9 2025, 21:30
PiRK updated the diff for D17501: [chronik] implement electrum RPC blockchain.block.headers.

rename helper function json_to_u31. We still return a i32, because that's what all functions expect a block height to be in the node and the indexer, but with the added guarantee that it is >=0 . Returning a u32 would just shift the problem from checking >= 0 to checking <=2**31 -1, while requiring a lot of as i32 conversions when calling the indexer functions.

Jan 9 2025, 20:58
PiRK added inline comments to D17501: [chronik] implement electrum RPC blockchain.block.headers.
Jan 9 2025, 20:30
PiRK planned changes to D17501: [chronik] implement electrum RPC blockchain.block.headers.
Jan 9 2025, 20:29
bytesofman added inline comments to D17500: [Cashtab] Lazy loading for agora.
Jan 9 2025, 20:27
PiRK updated the diff for D17501: [chronik] implement electrum RPC blockchain.block.headers.

remove a duplicated test and improve another comment

Jan 9 2025, 20:27
PiRK updated the diff for D17501: [chronik] implement electrum RPC blockchain.block.headers.

fix comment in test

Jan 9 2025, 20:21
Fabien requested changes to D17501: [chronik] implement electrum RPC blockchain.block.headers.
Jan 9 2025, 20:20
Fabien added inline comments to D17500: [Cashtab] Lazy loading for agora.
Jan 9 2025, 20:16
PiRK updated the summary of D17501: [chronik] implement electrum RPC blockchain.block.headers.
Jan 9 2025, 20:11
PiRK requested review of D17501: [chronik] implement electrum RPC blockchain.block.headers.
Jan 9 2025, 20:08
Fabien accepted D17498: [avalanche] Re-sort pollable contenders by reward rank.
Jan 9 2025, 19:59