- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 11 2025
Cool, works for me and is good interim solution. The polite loading is nice
Only suggestion is move the button below the initial listings for subjective reasons
better handling of timeout issue on tests
Jan 10 2025
rebase, make styles fit in new design, update tests
remove css class and make it a styled component
Looks much better. Also much better sorting UI vs the switches would love a similar UI lift on the Token page.
collect the headers_hex
comment on balanceXecx getter
use headers_by_range which simplifies the code a lot
More questions than requesting changes
was able to repeat the CI failure locally, failure does not occur with this patch
5 tokens to load on this page by default, then have a button to "load all" with a warning about how long it will take
SGTM
In D17500#398205, @emack wrote:I also did a manual test of cashtab-local-dev vs prod, on new wallets, and this diff loads slightly faster than prod, but are still taking over 2 minutes. Is that the expected behavior?
I also did a manual test of cashtab-local-dev vs prod, on new wallets, and this diff loads slightly faster than prod, but are still taking over 2 minutes. Is that the expected behavior?
Bump mocktime beyond the max registration time so there is not a bunch of flaky winners in the functional test
Jan 9 2025
also added some debug logging to the test site so you can see the counts going up
bail out if no promises to handle
rename helper function json_to_u31. We still return a i32, because that's what all functions expect a block height to be in the node and the indexer, but with the added guarantee that it is >=0 . Returning a u32 would just shift the problem from checking >= 0 to checking <=2**31 -1, while requiring a lot of as i32 conversions when calling the indexer functions.
remove a duplicated test and improve another comment
fix comment in test