Page MenuHomePhabricator
Feed All Stories

Fri, Feb 21

bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

rebase

Fri, Feb 21, 14:24
PiRK accepted D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

Still lgtm

Fri, Feb 21, 14:20
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 14:13
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Added unreachable panic, renamed test_blockchain_info to blockchain_info and added comments

Fri, Feb 21, 14:11
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 14:09
PiRK accepted D17684: [chronik] Fix the chronik_plugins test.
Fri, Feb 21, 14:05
Fabien requested review of D17684: [chronik] Fix the chronik_plugins test.
Fri, Feb 21, 14:02
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 13:58
Fabien closed D17682: Fix nullptr clientModel access during shutdown.
Fri, Feb 21, 13:58
Fabien committed rABC2f1230a53610: Fix nullptr clientModel access during shutdown (authored by furszy <matiasfurszyfer@protonmail.com>).
Fix nullptr clientModel access during shutdown
Fri, Feb 21, 13:58
Fabien closed D17683: [chronik] Fix handling of -chronikelectrummaxhistory.
Fri, Feb 21, 13:57
Fabien committed rABC4261e4fe94d7: [chronik] Fix handling of -chronikelectrummaxhistory (authored by Fabien).
[chronik] Fix handling of -chronikelectrummaxhistory
Fri, Feb 21, 13:57
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

more finds

Fri, Feb 21, 13:56
teamcity added a comment to D17683: [chronik] Fix handling of -chronikelectrummaxhistory.
Fri, Feb 21, 13:53
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 13:50
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 13:47
PiRK accepted D17682: Fix nullptr clientModel access during shutdown.
Fri, Feb 21, 13:42
tobias_ruck accepted D17683: [chronik] Fix handling of -chronikelectrummaxhistory.

works on my machine

Fri, Feb 21, 13:39
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

more atoms_vec finds

Fri, Feb 21, 13:35
Fabien requested review of D17683: [chronik] Fix handling of -chronikelectrummaxhistory.
Fri, Feb 21, 13:35
teamcity updated the summary of D17682: Fix nullptr clientModel access during shutdown.
Fri, Feb 21, 13:09
Fabien requested review of D17682: Fix nullptr clientModel access during shutdown.
Fri, Feb 21, 13:09
bytesofman added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

apologies for the phab noise here ... not sure how to find all these locally. ninja check-functional is passing

Fri, Feb 21, 12:43
teamcity triaged T3756: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX MacOS is broken. as Unbreak Now! priority.
Fri, Feb 21, 12:14
PiRK closed D17681: [chronik] make the maximum history length for electrum RPCs an init param.
Fri, Feb 21, 10:35
PiRK committed rABCb760220009df: [chronik] make the maximum history length for electrum RPCs an init param (authored by PiRK).
[chronik] make the maximum history length for electrum RPCs an init param
Fri, Feb 21, 10:35
Fabien requested changes to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Fri, Feb 21, 08:45
Fabien accepted D17607: [avalanche] Poll for stake contenders.
Fri, Feb 21, 08:41
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 05:16
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 05:14
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

more atoms_vec

Fri, Feb 21, 05:06
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 00:50
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 00:46
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

test patch

Fri, Feb 21, 00:40
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 00:36
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 00:34
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

more script patches, update other amounts params

Fri, Feb 21, 00:27
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 00:05
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 00:04
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 00:03
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 00:02
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Fri, Feb 21, 00:01

Thu, Feb 20

bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

chronik updates from name changes in mint data

Thu, Feb 20, 23:56
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Thu, Feb 20, 23:36
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Thu, Feb 20, 23:35
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Thu, Feb 20, 23:33
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Thu, Feb 20, 23:32
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Thu, Feb 20, 23:29
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

update more names, implement

Thu, Feb 20, 23:25
bytesofman added inline comments to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Thu, Feb 20, 23:20
hazzarust abandoned D17653: [chronik] Add block_and_blocks to bitcoinsuite-chronik-client.
Thu, Feb 20, 23:03
hazzarust updated the summary of D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Thu, Feb 20, 22:37
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Renamed blockchain_info_new to blockchain_info

Thu, Feb 20, 22:36
hazzarust retitled D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client from [chronik] Add blockchain_info to bitcoinsuite-chronik-client to [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.
Thu, Feb 20, 22:36
Fabien accepted D17681: [chronik] make the maximum history length for electrum RPCs an init param.
Thu, Feb 20, 19:46
Fabien requested changes to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

The title and the file name are incorrect, please fix this before the review

Thu, Feb 20, 19:46
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

sorry relint

Thu, Feb 20, 19:38
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

lint

Thu, Feb 20, 19:37
PiRK retitled D17681: [chronik] make the maximum history length for electrum RPCs an init param from [chronik] make the maximum history length an init param to [chronik] make the maximum history length for electrum RPCs an init param.
Thu, Feb 20, 19:36
hazzarust added a comment to D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

I will make the changes from Pierre's comment in a separate diff to all current integration tests.

Thu, Feb 20, 19:36
hazzarust updated the diff for D17638: [chronik] Add an integration test for the blockchain_info endpoint in bitcoinsuite-chronik-client.

Revamped blockchain_info to include the new trait changes.

Thu, Feb 20, 19:34
tobias_ruck requested changes to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Thu, Feb 20, 19:26
PiRK requested review of D17681: [chronik] make the maximum history length for electrum RPCs an init param.
Thu, Feb 20, 19:21
Fabien closed D17680: [chronik-client] Fix a bug in the plugins integration test.
Thu, Feb 20, 19:15
Fabien committed rABCea44416f09d0: [chronik-client] Fix a bug in the plugins integration test (authored by Fabien).
[chronik-client] Fix a bug in the plugins integration test
Thu, Feb 20, 19:15
bytesofman accepted D17680: [chronik-client] Fix a bug in the plugins integration test.
Thu, Feb 20, 14:52
hazzarust accepted D17680: [chronik-client] Fix a bug in the plugins integration test.
Thu, Feb 20, 14:43
Fabien requested review of D17680: [chronik-client] Fix a bug in the plugins integration test.
Thu, Feb 20, 13:25
Fabien added inline comments to D17607: [avalanche] Poll for stake contenders.
Thu, Feb 20, 08:37
Fabien closed D17679: Remove extra mockscheduler call in abc_p2p_getavaaddr.
Thu, Feb 20, 08:28
Fabien committed rABC2a1c960435b6: Remove extra mockscheduler call in abc_p2p_getavaaddr (authored by Fabien).
Remove extra mockscheduler call in abc_p2p_getavaaddr
Thu, Feb 20, 08:28
teamcity closed T3755: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Resolved.
Thu, Feb 20, 07:44
PiRK closed D17676: [chronik] implement server.version electrum method.
Thu, Feb 20, 07:38
PiRK committed rABC91ef9971ad45: [chronik] implement server.version electrum method (authored by PiRK).
[chronik] implement server.version electrum method
Thu, Feb 20, 07:38
PiRK accepted D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Thu, Feb 20, 07:24
Unknown Object (User) added a comment to rABC35b8201a4d31: [electrum] Bump version to 5.2.12 and add release notes.
Thu, Feb 20, 05:39

Wed, Feb 19

roqqit updated the diff for D17607: [avalanche] Poll for stake contenders.

Rebase on D17660 to address the feedback about splitting up setContenderStatusForLocalWinners(). It should be more clear now that addToReconcile() is only called once per block.

Wed, Feb 19, 22:04
roqqit accepted D17679: Remove extra mockscheduler call in abc_p2p_getavaaddr.
Wed, Feb 19, 20:59
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

update mock to new shape

Wed, Feb 19, 17:53
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Wed, Feb 19, 17:18
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

update types in chronik-http/src/electrum.rs

Wed, Feb 19, 17:02
Fabien requested review of D17679: Remove extra mockscheduler call in abc_p2p_getavaaddr.
Wed, Feb 19, 17:01
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Wed, Feb 19, 16:04
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Wed, Feb 19, 16:02
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Wed, Feb 19, 16:00
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Wed, Feb 19, 15:59
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Wed, Feb 19, 15:58
teamcity added a comment to D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).
Wed, Feb 19, 15:55
bytesofman updated the diff for D17650: [chronik, chronik-client, ecash-agora, ecash-lib, cashtab, ecash-herald, token-server, faucet, mock-chronik-client] Improve names of keys and params that expect satoshis and atoms (aka base tokens).

rebase, remove debug logs, remove duplicated branch in cashtab wallet migration, revert unrelated lint change in Configure.test.js

Wed, Feb 19, 15:48
Fabien accepted D17678: [Cashtab] Improve test match syntax for token actions.
Wed, Feb 19, 15:46
bytesofman published D17678: [Cashtab] Improve test match syntax for token actions for review.
Wed, Feb 19, 15:34
teamcity awarded D17659: [WIP] CI investigation a Like token.
Wed, Feb 19, 14:51
Fabien closed D17677: Improve reliability of abc_rpc_getavalancheproofs.
Wed, Feb 19, 13:46
Fabien committed rABC27cd694c2d62: Improve reliability of abc_rpc_getavalancheproofs (authored by Fabien).
Improve reliability of abc_rpc_getavalancheproofs
Wed, Feb 19, 13:46
Fabien closed D17675: [chronik] Consistently sync the validation queue in functional tests.
Wed, Feb 19, 13:46
Fabien committed rABC5db4ff6efcd3: [chronik] Consistently sync the validation queue in functional tests (authored by Fabien).
[chronik] Consistently sync the validation queue in functional tests
Wed, Feb 19, 13:46
teamcity awarded D17659: [WIP] CI investigation a Love token.
Wed, Feb 19, 13:45
PiRK accepted D17677: Improve reliability of abc_rpc_getavalancheproofs.
Wed, Feb 19, 11:50
PiRK accepted D17675: [chronik] Consistently sync the validation queue in functional tests.
Wed, Feb 19, 11:49
teamcity awarded D17659: [WIP] CI investigation a Like token.
Wed, Feb 19, 10:13