Remove debug print

Remove dead pagination code, fix clippy

Superseded by D18958

test plan succeeded (i was waiting for a fusion round)

that other instance of tx_external_keypairs is not a direct API access, but a dynamic access via hooks. I will fix this in a separate diff, because the hooks are broken in multiple ways

found one more instance to fix...

In D19000#433073, @johnkuney wrote:

In D19000#433072, @alitayin wrote:

In D19000#432951, @johnkuney wrote:

Okay good points. How can I get the mempool transactions though? Is that possible with chronik? I saw blockchair has an endpoint for it, but we probably dont want to use that right?

https://ecashmempool.vercel.app/ "chronik-client": "3.6.0-rc0",

You are using https://api.blockchair.com/ecash/mempool/transactions to get the mempool right?

In D19000#433072, @alitayin wrote:

In D19000#432951, @johnkuney wrote:

Okay good points. How can I get the mempool transactions though? Is that possible with chronik? I saw blockchair has an endpoint for it, but we probably dont want to use that right?

https://ecashmempool.vercel.app/ "chronik-client": "3.6.0-rc0",

In D19000#432951, @johnkuney wrote:

Okay good points. How can I get the mempool transactions though? Is that possible with chronik? I saw blockchair has an endpoint for it, but we probably dont want to use that right?

Cool, just noticed that.

In D19007#433040, @aimal wrote:

Maybe mention that it's open source.

Maybe mention that it's open source.

Okay good points. How can I get the mempool transactions though? Is that possible with chronik? I saw blockchair has an endpoint for it, but we probably dont want to use that right?

There is no point adding a mempool view that doesn't show the mempool. The explorer is a source of trust that we send to users and business to check their node is working, you can explain tons of questions within seconds because users nodes will not show the same as the explorer.
Also:

• This will break the testnet explorer
• This is trying to fit cubes into circle holes with finalization. Rather than copying what other chain without preconsensus do, let's take advantage of it to show a better representation. Here is my proposal:
  • Have a view with 2 sides, non final and final
  • Move the tx from one side the other upon finalization This will be useful if e.g. the mempool is full to see what transaction are being finalized and which are pending. Also helps figuring out how block mining works by draining the finalized txs