Page MenuHomePhabricator
Feed All Stories

Aug 28 2019

nakihito added a comment to D3953: Merge #12618: Set SCHED_BATCH priority on the loadblk thread..

https://github.com/bitcoin/bitcoin/issues/12915
This is supposed to introduce the above bug, but I could not build with the same configure options to test. The fix is made in D3954.

Aug 28 2019, 00:54
teamcity added a comment to D3954: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 28 2019, 00:53
nakihito updated the summary of D3954: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0.
Aug 28 2019, 00:52
teamcity added a comment to D3954: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 28 2019, 00:52
nakihito created D3954: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0.
Aug 28 2019, 00:52
teamcity added a comment to D3953: Merge #12618: Set SCHED_BATCH priority on the loadblk thread..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 28 2019, 00:50
nakihito created D3953: Merge #12618: Set SCHED_BATCH priority on the loadblk thread..
Aug 28 2019, 00:50

Aug 27 2019

deadalnix accepted D3942: Remove script to clean up datadirs.
Aug 27 2019, 22:54
deadalnix accepted D3951: Migrate gitian-build.sh to python.
Aug 27 2019, 22:53
deadalnix accepted D3944: [docs] Add instructions for lcov coverage report generation.
Aug 27 2019, 22:53
deadalnix requested changes to D3871: [CMAKE] Add support to build secp256k1 JNI binding and tests.
Aug 27 2019, 22:52
deadalnix requested changes to D3870: [CMAKE] Allow for building static and shared versions of secp256k1.

I'm not a fan of the approach. There is a set of global settings for cmake that allow to specify if you want thing shared or not by default. secp256k1 should be whatever the default is for cmake.

Aug 27 2019, 22:44
teamcity added a comment to D3952: Merge #12702: [wallet] [rpc] [doc] importprivkey: hint about importmulti.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 27 2019, 20:38
teamcity added a comment to D3952: Merge #12702: [wallet] [rpc] [doc] importprivkey: hint about importmulti.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 27 2019, 20:31
nakihito created D3952: Merge #12702: [wallet] [rpc] [doc] importprivkey: hint about importmulti.
Aug 27 2019, 20:31
fpelliccioni committed rABC8b217943d251: Add DynamicMemoryUsage() to LevelDB (authored by Evan Klitzke <evan@eklitzke.org>).
Add DynamicMemoryUsage() to LevelDB
Aug 27 2019, 20:05
fpelliccioni closed D3948: Add DynamicMemoryUsage() to LevelDB.
Aug 27 2019, 20:05
Fabien accepted D3948: Add DynamicMemoryUsage() to LevelDB.
Aug 27 2019, 20:04
fpelliccioni updated the summary of D3948: Add DynamicMemoryUsage() to LevelDB.
Aug 27 2019, 20:03
teamcity added a comment to D3950: Merge #12953: Deprecate accounts.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 27 2019, 19:48
teamcity added a comment to D3950: Merge #12953: Deprecate accounts.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 27 2019, 19:41
nakihito updated the diff for D3950: Merge #12953: Deprecate accounts.

Fixed incorrect version numbers.

Aug 27 2019, 19:41
fpelliccioni updated the test plan for D3948: Add DynamicMemoryUsage() to LevelDB.
Aug 27 2019, 18:50
teamcity added a comment to D3948: Add DynamicMemoryUsage() to LevelDB.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 27 2019, 18:26
teamcity added a comment to D3948: Add DynamicMemoryUsage() to LevelDB.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 27 2019, 18:19
fpelliccioni updated the diff for D3948: Add DynamicMemoryUsage() to LevelDB.

Backport of Bitcoin Core PR12784
https://github.com/bitcoin/bitcoin/pull/12784

Aug 27 2019, 18:19
nakihito added inline comments to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.
Aug 27 2019, 17:55
fpelliccioni added inline comments to D3948: Add DynamicMemoryUsage() to LevelDB.
Aug 27 2019, 16:24
teamcity added a comment to D3951: Migrate gitian-build.sh to python.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 27 2019, 16:15
teamcity added a comment to D3951: Migrate gitian-build.sh to python.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 27 2019, 16:08
Fabien created D3951: Migrate gitian-build.sh to python.
Aug 27 2019, 16:08
Fabien committed rABCdca8f7210c89: [contrib] Add Valgrind suppressions file (authored by practicalswift <practicalswift@users.noreply.github.com>).
[contrib] Add Valgrind suppressions file
Aug 27 2019, 15:29
Fabien closed D3943: [contrib] Add Valgrind suppressions file.
Aug 27 2019, 15:28
deadalnix accepted D3943: [contrib] Add Valgrind suppressions file.
Aug 27 2019, 13:23
deadalnix accepted D3947: [LINTER] Enforce using `#!/usr/bin/env bash` for shell scripts.
Aug 27 2019, 13:22
Fabien requested changes to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.
Aug 27 2019, 10:13
Fabien requested changes to D3950: Merge #12953: Deprecate accounts.

Please fix the version numbers. Next major is 0.21 not 0.30, and there are some core numbers remaining.

Aug 27 2019, 10:08
Fabien requested changes to D3948: Add DynamicMemoryUsage() to LevelDB.

Your test plan is not testing for the change, please update it.

Aug 27 2019, 08:55
Fabien abandoned D3946: Add a trailing comma to the Mode enum.

The linter changes got landed in D3893, no need to prevent it anymore.

Aug 27 2019, 06:35
nakihito accepted D3946: Add a trailing comma to the Mode enum.
Aug 27 2019, 00:31

Aug 26 2019

teamcity added a comment to D3950: Merge #12953: Deprecate accounts.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 20:59
nakihito added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

Help entry duplication issue is fixed in D3950.

Aug 26 2019, 20:54
nakihito added a reviewer for D3950: Merge #12953: Deprecate accounts: markblundeberg.
Aug 26 2019, 20:53
nakihito added a reviewer for D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet: markblundeberg.
Aug 26 2019, 20:53
nakihito updated the summary of D3950: Merge #12953: Deprecate accounts.
Aug 26 2019, 20:53
teamcity added a comment to D3950: Merge #12953: Deprecate accounts.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 20:51
nakihito created D3950: Merge #12953: Deprecate accounts.
Aug 26 2019, 20:51
teamcity added a comment to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 20:51
teamcity added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 20:43
teamcity added a comment to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 20:39
teamcity added a comment to D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 20:38
nakihito created D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.
Aug 26 2019, 20:38
teamcity added a comment to D3308: Merge #9894: remove 'label' filter for rpc command help.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 20:36
nakihito updated the diff for D3308: Merge #9894: remove 'label' filter for rpc command help.

Rebase.

Aug 26 2019, 20:36
Nico Guiton <nico@bitframe.org> committed rABC8cd5e4ccde0c: Merge #12747: Fix typos (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12747: Fix typos
Aug 26 2019, 20:13
Nico Guiton <nico@bitframe.org> closed D3893: Merge #12747: Fix typos.
Aug 26 2019, 20:13
teamcity added a comment to D3948: Add DynamicMemoryUsage() to LevelDB.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 20:08
teamcity added a comment to D3948: Add DynamicMemoryUsage() to LevelDB.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 20:01
fpelliccioni updated the diff for D3948: Add DynamicMemoryUsage() to LevelDB.

added Linter exception

Aug 26 2019, 20:01
Fabien accepted D3893: Merge #12747: Fix typos.
Aug 26 2019, 19:27
Nico Guiton <nico@bitframe.org> committed rABCcef845e73412: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #11193: [Qt] Terminate string *pszExePath after readlink and without…
Aug 26 2019, 18:42
Nico Guiton <nico@bitframe.org> closed D3933: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset.
Aug 26 2019, 18:42
teamcity added a comment to D3948: Add DynamicMemoryUsage() to LevelDB.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 18:40
teamcity added a comment to D3948: Add DynamicMemoryUsage() to LevelDB.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 18:32
fpelliccioni created D3948: Add DynamicMemoryUsage() to LevelDB.
Aug 26 2019, 18:32
teamcity added a comment to D3893: Merge #12747: Fix typos.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 18:28
nakihito added inline comments to D3893: Merge #12747: Fix typos.
Aug 26 2019, 18:23
nakihito updated the test plan for D3893: Merge #12747: Fix typos.
Aug 26 2019, 18:22
teamcity added a comment to D3893: Merge #12747: Fix typos.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 18:21
nakihito updated the diff for D3893: Merge #12747: Fix typos.

Added "transation": "transaction" to the linter dictionary and added arc lint --everything to test plan.

Aug 26 2019, 18:21
teamcity added a comment to D3947: [LINTER] Enforce using `#!/usr/bin/env bash` for shell scripts.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 17:28
Fabien created D3947: [LINTER] Enforce using `#!/usr/bin/env bash` for shell scripts.
Aug 26 2019, 17:21
teamcity added a comment to D3947: [LINTER] Enforce using `#!/usr/bin/env bash` for shell scripts.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 17:21
teamcity added a comment to D3946: Add a trailing comma to the Mode enum.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 17:13
teamcity added a comment to D3945: Improve formatting of developer notes.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 17:10
teamcity added a comment to D3944: [docs] Add instructions for lcov coverage report generation.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 17:01
teamcity added a comment to D3945: Improve formatting of developer notes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 16:59
teamcity added a comment to D3946: Add a trailing comma to the Mode enum.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 16:59
Fabien created D3946: Add a trailing comma to the Mode enum.
Aug 26 2019, 16:59
teamcity added a comment to D3945: Improve formatting of developer notes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 16:58
teamcity added a comment to D3945: Improve formatting of developer notes.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 16:57
Fabien created D3945: Improve formatting of developer notes.
Aug 26 2019, 16:57
teamcity added a comment to D3944: [docs] Add instructions for lcov coverage report generation.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 16:54
Fabien created D3944: [docs] Add instructions for lcov coverage report generation.
Aug 26 2019, 16:54
teamcity added a comment to D3943: [contrib] Add Valgrind suppressions file.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 16:53
teamcity added a comment to D3943: [contrib] Add Valgrind suppressions file.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 16:46
Fabien created D3943: [contrib] Add Valgrind suppressions file.
Aug 26 2019, 16:46
fpelliccioni committed rABC7b0d5028a6b5: use base58 map instead of strchr() (authored by Kevin Pan <bit.kevin@gmail.com>).
use base58 map instead of strchr()
Aug 26 2019, 14:23
fpelliccioni closed D3938: use base58 map instead of strchr().
Aug 26 2019, 14:23
Fabien accepted D3938: use base58 map instead of strchr().
Aug 26 2019, 14:21
teamcity added a comment to D3938: use base58 map instead of strchr().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 14:03
teamcity added a comment to D3938: use base58 map instead of strchr().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 13:55
fpelliccioni updated the diff for D3938: use base58 map instead of strchr().

Fixed comments and braces

Aug 26 2019, 13:55
teamcity added a comment to D3942: Remove script to clean up datadirs.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 26 2019, 09:50
teamcity added a comment to D3942: Remove script to clean up datadirs.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 26 2019, 09:43
Fabien created D3942: Remove script to clean up datadirs.
Aug 26 2019, 09:42
Fabien committed rABCcde47be6adbf: Disable wallet and address book Qt tests on macOS minimal platform (authored by Russell Yanofsky <russ@yanofsky.org>).
Disable wallet and address book Qt tests on macOS minimal platform
Aug 26 2019, 07:43
Fabien closed D3936: Disable wallet and address book Qt tests on macOS minimal platform.
Aug 26 2019, 07:43
Fabien requested changes to D3893: Merge #12747: Fix typos.
Aug 26 2019, 07:38
Fabien accepted D3933: Merge #11193: [Qt] Terminate string *pszExePath after readlink and without using memset.
Aug 26 2019, 07:15