Page MenuHomePhabricator
Feed All Stories

Mar 27 2020

teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) passed.

Mar 27 2020, 15:31
jasonbcox accepted D5587: Disable thread_local for i686-mingw.
Mar 27 2020, 15:30
teamcity added a comment to D5589: [secp256k1] Install all packages in travis.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 15:28
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 15:28
deadalnix committed rABC98369fa6fd64: [secp256k1] Install all packages in travis (authored by deadalnix).
[secp256k1] Install all packages in travis
Mar 27 2020, 15:28
deadalnix closed D5589: [secp256k1] Install all packages in travis.
Mar 27 2020, 15:27
Fabien accepted D5589: [secp256k1] Install all packages in travis.

See https://travis-ci.org/github/Fabcien/secp256k1/builds/667740396

Mar 27 2020, 15:22
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 15:18
teamcity added a comment to D5589: [secp256k1] Install all packages in travis.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 15:18
Fabien updated the diff for D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Remove obsolete if available from docstring.

Mar 27 2020, 15:18
deadalnix updated the diff for D5589: [secp256k1] Install all packages in travis.

Make sure that the opposite of no is indeed gmp.

Mar 27 2020, 15:18
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

Mar 27 2020, 15:13
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 15:13
deadalnix retitled D5589: [secp256k1] Install all packages in travis from [secp256k1] Install all packes in travis to [secp256k1] Install all packages in travis.
Mar 27 2020, 15:10
deadalnix accepted D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.
Mar 27 2020, 15:09
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) passed.

Mar 27 2020, 15:08
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

Mar 27 2020, 15:05
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (osx) started.

Mar 27 2020, 15:05
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (linux) started.

Mar 27 2020, 15:04
teamcity added a comment to D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 15:03
Fabien created D5590: [SECP256K1] Turn off ASM by default on target with no ASM support.
Mar 27 2020, 15:03
teamcity added a comment to D5589: [secp256k1] Install all packages in travis.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 14:48
teamcity added a comment to D5589: [secp256k1] Install all packages in travis.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 14:39
teamcity added a comment to D5589: [secp256k1] Install all packages in travis.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 14:31
deadalnix updated the diff for D5589: [secp256k1] Install all packages in travis.

Make bignum explicitely yes and remove install directive

Mar 27 2020, 14:31
teamcity added a comment to D5589: [secp256k1] Install all packages in travis.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 14:27
deadalnix created D5589: [secp256k1] Install all packages in travis.
Mar 27 2020, 14:26
Fabien requested changes to D5580: Constant-time behaviour test using valgrind memtest..
Mar 27 2020, 14:12
Fabien committed rABCb6265e2acb6c: [SECP256K1] Fix Travis missing ninja (authored by Fabien).
[SECP256K1] Fix Travis missing ninja
Mar 27 2020, 13:56
teamcity added a comment to D5588: [SECP256K1] Fix Travis missing ninja.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 13:56
Fabien closed D5588: [SECP256K1] Fix Travis missing ninja.
Mar 27 2020, 13:56
deadalnix accepted D5588: [SECP256K1] Fix Travis missing ninja.
Mar 27 2020, 13:55
teamcity added a comment to D5588: [SECP256K1] Fix Travis missing ninja.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 13:46
Fabien created D5588: [SECP256K1] Fix Travis missing ninja.
Mar 27 2020, 13:46
deadalnix requested changes to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

I'm sorry, but I don't buy the finalization argument, mostly because it's not an argument. I've seen enough cultish behavior in this industry to know people will say you shouldn't do X or must do Y the Z way with absolutely no reason whatsoever and it often turns out to be a bad idea. If there is a reason to not do it, then people should be able to state it and we should be able to assert why it applies or not to our current situation. Every time someone brings up that this is the "the way" without providing a proper rationale, this is only a stronger reason to dismiss this concern.

Mar 27 2020, 13:34
Fabien requested changes to D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.
Mar 27 2020, 13:25
teamcity added a comment to D5587: Disable thread_local for i686-mingw.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 13:09
teamcity added a comment to D5587: Disable thread_local for i686-mingw.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 12:56
teamcity updated the summary of D5587: Disable thread_local for i686-mingw.
Mar 27 2020, 12:56
teamcity added a comment to D5587: Disable thread_local for i686-mingw.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Mar 27 2020, 12:56
Fabien created D5587: Disable thread_local for i686-mingw.
Mar 27 2020, 12:56
abc-bot committed rABC5da5396e8d0d: [Automated] Update manpages (authored by abc-bot).
[Automated] Update manpages
Mar 27 2020, 01:21
jasonbcox committed rABCd9f4298eca5b: [test_runner] Fix result collector variable shadowing (authored by jasonbcox).
[test_runner] Fix result collector variable shadowing
Mar 27 2020, 01:13
jasonbcox closed D5584: [test_runner] Fix result collector variable shadowing.
Mar 27 2020, 01:13
jasonbcox committed rABCe248a3311de3: [test_runner] Use the daemon property directly instead of setDaemon() (authored by jasonbcox).
[test_runner] Use the daemon property directly instead of setDaemon()
Mar 27 2020, 01:13
jasonbcox closed D5583: [test_runner] Use the daemon property directly instead of setDaemon().
Mar 27 2020, 01:12
jasonbcox committed rABC1e2aab4a99d7: Add missing softforks help text to getblockchaininfo (authored by jasonbcox).
Add missing softforks help text to getblockchaininfo
Mar 27 2020, 01:12
jasonbcox closed D5581: Add missing softforks help text to getblockchaininfo.
Mar 27 2020, 01:12
teamcity added a comment to D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 00:32
teamcity added a comment to D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 00:22
teamcity updated the summary of D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.
Mar 27 2020, 00:22
teamcity added a comment to D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Mar 27 2020, 00:22
nakihito created D5586: Merge #14885: rpc: Assert named arguments are unique in RPCHelpMan.
Mar 27 2020, 00:22
teamcity added a comment to D5585: Merge #14987: RPCHelpMan: Pass through Result and Examples.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 00:17
nakihito planned changes to D5585: Merge #14987: RPCHelpMan: Pass through Result and Examples.
Mar 27 2020, 00:09
teamcity added a comment to D5585: Merge #14987: RPCHelpMan: Pass through Result and Examples.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 27 2020, 00:07
nakihito updated the diff for D5585: Merge #14987: RPCHelpMan: Pass through Result and Examples.

Forgot to squash changes.

Mar 27 2020, 00:06
teamcity added a comment to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 27 2020, 00:01

Mar 26 2020

Harbormaster failed remote builds in B10003: Diff 17231 for D5585: Merge #14987: RPCHelpMan: Pass through Result and Examples!
Mar 26 2020, 23:55
teamcity added a comment to D5585: Merge #14987: RPCHelpMan: Pass through Result and Examples.
Mar 26 2020, 23:54
teamcity added a comment to D5585: Merge #14987: RPCHelpMan: Pass through Result and Examples.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 26 2020, 23:54
teamcity added a comment to D5585: Merge #14987: RPCHelpMan: Pass through Result and Examples.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Mar 26 2020, 23:54
teamcity updated the summary of D5585: Merge #14987: RPCHelpMan: Pass through Result and Examples.
Mar 26 2020, 23:54
nakihito planned changes to D5585: Merge #14987: RPCHelpMan: Pass through Result and Examples.
Mar 26 2020, 23:53
nakihito created D5585: Merge #14987: RPCHelpMan: Pass through Result and Examples.
Mar 26 2020, 23:53
teamcity added a comment to D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 26 2020, 23:51
nakihito updated the diff for D5571: Merge #14796: rpc: Pass argument descriptions to RPCHelpMan.

Rebased.

Mar 26 2020, 23:51
nakihito committed rABCdee5e745ae59: Merge #14813: qa: Add wallet_encryption error tests (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14813: qa: Add wallet_encryption error tests
Mar 26 2020, 23:39
nakihito closed D5582: Merge #14813: qa: Add wallet_encryption error tests.
Mar 26 2020, 23:38
teamcity added a comment to D5584: [test_runner] Fix result collector variable shadowing.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 26 2020, 23:33
jasonbcox retitled D5584: [test_runner] Fix result collector variable shadowing from [test_runner] Fix resource collector variable shadowing to [test_runner] Fix result collector variable shadowing.
Mar 26 2020, 23:24
teamcity added a comment to D5584: [test_runner] Fix result collector variable shadowing.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 26 2020, 23:24
jasonbcox updated the diff for D5584: [test_runner] Fix result collector variable shadowing.

Fix typo

Mar 26 2020, 23:24
deadalnix accepted D5582: Merge #14813: qa: Add wallet_encryption error tests.
Mar 26 2020, 23:19
deadalnix accepted D5581: Add missing softforks help text to getblockchaininfo.
Mar 26 2020, 23:16
nakihito accepted D5584: [test_runner] Fix result collector variable shadowing.
Mar 26 2020, 22:57
nakihito accepted D5583: [test_runner] Use the daemon property directly instead of setDaemon().
Mar 26 2020, 22:56
teamcity added a comment to D5584: [test_runner] Fix result collector variable shadowing.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 26 2020, 22:34
teamcity added a comment to D5583: [test_runner] Use the daemon property directly instead of setDaemon().

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 26 2020, 22:31
teamcity added a comment to D5584: [test_runner] Fix result collector variable shadowing.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 26 2020, 22:25
jasonbcox created D5584: [test_runner] Fix result collector variable shadowing.
Mar 26 2020, 22:24
teamcity added a comment to D5583: [test_runner] Use the daemon property directly instead of setDaemon().

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 26 2020, 22:21
jasonbcox created D5583: [test_runner] Use the daemon property directly instead of setDaemon().
Mar 26 2020, 22:21
teamcity added a comment to D5582: Merge #14813: qa: Add wallet_encryption error tests.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 26 2020, 22:09
teamcity added a comment to D5582: Merge #14813: qa: Add wallet_encryption error tests.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 26 2020, 21:59
teamcity added a comment to D5582: Merge #14813: qa: Add wallet_encryption error tests.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Mar 26 2020, 21:59
teamcity updated the summary of D5582: Merge #14813: qa: Add wallet_encryption error tests.
Mar 26 2020, 21:59
nakihito created D5582: Merge #14813: qa: Add wallet_encryption error tests.
Mar 26 2020, 21:58
jasonbcox accepted D5574: [depends] ZeroMQ 4.2.2.

I've added 4.2.2 to https://download.bitcoinabc.org/depends-sources/

Mar 26 2020, 20:48
teamcity added a comment to D5577: [CMAKE] Pull zmq windows library dependencies in the find module.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) passed.

Mar 26 2020, 20:44
jasonbcox accepted D5577: [CMAKE] Pull zmq windows library dependencies in the find module.
Mar 26 2020, 20:38
teamcity added a comment to D5577: [CMAKE] Pull zmq windows library dependencies in the find module.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing (win) started.

Mar 26 2020, 20:36
jasonbcox accepted D5575: [CMAKE] Pull miniupnpc windows library dependencies in the find module.
Mar 26 2020, 20:35
jasonbcox accepted D5576: [CMAKE] Pass the interface linked libraries to find_component.
Mar 26 2020, 20:31
teamcity added a comment to D5581: Add missing softforks help text to getblockchaininfo.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Mar 26 2020, 18:44
teamcity added a comment to D5581: Add missing softforks help text to getblockchaininfo.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Mar 26 2020, 18:27
jasonbcox created D5581: Add missing softforks help text to getblockchaininfo.
Mar 26 2020, 18:26
jasonbcox committed rABCe9e2fef6eb8c: Fixup release notes formatting (authored by jasonbcox).
Fixup release notes formatting
Mar 26 2020, 18:18
jasonbcox closed D5578: Fixup release notes formatting.
Mar 26 2020, 18:18
Harbormaster failed remote builds in B9995: Diff 17220 for D5580: Constant-time behaviour test using valgrind memtest.!
Mar 26 2020, 18:15