Because the pointer is set and never mutated, you actually don't need the mutex to access the pointed data - which are immutable. The scope of these lock is too large. buildRemoteSighash for instance, shouldn't need the lock.

Address feedback.
Optimize PairNodesWithProofs.
Refactor the AvaHello message handling code so that the delegation and the proof id stored in the map are always in sync. If the delegation is invalid, we don't even need to create the AvalancheState and store the delegation.

move lock annotation to the header file

Feedback

add an AssertLockHeld.

@bot build-tsan

Remove the proof from the set when we receive a getdata request, fix the test and add a case for the proof becoming invalid.

@bot build-tsan

@bot build-debug build-tsan

rebase onto master after splitting abc_p2p_avalanche.py, move the new test code to abc_p2p_avalanche_peer_discovery.py

remove unnecessary mutable keyword

Rebase

with the -ecash prefix, this seems less relevant. abandoning for now.

rebase on D9686 and lock cs_avalanche_state before reading the peer's delegation

Fix clang-tidy

Rebase on top of D9681

Don't add a new method. It is enough to just initialize nodeid in __init__ to solve the linter issue.

@bot build-tsan