Page MenuHomePhabricator
Feed All Stories

Yesterday

PiRK added inline comments to D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Sat, Dec 21, 08:03
roqqit accepted D17382: test: Avoid intermittent block download timeout in p2p_ibd_stalling.
Sat, Dec 21, 02:33
roqqit closed D17381: test: Avoid race after connect_nodes.
Sat, Dec 21, 02:30
roqqit committed rABCefbf025838b6: test: Avoid race after connect_nodes (authored by MarcoFalke <falke.marco@gmail.com>).
test: Avoid race after connect_nodes
Sat, Dec 21, 02:30

Fri, Dec 20

teamcity updated the summary of D17382: test: Avoid intermittent block download timeout in p2p_ibd_stalling.
Fri, Dec 20, 22:16
Fabien requested review of D17382: test: Avoid intermittent block download timeout in p2p_ibd_stalling.
Fri, Dec 20, 22:16
Fabien accepted D17381: test: Avoid race after connect_nodes.
Fri, Dec 20, 21:53
teamcity updated the summary of D17381: test: Avoid race after connect_nodes.
Fri, Dec 20, 21:32
roqqit requested review of D17381: test: Avoid race after connect_nodes.
Fri, Dec 20, 21:32
hazzarust closed D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Fri, Dec 20, 18:24
hazzarust committed rABC658e3ea4a040: [Modules] Added `bitcoinsuite-chronik-client` to monorepo (authored by hazzarust).
[Modules] Added `bitcoinsuite-chronik-client` to monorepo
Fri, Dec 20, 18:24
bytesofman closed D17379: [mock-chronik-client] Dockerfile back to latest.
Fri, Dec 20, 13:31
bytesofman committed rABC16bee227b522: [mock-chronik-client] Dockerfile back to latest (authored by bytesofman).
[mock-chronik-client] Dockerfile back to latest
Fri, Dec 20, 13:31
bytesofman closed D17377: [chronik-client] Dockerfile back to latest.
Fri, Dec 20, 13:30
bytesofman committed rABCc0764c52ccd0: [chronik-client] Dockerfile back to latest (authored by bytesofman).
[chronik-client] Dockerfile back to latest
Fri, Dec 20, 13:30
Fabien accepted D17379: [mock-chronik-client] Dockerfile back to latest.
Fri, Dec 20, 13:07
Fabien accepted D17377: [chronik-client] Dockerfile back to latest.

We could do some hacking of the docker file so we don't have to clear the cache when not needed, I will look in to it

Fri, Dec 20, 13:06
bytesofman added a comment to D17379: [mock-chronik-client] Dockerfile back to latest.

CI has been updated to cache bust

Fri, Dec 20, 12:15
bytesofman added a comment to D17377: [chronik-client] Dockerfile back to latest.

ci has been updated to cache-bust

Fri, Dec 20, 12:14
bytesofman closed D17357: [Cashtab] Do not airdrop XEC to agora scripts.
Fri, Dec 20, 12:05
bytesofman committed rABC8e4c1c271064: [Cashtab] Do not airdrop XEC to agora scripts (authored by bytesofman).
[Cashtab] Do not airdrop XEC to agora scripts
Fri, Dec 20, 12:05
emack accepted D17357: [Cashtab] Do not airdrop XEC to agora scripts.
Fri, Dec 20, 10:09
tobias_ruck requested changes to D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Fri, Dec 20, 09:52
teamcity added a comment to D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Fri, Dec 20, 08:38
PiRK updated the diff for D17370: [chronik] add blockchain.transaction.broadcast electrum method.

use a match no that the Err branch is a single liner

Fri, Dec 20, 08:29
PiRK updated the diff for D17370: [chronik] add blockchain.transaction.broadcast electrum method.

leak, complete error messages

Fri, Dec 20, 08:20
bytesofman updated the diff for D17357: [Cashtab] Do not airdrop XEC to agora scripts.

rebase, remove debug logs

Fri, Dec 20, 04:00
bytesofman added inline comments to D17357: [Cashtab] Do not airdrop XEC to agora scripts.
Fri, Dec 20, 04:00
bytesofman published D17379: [mock-chronik-client] Dockerfile back to latest for review.
Fri, Dec 20, 03:50
bytesofman closed D17378: [mock-chronik-client] Cache bust dockerfile deployment.
Fri, Dec 20, 03:44
bytesofman committed rABC23f8e87875f8: [mock-chronik-client] Cache bust dockerfile deployment (authored by bytesofman).
[mock-chronik-client] Cache bust dockerfile deployment
Fri, Dec 20, 03:44
emack accepted D17378: [mock-chronik-client] Cache bust dockerfile deployment.
Fri, Dec 20, 03:44
bytesofman published D17378: [mock-chronik-client] Cache bust dockerfile deployment for review.
Fri, Dec 20, 03:42
bytesofman published D17377: [chronik-client] Dockerfile back to latest for review.
Fri, Dec 20, 03:36
bytesofman closed D17376: [chronik-client] CI patch test.
Fri, Dec 20, 03:28
bytesofman committed rABC9331d496b239: [chronik-client] CI patch test (authored by bytesofman).
[chronik-client] CI patch test
Fri, Dec 20, 03:28
emack accepted D17376: [chronik-client] CI patch test.
Fri, Dec 20, 03:24
bytesofman published D17376: [chronik-client] CI patch test for review.
Fri, Dec 20, 02:28
emack requested changes to D17357: [Cashtab] Do not airdrop XEC to agora scripts.
Fri, Dec 20, 02:17
bytesofman closed D17375: [faucet] CI fix.
Fri, Dec 20, 00:51
bytesofman committed rABC79a481529ae3: [faucet] CI fix (authored by bytesofman).
[faucet] CI fix
Fri, Dec 20, 00:51
tobias_ruck accepted D17375: [faucet] CI fix.
Fri, Dec 20, 00:46
bytesofman published D17375: [faucet] CI fix for review.
Fri, Dec 20, 00:38
bytesofman closed D17374: [CI fixes for ecashaddrjs diff] Update dockerfiles for CI impacts of lib change.
Fri, Dec 20, 00:24
bytesofman committed rABCf9679684fd54: [CI fixes for ecashaddrjs diff] Update dockerfiles for CI impacts of lib change (authored by bytesofman).
[CI fixes for ecashaddrjs diff] Update dockerfiles for CI impacts of lib change
Fri, Dec 20, 00:24
tobias_ruck accepted D17374: [CI fixes for ecashaddrjs diff] Update dockerfiles for CI impacts of lib change.
Fri, Dec 20, 00:24
bytesofman published D17374: [CI fixes for ecashaddrjs diff] Update dockerfiles for CI impacts of lib change for review.
Fri, Dec 20, 00:20

Thu, Dec 19

bytesofman closed D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Thu, Dec 19, 23:55
bytesofman committed rABC9d6760682b0f: [ecash-lib] Improve address handling of ecash dev libraries (authored by bytesofman).
[ecash-lib] Improve address handling of ecash dev libraries
Thu, Dec 19, 23:55
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

rebase, README improvements, preserve txBuilder.test.ts dependency groupings

Thu, Dec 19, 23:34
tobias_ruck accepted D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Thu, Dec 19, 23:24
tobias_ruck accepted D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Thu, Dec 19, 22:21
teamcity closed T3712: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Thu, Dec 19, 18:19
roqqit closed D17373: Fix flakiness in tests that wait for peer info to update immediately after disconnecting peers.
Thu, Dec 19, 17:26
roqqit committed rABC7f213483007a: Fix flakiness in tests that wait for peer info to update immediately after… (authored by roqqit).
Fix flakiness in tests that wait for peer info to update immediately after…
Thu, Dec 19, 17:26
bytesofman accepted D17373: Fix flakiness in tests that wait for peer info to update immediately after disconnecting peers.
Thu, Dec 19, 17:02
roqqit requested review of D17373: Fix flakiness in tests that wait for peer info to update immediately after disconnecting peers.
Thu, Dec 19, 16:43
PiRK added inline comments to D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Thu, Dec 19, 15:39
teamcity triaged T3712: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Thu, Dec 19, 15:28
bytesofman closed D17372: [Cashtab] Bump rendered txs in history from 10 to 20.
Thu, Dec 19, 14:29
bytesofman committed rABC13d309c93daf: [Cashtab] Bump rendered txs in history from 10 to 20 (authored by bytesofman).
[Cashtab] Bump rendered txs in history from 10 to 20
Thu, Dec 19, 14:29
bytesofman closed D17367: [Cashtab] Show a spinner while parsed txs are loading.
Thu, Dec 19, 14:21
bytesofman committed rABC962a0b53bbfe: [Cashtab] Show a spinner while parsed txs are loading (authored by bytesofman).
[Cashtab] Show a spinner while parsed txs are loading
Thu, Dec 19, 14:21
Fabien added inline comments to D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Thu, Dec 19, 13:02
PiRK closed D17371: [electrum] update server response message for excessive fee.
Thu, Dec 19, 13:02
PiRK committed rABC235133d95690: [electrum] update server response message for excessive fee (authored by PiRK).
[electrum] update server response message for excessive fee
Thu, Dec 19, 13:02
PiRK updated the diff for D17370: [chronik] add blockchain.transaction.broadcast electrum method.

rebase to restart CI. I can't figure out why rpc_psbt.py failed, but it is clearly unrelated (nodes[2] never received an inv for the transaction)

Thu, Dec 19, 11:44
PiRK accepted D17372: [Cashtab] Bump rendered txs in history from 10 to 20.
Thu, Dec 19, 10:32
PiRK accepted D17367: [Cashtab] Show a spinner while parsed txs are loading.
Thu, Dec 19, 10:31
Fabien accepted D17371: [electrum] update server response message for excessive fee.
Thu, Dec 19, 08:17
PiRK planned changes to D17370: [chronik] add blockchain.transaction.broadcast electrum method.

investigating build failure

Thu, Dec 19, 07:53
bytesofman retitled D17269: [ecash-lib] Improve address handling of ecash dev libraries from [ecash-lib] Implement ecashaddrjs functions in ecash-lib to [ecash-lib] Improve address handling of ecash dev libraries.
Thu, Dec 19, 07:42

Wed, Dec 18

roqqit closed D17337: [avalanche] Set local stake winner in the contender cache.
Wed, Dec 18, 22:45
roqqit committed rABCb1cea59f8291: [avalanche] Set local stake winner in the contender cache (authored by roqqit).
[avalanche] Set local stake winner in the contender cache
Wed, Dec 18, 22:45
roqqit closed D17368: Fix race to check chaintips in p2p_headers_sync_with_minchainwork.
Wed, Dec 18, 22:37
roqqit committed rABC607be5e6570a: Fix race to check chaintips in p2p_headers_sync_with_minchainwork (authored by roqqit).
Fix race to check chaintips in p2p_headers_sync_with_minchainwork
Wed, Dec 18, 22:37
roqqit closed D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.
Wed, Dec 18, 22:37
roqqit committed rABC0657e8a86eeb: [avalanche] Make sure each proof is added to contender cache before mining the… (authored by roqqit).
[avalanche] Make sure each proof is added to contender cache before mining the…
Wed, Dec 18, 22:37
bytesofman published D17372: [Cashtab] Bump rendered txs in history from 10 to 20 for review.
Wed, Dec 18, 22:12
bytesofman updated the summary of D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Wed, Dec 18, 21:54
bytesofman closed D17369: [mock-chronik-client] Add support for Agora ws subscriptions.
Wed, Dec 18, 21:49
bytesofman committed rABC7e2b466cd342: [mock-chronik-client] Add support for Agora ws subscriptions (authored by bytesofman).
[mock-chronik-client] Add support for Agora ws subscriptions
Wed, Dec 18, 21:48
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

pull out cashaddr logic from ecash-lib, remove dependencies from ecashaddrjs, major version bump for ecashaddrjs, implement ecashaddrjs 2.0.0 in all monorepo libraries, modify toLegacyAddress so it is a no-op if called with legacy addr

Wed, Dec 18, 21:47
johnkuney accepted D17369: [mock-chronik-client] Add support for Agora ws subscriptions.
Wed, Dec 18, 21:42
teamcity added a comment to D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Wed, Dec 18, 21:37
PiRK added a comment to D17370: [chronik] add blockchain.transaction.broadcast electrum method.

I updated the diff a bit too fast, so some of these recent errors are from previous versions of the diff.

Wed, Dec 18, 21:35
teamcity added a comment to D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Wed, Dec 18, 21:23
teamcity added a comment to D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Wed, Dec 18, 21:21
PiRK updated the diff for D17370: [chronik] add blockchain.transaction.broadcast electrum method.

improve for loop as per clippy's advice

Wed, Dec 18, 21:19
teamcity added a comment to D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Wed, Dec 18, 21:14
PiRK updated the diff for D17370: [chronik] add blockchain.transaction.broadcast electrum method.

remove unneeded rehash and wrong comment

Wed, Dec 18, 21:13
teamcity added a comment to D17370: [chronik] add blockchain.transaction.broadcast electrum method.
Wed, Dec 18, 21:11
PiRK retitled D17370: [chronik] add blockchain.transaction.broadcast electrum method from [chronik] add blockchain.transaction.boradcast electrum method to [chronik] add blockchain.transaction.broadcast electrum method.
Wed, Dec 18, 21:11
PiRK published D17370: [chronik] add blockchain.transaction.broadcast electrum method for review.
Wed, Dec 18, 21:10
PiRK requested review of D17371: [electrum] update server response message for excessive fee.
Wed, Dec 18, 21:09
tobias_ruck added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

What is the benefit vs a no-op ? Imagine I'm a mining pool and I want to convert all my miner addresses to legacy (real world use case) even if they are using BCH or XEC addresses. I would like to just use to_legacy() and not have to first check it's not legacy format already

Wed, Dec 18, 20:41
Fabien added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.

change toLegacyAddress behavior to throw if called with legacy address

Wed, Dec 18, 20:34
Fabien accepted D17337: [avalanche] Set local stake winner in the contender cache.
Wed, Dec 18, 20:23
Fabien accepted D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.
Wed, Dec 18, 20:15
Fabien accepted D17368: Fix race to check chaintips in p2p_headers_sync_with_minchainwork.
Wed, Dec 18, 20:11