Page MenuHomePhabricator
People nakihito

nakihito (Nico)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2018, 17:49 (335 w, 1 d)

Recent Activity
View All

Jun 23 2020

nakihito resigned from D6629: Merge #16152: Disable bloom filtering by default..
Jun 23 2020, 22:25
nakihito abandoned D5926: Add findforkhash RPC.
Jun 23 2020, 22:22
nakihito abandoned D4224: Rename some seeder options.
Jun 23 2020, 22:21
nakihito abandoned D4637: Remove gotos in seeder/dns.cpp.
Jun 23 2020, 22:21
nakihito abandoned D5144: Add LogPrint Benchmark.
Jun 23 2020, 22:20
nakihito planned changes to D6127: Add options to seeder to determine initial seed list at start up.
Jun 23 2020, 22:20
nakihito planned changes to D6629: Merge #16152: Disable bloom filtering by default..
Jun 23 2020, 22:20
nakihito abandoned D6647: Leftovers from PR15402.
Jun 23 2020, 22:18
nakihito planned changes to D5380: [seeder] Require good seeds to have latest checkpoint.
Jun 23 2020, 22:18
nakihito planned changes to D5956: Add -datadir option to allow specification of seeder's data directory.
Jun 23 2020, 22:17
nakihito planned changes to D6357: Dedup net message writing code in the seeder.
Jun 23 2020, 22:17
nakihito abandoned D6597: Merge #15059: test: Add basic test for BIP34.
Jun 23 2020, 22:14
nakihito abandoned D6603: Use fewer blocks in abc-miner-fund.py.
Jun 23 2020, 22:13

Jun 22 2020

nakihito planned changes to D6283: [seeder] Request headers from new connections.
Jun 22 2020, 22:55
nakihito updated the diff for D6283: [seeder] Request headers from new connections.

Added includes for primitives/blockhash.h and chainparams.h.

Jun 22 2020, 22:55
nakihito planned changes to D5987: Start using Logger for seeder logging.
Jun 22 2020, 22:35
nakihito updated the diff for D5987: Start using Logger for seeder logging.

Changed initialization code and new options to more closely resemble InitLogging().

Jun 22 2020, 22:35
nakihito committed rABC85999eb1fe47: Merge #13418: Docs: More precise explanation of parameter onlynet (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #13418: Docs: More precise explanation of parameter onlynet
Jun 22 2020, 21:51
nakihito closed D6672: Merge #13418: Docs: More precise explanation of parameter onlynet.
Jun 22 2020, 21:50
nakihito committed rABCedc303d7a396: Merge #13457: tests: Drop variadic macro (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13457: tests: Drop variadic macro
Jun 22 2020, 18:23
nakihito closed D6671: Merge #13457: tests: Drop variadic macro.
Jun 22 2020, 18:22
nakihito requested review of D6672: Merge #13418: Docs: More precise explanation of parameter onlynet.
Jun 22 2020, 18:20
nakihito requested review of D6671: Merge #13457: tests: Drop variadic macro.
Jun 22 2020, 18:05

Jun 19 2020

nakihito committed rABC094184ba4325: Merge #15999: init: Remove dead code in LoadChainTip (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15999: init: Remove dead code in LoadChainTip
Jun 19 2020, 00:28
nakihito closed D6631: Merge #15999: init: Remove dead code in LoadChainTip.
Jun 19 2020, 00:28

Jun 18 2020

nakihito committed rABC8baac1e576e1: Merge #13577: logging: avoid nStart may be used uninitialized in AppInitMain… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13577: logging: avoid nStart may be used uninitialized in AppInitMain…
Jun 18 2020, 22:44
nakihito closed D6646: Merge #13577: logging: avoid nStart may be used uninitialized in AppInitMain warning.
Jun 18 2020, 22:44
nakihito committed rABC5ba4892705aa: Merge #12401: Reset pblocktree before deleting LevelDB file (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12401: Reset pblocktree before deleting LevelDB file
Jun 18 2020, 22:38
nakihito closed D6632: Merge #12401: Reset pblocktree before deleting LevelDB file.
Jun 18 2020, 22:38
nakihito committed rABC6411602e25af: Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler…
Jun 18 2020, 22:26
nakihito closed D6489: Merge #15486: [addrman, net] Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups.
Jun 18 2020, 22:26
nakihito committed rABC76df4df8e642: Merge #15824: docs: Improve netbase comments (authored by nakihito).
Merge #15824: docs: Improve netbase comments
Jun 18 2020, 22:17
nakihito closed D6628: Merge #15824: docs: Improve netbase comments.
Jun 18 2020, 22:17
nakihito committed rABC20d411097e02: Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events. (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events.
Jun 18 2020, 22:14
nakihito closed D6630: Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events..
Jun 18 2020, 22:14
nakihito requested review of D6647: Leftovers from PR15402.
Jun 18 2020, 21:32
nakihito requested review of D6646: Merge #13577: logging: avoid nStart may be used uninitialized in AppInitMain warning.
Jun 18 2020, 20:59
nakihito accepted D6641: [backport#15751] Speed up deriveaddresses for large ranges.
Jun 18 2020, 19:27
nakihito requested review of D6632: Merge #12401: Reset pblocktree before deleting LevelDB file.
Jun 18 2020, 19:25
nakihito updated the summary of D6630: Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events..
Jun 18 2020, 19:01
nakihito requested review of D6630: Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events..
Jun 18 2020, 18:37
nakihito committed rABCa15468e67137: Merge #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp (authored by fanquake <fanquake@gmail.com>).
Merge #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp
Jun 18 2020, 18:34
nakihito closed D6634: Merge #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp.
Jun 18 2020, 18:33
nakihito updated the diff for D6628: Merge #15824: docs: Improve netbase comments.

Addressed nits.

Jun 18 2020, 17:04
nakihito requested review of D6634: Merge #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp.
Jun 18 2020, 01:27

Jun 17 2020

nakihito planned changes to D6632: Merge #12401: Reset pblocktree before deleting LevelDB file.
Jun 17 2020, 23:33
nakihito requested review of D6632: Merge #12401: Reset pblocktree before deleting LevelDB file.
Jun 17 2020, 23:33
nakihito committed rABCd022eaaeacfd: Merge #16188: net: Document what happens to getdata of unknown type (authored by fanquake <fanquake@gmail.com>).
Merge #16188: net: Document what happens to getdata of unknown type
Jun 17 2020, 23:12
nakihito closed D6625: Merge #16188: net: Document what happens to getdata of unknown type.
Jun 17 2020, 23:12
nakihito requested review of D6631: Merge #15999: init: Remove dead code in LoadChainTip.

Updated summary.

Jun 17 2020, 23:08
nakihito updated the summary of D6631: Merge #15999: init: Remove dead code in LoadChainTip.
Jun 17 2020, 23:07
nakihito planned changes to D6631: Merge #15999: init: Remove dead code in LoadChainTip.
Jun 17 2020, 23:02
nakihito requested review of D6631: Merge #15999: init: Remove dead code in LoadChainTip.
Jun 17 2020, 22:53
nakihito planned changes to D6630: Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events..
Jun 17 2020, 20:58
nakihito requested review of D6630: Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events..
Jun 17 2020, 20:58
nakihito requested review of D6629: Merge #16152: Disable bloom filtering by default..
Jun 17 2020, 20:31
nakihito requested review of D6628: Merge #15824: docs: Improve netbase comments.
Jun 17 2020, 19:13
nakihito requested review of D6625: Merge #16188: net: Document what happens to getdata of unknown type.
Jun 17 2020, 18:02

Jun 16 2020

nakihito committed rABC0ef55b58f3b6: generatetoaddress should mention ABC wallet not Core (authored by nakihito).
generatetoaddress should mention ABC wallet not Core
Jun 16 2020, 22:34
nakihito closed D6617: generatetoaddress should mention ABC wallet not Core.
Jun 16 2020, 22:34
nakihito requested review of D6617: generatetoaddress should mention ABC wallet not Core.
Jun 16 2020, 22:05
nakihito committed rABC31eb6eb78c10: Leftovers from PR14119 (authored by nakihito).
Leftovers from PR14119
Jun 16 2020, 21:02
nakihito closed D6599: Leftovers from PR14119.
Jun 16 2020, 21:01
nakihito updated the summary of D6597: Merge #15059: test: Add basic test for BIP34.
Jun 16 2020, 01:46
nakihito updated the diff for D6597: Merge #15059: test: Add basic test for BIP34.

Rebased off D6603.

Jun 16 2020, 01:45
nakihito requested review of D6603: Use fewer blocks in abc-miner-fund.py.
Jun 16 2020, 01:40

Jun 15 2020

nakihito requested review of D6599: Leftovers from PR14119.
Jun 15 2020, 23:26
nakihito added inline comments to D6597: Merge #15059: test: Add basic test for BIP34.
Jun 15 2020, 21:59
nakihito requested review of D6597: Merge #15059: test: Add basic test for BIP34.
Jun 15 2020, 21:57
nakihito accepted D6585: Use the new Check facility is rpc/blockchain.cpp.
Jun 15 2020, 18:31
nakihito accepted D6583: Use the new Check facility in rpc/misc.cpp.
Jun 15 2020, 18:27
nakihito accepted D6584: Use the new Check facility is wallet/rpcdump.cpp.
Jun 15 2020, 18:24
nakihito accepted D6581: Use the new Check facility in rpc/net.cpp.
Jun 15 2020, 18:21
nakihito accepted D6580: Use the new Check facility in rpc/rawtransaction.cpp.
Jun 15 2020, 18:19
nakihito accepted D6577: Use the new Check facility in rpc/mining.cpp.
Jun 15 2020, 18:06
nakihito committed rABCbbe97bafe5d5: Merge #14719: qa: Check specific reject reasons in feature_block (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14719: qa: Check specific reject reasons in feature_block
Jun 15 2020, 18:02
nakihito closed D6526: Merge #14719: qa: Check specific reject reasons in feature_block.
Jun 15 2020, 18:02
nakihito accepted D6561: [backport#16227 8/8] Move WatchOnly stuff from SigningProvider to CWallet.
Jun 15 2020, 01:51

Jun 13 2020

nakihito added inline comments to D6561: [backport#16227 8/8] Move WatchOnly stuff from SigningProvider to CWallet.
Jun 13 2020, 01:55
nakihito requested changes to D6561: [backport#16227 8/8] Move WatchOnly stuff from SigningProvider to CWallet.
Jun 13 2020, 01:31
nakihito committed rABCaea5b41c25cb: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block…
Jun 13 2020, 00:26
nakihito closed D6525: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request.
Jun 13 2020, 00:26

Jun 12 2020

nakihito accepted D6558: [backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h}.
Jun 12 2020, 21:51
nakihito updated the diff for D5380: [seeder] Require good seeds to have latest checkpoint.

Rebased.

Jun 12 2020, 21:15
nakihito updated the diff for D6357: Dedup net message writing code in the seeder.

Removed change to seeder/bitcoin.h copyright.

Jun 12 2020, 21:14
nakihito updated the diff for D6525: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request.

Rebased.

Jun 12 2020, 20:50
nakihito requested review of D6526: Merge #14719: qa: Check specific reject reasons in feature_block.

Actually fixed test plan.

Jun 12 2020, 20:47
nakihito updated the test plan for D6525: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request.
Jun 12 2020, 20:46
nakihito accepted D6556: [backport#16227 4/8] scripted-diff: rename CBasicKeyStore to FillableSigningProvider.
Jun 12 2020, 20:34
nakihito requested changes to D6558: [backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h}.

Test plan doesn't cover autotools and some small nits.

Jun 12 2020, 20:29
nakihito accepted D6557: [backport#16227 5/8] Move KeyOriginInfo to its own header file.
Jun 12 2020, 20:19
nakihito accepted D6555: [backport#16227 3/8] Move HaveKey static function from keystore to rpcwallet where it is used.
Jun 12 2020, 20:03
nakihito accepted D6553: [backport#16227 1/8]Add HaveKey and HaveCScript to SigningProvider.
Jun 12 2020, 20:00
nakihito accepted D6554: [backport#16227 2/8] Remove CKeyStore and squash into CBasicKeyStore.
Jun 12 2020, 19:59
nakihito updated the test plan for D6526: Merge #14719: qa: Check specific reject reasons in feature_block.
Jun 12 2020, 17:38
nakihito accepted D6543: Add a lock on cs_main while modifying the config in setexcessiveblock.

This is actually necessary to fix WSL too.

Jun 12 2020, 01:27

Jun 11 2020

nakihito requested review of D6525: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request.

Updated test plan.

Jun 11 2020, 18:03
nakihito planned changes to D6525: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request.
Jun 11 2020, 17:46
nakihito updated the test plan for D6525: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request.
Jun 11 2020, 17:28
nakihito updated the test plan for D6526: Merge #14719: qa: Check specific reject reasons in feature_block.
Jun 11 2020, 17:24