Details

Reviewers

Fabien
schancel

Group Reviewers

Restricted Project

Summary

This is essentially an interface to use what was created in D2040 in a way that is applicable to the Bitcoin Cash protocol.

Depends on D2040

Test Plan

Added test cases.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalancheblock

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3835
Build 5743: Bitcoin ABC Buildbot (legacy)
Build 5742: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 11 2018, 02:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2018, 02:48

deadalnix changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 11 2018, 02:48

schancel added a subscriber: schancel.Nov 11 2018, 03:09

schancel added inline comments.

src/test/avalanche_tests.cpp
102	Why is this error still considered valid? It shouldn't be finalized if it's invalid?

deadalnix added a child revision: D2043: [avalanche] Create an event loop facility..Nov 11 2018, 14:23

Remove blocks_to_reconciliate and dd test for addBlockToReconciliate return value.

jasonbcox requested changes to this revision.Nov 11 2018, 17:16

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/test/avalanche_tests.cpp
102	Ya, seems like this should move down a few lines to before the undo for loop for clarity.

This revision now requires changes to proceed.Nov 11 2018, 17:16

schancel added inline comments.Nov 11 2018, 18:37

src/test/avalanche_tests.cpp
102	Correction. Shouldn't it NOT be finalized if it's invalid?

deadalnix requested review of this revision.Nov 11 2018, 20:46

deadalnix marked an inline comment as done.

deadalnix added inline comments.

src/test/avalanche_tests.cpp
102	Because it is how the protocol works. We don't stop everything because one dude says no.

addBlockToReconciliate => addBlockToReconcile

Fabien edited the summary of this revision. (Show Details)Nov 11 2018, 21:50

jasonbcox added inline comments.Nov 11 2018, 23:02

src/test/avalanche_tests.cpp
102	Then you need to comment something like `Vote one more time to finalize. Using a no vote to ensure a small number of no votes still allow finalization.`

Make AvalancheVote layout consistent with CInv

Fabien accepted this revision as: Fabien.Nov 12 2018, 13:51

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/test/avalanche_tests.cpp
94 ↗	(On Diff #5759)	accepeted => accepted

schancel accepted this revision.Nov 12 2018, 20:58

jasonbcox requested changes to this revision.Nov 12 2018, 22:06

This revision now requires changes to proceed.Nov 12 2018, 22:06

Fix typo

rebase

Use CBlockIndex internally

deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 21 2018, 12:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4018: Diff 5973.Nov 21 2018, 14:32

Use a map instead of a vector of pairs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4038: Diff 5998!Nov 21 2018, 21:32

deadalnix removed a reviewer: jasonbcox.Nov 22 2018, 18:12

Fabien accepted this revision.Nov 22 2018, 18:13

This revision is now accepted and ready to land.Nov 22 2018, 18:13

Closed by commit rABC7fd9d97515b9: [avalanche] Add a block registry and facility to register votes on these blocks. (authored by deadalnix). · Explain WhyNov 22 2018, 18:14

This revision was automatically updated to reflect the committed changes.

bitcoinabc removed commits: rSTAGING7fd9d97515b9: [avalanche] Add a block registry and facility to register votes on these blocks., rABC7fd9d97515b9: [avalanche] Add a block registry and facility to register votes on these blocks..Jul 19 2021, 12:07

[avalanche] Add a block registry and facility to register votes on these blocks.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 5739

src/CMakeLists.txt

src/Makefile.am

src/avalanche.h

src/avalanche.cpp

src/avalanche_impl.h

src/test/avalanche_tests.cpp

[avalanche] Add a block registry and facility to register votes on these blocks.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5739

src/CMakeLists.txt

src/Makefile.am

src/avalanche.h

src/avalanche.cpp

src/avalanche_impl.h

src/test/avalanche_tests.cpp

[avalanche] Add a block registry and facility to register votes on these blocks.
ClosedPublic
Actions

Revision Contents
Changeset List