Details

Reviewers

jasonbcox
schancel
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING91e28d4f1b1f: [avalanche] Report the list of finalized blocks when votes are accounted for
rABC91e28d4f1b1f: [avalanche] Report the list of finalized blocks when votes are accounted for

Summary

AvalancheProcessor doesn't need to keep track of finalized items. Instead, it can forget about them let the caller know about finalization.

Depends on D2121

Test Plan

Modifed unit tests to reflect the change.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

producefinalized

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4087
Build 6245: Bitcoin ABC Buildbot (legacy)
Build 6244: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 11 2018, 19:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2018, 19:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 11 2018, 19:08

deadalnix added a child revision: D2046: [avalanche] Implement the challenge/response protocol.Nov 11 2018, 19:53

deadalnix edited the summary of this revision. (Show Details)

deadalnix added a parent revision: D2044: [avalanche] Add a facility to select invs to poll.

Separate accepted and rejected in two different vectors

Add test to make sure registerVotes do not resurrect votes.

jasonbcox retitled this revision from [avalanche] Report the list of finalized hashes when votes are acocunted for. to [avalanche] Report the list of finalized hashes when votes are accounted for.Nov 11 2018, 23:27

jasonbcox accepted this revision.Nov 11 2018, 23:46

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/avalanche.cpp
54 ↗	(On Diff #5754)	note -> not
src/test/avalanche_tests.cpp
80 ↗	(On Diff #5754)	This is much better. thank you

This revision is now accepted and ready to land.Nov 11 2018, 23:46

schancel accepted this revision.Nov 12 2018, 21:19

rebase

deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 21 2018, 14:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4022: Diff 5977.Nov 21 2018, 15:03

deadalnix requested review of this revision.Nov 21 2018, 17:07

deadalnix retitled this revision from [avalanche] Report the list of finalized hashes when votes are accounted for to [avalanche] Report the list of finalized blocks when votes are accounted for.Nov 21 2018, 21:10

Make the code more consistent with what's to come.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4037: Diff 5997.Nov 21 2018, 21:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.