Page MenuHomePhabricator
Differential D2363

Implement BIP159 NODE_NETWORK_LIMITED (pruned peers) *signaling only*
ClosedPublic
Actions

Authored by Fabien on Jan 21 2019, 13:01.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING00fa5cd2962e: Implement BIP159 NODE_NETWORK_LIMITED (pruned peers) *signaling only*
rABC00fa5cd2962e: Implement BIP159 NODE_NETWORK_LIMITED (pruned peers) *signaling only*
Summary
Does implement BIP159, but only the signalling part. No connections are
made to NODE_NETWORK_LIMITED in this PR.

Backport of core PR11740

Depends on D2362

Test Plan
./test/functional/test_runner.py node_network_limited

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11740
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4649
Build 7361: Bitcoin ABC Buildbot (legacy)
Build 7360: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 21 2019, 13:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2019, 13:01
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 21 2019, 13:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 21 2019, 13:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4608: Diff 6778.Jan 21 2019, 13:12
Fabien added a child revision: D2364: [tests] Rename feature_* functional tests..Jan 21 2019, 15:30
Fabien added a child revision: D2366: [tests] fix flake8 warnings in node_network_limited.py.Jan 21 2019, 16:08
Fabien removed a child revision: D2364: [tests] Rename feature_* functional tests..Jan 21 2019, 16:32
jasonbcox requested changes to this revision.Jan 22 2019, 18:00
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/node_network_limited.py
52 ↗(On Diff #6778)

remove NODE_WITNESS from comment

This revision now requires changes to proceed.Jan 22 2019, 18:00
Fabien updated this revision to Diff 6837.Jan 22 2019, 18:12

Fix comment

teamcity added a comment.Jan 22 2019, 18:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Jan 22 2019, 18:17
This revision is now accepted and ready to land.Jan 22 2019, 18:17
teamcity added a comment.Jan 22 2019, 18:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4649: Diff 6837.Jan 22 2019, 18:21
Closed by commit rABC00fa5cd2962e: Implement BIP159 NODE_NETWORK_LIMITED (pruned peers) *signaling only* (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by Fabien). · Explain WhyJan 22 2019, 18:27
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING00fa5cd2962e: Implement BIP159 NODE_NETWORK_LIMITED (pruned peers) *signaling only*.Sep 18 2019, 22:01

Revision Contents
Changeset List

PathSize
doc/
1 line
src/
2 lines
20 lines
10 lines
2 lines
test/
functional/
90 lines

Diff 6837

View Options

doc/bips.md

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/protocol.h

Loading...
View Options

src/validation.h

Loading...
View Options

test/functional/node_network_limited.py

Loading...