Page MenuHomePhabricator

Remove direct bitcoin calls from qt/clientmodel.cpp
ClosedPublic

Authored by jasonbcox on Apr 17 2019, 18:25.

Details

Summary
Test Plan

make check
ninja
bitcoin-qt # sanity checking; check traffic graph

Diff Detail

Repository
rABC Bitcoin ABC
Branch
c6b
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5533
Build 9128: Bitcoin ABC Teamcity Staging
Build 9127: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 17 2019, 18:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2019, 18:25
jasonbcox added inline comments.Apr 17 2019, 18:28
src/validation.h
430 ↗(On Diff #8104)

Originally, this should be backported in D1972 but it's dependency on D2645 is likely to cause significant delays. Considering this change is small, self-contained, and not actually related to D1972's PR description (Move some additional variables into CChainState private), I think it makes sense to include it here instead.

deadalnix requested changes to this revision.Apr 17 2019, 23:11
deadalnix added inline comments.
src/interface/node.h
15 ↗(On Diff #8104)

C++ style includes.

This revision now requires changes to proceed.Apr 17 2019, 23:11
jasonbcox edited the test plan for this revision. (Show Details)Apr 18 2019, 00:12
jasonbcox updated this revision to Diff 8114.Apr 18 2019, 00:19

C++ style includes

Fabien requested changes to this revision.Apr 18 2019, 07:54
Fabien added inline comments.
src/qt/clientmodel.h
23 ↗(On Diff #8114)

interfaces, see https://github.com/bitcoin/bitcoin/pull/12906
The same applies to the other places in the code

src/validation.cpp
5691 ↗(On Diff #8114)

Dito

src/validation.h
429 ↗(On Diff #8114)

This seems unrelated

This revision now requires changes to proceed.Apr 18 2019, 07:54
jasonbcox added inline comments.Apr 18 2019, 14:50
src/validation.h
429 ↗(On Diff #8114)

See my comment immediately below this. The build fails without it.

Fabien added inline comments.Apr 18 2019, 15:00
src/validation.h
429 ↗(On Diff #8114)

OK, I missed the comment

Fabien accepted this revision.Apr 20 2019, 13:10
deadalnix requested changes to this revision.Apr 20 2019, 14:49
deadalnix added inline comments.
src/interfaces/node.cpp
35

System libs come last.

This revision now requires changes to proceed.Apr 20 2019, 14:49
jasonbcox updated this revision to Diff 8207.Apr 22 2019, 16:47

Rebase + fix include ordering

deadalnix accepted this revision.Apr 23 2019, 20:53
This revision is now accepted and ready to land.Apr 23 2019, 20:53
This revision was automatically updated to reflect the committed changes.