[schnorr functional test] remove ComparisonTestFramework dependency
ClosedPublic
Actions

Authored by markblundeberg on Jul 8 2019, 22:43.

Details

Reviewers

Mengerian
Fabien
jasonbcox
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGc5c9afad5db9: [schnorr functional test] remove ComparisonTestFramework dependency
rABCc5c9afad5db9: [schnorr functional test] remove ComparisonTestFramework dependency

Summary

This switches the Schnorr test to not rely on comptool (which is
deprecated), and takes advantage of the newly backported P2PDataStore
features. bootstrap_p2p and reconnect_p2p are borrowed from
p2p_invalid_tx.py (introduced D3527).

This nicely removes the need to rely on -whitelist for rejected
blocks, instead we can send them and get "banned" (disconnected), and
then reconnect.

I've also added some logging to the test, while I'm at it.

Test Plan

./test/functional/test_runner.py abc-schnorr.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6765
Build 11577: Bitcoin ABC Buildbot (legacy)
Build 11576: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jul 8 2019, 22:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 8 2019, 22:43

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B6748: Diff 10117!Jul 8 2019, 22:45

In D3601#84923, @teamcity wrote:

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

validation_block_tests biting me once again...

After seeing this on phabricator it's a much bigger Diff than I imagined 😅 ... will break it up.

splitting up the big diff into smaller pieces...

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a child revision: D3615: [schnorr functional test] change block setup logic.Jul 9 2019, 18:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6765: Diff 10139.Jul 9 2019, 18:16

deadalnix accepted this revision.Jul 9 2019, 20:24

deadalnix added inline comments.

test/functional/abc-schnorr.py
2	I'm pretty sure bitcoin core did not write that test.

This revision is now accepted and ready to land.Jul 9 2019, 20:24

markblundeberg added inline comments.Jul 9 2019, 21:40

test/functional/abc-schnorr.py
2	There is a bunch of borrowed code at this point, in this case stuff from `p2p_invalid_tx.py` is being added. I dunno, we aren't very consistent with maintaining copyright headers (in case of backports), in any case ...