Page MenuHomePhabricator
Differential D4361

[tests] Rename rpc_listtransactions.py to wallet_listtransactions.py
ClosedPublic
Actions

Authored by nakihito on Nov 4 2019, 04:48.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGb96fe21d96ca: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py
rABCb96fe21d96ca: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py
Summary

listtransactions is a wallet RPC. The test name should indicate that
this is a wallet test.

Partial backport of Core PR12953
https://github.com/bitcoin/bitcoin/pull/12953/commits/4e671f0353beaa3759f2069569f05239c0be89cf

Depends on D3949

Test Plan
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12953-1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7964
Build 13931: Bitcoin ABC Buildbot (legacy)
Build 13930: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 4 2019, 04:48
Owners added a reviewer: Restricted Owners Package.Nov 4 2019, 04:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 4 2019, 04:48
nakihito planned changes to this revision.Nov 4 2019, 04:48
teamcity added a comment.Nov 4 2019, 04:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7964: Diff 13882.Nov 4 2019, 04:58
teamcity added a comment.Nov 4 2019, 04:58

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito requested review of this revision.Nov 4 2019, 19:08
nakihito edited the summary of this revision. (Show Details)
nakihito added a parent revision: D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.
nakihito added a child revision: D4368: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table.
nakihito mentioned this in D3950: Merge #12953: Deprecate accounts.Nov 4 2019, 19:33
Fabien accepted this revision.Nov 4 2019, 22:05
This revision is now accepted and ready to land.Nov 4 2019, 22:05
Closed by commit rABCb96fe21d96ca: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py (authored by John Newbery <john@johnnewbery.com>, committed by nakihito). · Explain WhyNov 5 2019, 21:20
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCb96fe21d96ca: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py.
nakihito added a commit: rSTAGINGb96fe21d96ca: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py.Apr 7 2020, 21:36

Revision Contents
Changeset List

PathSize
test/
functional/
8 lines
wallet_listtransactions.py
rpc_listtransactions.py
97 lines

Diff 13882

View Options

test/functional/rpc_listtransactions.py

Loading...
View Options

test/functional/timing.json

Loading...
View Options

test/functional/wallet_listtransactions.py

Loading...