Page MenuHomePhabricator
Differential D3589

[5 of 5] Style cleanup.
ClosedPublic
Actions

Authored by markblundeberg on Jul 7 2019, 22:49.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Project
Maniphest Tasks
T631: Backport PR 15118 "Refactor block file logic"
Commits
rSTAGINGd181505a6b0f: [5 of 5] Style cleanup.
rABCd181505a6b0f: [5 of 5] Style cleanup.
Summary

last partial PR15118 backport
https://github.com/bitcoin/bitcoin/pull/15118/commits/04cca330944f859b4ed68cb8da8a79f5206fd630

Depends on D3588

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15118e
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6774
Build 11595: Bitcoin ABC Buildbot (legacy)
Build 11594: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jul 7 2019, 22:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 7 2019, 22:49
teamcity added a comment.Jul 7 2019, 22:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 7 2019, 22:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6722: Diff 10067.Jul 7 2019, 22:59
markblundeberg added a task: T631: Backport PR 15118 "Refactor block file logic".Jul 7 2019, 23:06
markblundeberg updated this revision to Diff 10155.Jul 9 2019, 19:03

rebase for minor conflict

teamcity added a comment.Jul 9 2019, 19:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 9 2019, 19:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6774: Diff 10155.Jul 9 2019, 19:15
markblundeberg updated this revision to Diff 10279.Jul 13 2019, 02:02

minor conflict -- one braces fix now done in ancestor

teamcity added a comment.Jul 13 2019, 02:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 13 2019, 02:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6851: Diff 10279.Jul 13 2019, 02:17
jasonbcox requested changes to this revision.Jul 16 2019, 21:45

system.h/cpp needs to be backported first

This revision now requires changes to proceed.Jul 16 2019, 21:45
markblundeberg added a comment.EditedJul 18 2019, 06:13
In D3589#86858, @jasonbcox wrote:

system.h/cpp needs to be backported first

The difference is just a rename; util.cpp -> util/system.cpp.

See https://github.com/bitcoin/bitcoin/pull/14555/commits/2068f089c8b7b90eb4557d3f67ea0f0ed2059a23

markblundeberg requested review of this revision.Jul 19 2019, 15:34
deadalnix accepted this revision.Jul 21 2019, 13:33
jasonbcox accepted this revision.Aug 14 2019, 23:37
This revision is now accepted and ready to land.Aug 14 2019, 23:37
Closed by commit rABCd181505a6b0f: [5 of 5] Style cleanup. (authored by jimpo, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyAug 15 2019, 00:01
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCd181505a6b0f: [5 of 5] Style cleanup..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGd181505a6b0f: [5 of 5] Style cleanup..Sep 19 2019, 01:50

Revision Contents
Changeset List

PathSize
src/
10 lines
22 lines
2 lines
8 lines

Diff 10155

View Options

src/flatfile.h

Loading...
View Options

src/flatfile.cpp

Loading...
View Options

src/util.h

Loading...
View Options

src/util.cpp

Loading...