Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING5f7aec629b38: Merge #14023: Remove accounts rpcs
rABC5f7aec629b38: Merge #14023: Remove accounts rpcs

Summary

bb08423d5ca866d4a139a3b57ff110d818d08b32 [doc] Add release notes for 'account' API removal (John Newbery)
1f4b865e57b4567270b1586bb1f348ab9106485d [wallet] Re-sort wallet RPC commands (John Newbery)
f0dc850bf698f7377797d7d68365d4fc79b0221c [wallet] Remove wallet account RPCs (John Newbery)

Pull request description:

This is the first part of #13825. It simply removes the RPC methods and tests.

#13825 touches lots of files and will require frequent rebasing.

Breaking it down for easier reviewing and fewer rebases.

Tree-SHA512: d29af8e7a035e4484e6b9bb56cb86592be0ec112d8ba4ce19c15d15366ff3086e89e99fca26b90c9d66f6d3e06894486d0f29948df0bb7dcb1e2c49c6887a85a

Backport of Core PR14023

Test Plan

make check
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli help

Verify the account rpcs were removed.

./bitcoin-cli help sendmany

Verify the change to sendmany help text.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14023

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9543
Build 16995: Default Diff Build & Tests
Build 16994: arc lint + arc unit

Event Timeline

nakihito created this revision.Feb 22 2020, 00:27

Owners added a reviewer: Restricted Owners Package.Feb 22 2020, 00:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2020, 00:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Feb 22 2020, 00:28

nakihito added a parent revision: D5315: [tests] Remove wallet accounts test.

nakihito added inline comments.Feb 22 2020, 00:37

src/wallet/rpcwallet.cpp
245	This is removed in a future PR. but I see no reason not to remove it now as leaving it in would cause an unnecessary warning in the compiler until it was removed.

nakihito planned changes to this revision.Feb 22 2020, 00:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9543: Diff 16460.Feb 22 2020, 00:44

nakihito mentioned this in D5315: [tests] Remove wallet accounts test.Feb 22 2020, 00:59

Rebased.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9545: Diff 16462.Feb 22 2020, 01:21

See D5315, clearing my queue.

This revision now requires changes to proceed.Feb 22 2020, 15:57

nakihito planned changes to this revision.Feb 22 2020, 20:40

nakihito edited the summary of this revision. (Show Details)Feb 24 2020, 21:10

nakihito edited the test plan for this revision. (Show Details)

Squashed with D5315.

nakihito planned changes to this revision.Feb 24 2020, 22:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito removed a parent revision: D5315: [tests] Remove wallet accounts test.Feb 24 2020, 22:55

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9555: Diff 16484.Feb 24 2020, 23:03

nakihito requested review of this revision.Mar 3 2020, 18:36

nakihito added a child revision: D5410: [wallet] Remove 'account' argument from GetLegacyBalance().Mar 3 2020, 18:42

nakihito added a child revision: D5411: [wallet] Remove AccountMove().

nakihito added a child revision: D5412: [wallet] Remove CWallet::ListAccountCreditDebit() and GetAccountCreditDebit().Mar 3 2020, 18:44

nakihito added a child revision: D5415: [wallet] Don't read acentry key-values from wallet on load..Mar 3 2020, 19:50

nakihito added a child revision: D5419: [wallet] Delete unused account functions.Mar 3 2020, 22:20

nakihito added a child revision: D5421: [wallet] Remove strFromAccount and strSentAccount.Mar 3 2020, 22:41

Fabien requested changes to this revision.Mar 4 2020, 07:48

Fabien added inline comments.

doc/release-notes.md
33 ↗	(On Diff #16484)	Needs rebase.
src/wallet/rpcwallet.cpp
925 ↗	(On Diff #16484)	Not 8
927 ↗	(On Diff #16484)	The dummy element is missing (and was also previously, despite the detailed doc has it. Is this a backport missing or an oversight from another backport ?).
1500 ↗	(On Diff #16484)	There is a missing `EXCLUSIVE_LOCKS_REQUIRED`, is there a missing backport ?
test/functional/wallet_labels.py
69 ↗	(On Diff #16484)	Can you point to the missing backport and make sure there is no other code change that will be missing after this gets landed ?

This revision now requires changes to proceed.Mar 4 2020, 07:48

nakihito added inline comments.Mar 4 2020, 20:04

src/wallet/rpcwallet.cpp
927 ↗	(On Diff #16484)	https://reviews.bitcoinabc.org/D4370#change-4q6XVS3POqj5 https://github.com/bitcoin/bitcoin/pull/12953/files#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceR1089-R1132 https://github.com/bitcoin/bitcoin/pull/14023/files?file-filters%5B%5D=.cpp#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceL1124-L1169 The dummy element has always been missing, even on Core.
1500 ↗	(On Diff #16484)	https://github.com/bitcoin/bitcoin/pull/13083/files but it does not affect this change.
test/functional/wallet_labels.py
69 ↗	(On Diff #16484)	Originally added here: D1167 Removed here: D1799

Rebase, added braces, and fixed argument count.

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added inline comments.Mar 4 2020, 20:20

src/wallet/rpcwallet.cpp
1500 ↗	(On Diff #16484)	Should've been added in D4094.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9730: Diff 16770.Mar 4 2020, 20:29

Fabien requested changes to this revision.Mar 5 2020, 07:19

Fabien added inline comments.

src/wallet/rpcwallet.cpp
927 ↗	(On Diff #16484)	Thanks for digging into this. Please add it to the diff, there is no reason for not fixing a known mistake and it seems appropriated to do it here since it's account/label related.
1500 ↗	(On Diff #16484)	OK, agreed it's out of scope.