Page MenuHomePhabricator
Differential D2044

[avalanche] Add a facility to select invs to poll
ClosedPublic
Actions

Authored by deadalnix on Nov 11 2018, 15:38.

Details

Reviewers
schancel
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGf245a0ce69ec: [avalanche] Add a facility to select invs to poll
rABCf245a0ce69ec: [avalanche] Add a facility to select invs to poll
Summary

This extends the AvalancheProcessor with facility to decide what to poll.

Depends on D2043

Test Plan

Added unit tests.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
getinvs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3914
Build 5900: Bitcoin ABC Buildbot (legacy)
Build 5899: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 11 2018, 15:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2018, 15:38
teamcity added a subscriber: teamcity.Nov 11 2018, 15:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 11 2018, 15:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3840: Diff 5746.Nov 11 2018, 15:49
deadalnix changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 11 2018, 17:29
deadalnix added a child revision: D2045: [avalanche] Report the list of finalized blocks when votes are accounted for.Nov 11 2018, 19:53
deadalnix updated this revision to Diff 5751.Nov 11 2018, 21:06

addBlockToReconciliate => addBlockToReconcile

jasonbcox accepted this revision.Nov 11 2018, 23:33
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/avalanche.cpp
65 ↗(On Diff #5751)

Does this need a static_assert() to ensure it's strictly less than MAX_INV_SZ?

This revision is now accepted and ready to land.Nov 11 2018, 23:33
Fabien added a subscriber: Fabien.Nov 12 2018, 16:11

Can you rebase ?

schancel accepted this revision.Nov 12 2018, 21:15
jasonbcox requested changes to this revision.Nov 13 2018, 03:43
jasonbcox added inline comments.
src/avalanche.cpp
65 ↗(On Diff #5751)

The more I look at the other changes, the more important I think this is. Either strictly less than MAX_INV_SZ or dependent on MAX_PROTOCOL_MESSAGE_LENGTH in some way.

This revision now requires changes to proceed.Nov 13 2018, 03:43
deadalnix requested review of this revision.Nov 13 2018, 03:46
deadalnix marked an inline comment as done.
deadalnix added inline comments.
src/avalanche.cpp
65 ↗(On Diff #5751)

No. This is fast protocol, we want a low limit.

jasonbcox added inline comments.Nov 13 2018, 22:57
src/avalanche.cpp
65 ↗(On Diff #5751)

Ok, as long as we expect it to always be way lower.

deadalnix updated this revision to Diff 5833.Nov 16 2018, 18:19

rebase

Fabien accepted this revision as: Fabien.Nov 17 2018, 15:27
deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 21 2018, 13:28
deadalnix updated this revision to Diff 5975.Nov 21 2018, 14:00

rebase

deadalnix updated this revision to Diff 5976.Nov 21 2018, 14:01

wrong diff

teamcity added a comment.Nov 21 2018, 14:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4020: Diff 5975.Nov 21 2018, 14:47
teamcity added a comment.Nov 21 2018, 14:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 21 2018, 14:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4021: Diff 5976.Nov 21 2018, 14:55
teamcity added a comment.Nov 21 2018, 14:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix updated this revision to Diff 6001.Nov 21 2018, 23:47

remove unecessary code

teamcity added a comment.Nov 21 2018, 23:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 21 2018, 23:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4041: Diff 6001.Nov 21 2018, 23:55
deadalnix added a child revision: D2121: [avalanche] Add support to poll multiple block at once..Nov 22 2018, 18:44
deadalnix removed a child revision: D2045: [avalanche] Report the list of finalized blocks when votes are accounted for.Nov 22 2018, 18:52
Fabien accepted this revision.Nov 22 2018, 18:58
deadalnix removed a reviewer: jasonbcox.Nov 22 2018, 18:59
This revision is now accepted and ready to land.Nov 22 2018, 18:59
Closed by commit rABCf245a0ce69ec: [avalanche] Add a facility to select invs to poll (authored by deadalnix). · Explain WhyNov 22 2018, 19:00
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
25 lines
31 lines
test/
43 lines

Diff 5833

View Options

src/avalanche.h

Loading...
View Options

src/avalanche.cpp

Loading...
View Options

src/test/avalanche_tests.cpp

Loading...