Page MenuHomePhabricator
Differential D2783

Remove much of the remaining BIP9 code
ClosedPublic
Actions

Authored by schancel on Apr 7 2019, 06:35.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING36fb94ee0821: Remove much of the remaining BIP9 code
rABC36fb94ee0821: Remove much of the remaining BIP9 code
Summary

Much of the BIP9 handling code was removed in the following revisions:

This commit removes the unused versionbits handling code, and remaining extern references.

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
del-versionbits (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5406
Build 8874: Bitcoin ABC Buildbot (legacy)
Build 8873: arc lint + arc unit

Event Timeline

schancel created this revision.Apr 7 2019, 06:35
Owners added a reviewer: Restricted Owners Package.Apr 7 2019, 06:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 7 2019, 06:35
Herald added a reviewer: deadalnix. · View Herald Transcript
schancel updated this revision to Diff 7982.Apr 7 2019, 06:37

Fix missing newline

teamcity added a comment.Apr 7 2019, 06:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 7 2019, 06:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 7 2019, 06:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5406: Diff 7982.Apr 7 2019, 06:51
teamcity added a comment.Apr 7 2019, 06:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5405: Diff 7981.Apr 7 2019, 06:52
deadalnix added inline comments.Apr 8 2019, 20:00
src/validation.h
16

Why is that required ? Can't this be replaced favorably by a forward declaration ?

schancel updated this revision to Diff 8004.Apr 9 2019, 01:24

Remove chain.h as an include from validation.h

teamcity added a comment.Apr 9 2019, 01:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 9 2019, 01:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5419: Diff 8004.Apr 9 2019, 01:38
deadalnix accepted this revision.Apr 9 2019, 14:55
This revision is now accepted and ready to land.Apr 9 2019, 14:55
Closed by commit rABC36fb94ee0821: Remove much of the remaining BIP9 code (authored by schancel). · Explain WhyApr 10 2019, 01:09
This revision was automatically updated to reflect the committed changes.
nakihito mentioned this in D3293: Merge #13163: Make it clear which functions that are intended to be translation unit local.Jun 12 2019, 23:30
schancel added a commit: rSTAGING36fb94ee0821: Remove much of the remaining BIP9 code.Sep 19 2019, 14:55
PiRK mentioned this in D11211: validation: Remove global ::VersionBitsTip{State,SinceHeight,Statistics}.Mar 17 2022, 12:06
PiRK mentioned this in rABC7176fb75a43a: validation: Remove global ::VersionBitsTip{State,SinceHeight,Statistics}.Mar 17 2022, 14:16

Revision Contents
Changeset List

Diff 7982

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/Makefile.test.include

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/versionbits_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/versionbits.h

Loading...
View Options

src/versionbits.cpp

Loading...