Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/fe6f27e6ea68a139d3a98b30a53706008ef8b132
Progress towards T417
Depends on D2817
Details
Details
- Reviewers
deadalnix Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGINGd5744ecaae97: Remove direct bitcoin calls from qt/clientmodel.cpp
rABCd5744ecaae97: Remove direct bitcoin calls from qt/clientmodel.cpp
make check
ninja
bitcoin-qt # sanity checking; check traffic graph
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- c6b
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5559 Build 9180: Bitcoin ABC Buildbot (legacy) Build 9179: arc lint + arc unit
Event Timeline
| src/validation.h | ||
|---|---|---|
| 430 ↗ | (On Diff #8104) | Originally, this should be backported in D1972 but it's dependency on D2645 is likely to cause significant delays. Considering this change is small, self-contained, and not actually related to D1972's PR description (Move some additional variables into CChainState private), I think it makes sense to include it here instead. |
| src/interface/node.h | ||
|---|---|---|
| 15 ↗ | (On Diff #8104) | C++ style includes. |
| src/qt/clientmodel.h | ||
|---|---|---|
| 23 ↗ | (On Diff #8114) | interfaces, see https://github.com/bitcoin/bitcoin/pull/12906 |
| src/validation.cpp | ||
| 5691 ↗ | (On Diff #8114) | Dito |
| src/validation.h | ||
| 429 ↗ | (On Diff #8114) | This seems unrelated |
| src/validation.h | ||
|---|---|---|
| 429 ↗ | (On Diff #8114) | See my comment immediately below this. The build fails without it. |
| src/validation.h | ||
|---|---|---|
| 429 ↗ | (On Diff #8114) | OK, I missed the comment |
| src/interfaces/node.cpp | ||
|---|---|---|
| 35 ↗ | (On Diff #8174) | System libs come last. |