Page MenuHomePhabricator
Feed Advanced Search

Mar 16 2018

movrcx updated the diff for D1099: Adds OP_SPLIT functionality into interpreter.cpp.

Cleaning up due to D1202

Mar 16 2018, 02:49
movrcx updated the diff for D1097: Add support for CAT, and SPLIT opcodes.

Cleaning up due to D1202

Mar 16 2018, 02:37
movrcx updated the diff for D1095: Adds OP_MOD functionality into interpreter.cpp.

Cleaning up due to D1202

Mar 16 2018, 02:29
movrcx updated the diff for D1093: Adds OP_DIV functionality into interpreter.cpp.

Cleaning up due to D1202

Mar 16 2018, 02:05
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Cleaning up due to D1202

Mar 16 2018, 01:36
movrcx updated the diff for D1202: Pre-deployment for Monolith Opcode Deployment.

Fix tab/space issue in Cmake file

Mar 16 2018, 00:15
movrcx updated the diff for D1202: Pre-deployment for Monolith Opcode Deployment.

Fixup: add missing breaks, rename op_codes.cpp to monolith_opcodes.cpp

Mar 16 2018, 00:12

Mar 15 2018

movrcx updated the diff for D1202: Pre-deployment for Monolith Opcode Deployment.

Fix spaces to tab in Cmake file

Mar 15 2018, 23:00
Herald added 1 blocking reviewer(s) for D1202: Pre-deployment for Monolith Opcode Deployment: Restricted Project.
Mar 15 2018, 22:57
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Rename op_code.cpp file to op_codes.cpp

Mar 15 2018, 17:56
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Update op_codes.cpp to use SCRIPT_ERR_INVALID_BITWISE_LENGTH

Mar 15 2018, 17:22
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Fixup: Bitwise error message

Mar 15 2018, 17:15
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Update Bitwise error message

Mar 15 2018, 17:12
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Rename op_code.cpp to op_codes.cpp

Mar 15 2018, 16:19
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Rename op_code.cpp to op_codes.cpp

Mar 15 2018, 16:18

Mar 8 2018

movrcx updated the diff for D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.

This implementation doesn't reuse previous opcodes

Mar 8 2018, 06:20

Mar 5 2018

movrcx updated the summary of D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.
Mar 5 2018, 21:09
movrcx updated the diff for D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.

Add unit tests

Mar 5 2018, 20:29
movrcx abandoned D1140: Add SCRIPT_ENABLE_OPCODES0 flag.

Merging diffs so this is no longer needed.

Mar 5 2018, 20:25

Feb 28 2018

movrcx added inline comments to D1139: Enable May 15 2018 HF Activation.
Feb 28 2018, 16:53
movrcx added a comment to D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.

There are no tests.

Feb 28 2018, 16:52
movrcx added a comment to D1090: Adds Bitwise functionality into interpreter.cpp.

Ok, before this move forward, you some code to gate the activation of the new opcodes. There should remain invalid until the fork is activated.

Feb 28 2018, 02:52
movrcx updated the diff for D1142: Added tests for disabled opcodes before/after the fork..

Fixes tabs to spaces

Feb 28 2018, 02:04
movrcx created D1142: Added tests for disabled opcodes before/after the fork..
Feb 28 2018, 01:56
movrcx created D1141: Prepare for re-enabled opcodes for the May 2018 protocol upgrade.
Feb 28 2018, 01:54
movrcx created D1140: Add SCRIPT_ENABLE_OPCODES0 flag.
Feb 28 2018, 01:52
movrcx updated the diff for D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.

Update comments and add OP_BIN2NUM definition in script.cpp

Feb 28 2018, 00:25

Feb 27 2018

movrcx updated the diff for D1103: Add support for NUM2BIN, and BIN2NUM opcodes.

Add OP_NUM2BIN definition in script.cpp

Feb 27 2018, 23:55
movrcx updated the diff for D1103: Add support for NUM2BIN, and BIN2NUM opcodes.

Update variable names for clarity

Feb 27 2018, 23:47
movrcx added inline comments to D1103: Add support for NUM2BIN, and BIN2NUM opcodes.
Feb 27 2018, 22:18
movrcx added inline comments to D1103: Add support for NUM2BIN, and BIN2NUM opcodes.
Feb 27 2018, 22:08
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Added default case statement

Feb 27 2018, 21:45
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Fixup that re-inserts code that was dropped off from previous commit (this one still uses c++11 style loops)

Feb 27 2018, 21:14
movrcx added a comment to T245: Add a hardfork date parameter for May 15th HF..

I've added https://reviews.bitcoinabc.org/D1139 to be used for MTP activation... Since it's a trailing indicator ABC will likely activate after BU's activation by local system time.

Feb 27 2018, 20:34 ยท Bootcamp
movrcx created D1139: Enable May 15 2018 HF Activation.
Feb 27 2018, 20:30

Feb 22 2018

movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Switch for loops to c++11

Feb 22 2018, 21:19

Feb 16 2018

movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Add default case statement

Feb 16 2018, 09:30
movrcx abandoned D1107: Enable bitwise opcodes OP_AND, OP_OR, OP_XOR.
Feb 16 2018, 08:42
movrcx abandoned D1108: Enable OP_DIV.
Feb 16 2018, 08:41
movrcx abandoned D1109: Enable OP_MOD.
Feb 16 2018, 08:41
movrcx abandoned D1104: unit tests for OP_NUM2BIN.
Feb 16 2018, 08:34
movrcx abandoned D1102: unit tests for OP_BIN2NUM.
Feb 16 2018, 08:33
movrcx abandoned D1100: unit tests for OP_SPLIT.
Feb 16 2018, 08:33
movrcx abandoned D1098: unit test for OP_CAT.
Feb 16 2018, 08:33
movrcx abandoned D1096: unit test for OP_MOD.
Feb 16 2018, 08:30
movrcx abandoned D1094: unit test for OP_DIV.
Feb 16 2018, 08:30
movrcx abandoned D1092: unit test for bitwise operations (AND, OR, XOR).
Feb 16 2018, 08:30
movrcx abandoned D1091: unit test removal OP_LEFT/RIGHT/SUBSTR.
Feb 16 2018, 08:29
movrcx updated the diff for D1103: Add support for NUM2BIN, and BIN2NUM opcodes.

Unit tests are attached and may be executed with ./test-bitcoin --run_test=op_code

Feb 16 2018, 08:25
movrcx updated the diff for D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.

Unit tests are attached and may be executed with ./test-bitcoin --run_test=op_code

Feb 16 2018, 08:22
movrcx updated the diff for D1099: Adds OP_SPLIT functionality into interpreter.cpp.

Unit tests are attached and may be executed with ./test-bitcoin --run_test=op_code

Feb 16 2018, 08:20
movrcx updated the diff for D1097: Add support for CAT, and SPLIT opcodes.

Adds unit tests

Feb 16 2018, 08:17
movrcx updated the diff for D1095: Adds OP_MOD functionality into interpreter.cpp.

Adding unit tests

Feb 16 2018, 08:14
movrcx updated the diff for D1093: Adds OP_DIV functionality into interpreter.cpp.

Adds unit tests

Feb 16 2018, 08:07
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Adds Bitwise functionality into interpreter.cpp

Feb 16 2018, 07:39
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Adds unit tests for the Bitwise operations
Unit tests are attached and may be executed with ./test-bitcoin --run_test=op_code

Feb 16 2018, 07:32
movrcx updated the diff for D1090: Adds Bitwise functionality into interpreter.cpp.

Removes tests for deprecated opcodes (LEFT,RIGHT,SUBSTR)
Unit tests are attached and may be executed with ./test-bitcoin --run_test=op_code

Feb 16 2018, 07:30
movrcx updated the diff for D1107: Enable bitwise opcodes OP_AND, OP_OR, OP_XOR.

Fixup

Feb 16 2018, 07:15
movrcx created D1109: Enable OP_MOD.
Feb 16 2018, 07:13
movrcx created D1108: Enable OP_DIV.
Feb 16 2018, 07:11
Owners added a reviewer for D1107: Enable bitwise opcodes OP_AND, OP_OR, OP_XOR: Restricted Owners Package.
Feb 16 2018, 07:07

Feb 15 2018

movrcx updated the diff for D1092: unit test for bitwise operations (AND, OR, XOR).

Updating copyright date

Feb 15 2018, 02:54
movrcx added a comment to D1094: unit test for OP_DIV.

In C++ there is a corner-case where the maximal negative integer, divided by -1, overflows. Is there something similar in script?

Feb 15 2018, 02:49
movrcx updated the summary of D1090: Adds Bitwise functionality into interpreter.cpp.
Feb 15 2018, 02:42
movrcx updated the summary of D1094: unit test for OP_DIV.
Feb 15 2018, 02:40
movrcx updated the summary of D1091: unit test removal OP_LEFT/RIGHT/SUBSTR.
Feb 15 2018, 02:39
movrcx updated the summary of D1092: unit test for bitwise operations (AND, OR, XOR).
Feb 15 2018, 02:39
movrcx updated the summary of D1098: unit test for OP_CAT.
Feb 15 2018, 02:39
movrcx updated the summary of D1100: unit tests for OP_SPLIT.
Feb 15 2018, 02:38
movrcx updated the summary of D1104: unit tests for OP_NUM2BIN.
Feb 15 2018, 02:38
movrcx updated the summary of D1093: Adds OP_DIV functionality into interpreter.cpp.
Feb 15 2018, 01:59
movrcx updated the summary of D1095: Adds OP_MOD functionality into interpreter.cpp.
Feb 15 2018, 01:59
movrcx updated the summary of D1097: Add support for CAT, and SPLIT opcodes.
Feb 15 2018, 01:59
movrcx updated the summary of D1099: Adds OP_SPLIT functionality into interpreter.cpp.
Feb 15 2018, 01:59
movrcx updated the summary of D1103: Add support for NUM2BIN, and BIN2NUM opcodes.
Feb 15 2018, 01:58
movrcx updated the summary of D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.
Feb 15 2018, 01:58
movrcx updated the summary of D1099: Adds OP_SPLIT functionality into interpreter.cpp.
Feb 15 2018, 01:57
movrcx updated the summary of D1097: Add support for CAT, and SPLIT opcodes.
Feb 15 2018, 01:57
movrcx updated the summary of D1095: Adds OP_MOD functionality into interpreter.cpp.
Feb 15 2018, 01:57
movrcx updated the summary of D1090: Adds Bitwise functionality into interpreter.cpp.
Feb 15 2018, 01:57
movrcx updated the summary of D1093: Adds OP_DIV functionality into interpreter.cpp.
Feb 15 2018, 01:56
movrcx updated the summary of D1090: Adds Bitwise functionality into interpreter.cpp.
Feb 15 2018, 01:54
movrcx updated the diff for D1095: Adds OP_MOD functionality into interpreter.cpp.

Removing autolinting

Feb 15 2018, 01:29
movrcx updated the diff for D1093: Adds OP_DIV functionality into interpreter.cpp.

Removing autolinting

Feb 15 2018, 01:28
movrcx created D1104: unit tests for OP_NUM2BIN.
Feb 15 2018, 01:25
movrcx created D1103: Add support for NUM2BIN, and BIN2NUM opcodes.
Feb 15 2018, 01:24
movrcx created D1102: unit tests for OP_BIN2NUM.
Feb 15 2018, 01:20
movrcx created D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.
Feb 15 2018, 01:18
movrcx created D1100: unit tests for OP_SPLIT.
Feb 15 2018, 01:14
movrcx created D1099: Adds OP_SPLIT functionality into interpreter.cpp.
Feb 15 2018, 01:13
movrcx updated the diff for D1097: Add support for CAT, and SPLIT opcodes.

Fixing auto-linting

Feb 15 2018, 01:10
movrcx created D1098: unit test for OP_CAT.
Feb 15 2018, 01:03
movrcx created D1097: Add support for CAT, and SPLIT opcodes.
Feb 15 2018, 01:02
movrcx created D1096: unit test for OP_MOD.
Feb 15 2018, 00:59
movrcx created D1095: Adds OP_MOD functionality into interpreter.cpp.
Feb 15 2018, 00:57
movrcx created D1094: unit test for OP_DIV.
Feb 15 2018, 00:54
movrcx created D1093: Adds OP_DIV functionality into interpreter.cpp.
Feb 15 2018, 00:52
movrcx created D1092: unit test for bitwise operations (AND, OR, XOR).
Feb 15 2018, 00:49
movrcx created D1091: unit test removal OP_LEFT/RIGHT/SUBSTR.
Feb 15 2018, 00:45
Owners added a reviewer for D1090: Adds Bitwise functionality into interpreter.cpp: Restricted Owners Package.
Feb 15 2018, 00:42