@dagurval points out, maybe we want to go straight for https://github.com/bitcoin/bitcoin/pull/14670 ... sounds like this exits uncleanly in some cases?

Feb 13 2019, 22:03

markblundeberg added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.

Feb 13 2019, 21:57

teamcity added a comment to D2479: Add activation code for SEGWIT_RECOVERY.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 13 2019, 21:56

markblundeberg updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

some tiny nits that @Fabien pointed out on D2483 / D2527

Feb 13 2019, 21:55

teamcity added a comment to D2479: Add activation code for SEGWIT_RECOVERY.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 13 2019, 21:50

markblundeberg updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

fully mock test time
one more sendrawtransaction rejection test
misc changes

Feb 13 2019, 21:49

Fabien accepted D2544: Improve shutdown process.

Feb 13 2019, 21:21

teamcity added a comment to D2545: qt: Poll ShutdownTimer after init is done.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Feb 13 2019, 20:14

teamcity added a comment to D2545: qt: Poll ShutdownTimer after init is done.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 13 2019, 20:00

Herald added a reviewer for D2545: qt: Poll ShutdownTimer after init is done: Restricted Project.

Feb 13 2019, 20:00

teamcity added a comment to D2544: Improve shutdown process.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Feb 13 2019, 19:59

teamcity added a comment to D2544: Improve shutdown process.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 13 2019, 19:46

Herald added a reviewer for D2544: Improve shutdown process: Restricted Project.

Feb 13 2019, 19:45

teamcity added a comment to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Feb 13 2019, 19:34

jasonbcox added inline comments to D2542: Format BIP32 test cases manually.

Feb 13 2019, 19:30

teamcity added a comment to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 13 2019, 19:19

Herald added a reviewer for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC: Restricted Project.

Feb 13 2019, 19:18

deadalnix requested changes to D2479: Add activation code for SEGWIT_RECOVERY.

Ok some comments, but nothing really bad. This will be in very soon.

Feb 13 2019, 19:07

Fabien added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.

Feb 13 2019, 18:56

deadalnix requested review of D2457: [schnorr] Refactor the signature process in reusable component.

Feb 13 2019, 18:46

jasonbcox added a parent task for T521: Backport Core PR 10706: T536: Make nTxConfirmTarget use config instead of being global.

Feb 13 2019, 18:24 · Backport

jasonbcox added a subtask for T536: Make nTxConfirmTarget use config instead of being global: T521: Backport Core PR 10706.

Feb 13 2019, 18:24 · Bootcamp, Restricted Project

jasonbcox triaged T536: Make nTxConfirmTarget use config instead of being global as Normal priority.

Feb 13 2019, 18:24 · Bootcamp, Restricted Project

jasonbcox committed rABCea21177017ac: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee (authored by jasonbcox).

Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee

Feb 13 2019, 18:03

jasonbcox closed D2540: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee.

Feb 13 2019, 18:03

markblundeberg added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.

Feb 13 2019, 17:45

markblundeberg added inline comments to D2483: Schnorr signature activation.

Feb 13 2019, 17:42

markblundeberg added inline comments to D2483: Schnorr signature activation.

Feb 13 2019, 17:42

markblundeberg added inline comments to D2483: Schnorr signature activation.

Feb 13 2019, 17:36

teamcity added a comment to D2479: Add activation code for SEGWIT_RECOVERY.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Feb 13 2019, 16:51

teamcity added a comment to D2483: Schnorr signature activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Feb 13 2019, 16:43

teamcity added a comment to D2479: Add activation code for SEGWIT_RECOVERY.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 13 2019, 16:36

markblundeberg updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

rebase after D2527 landing

Feb 13 2019, 16:36

markblundeberg commandeered D2479: Add activation code for SEGWIT_RECOVERY.

commandeering this one for the home stretch

Feb 13 2019, 16:35

teamcity added a comment to D2483: Schnorr signature activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 13 2019, 16:29

markblundeberg updated the diff for D2483: Schnorr signature activation.

rebase after D2527 landing

Feb 13 2019, 16:28

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC8ff468e92bf4: Improved mempool handling when changing validation rulesets (authored by florian).

Improved mempool handling when changing validation rulesets

Feb 13 2019, 15:23

florian closed D2527: Improved mempool handling when changing validation rulesets.

Feb 13 2019, 15:23

teamcity added a comment to D2527: Improved mempool handling when changing validation rulesets.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Feb 13 2019, 15:16

teamcity added a comment to D2527: Improved mempool handling when changing validation rulesets.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 13 2019, 15:02

markblundeberg updated the diff for D2527: Improved mempool handling when changing validation rulesets.

last nit for % formatting

Feb 13 2019, 15:01

teamcity added a comment to D2542: Format BIP32 test cases manually.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Feb 13 2019, 14:53

teamcity added a comment to D2542: Format BIP32 test cases manually.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 13 2019, 14:38

Herald added a reviewer for D2542: Format BIP32 test cases manually: Restricted Project.

Feb 13 2019, 14:37

teamcity added a comment to D2541: [WIP] Integrate test_bitcoin with arcanist through arc unit.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Feb 13 2019, 11:25

teamcity added a comment to D2541: [WIP] Integrate test_bitcoin with arcanist through arc unit.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 13 2019, 11:11

Herald added a reviewer for D2541: [WIP] Integrate test_bitcoin with arcanist through arc unit: deadalnix.

Feb 13 2019, 11:10

Fabien accepted D2540: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee.

Feb 13 2019, 09:25

Fabien added inline comments to D2483: Schnorr signature activation.

Feb 13 2019, 09:09

Fabien accepted D2527: Improved mempool handling when changing validation rulesets.

Feb 13 2019, 08:57

dagurval abandoned D2508: [tests] nulldummy cleanup.

According to telegram discussion, this change is controversial and needs to be split into 7 diffs.

Feb 13 2019, 07:07

jasonbcox accepted D2527: Improved mempool handling when changing validation rulesets.

Feb 13 2019, 00:59

teamcity added a comment to D2527: Improved mempool handling when changing validation rulesets.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Feb 13 2019, 00:48

teamcity added a comment to D2527: Improved mempool handling when changing validation rulesets.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 13 2019, 00:33

markblundeberg updated the diff for D2527: Improved mempool handling when changing validation rulesets.

address jason comments

Feb 13 2019, 00:32

Feb 12 2019

jasonbcox accepted D2008: Change signrawtransaction to signrawtransactionwithwallet in tests, add a test for legacy signrawtransaction.

Feb 12 2019, 23:50

jasonbcox accepted D2009: [Target v0.19] Deprecate and add test for signrawtransaction.

Feb 12 2019, 23:47

jasonbcox accepted D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.

Feb 12 2019, 23:46

jasonbcox accepted D2483: Schnorr signature activation.

Feb 12 2019, 23:36

jasonbcox requested changes to D2527: Improved mempool handling when changing validation rulesets.

Feb 12 2019, 23:25

deadalnix accepted D2527: Improved mempool handling when changing validation rulesets.

Feb 12 2019, 23:10

teamcity added a comment to D2540: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Feb 12 2019, 23:09

teamcity added a comment to D2540: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 12 2019, 22:55

Herald added a reviewer for D2540: Remove txmempool::estimateSmartFee as it's redundant with ::estimateFee: Restricted Project.

Feb 12 2019, 22:53

jasonbcox closed T512: Backport Core PR 10420 as Resolved.

Feb 12 2019, 22:44 · Backport

jasonbcox closed T512: Backport Core PR 10420, a subtask of T417: Backport PR10244 from core, as Resolved.

Feb 12 2019, 22:44 · Backport

jasonbcox committed rABCc3f35428fd2e: Add Qt tests for wallet spends (authored by Russell Yanofsky <russ@yanofsky.org>).

Add Qt tests for wallet spends

Feb 12 2019, 22:28

jasonbcox closed D2538: Add Qt tests for wallet spends.

Feb 12 2019, 22:28

teamcity added a comment to D2527: Improved mempool handling when changing validation rulesets.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Feb 12 2019, 20:29

Fabien accepted D2538: Add Qt tests for wallet spends.

Feb 12 2019, 20:22

teamcity added a comment to D2527: Improved mempool handling when changing validation rulesets.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 12 2019, 20:15

markblundeberg updated the diff for D2527: Improved mempool handling when changing validation rulesets.

address requests for change:

misc nits
logging messages altered
test now fully mock-timed
expanded comments about how transactions are tracked in invalidateblock and reorg events

Feb 12 2019, 20:14

teamcity added a comment to D2538: Add Qt tests for wallet spends.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Feb 12 2019, 19:23

jasonbcox closed T511: Backport Core PR 10770 as Resolved.

Feb 12 2019, 19:15 · Backport

jasonbcox closed T511: Backport Core PR 10770, a subtask of T417: Backport PR10244 from core, as Resolved.

Feb 12 2019, 19:15 · Backport

jasonbcox accepted D2518: Add an argument to the test framework to enable great wall activation.

Feb 12 2019, 19:15

jasonbcox added a comment to D2538: Add Qt tests for wallet spends.

I can see this is a dependency for T417 in the task list but fail to see how they are linked together; is there another intermediate backport that needs to build on top of this one ?

Feb 12 2019, 19:09

teamcity added a comment to D2538: Add Qt tests for wallet spends.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Feb 12 2019, 19:09

jasonbcox updated the diff for D2538: Add Qt tests for wallet spends.

Fixed according to feedback

Feb 12 2019, 19:07

All StoriesUse ResultsEdit QueryHide Query

Feb 14 2019

Feb 13 2019

Feb 12 2019

All Stories
Use Results
Edit Query
Hide Query