Gonna take control of this as florian will be away for the next few days, and this needs landing soon. Thanks for the hard work thus far @florian . :-D
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Feb 12 2019
Feb 12 2019
This is in pretty good shape now. The test looks great. I still got a few things to improve, but this is getting there.
Fabien requested changes to D2534: [schnorr] Add features to combine public keys in order to do musig..
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC43e73d0dfed6: nits in abc-replay-protection (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
nits in abc-replay-protection
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
@Fabien ping
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
fix nits that Fabien pointed out
Bunch of nits in the test
Fabien updated the summary of D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
teamcity added a comment to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Fabien updated the diff for D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Remove invalid sighash flags from the help messages
I can see this is a dependency for T417 in the task list but fail to see how they are linked together; is there another intermediate backport that needs to build on top of this one ?
Could you please rebase on current master ? This will close the discussion regarding ToHex()/FromHex()
markblundeberg added inline comments to D2527: Improved mempool handling when changing validation rulesets.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Improved readability of the functional test.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
rebased; shorten comment
(make check and all functional tests passed on my local machine as well)
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC31427f585a5c: Bump automatic replay protection to Nov 2019 upgrade (authored by dagurval).
Bump automatic replay protection to Nov 2019 upgrade
Feb 11 2019
Feb 11 2019
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
rebased ; release notes now applied to 0.19.0
I'm gonna grab this just to make sure it can get landed soon. Sorry for barging in!
Feb 11 2019, 22:36 · Restricted Project
jasonbcox closed T381: Implement polymorphic RPC call registration, a subtask of T367: Create proof-of-concept for BlockTemplateManager, as Resolved.
Feb 11 2019, 22:36 · Restricted Project
jasonbcox closed T381: Implement polymorphic RPC call registration, a subtask of T368: Implement new getblocktemplate mode, as Resolved.
Feb 11 2019, 22:36 · Restricted Project
jasonbcox committed rABC97c2227fc9ba: Added RPCCommand base classes in preparation for RPC migration (authored by jasonbcox).
Added RPCCommand base classes in preparation for RPC migration
jasonbcox requested changes to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Use ToHex() in feature_nulldummy.py
Fabien committed rABC06092e020159: Use ToHex() in rpc_decodescript.py, remove dependency to mininode (authored by Fabien).
Use ToHex() in rpc_decodescript.py, remove dependency to mininode
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
jasonbcox committed rABC5f2ade873098: Remove BytesIO dependency from feature_dersig (authored by jasonbcox).
Remove BytesIO dependency from feature_dersig
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Refactored the ban testing code to only use public interfaces.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
teamcity added a comment to D2536: Use ToHex() in rpc_decodescript.py, remove dependency to mininode.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2536: Use ToHex() in rpc_decodescript.py, remove dependency to mininode.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Herald added a reviewer for D2536: Use ToHex() in rpc_decodescript.py, remove dependency to mininode: deadalnix.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2008: Change signrawtransaction to signrawtransactionwithwallet in tests, add a test for legacy signrawtransaction.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Rebase
teamcity added a comment to D2008: Change signrawtransaction to signrawtransactionwithwallet in tests, add a test for legacy signrawtransaction.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Fabien updated the diff for D2008: Change signrawtransaction to signrawtransactionwithwallet in tests, add a test for legacy signrawtransaction.
Rebase
teamcity added a comment to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
@markblundeberg Yes they are
Fabien updated the diff for D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
Rebase
Add importMempool
markblundeberg added inline comments to D2506: Update mandatory flags after Magnetic anomaly has activated.
jasonbcox committed rABC7777c68cf676: Remove dependency on BytesIO in feature_nulldummy.py (authored by jasonbcox).
Remove dependency on BytesIO in feature_nulldummy.py
markblundeberg added a comment to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.
@Fabien are these still on the table for 0.19?
Feb 10 2019
Feb 10 2019
Honestly the test is completely unreadable. There is no way I can ensure this is correct.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
markblundeberg added a comment to D2527: Improved mempool handling when changing validation rulesets.
Looks good on the functional test, you even did "Send post-fork-only txn into the mempool again" 👍
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.