Page MenuHomePhabricator
Feed Advanced Search

Nov 15 2020

deadalnix closed D8413: Load the descriptor cache from the wallet file.
Nov 15 2020, 00:51
deadalnix committed rABCbdb10f67a26d: Load the descriptor cache from the wallet file (authored by Andrew Chow <achow101-github@achow101.com>).
Load the descriptor cache from the wallet file
Nov 15 2020, 00:51
deadalnix closed D8411: Implement IsHDEnabled in DescriptorScriptPubKeyMan.
Nov 15 2020, 00:51
deadalnix committed rABC3c1c535e9545: Implement IsHDEnabled in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement IsHDEnabled in DescriptorScriptPubKeyMan
Nov 15 2020, 00:51
deadalnix closed D8410: Implement MarkUnusedAddresses in DescriptorScriptPubKeyMan.
Nov 15 2020, 00:50
deadalnix committed rABC519c2188002c: Implement MarkUnusedAddresses in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement MarkUnusedAddresses in DescriptorScriptPubKeyMan
Nov 15 2020, 00:50
deadalnix closed D8409: Implement IsMine for DescriptorScriptPubKeyMan.
Nov 15 2020, 00:50
deadalnix committed rABC26d8378ff2a5: Implement IsMine for DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement IsMine for DescriptorScriptPubKeyMan
Nov 15 2020, 00:50
deadalnix requested review of D8415: Add IsSingleType to Descriptors.
Nov 15 2020, 00:49
deadalnix requested review of D8414: Implement loading of keys for DescriptorScriptPubKeyMan.
Nov 15 2020, 00:39
deadalnix closed D8408: Add LoadDescriptorScriptPubKeyMan and SetActiveScriptPubKeyMan to CWallet.
Nov 15 2020, 00:32
deadalnix committed rABC8d87af1d95e3: Add LoadDescriptorScriptPubKeyMan and SetActiveScriptPubKeyMan to CWallet (authored by Andrew Chow <achow101-github@achow101.com>).
Add LoadDescriptorScriptPubKeyMan and SetActiveScriptPubKeyMan to CWallet
Nov 15 2020, 00:32
deadalnix requested review of D8413: Load the descriptor cache from the wallet file.
Nov 15 2020, 00:28
deadalnix requested review of D8412: Implement GetID for DescriptorScriptPubKeyMan.
Nov 15 2020, 00:16

Nov 14 2020

deadalnix requested review of D8411: Implement IsHDEnabled in DescriptorScriptPubKeyMan.
Nov 14 2020, 23:54
deadalnix requested review of D8410: Implement MarkUnusedAddresses in DescriptorScriptPubKeyMan.
Nov 14 2020, 23:48
deadalnix requested review of D8409: Implement IsMine for DescriptorScriptPubKeyMan.
Nov 14 2020, 23:41
deadalnix requested review of D8408: Add LoadDescriptorScriptPubKeyMan and SetActiveScriptPubKeyMan to CWallet.
Nov 14 2020, 23:34
deadalnix closed D8407: Implement SetType in DescriptorScriptPubKeyMan.
Nov 14 2020, 23:02
deadalnix committed rABCfa34b26b0851: Implement SetType in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement SetType in DescriptorScriptPubKeyMan
Nov 14 2020, 23:02
deadalnix closed D8406: Store WalletDescriptor in DescriptorScriptPubKeyMan.
Nov 14 2020, 22:58
deadalnix committed rABC3f54b6583733: Store WalletDescriptor in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Store WalletDescriptor in DescriptorScriptPubKeyMan
Nov 14 2020, 22:58
deadalnix closed D8405: Add a lock cs_desc_man for DescriptorScriptPubKeyMan.
Nov 14 2020, 22:54
deadalnix committed rABC58e5c16a1edf: Add a lock cs_desc_man for DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Add a lock cs_desc_man for DescriptorScriptPubKeyMan
Nov 14 2020, 22:54
deadalnix closed D8404: Introduce WalletDescriptor class.
Nov 14 2020, 22:50
deadalnix committed rABC9549dd30e3ea: Introduce WalletDescriptor class (authored by Andrew Chow <achow101-github@achow101.com>).
Introduce WalletDescriptor class
Nov 14 2020, 22:50
deadalnix closed D8403: Create LegacyScriptPubKeyMan when not a descriptor wallet.
Nov 14 2020, 20:59
deadalnix committed rABCf71ec45eb0be: Create LegacyScriptPubKeyMan when not a descriptor wallet (authored by Andrew Chow <achow101-github@achow101.com>).
Create LegacyScriptPubKeyMan when not a descriptor wallet
Nov 14 2020, 20:59
deadalnix closed D8402: Return nullptr from GetLegacyScriptPubKeyMan if descriptor wallet.
Nov 14 2020, 20:57
deadalnix committed rABCe9201a674f1e: Return nullptr from GetLegacyScriptPubKeyMan if descriptor wallet (authored by Andrew Chow <achow101-github@achow101.com>).
Return nullptr from GetLegacyScriptPubKeyMan if descriptor wallet
Nov 14 2020, 20:57
deadalnix closed D8401: Add WALLET_FLAG_DESCRIPTORS.
Nov 14 2020, 20:55
deadalnix committed rABC8df16fce7c96: Add WALLET_FLAG_DESCRIPTORS (authored by Andrew Chow <achow101-github@achow101.com>).
Add WALLET_FLAG_DESCRIPTORS
Nov 14 2020, 20:55
deadalnix closed D8400: Introduce DescriptorScriptPubKeyMan as a dummy class.
Nov 14 2020, 20:52
deadalnix committed rABCec3e0eb46de9: Introduce DescriptorScriptPubKeyMan as a dummy class (authored by Andrew Chow <achow101-github@achow101.com>).
Introduce DescriptorScriptPubKeyMan as a dummy class
Nov 14 2020, 20:52
deadalnix requested review of D8407: Implement SetType in DescriptorScriptPubKeyMan.
Nov 14 2020, 20:40
deadalnix closed D8399: Introduce SetType function to tell ScriptPubKeyMans the type and internal-ness of it.
Nov 14 2020, 20:32
deadalnix committed rABC1d9ce974373b: Introduce SetType function to tell ScriptPubKeyMans the type and internal-ness… (authored by Andrew Chow <achow101-github@achow101.com>).
Introduce SetType function to tell ScriptPubKeyMans the type and internal-ness…
Nov 14 2020, 20:32
deadalnix requested review of D8406: Store WalletDescriptor in DescriptorScriptPubKeyMan.
Nov 14 2020, 20:05
deadalnix requested review of D8405: Add a lock cs_desc_man for DescriptorScriptPubKeyMan.
Nov 14 2020, 19:59
deadalnix requested review of D8404: Introduce WalletDescriptor class.
Nov 14 2020, 18:28
deadalnix requested review of D8403: Create LegacyScriptPubKeyMan when not a descriptor wallet.
Nov 14 2020, 18:19
deadalnix requested review of D8402: Return nullptr from GetLegacyScriptPubKeyMan if descriptor wallet.
Nov 14 2020, 18:06
deadalnix requested review of D8401: Add WALLET_FLAG_DESCRIPTORS.
Nov 14 2020, 17:57
deadalnix requested review of D8400: Introduce DescriptorScriptPubKeyMan as a dummy class.
Nov 14 2020, 17:42
deadalnix requested review of D8399: Introduce SetType function to tell ScriptPubKeyMans the type and internal-ness of it.
Nov 14 2020, 17:24
deadalnix requested changes to D8339: Move seed list vector operations into distinct compilation unit.
Nov 14 2020, 17:11

Nov 13 2020

deadalnix closed D8395: Get the OutputType for a descriptor.
Nov 13 2020, 23:36
deadalnix committed rABCa9369bba4071: Get the OutputType for a descriptor (authored by Andrew Chow <achow101-github@achow101.com>).
Get the OutputType for a descriptor
Nov 13 2020, 23:36
deadalnix closed D8394: Various nits in descriptor.cpp.
Nov 13 2020, 19:57
deadalnix committed rABC2891975f13f1: Various nits in descriptor.cpp (authored by deadalnix).
Various nits in descriptor.cpp
Nov 13 2020, 19:57
deadalnix accepted D8393: qt: Add LogQtInfo() function.
Nov 13 2020, 18:15
deadalnix requested review of D8395: Get the OutputType for a descriptor.
Nov 13 2020, 18:06
deadalnix requested review of D8394: Various nits in descriptor.cpp.
Nov 13 2020, 17:43
deadalnix closed D8388: Cache parent xpub inside of BIP32PubkeyProvider.
Nov 13 2020, 13:34
deadalnix committed rABCec5a073bd022: Cache parent xpub inside of BIP32PubkeyProvider (authored by Andrew Chow <achow101-github@achow101.com>).
Cache parent xpub inside of BIP32PubkeyProvider
Nov 13 2020, 13:34
deadalnix closed D8387: Only cache xpubs that have a hardened last step.
Nov 13 2020, 13:32
deadalnix committed rABC3a378ee5ce2a: Only cache xpubs that have a hardened last step (authored by Andrew Chow <achow101-github@achow101.com>).
Only cache xpubs that have a hardened last step
Nov 13 2020, 13:32
deadalnix closed D8386: Cache the immediate derivation parent xpub.
Nov 13 2020, 13:30
deadalnix committed rABCf0c918349526: Cache the immediate derivation parent xpub (authored by Andrew Chow <achow101-github@achow101.com>).
Cache the immediate derivation parent xpub
Nov 13 2020, 13:30
deadalnix closed D8384: Add DescriptorCache* read_cache and DescriptorCache* write_cache to Expand and GetPubKey.
Nov 13 2020, 13:28
deadalnix committed rABC06534944000e: Add DescriptorCache* read_cache and DescriptorCache* write_cache to Expand and… (authored by Andrew Chow <achow101-github@achow101.com>).
Add DescriptorCache* read_cache and DescriptorCache* write_cache to Expand and…
Nov 13 2020, 13:28
deadalnix closed D8383: Rename BIP32PubkeyProvider.m_extkey to m_root_extkey.
Nov 13 2020, 13:22
deadalnix committed rABCca0a03351c0d: Rename BIP32PubkeyProvider.m_extkey to m_root_extkey (authored by Andrew Chow <achow101-github@achow101.com>).
Rename BIP32PubkeyProvider.m_extkey to m_root_extkey
Nov 13 2020, 13:22
deadalnix closed D8382: Track the index of the key expression in PubkeyProvider.
Nov 13 2020, 13:15
deadalnix committed rABC74509ddd8a62: Track the index of the key expression in PubkeyProvider (authored by Andrew Chow <achow101-github@achow101.com>).
Track the index of the key expression in PubkeyProvider
Nov 13 2020, 13:15
deadalnix closed D8381: Introduce DescriptorCache struct which caches xpubs.
Nov 13 2020, 13:13
deadalnix committed rABC4edde519407b: Introduce DescriptorCache struct which caches xpubs (authored by Andrew Chow <achow101-github@achow101.com>).
Introduce DescriptorCache struct which caches xpubs
Nov 13 2020, 13:13
deadalnix closed D8385: Add adaptation of the descriptor test that are using segwit in Core.
Nov 13 2020, 12:59
deadalnix committed rABCd089e4f386df: Add adaptation of the descriptor test that are using segwit in Core (authored by deadalnix).
Add adaptation of the descriptor test that are using segwit in Core
Nov 13 2020, 12:59
deadalnix closed D8380: Relayout doccomments in descriptor.h.
Nov 13 2020, 03:06
deadalnix committed rABC1a229a0ad622: Relayout doccomments in descriptor.h (authored by deadalnix).
Relayout doccomments in descriptor.h
Nov 13 2020, 03:06
deadalnix updated the diff for D8380: Relayout doccomments in descriptor.h.

Update layout

Nov 13 2020, 03:05
deadalnix requested review of D8388: Cache parent xpub inside of BIP32PubkeyProvider.
Nov 13 2020, 01:28
deadalnix requested review of D8387: Only cache xpubs that have a hardened last step.
Nov 13 2020, 01:24
deadalnix requested review of D8386: Cache the immediate derivation parent xpub.
Nov 13 2020, 01:22
deadalnix requested review of D8385: Add adaptation of the descriptor test that are using segwit in Core.
Nov 13 2020, 00:55
deadalnix requested review of D8384: Add DescriptorCache* read_cache and DescriptorCache* write_cache to Expand and GetPubKey.
Nov 13 2020, 00:01

Nov 12 2020

deadalnix requested review of D8383: Rename BIP32PubkeyProvider.m_extkey to m_root_extkey.
Nov 12 2020, 23:56
deadalnix requested review of D8382: Track the index of the key expression in PubkeyProvider.
Nov 12 2020, 23:52
deadalnix requested review of D8381: Introduce DescriptorCache struct which caches xpubs.
Nov 12 2020, 23:49
deadalnix requested review of D8380: Relayout doccomments in descriptor.h.
Nov 12 2020, 23:21
deadalnix accepted D8379: [backport#11558] Minimal code changes to allow msvc compilation.

ok for the backport, but we don't real support MSVC

Nov 12 2020, 22:16
deadalnix accepted D7804: [backport#15024] Allow specific private keys to be derived from descriptor.
Nov 12 2020, 20:44
deadalnix closed D8359: Add test for descriptor ranges in wallet_importmulti.py.
Nov 12 2020, 15:14
deadalnix committed rABC09cc5afe4fb7: Add test for descriptor ranges in wallet_importmulti.py (authored by deadalnix).
Add test for descriptor ranges in wallet_importmulti.py
Nov 12 2020, 15:14

Nov 10 2020

deadalnix updated the diff for D8359: Add test for descriptor ranges in wallet_importmulti.py.

Remove debug log

Nov 10 2020, 17:51
deadalnix requested review of D8359: Add test for descriptor ranges in wallet_importmulti.py.
Nov 10 2020, 17:39
deadalnix accepted D8337: test: Fix intermittent sync_blocks failures.
Nov 10 2020, 02:45
deadalnix accepted D8342: Add BCHN variant of check-seeds build.
Nov 10 2020, 00:06
deadalnix requested changes to D8339: Move seed list vector operations into distinct compilation unit.

This doesn't seems to be useful. This just adds initialization for no reason.

Nov 10 2020, 00:06

Nov 9 2020

deadalnix accepted D8316: tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such.
Nov 9 2020, 23:56
deadalnix closed D8319: Add routine to upgrade the block tree db to index block size.
Nov 9 2020, 21:34
deadalnix committed rABC47564b0e7b40: Add routine to upgrade the block tree db to index block size (authored by deadalnix).
Add routine to upgrade the block tree db to index block size
Nov 9 2020, 21:34
deadalnix updated the diff for D8319: Add routine to upgrade the block tree db to index block size.

Fix typos

Nov 9 2020, 18:12
deadalnix added a comment to D8319: Add routine to upgrade the block tree db to index block size.

More a question than requesting changes: comparing version against CLIENT_VERSION will force to upgrade the database at each version. This will read the disk content in the loop, but do nothing other than updating the version number in the end. Is there a use case for this or should version compare to TRACK_SIZE_VERSION instead ?

Nov 9 2020, 18:02
deadalnix requested changes to D8337: test: Fix intermittent sync_blocks failures.
Nov 9 2020, 17:59

Nov 8 2020

deadalnix updated the diff for D8319: Add routine to upgrade the block tree db to index block size.

Do not upgrade entries that do not require upgrading.

Nov 8 2020, 20:06
deadalnix accepted D8317: tests: Use a default of supports_cli=True (instead of supports_cli=False).
Nov 8 2020, 15:13
deadalnix accepted D8320: test: re-enable CLI test support by using EncodeDecimal in json.dumps().
Nov 8 2020, 15:12
deadalnix accepted D8307: util: Update tinyformat to upstream.
Nov 8 2020, 15:11