Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Nov 20 2020

deadalnix requested changes to D8476: Adding a landing page for BCHA information.
Nov 20 2020, 14:40
deadalnix accepted D8478: refactor: replace pointers by references within tx_verify.{h,cpp}.
Nov 20 2020, 14:39
deadalnix added inline comments to D8474: adding parent dir web/ for web apps.
Nov 20 2020, 14:37
deadalnix requested changes to D8477: Add a prettier linter for the web tools.
Nov 20 2020, 14:36

Nov 19 2020

deadalnix planned changes to D8475: add importdescriptors RPC and tests for native descriptor wallets.
Nov 19 2020, 23:55
deadalnix requested review of D8475: add importdescriptors RPC and tests for native descriptor wallets.
Nov 19 2020, 23:54
deadalnix accepted D8473: [buildbot] Add a facility for fetching the files changed in a given revision.
Nov 19 2020, 23:47
deadalnix closed D8467: Return error when no ScriptPubKeyMan is available for specified type.
Nov 19 2020, 20:40
deadalnix committed rABCf53059d18e7c: Return error when no ScriptPubKeyMan is available for specified type (authored by Andrew Chow <achow101-github@achow101.com>).
Return error when no ScriptPubKeyMan is available for specified type
Nov 19 2020, 20:40
deadalnix closed D8468: Correctly check for default wallet.
Nov 19 2020, 20:23
deadalnix committed rABCa58b36f37fc1: Correctly check for default wallet (authored by Andrew Chow <achow101-github@achow101.com>).
Correctly check for default wallet
Nov 19 2020, 20:22
deadalnix closed D8466: Implement CWallet::IsSpentKey for non-LegacySPKMans.
Nov 19 2020, 20:16
deadalnix committed rABC8b377d31cd2a: Implement CWallet::IsSpentKey for non-LegacySPKMans (authored by Andrew Chow <achow101-github@achow101.com>).
Implement CWallet::IsSpentKey for non-LegacySPKMans
Nov 19 2020, 20:16
deadalnix accepted D8472: [buildbot] Support a list of regex when matching builds to changed files.
Nov 19 2020, 20:02
deadalnix accepted D8464: indexes: Add compact block filter headers cache.
Nov 19 2020, 16:02
deadalnix accepted D8463: Serve cfcheckpt requests.
Nov 19 2020, 16:01
deadalnix accepted D8462: refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg.
Nov 19 2020, 15:58
deadalnix accepted D8469: net processing: Add support for getcfilters.
Nov 19 2020, 15:57
deadalnix accepted D8465: net processing: Add support for getcfheaders.
Nov 19 2020, 15:54
deadalnix requested review of D8468: Correctly check for default wallet.
Nov 19 2020, 15:31
deadalnix requested review of D8467: Return error when no ScriptPubKeyMan is available for specified type.
Nov 19 2020, 15:22
deadalnix requested review of D8466: Implement CWallet::IsSpentKey for non-LegacySPKMans.
Nov 19 2020, 15:15
deadalnix accepted D8461: scripted-diff: test: replace command with msgtype (naming).
Nov 19 2020, 14:07
deadalnix closed D8458: Add IsLegacy to CWallet so that the GUI knows whether to show watchonly.
Nov 19 2020, 14:00
deadalnix committed rABC36c78200690b: Add IsLegacy to CWallet so that the GUI knows whether to show watchonly (authored by Andrew Chow <achow101-github@achow101.com>).
Add IsLegacy to CWallet so that the GUI knows whether to show watchonly
Nov 19 2020, 14:00
deadalnix accepted D8460: scripted-diff: Replace strCommand with msg_type.
Nov 19 2020, 13:55
deadalnix closed D8457: Generate new descriptors when encrypting.
Nov 19 2020, 13:53
deadalnix committed rABC73cf12785f48: Generate new descriptors when encrypting (authored by Andrew Chow <achow101-github@achow101.com>).
Generate new descriptors when encrypting
Nov 19 2020, 13:53
deadalnix closed D8455: Be able to create new wallets with DescriptorScriptPubKeyMans as backing.
Nov 19 2020, 13:46
deadalnix committed rABC2ab0aaff663c: Be able to create new wallets with DescriptorScriptPubKeyMans as backing (authored by Andrew Chow <achow101-github@achow101.com>).
Be able to create new wallets with DescriptorScriptPubKeyMans as backing
Nov 19 2020, 13:46
deadalnix closed D8454: Implement GetMetadata in DescriptorScriptPubKeyMan.
Nov 19 2020, 13:41
deadalnix committed rABC0fcd2b0ffae7: Implement GetMetadata in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement GetMetadata in DescriptorScriptPubKeyMan
Nov 19 2020, 13:41
deadalnix closed D8453: Change GetMetadata to use unique_ptr<CKeyMetadata>.
Nov 19 2020, 13:37
deadalnix committed rABCf18cf5b36037: Change GetMetadata to use unique_ptr<CKeyMetadata> (authored by Andrew Chow <achow101-github@achow101.com>).
Change GetMetadata to use unique_ptr<CKeyMetadata>
Nov 19 2020, 13:37
deadalnix closed D8451: Implement FillPSBT in DescriptorScriptPubKeyMan.
Nov 19 2020, 13:27
deadalnix committed rABC69c82b89f1e5: Implement FillPSBT in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement FillPSBT in DescriptorScriptPubKeyMan
Nov 19 2020, 13:27
deadalnix requested changes to D8452: Adding cashtab in web folder.

First create a web folder.
Then you can fan out. Add the tools for the web folder, such as prettier & al and in parallel, add the tab project.

Nov 19 2020, 13:24
deadalnix accepted D8459: [buildbot] Add revision ID as arg to /buildDiff.
Nov 19 2020, 01:51
deadalnix requested review of D8458: Add IsLegacy to CWallet so that the GUI knows whether to show watchonly.
Nov 19 2020, 01:10
deadalnix requested review of D8457: Generate new descriptors when encrypting.
Nov 19 2020, 00:39
deadalnix accepted D8456: Set a different default PPA depending on network.
Nov 19 2020, 00:27
deadalnix requested review of D8455: Be able to create new wallets with DescriptorScriptPubKeyMans as backing.
Nov 19 2020, 00:21
deadalnix requested review of D8454: Implement GetMetadata in DescriptorScriptPubKeyMan.
Nov 19 2020, 00:12
deadalnix requested review of D8453: Change GetMetadata to use unique_ptr<CKeyMetadata>.
Nov 19 2020, 00:06

Nov 18 2020

deadalnix requested review of D8451: Implement FillPSBT in DescriptorScriptPubKeyMan.
Nov 18 2020, 23:51
deadalnix requested changes to D8449: Moving cashtab to web/ folder.

I wonder what's the deal with "doing XXX" rather than "do XXX". Is there a reason? I've seen you and John do it and never anyone else I've worked with before.

Nov 18 2020, 23:44
deadalnix requested changes to D8450: Implementing inline revisions.
Nov 18 2020, 23:41
deadalnix added a comment to D8450: Implementing inline revisions.

Just amend your previous patch. There is no need to commit wrong stuff and then patches that et them fixed int he repo history.

Nov 18 2020, 23:40
deadalnix added inline comments to D8441: Adding cashtab and draft deploy scripts.
Nov 18 2020, 22:55
deadalnix closed D8448: Implement SignMessage for descriptor wallets.
Nov 18 2020, 22:53
deadalnix committed rABC52063277f89e: Implement SignMessage for descriptor wallets (authored by Andrew Chow <achow101-github@achow101.com>).
Implement SignMessage for descriptor wallets
Nov 18 2020, 22:53
deadalnix closed D8447: Implement SignTransaction in DescriptorScriptPubKeyMan.
Nov 18 2020, 22:25
deadalnix committed rABC79aee7021f5a: Implement SignTransaction in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement SignTransaction in DescriptorScriptPubKeyMan
Nov 18 2020, 22:25
deadalnix requested review of D8448: Implement SignMessage for descriptor wallets.
Nov 18 2020, 21:56
deadalnix closed D8446: Implement GetSolvingProvider for DescriptorScriptPubKeyMan.
Nov 18 2020, 21:41
deadalnix committed rABCd9256979b0ff: Implement GetSolvingProvider for DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement GetSolvingProvider for DescriptorScriptPubKeyMan
Nov 18 2020, 21:41
deadalnix closed D8445: Implement GetKeypoolOldestTime and only display it if greater than 0.
Nov 18 2020, 21:39
deadalnix committed rABCc3e6f224b76e: Implement GetKeypoolOldestTime and only display it if greater than 0 (authored by Andrew Chow <achow101-github@achow101.com>).
Implement GetKeypoolOldestTime and only display it if greater than 0
Nov 18 2020, 21:38
deadalnix requested review of D8447: Implement SignTransaction in DescriptorScriptPubKeyMan.
Nov 18 2020, 21:37
deadalnix requested review of D8446: Implement GetSolvingProvider for DescriptorScriptPubKeyMan.
Nov 18 2020, 21:14
deadalnix requested review of D8445: Implement GetKeypoolOldestTime and only display it if greater than 0.
Nov 18 2020, 20:37
deadalnix requested changes to D8441: Adding cashtab and draft deploy scripts.

This does not looks like it is in an appropriate place in the middle of bitcoind's source code.

Nov 18 2020, 02:12

Nov 17 2020

deadalnix closed D8428: Implement ReturnDestination in DescriptorScriptPubKeyMan.
Nov 17 2020, 01:58
deadalnix committed rABC39b171eb1f29: Implement ReturnDestination in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement ReturnDestination in DescriptorScriptPubKeyMan
Nov 17 2020, 01:57
deadalnix closed D8427: Implement GetReservedDestination in DescriptorScriptPubKeyMan.
Nov 17 2020, 01:56
deadalnix committed rABC370080ae4a3a: Implement GetReservedDestination in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement GetReservedDestination in DescriptorScriptPubKeyMan
Nov 17 2020, 01:56
deadalnix closed D8426: Implement Unlock and Encrypt in DescriptorScriptPubKeyMan.
Nov 17 2020, 01:56
deadalnix committed rABC8f3b9050ec7b: Implement Unlock and Encrypt in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement Unlock and Encrypt in DescriptorScriptPubKeyMan
Nov 17 2020, 01:55
deadalnix requested review of D8428: Implement ReturnDestination in DescriptorScriptPubKeyMan.
Nov 17 2020, 01:06

Nov 16 2020

deadalnix accepted D8425: Fix improper Doxygen inline comments.
Nov 16 2020, 21:07
deadalnix requested review of D8427: Implement GetReservedDestination in DescriptorScriptPubKeyMan.
Nov 16 2020, 20:55
deadalnix requested review of D8426: Implement Unlock and Encrypt in DescriptorScriptPubKeyMan.
Nov 16 2020, 20:49
deadalnix closed D8421: Implement GetNewDestination for DescriptorScriptPubKeyMan.
Nov 16 2020, 20:42
deadalnix committed rABC1390ead60fa8: Implement GetNewDestination for DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement GetNewDestination for DescriptorScriptPubKeyMan
Nov 16 2020, 20:42
deadalnix closed D8419: Implement TopUp in DescriptorScriptPubKeyMan.
Nov 16 2020, 20:40
deadalnix committed rABC1031d71bffdc: Implement TopUp in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement TopUp in DescriptorScriptPubKeyMan
Nov 16 2020, 20:40
deadalnix updated the diff for D8421: Implement GetNewDestination for DescriptorScriptPubKeyMan.

rebase

Nov 16 2020, 16:17
deadalnix updated the diff for D8419: Implement TopUp in DescriptorScriptPubKeyMan.

Various nits

Nov 16 2020, 16:15
deadalnix closed D8418: Implement SetupGeneration for DescriptorScriptPubKeyMan.
Nov 16 2020, 16:09
deadalnix committed rABC20931601ca6d: Implement SetupGeneration for DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement SetupGeneration for DescriptorScriptPubKeyMan
Nov 16 2020, 16:09
deadalnix closed D8423: [avalanche] Add a custom TestSetup for processor_tests.
Nov 16 2020, 16:05
deadalnix committed rABC85b7c1ab15d7: [avalanche] Add a custom TestSetup for processor_tests (authored by Andrew Chow <achow101-github@achow101.com>).
[avalanche] Add a custom TestSetup for processor_tests
Nov 16 2020, 16:05
deadalnix requested review of D8423: [avalanche] Add a custom TestSetup for processor_tests.
Nov 16 2020, 14:28

Nov 15 2020

deadalnix accepted D8422: Add checkpoints for Axion upgrade.
Nov 15 2020, 23:57
deadalnix requested review of D8421: Implement GetNewDestination for DescriptorScriptPubKeyMan.
Nov 15 2020, 11:56
deadalnix requested changes to D8420: Add email form to landing page and sub pages.

Please edit the diff to use proper description.

Nov 15 2020, 02:23
deadalnix closed D8417: Implement writing descriptorkeys, descriptorckeys, and descriptors to wallet file.
Nov 15 2020, 01:56
deadalnix committed rABC881011822362: Implement writing descriptorkeys, descriptorckeys, and descriptors to wallet… (authored by Andrew Chow <achow101-github@achow101.com>).
Implement writing descriptorkeys, descriptorckeys, and descriptors to wallet…
Nov 15 2020, 01:56
deadalnix closed D8416: Implement several simple functions in DescriptorScriptPubKeyMan.
Nov 15 2020, 01:55
deadalnix committed rABC1227eefb4e4c: Implement several simple functions in DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement several simple functions in DescriptorScriptPubKeyMan
Nov 15 2020, 01:55
deadalnix requested review of D8419: Implement TopUp in DescriptorScriptPubKeyMan.
Nov 15 2020, 01:26
deadalnix requested review of D8418: Implement SetupGeneration for DescriptorScriptPubKeyMan.
Nov 15 2020, 01:17
deadalnix requested review of D8417: Implement writing descriptorkeys, descriptorckeys, and descriptors to wallet file.
Nov 15 2020, 01:11
deadalnix requested review of D8416: Implement several simple functions in DescriptorScriptPubKeyMan.
Nov 15 2020, 01:04
deadalnix closed D8415: Add IsSingleType to Descriptors.
Nov 15 2020, 00:57
deadalnix committed rABC479c54739f92: Add IsSingleType to Descriptors (authored by Andrew Chow <achow101-github@achow101.com>).
Add IsSingleType to Descriptors
Nov 15 2020, 00:57
deadalnix closed D8414: Implement loading of keys for DescriptorScriptPubKeyMan.
Nov 15 2020, 00:56
deadalnix committed rABCa493b3bce9d6: Implement loading of keys for DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement loading of keys for DescriptorScriptPubKeyMan
Nov 15 2020, 00:56
deadalnix closed D8412: Implement GetID for DescriptorScriptPubKeyMan.
Nov 15 2020, 00:53
deadalnix committed rABCd15b9f5026f8: Implement GetID for DescriptorScriptPubKeyMan (authored by Andrew Chow <achow101-github@achow101.com>).
Implement GetID for DescriptorScriptPubKeyMan
Nov 15 2020, 00:53
First
Prev
Next