It is difficult to provide meaningful feedback since the starting code is difficult to read and reason. This seems to move in the right direction since the logic is simplified and there are more removals than additions. The ideal state is a BlockAssembler that pulls packages "off the top" so to speak from the mempool instead of the selection business that it's doing now.

Remove the bit flags in favor of a wrapper that calls the appropriate validation path depending on Wellington activation

Improve test correctness

Add test cases

Cleanup and quick unit test for TxDestinationHasher

One nit to match the port

Use unordered_set

Ordering does not matter at this time. If it did, then the code is broken already. It appears to be designed this way so that the API is more clear if multiple addresses are introduced later.

Fix missing vector -> set in the unit test

Include limited_proofid too

The proof in the CI failure was nearly 4 seconds so 5 seconds may not be enough headroom. But this does bring this timeout up to match other similarly short timeouts in avatools. If we hit these timeouts in the future we should look at a more general fix instead of bumping with each failure.

Looks like the title refers to an extra "UNREACHABLE" that is not there. Please fix before landing.

This patch looks ok as it is but the current state of the version bits business needs sorting out.

Please monitor IBD test logs for network related messages that indicate Avalanche is not initialized. I don't expect them but let's be sure about it.

feedback

Cleanup before landing

Make the comment more informative about the hacky way the invalid block was finalized

Rebase on D13064

Refactor ChainstateManager

Rebase on D13063

reference to prerequisite backport that reduced the cs_main locking: https://reviews.bitcoinabc.org/D2979#change-8J68DPC7df8b

Patch is good. I will leave final call on the naming to you.

Normally wouldn't block on a comment, but the added inbound is not obvious reading the tests by themselves.

Diff title needs rewriting now that there isn't a typo being fixed