Page MenuHomePhabricator
Feed Advanced Search

Feb 25 2024

emack updated the diff for D15483: [Cashtab] Improve alias error handling.

rebase after npm ci

Feb 25 2024, 02:46
emack updated the diff for D15483: [Cashtab] Improve alias error handling.

version bump

Feb 25 2024, 02:30

Feb 24 2024

emack published D15403: [Cashtab] Increase txHistoryCount to 20 for review.
Feb 24 2024, 07:32
emack updated the diff for D15483: [Cashtab] Improve alias error handling.

Combined similar .toHaveTextContent() tests

Feb 24 2024, 07:22
emack added a comment to D15483: [Cashtab] Improve alias error handling.

why does no price trigger aliasValidationError?

Feb 24 2024, 00:34

Feb 23 2024

emack updated the diff for D15483: [Cashtab] Improve alias error handling.

Added integration tests that validates behavior between aliasValidationError and aliasServerError states.

Feb 23 2024, 14:30
emack updated the test plan for D15483: [Cashtab] Improve alias error handling.
Feb 23 2024, 13:15

Feb 22 2024

emack added a comment to D15501: [chronik-client] Support new tokenId endpoints.
Feb 22 2024, 13:37
emack accepted D15515: [Cashtab] Bump jest timeout.

version bump

Feb 22 2024, 13:36
emack accepted D15514: [Cashtab] Pass localforage as a param in cashtab test initializer function.
Feb 22 2024, 13:33

Feb 20 2024

emack closed D15476: [Cashtab] Update incoming txs with direct calls to antd.
Feb 20 2024, 09:17
emack committed rABCf8d0931e35e3: [Cashtab] Update incoming txs with direct calls to antd (authored by emack).
[Cashtab] Update incoming txs with direct calls to antd
Feb 20 2024, 09:17
emack updated the diff for D15476: [Cashtab] Update incoming txs with direct calls to antd.

Rebase, version bump and commenting updates

Feb 20 2024, 08:39
emack accepted D15482: [Cashtab] Improve and standardize CreateToken tests.
Feb 20 2024, 08:19

Feb 19 2024

emack accepted D15480: [Cashtab] Bring QRCode tests in line with rest of react testing lib tests.
Feb 19 2024, 20:35
emack accepted D15419: [Cashtab] Standardize getter and setter functions for db and state.

Great approach, doesn't even need migration logic since it's updating the same key in localforage. I did a manual test and the existing wallet did not lose existing contacts either.

Feb 19 2024, 08:22
emack requested changes to D15482: [Cashtab] Improve and standardize CreateToken tests.
Feb 19 2024, 07:36
emack accepted D15479: [Cashtab] Apply best practices to improve BalanceHeader integration tests.

Accepted with minor nit for consistency

Feb 19 2024, 06:56
emack requested changes to D15480: [Cashtab] Bring QRCode tests in line with rest of react testing lib tests.
Feb 19 2024, 06:49
emack accepted D15478: [Cashtab] Bump jest timeout to 30s.
Feb 19 2024, 05:40
emack accepted D15474: [Cashtab] Apply standardized test wrappers to App.test.js.
Feb 19 2024, 05:39
emack added a reviewer for D15476: [Cashtab] Update incoming txs with direct calls to antd: bytesofman.
Feb 19 2024, 05:35
emack published D15476: [Cashtab] Update incoming txs with direct calls to antd for review.
Feb 19 2024, 05:33
emack updated the test plan for D15483: [Cashtab] Improve alias error handling.
Feb 19 2024, 05:24
emack updated the diff for D15483: [Cashtab] Improve alias error handling.

Replaced setAliasServerError() calls which was the trigger to not render registered and pending alias lists in dropdowns. Now using setAliasValidationError() to hold the error displayed below the input field.

Feb 19 2024, 05:22

Feb 18 2024

emack added a comment to D15483: [Cashtab] Improve alias error handling.

FYI - using arc diff --nolint for now until I can resolve the arc lint exceptions. My python was already v3.12 and it didn't seem to fix it. Have also tested with versions < 3.12.

Feb 18 2024, 22:28
emack published D15483: [Cashtab] Improve alias error handling for review.
Feb 18 2024, 22:28
emack updated the diff for D15466: [Cashtab] Update alias.js with direct antd calls.

Removed setIsValidAliasInput(false) on price error

Feb 18 2024, 10:27
emack accepted D15475: [Cashtab] Remove unused state param in Config.

nvm, started observing the timeouts with other diffs so not for resolution here. Just needs a separate timeout bump diff.

Feb 18 2024, 10:18
emack requested changes to D15475: [Cashtab] Remove unused state param in Config.

I ran npm test 5 times on this diff and 5 times on master. This diff was getting consistent jest timeouts over Configure.js whilst master was all ok.
Normally I'd chalk timeouts to local factors but this seems rather specific to this dirty param you're removing.
Is this the case for you?

image.png (126×564 px, 17 KB)

Feb 18 2024, 09:13
emack added inline comments to D15474: [Cashtab] Apply standardized test wrappers to App.test.js.
Feb 18 2024, 06:31

Feb 17 2024

emack requested review of D15466: [Cashtab] Update alias.js with direct antd calls.
Feb 17 2024, 08:25
emack closed D15468: [Cashtab] Update airdrop.js with direct antd calls.
Feb 17 2024, 07:36
emack committed rABC58a837932d0a: [Cashtab] Update airdrop.js with direct antd calls (authored by emack).
[Cashtab] Update airdrop.js with direct antd calls
Feb 17 2024, 07:36

Feb 16 2024

emack updated the diff for D15468: [Cashtab] Update airdrop.js with direct antd calls.

Rebase and version bump

Feb 16 2024, 14:07
emack published D15466: [Cashtab] Update alias.js with direct antd calls for review.
Feb 16 2024, 14:04
emack published D15468: [Cashtab] Update airdrop.js with direct antd calls for review.
Feb 16 2024, 13:25

Feb 14 2024

emack accepted D15443: [Cashtab] Remove missed debug log from ismobile.
Feb 14 2024, 08:18

Feb 13 2024

emack closed D15420: [Cashtab] Update configure.js with direct antd calls.
Feb 13 2024, 13:52
emack committed rABCd129cfb43dc0: [Cashtab] Update configure.js with direct antd calls (authored by emack).
[Cashtab] Update configure.js with direct antd calls
Feb 13 2024, 13:51
emack updated the diff for D15420: [Cashtab] Update configure.js with direct antd calls.

Updated to use queryByText for elements which are not expected to be rendered and getByText for when it is expected.

Feb 13 2024, 06:29

Feb 12 2024

emack updated the diff for D15420: [Cashtab] Update configure.js with direct antd calls.

Removed single reference var and comment

Feb 12 2024, 06:50
emack updated the diff for D15420: [Cashtab] Update configure.js with direct antd calls.

Updated comments

Feb 12 2024, 06:40
emack updated the diff for D15420: [Cashtab] Update configure.js with direct antd calls.

Updated var usage

Feb 12 2024, 06:35

Feb 11 2024

emack accepted D15410: [Cashtab] Do not auto-open the QR code scanner in the extension.
Feb 11 2024, 20:36
emack accepted D15416: [Cashtab] Move jest settings to own config file.
Feb 11 2024, 11:37
emack accepted D15415: [Cashtab] Remove react router mocks from tests.
Feb 11 2024, 11:30
emack requested changes to D15410: [Cashtab] Do not auto-open the QR code scanner in the extension.

Minor commenting nit but otherwise tested all ok across small-windowed web, extension and mobile.

Feb 11 2024, 11:21
emack requested review of D15420: [Cashtab] Update configure.js with direct antd calls.
Feb 11 2024, 08:50

Feb 7 2024

emack accepted D15405: Revert "[Cashtab] Upgrade react-router-dom to latest version".
Feb 7 2024, 11:11
emack updated the diff for D15375: [Cashtab] Improve multi send value validation.
  • Updated onMax() to return the value upon completion, which is then passed as a param to isValidMultiSendUserInput from SendXec.js
  • Removed redundant vector and related unit test on a single amount being greater than wallet balance
Feb 7 2024, 03:54
emack accepted D15379: [Cashtab] Upgrade react-router-dom to latest version.
Feb 7 2024, 01:47

Feb 6 2024

emack requested changes to D15379: [Cashtab] Upgrade react-router-dom to latest version.

Two areas that need to either be automated or manually tested:

Feb 6 2024, 23:39
emack updated the diff for D15375: [Cashtab] Improve multi send value validation.
  • Refactored isValidMultiSendUserInput unit tests to use the vectors approach
  • Updated comments
  • Replaced BN usage with Number and converting balances.totalBalance in SendXec.js to number when passing in to this function
Feb 6 2024, 03:46

Feb 3 2024

emack updated the summary of D15375: [Cashtab] Improve multi send value validation.
Feb 3 2024, 12:09
emack updated the diff for D15375: [Cashtab] Improve multi send value validation.

Added check for aggregate send value exceeding wallet balance and corresponding unit tests

Feb 3 2024, 12:08
emack closed D15363: [Cashtab] Update Token components with direct calls to antd notifications.
Feb 3 2024, 09:45
emack committed rABCc745741f56cc: [Cashtab] Update Token components with direct calls to antd notifications (authored by emack).
[Cashtab] Update Token components with direct calls to antd notifications
Feb 3 2024, 09:45
emack updated the diff for D15363: [Cashtab] Update Token components with direct calls to antd notifications.

version bump and test plan updated

Feb 3 2024, 09:31
emack updated the test plan for D15363: [Cashtab] Update Token components with direct calls to antd notifications.
Feb 3 2024, 09:30

Feb 2 2024

emack requested review of D15375: [Cashtab] Improve multi send value validation.
Feb 2 2024, 13:45
emack published D15363: [Cashtab] Update Token components with direct calls to antd notifications for review.
Feb 2 2024, 12:26
emack closed D15360: [Cashtab] Update SendXec with direct calls to antd notifications.
Feb 2 2024, 00:56
emack committed rABCb267ab21d00d: [Cashtab] Update SendXec with direct calls to antd notifications (authored by emack).
[Cashtab] Update SendXec with direct calls to antd notifications
Feb 2 2024, 00:56
emack updated the diff for D15360: [Cashtab] Update SendXec with direct calls to antd notifications.

version bump

Feb 2 2024, 00:52

Feb 1 2024

emack updated the diff for D15360: [Cashtab] Update SendXec with direct calls to antd notifications.

Updated var assignments

Feb 1 2024, 14:10
emack updated the test plan for D15360: [Cashtab] Update SendXec with direct calls to antd notifications.
Feb 1 2024, 12:26
emack requested review of D15360: [Cashtab] Update SendXec with direct calls to antd notifications.
Feb 1 2024, 12:25
emack accepted D15336: [Cashtab] Upgrade to React 18.
Feb 1 2024, 06:51
emack accepted D15353: [Cashtab] Upgrade antd.
Feb 1 2024, 00:40
emack accepted D15347: [Cashtab] Improve isValidContactList function and tests.
Feb 1 2024, 00:33
emack closed D15305: [Cashtab] Update SignVerifyMsg with direct calls to antd notifications.
Feb 1 2024, 00:24
emack committed rABCe53318a95b5d: [Cashtab] Update SignVerifyMsg with direct calls to antd notifications (authored by emack).
[Cashtab] Update SignVerifyMsg with direct calls to antd notifications
Feb 1 2024, 00:24
emack updated the diff for D15305: [Cashtab] Update SignVerifyMsg with direct calls to antd notifications.

version bump

Feb 1 2024, 00:08
emack requested changes to D15353: [Cashtab] Upgrade antd.

When testing on mobile, both iOS and android devices are showing the create token button stretching off to the right of the screen. It's not the case with master.

Feb 1 2024, 00:05

Jan 31 2024

emack accepted D15352: [Cashtab] Improve formatting of useWallet tests.
Jan 31 2024, 23:32
emack accepted D15349: [Cashtab] Upgrade qrcode.react.

reminder to npm i prior to rebase/land to sync up package-lock.json versioning
also update test plan to validate QR code being rendered and scanned successfully (tested all ok from my side)

Jan 31 2024, 23:29
emack accepted D15348: [Cashtab] Remove unused dependency.
Jan 31 2024, 23:22
emack requested changes to D15347: [Cashtab] Improve isValidContactList function and tests.

Wallets with aliases in contact list currently throw the list out and do not set to context.

Jan 31 2024, 23:19
emack updated the diff for D15305: [Cashtab] Update SignVerifyMsg with direct calls to antd notifications.

Rebase and version bump

Jan 31 2024, 23:09
emack updated the diff for D15305: [Cashtab] Update SignVerifyMsg with direct calls to antd notifications.

Rebased to D15338 and D15323 which deprecated the react-device-detect library, deprecated the getDeviceNotificationStyle function, as well as removed the <Paragraph> tags and passing in of style props into the antd notification calls.

Jan 31 2024, 12:37
emack updated the test plan for D15305: [Cashtab] Update SignVerifyMsg with direct calls to antd notifications.
Jan 31 2024, 12:29
emack accepted D15340: [Cashtab] Wrap useWallet hook test in act.
Jan 31 2024, 11:51
emack closed D15338: [Cashtab] Deprecate react-device-detect.
Jan 31 2024, 11:37
emack committed rABC0835f3ca5f46: [Cashtab] Deprecate react-device-detect (authored by emack).
[Cashtab] Deprecate react-device-detect
Jan 31 2024, 11:37
emack updated the diff for D15338: [Cashtab] Deprecate react-device-detect.

version bump

Jan 31 2024, 11:28
emack updated the diff for D15338: [Cashtab] Deprecate react-device-detect.

version bump

Jan 31 2024, 11:22
emack accepted D15334: [Cashtab] Add tests for routing.
Jan 31 2024, 11:19
emack accepted D15337: [Cashtab] Do not clearTimeout when alias component unmounts.
Jan 31 2024, 06:56
emack requested changes to D15334: [Cashtab] Add tests for routing.
Jan 31 2024, 06:33
emack accepted D15333: [Cashtab] Move app tests to appropriate dir level.
Jan 31 2024, 06:21
emack updated the diff for D15338: [Cashtab] Deprecate react-device-detect.

Refreshed package-lock.json to sync version bump

Jan 31 2024, 03:05
emack requested review of D15338: [Cashtab] Deprecate react-device-detect.
Jan 31 2024, 03:02
emack closed D15323: [Cashtab] Deprecate getDeviceNotificationStyle.
Jan 31 2024, 01:53
emack committed rABCec4f96193676: [Cashtab] Deprecate getDeviceNotificationStyle (authored by emack).
[Cashtab] Deprecate getDeviceNotificationStyle
Jan 31 2024, 01:53
emack updated the diff for D15323: [Cashtab] Deprecate getDeviceNotificationStyle.

rebase and version bump

Jan 31 2024, 01:44

Jan 30 2024

emack requested review of D15323: [Cashtab] Deprecate getDeviceNotificationStyle.
Jan 30 2024, 13:58

Jan 29 2024

emack accepted D15304: [Cashtab] Receive screen improvements.

Yup, it was indeed related to the logo, scans all ok now.

Jan 29 2024, 01:29
emack updated the diff for D15305: [Cashtab] Update SignVerifyMsg with direct calls to antd notifications.

Added an additional test showing notification is NOT rendered before signing/verification

Jan 29 2024, 01:21

Jan 28 2024

emack published D15305: [Cashtab] Update SignVerifyMsg with direct calls to antd notifications for review.
Jan 28 2024, 13:19