Page MenuHomePhabricator
Feed All Stories

Apr 16 2024

emack accepted D15985: [Cashtab] Do not render reply option to eCash chat.
Apr 16 2024, 00:31
emack accepted D15984: [Cashtab] Use dust for dust throughout app.
Apr 16 2024, 00:19
emack added a comment to D15981: [Cashtab] Patch minify menu flicker.

The effects of D15972 seems to have regressed here, allowing scrolling down when there is no content below.

could you show an example?

but also, imo the flickering is much worse than the extra scrolling. The extra scrolling situation still needs another patch anyway to deal with the size of other non-footer elements.

Apr 16 2024, 00:09
bytesofman closed D15982: [Cashtab] Improve focus-visible for wallet dropdown menu.
Apr 16 2024, 00:05
bytesofman committed rABCd277ac2d1ed2: [Cashtab] Improve focus-visible for wallet dropdown menu (authored by bytesofman).
[Cashtab] Improve focus-visible for wallet dropdown menu
Apr 16 2024, 00:05
emack accepted D15983: [Cashtab] Update airdrop icon.

Minor nit not for this diff, but should add "XEC" to the Airdrop label, otherwise it looks like it was an eToken airdrop.

Apr 16 2024, 00:05
bytesofman added a comment to D15981: [Cashtab] Patch minify menu flicker.

The effects of D15972 seems to have regressed here, allowing scrolling down when there is no content below.

Apr 16 2024, 00:04
emack accepted D15982: [Cashtab] Improve focus-visible for wallet dropdown menu.
Apr 16 2024, 00:00

Apr 15 2024

emack accepted D15980: [Cashtab] Add function to generate target outputs for an slpv1 nft parent mint tx.

On a related note, are we sticking with the whole parent vs child terminology all the way through to the frontend? I recall back in 2021 there was discussion on using more user friendly terminology in the frontend, like using "Collection" for parent and "NFT" for child. This way it'll be a smoother experience for users who are used to NFT terminology from other chains.

Apr 15 2024, 23:55
emack requested changes to D15981: [Cashtab] Patch minify menu flicker.

The effects of D15972 seems to have regressed here, allowing scrolling down when there is no content below.

Apr 15 2024, 23:50
emack accepted D15967: [Cashtab] Handle multiple token types on token action screen.
Apr 15 2024, 23:37
bytesofman updated the diff for D15986: [Cashtab] Stop redirecting to /wallet route from cashtab home.

fix branch name

Apr 15 2024, 22:06
bytesofman published D15986: [Cashtab] Stop redirecting to /wallet route from cashtab home for review.
Apr 15 2024, 21:54
bytesofman published D15985: [Cashtab] Do not render reply option to eCash chat for review.
Apr 15 2024, 21:37
bytesofman published D15984: [Cashtab] Use dust for dust throughout app for review.
Apr 15 2024, 21:06
bytesofman updated the test plan for D15983: [Cashtab] Update airdrop icon.
Apr 15 2024, 21:05
bytesofman published D15983: [Cashtab] Update airdrop icon for review.
Apr 15 2024, 20:50
bytesofman published D15982: [Cashtab] Improve focus-visible for wallet dropdown menu for review.
Apr 15 2024, 20:44
PiRK closed D15979: test: Combine sync_send_with_ping and sync_with_ping.
Apr 15 2024, 20:31
PiRK committed rABC2af41ff856ff: test: Combine sync_send_with_ping and sync_with_ping (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
test: Combine sync_send_with_ping and sync_with_ping
Apr 15 2024, 20:31
bytesofman updated the diff for D15767: [chronik.e.cash] Docs site for chronik.

rebase for ci re-run

Apr 15 2024, 20:30
bytesofman added a comment to D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions.

I mean there are already a few tests like this, for example the it('TxBuilder P2PKH'), but if you want I can add some more.

Apr 15 2024, 20:28
teamcity added a comment to D15767: [chronik.e.cash] Docs site for chronik.
Apr 15 2024, 20:12
tobias_ruck added inline comments to D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions.
Apr 15 2024, 20:11
bytesofman published D15980: [Cashtab] Add function to generate target outputs for an slpv1 nft parent mint tx for review.
Apr 15 2024, 20:03
bytesofman added a comment to D15767: [chronik.e.cash] Docs site for chronik.

re: nojekyll, this is part of the docusaurus boilerplate:

Apr 15 2024, 20:02
bytesofman updated the diff for D15767: [chronik.e.cash] Docs site for chronik.

document .abclatest version in README, remove .abclatestversion from git repo with gitignore, include sample file

Apr 15 2024, 20:02
bytesofman published D15981: [Cashtab] Patch minify menu flicker for review.
Apr 15 2024, 19:44
Fabien closed D15978: [explorer] Massage column priority in the address history.
Apr 15 2024, 19:36
Fabien committed rABC047b48968199: [explorer] Massage column priority in the address history (authored by Fabien).
[explorer] Massage column priority in the address history
Apr 15 2024, 19:36
Fabien closed D15977: [explorer] Show finalization status in the transaction page.
Apr 15 2024, 19:35
Fabien committed rABC7f4ebeccd2f3: [explorer] Show finalization status in the transaction page (authored by Fabien).
[explorer] Show finalization status in the transaction page
Apr 15 2024, 19:35
Fabien closed D15976: [explorer] Show the finalization status in the block page.
Apr 15 2024, 19:35
Fabien committed rABC13deb63962b7: [explorer] Show the finalization status in the block page (authored by Fabien).
[explorer] Show the finalization status in the block page
Apr 15 2024, 19:35
Fabien closed D15975: [explorer] Show invalid token txs as such.
Apr 15 2024, 19:34
Fabien committed rABCf845d6cbdbcd: [explorer] Show invalid token txs as such (authored by Fabien).
[explorer] Show invalid token txs as such
Apr 15 2024, 19:34
Fabien requested changes to D15767: [chronik.e.cash] Docs site for chronik.

Minor things, it's getting there

Apr 15 2024, 19:23
Fabien accepted D15979: test: Combine sync_send_with_ping and sync_with_ping.
Apr 15 2024, 19:09
PiRK accepted D15976: [explorer] Show the finalization status in the block page.
Apr 15 2024, 19:06
tobias_ruck added a comment to D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions.
  • Would be useful to include some tests for "normal" txs, even if they are not bounced off the node (could just test against expected raw hex, though now that the node is here, I suppose might as well use it...but can see it being complicated to give an address a normal balance in that kind of test script). For example,
  • generate a private key, generate a p2pkh address from this key, fund it, send a tx to a p2pkh adddress with change
  • send a tx to a p2pkh address without change (exact amount)

I mean there are already a few tests like this, for example the it('TxBuilder P2PKH'), but if you want I can add some more.

Apr 15 2024, 19:01
bytesofman requested changes to D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions.
Apr 15 2024, 16:52
bytesofman added a comment to D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions.
  • Would be useful to include some tests for "normal" txs, even if they are not bounced off the node (could just test against expected raw hex, though now that the node is here, I suppose might as well use it...but can see it being complicated to give an address a normal balance in that kind of test script). For example,
Apr 15 2024, 16:52
teamcity added a comment to D15967: [Cashtab] Handle multiple token types on token action screen.
Apr 15 2024, 16:25
teamcity added a comment to D15967: [Cashtab] Handle multiple token types on token action screen.
Apr 15 2024, 16:25
bytesofman added inline comments to D15967: [Cashtab] Handle multiple token types on token action screen.
Apr 15 2024, 16:23
bytesofman updated the diff for D15967: [Cashtab] Handle multiple token types on token action screen.

revert package-lock changes

Apr 15 2024, 16:23
bytesofman updated the diff for D15967: [Cashtab] Handle multiple token types on token action screen.

revert test dep

Apr 15 2024, 16:22
bytesofman updated the diff for D15967: [Cashtab] Handle multiple token types on token action screen.

add mocks and test for nft1 parent

Apr 15 2024, 16:21
tobias_ruck published D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions for review.
Apr 15 2024, 16:14
teamcity awarded D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions a Like token.
Apr 15 2024, 15:52
teamcity updated the summary of D15979: test: Combine sync_send_with_ping and sync_with_ping.
Apr 15 2024, 15:40
PiRK requested review of D15979: test: Combine sync_send_with_ping and sync_with_ping.
Apr 15 2024, 15:40
PiRK accepted D15978: [explorer] Massage column priority in the address history.
Apr 15 2024, 15:21
PiRK accepted D15977: [explorer] Show finalization status in the transaction page.
Apr 15 2024, 15:19
PiRK accepted D15975: [explorer] Show invalid token txs as such.
Apr 15 2024, 15:13
Fabien requested review of D15978: [explorer] Massage column priority in the address history.
Apr 15 2024, 14:26
Fabien requested review of D15977: [explorer] Show finalization status in the transaction page.
Apr 15 2024, 14:25
emack requested changes to D15967: [Cashtab] Handle multiple token types on token action screen.

Can you send some ALP and NFT parent tokens to ecash:qzz0p9yux89uvgnq86u5qnztver6u7g0vqc65920xr pls? thx.

Apr 15 2024, 14:25
Fabien requested review of D15976: [explorer] Show the finalization status in the block page.
Apr 15 2024, 14:25
Fabien requested review of D15975: [explorer] Show invalid token txs as such.
Apr 15 2024, 14:24
teamcity triaged T3544: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download w/o Checkpoints is broken. as Unbreak Now! priority.
Apr 15 2024, 14:06
bytesofman published D15967: [Cashtab] Handle multiple token types on token action screen for review.
Apr 15 2024, 13:55
bytesofman added inline comments to D15767: [chronik.e.cash] Docs site for chronik.
Apr 15 2024, 12:14
bytesofman updated the diff for D15767: [chronik.e.cash] Docs site for chronik.

stop using cmakelist to get version

Apr 15 2024, 12:12
emack accepted D15973: [Cashtab] Debounce scroll event handler.
Apr 15 2024, 05:47

Apr 14 2024

abc-bot committed rABC58d05eff5a84: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Apr 14 2024, 21:20
abc-bot committed rABC08e75d06d9fb: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Apr 14 2024, 21:09
abc-bot committed rABC87df01bdf47c: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Apr 14 2024, 20:36
bytesofman published D15973: [Cashtab] Debounce scroll event handler for review.
Apr 14 2024, 14:14
bytesofman closed D15972: [Cashtab] No scrolling of no content below fold.
Apr 14 2024, 14:05
bytesofman committed rABC2cec9cac5d82: [Cashtab] No scrolling of no content below fold (authored by bytesofman).
[Cashtab] No scrolling of no content below fold
Apr 14 2024, 14:05
emack accepted D15972: [Cashtab] No scrolling of no content below fold.

It still scrolls, albeit by a negligible 1px or so, across both mobile and web. Not a blocking issue.

Apr 14 2024, 13:58
bytesofman updated the test plan for D15972: [Cashtab] No scrolling of no content below fold.
Apr 14 2024, 13:34
bytesofman published D15972: [Cashtab] No scrolling of no content below fold for review.
Apr 14 2024, 13:33
bytesofman closed D15968: [Cashtab] Add function to get target outputs for NFT1 parent genesis tx.
Apr 14 2024, 12:58
bytesofman committed rABC50ddf7ca9a98: [Cashtab] Add function to get target outputs for NFT1 parent genesis tx (authored by bytesofman).
[Cashtab] Add function to get target outputs for NFT1 parent genesis tx
Apr 14 2024, 12:58
PiRK accepted D15954: [ecash-lib] Add `SigHashType`.

Note that the BIP143 naming is not used in the c++ code, the FORKID name is used instead. That got me confused for a while.

Apr 14 2024, 07:20

Apr 13 2024

teamcity awarded D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions a Mountain of Wealth token.
Apr 13 2024, 17:29
teamcity awarded D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions a Doubloon token.
Apr 13 2024, 16:26
teamcity awarded D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions a Piece of Eight token.
Apr 13 2024, 16:15
teamcity awarded D15963: [ecash-lib] Add `TxBuilder` to build Bitcoin transactions a Haypence token.
Apr 13 2024, 16:02
emack accepted D15968: [Cashtab] Add function to get target outputs for NFT1 parent genesis tx.
Apr 13 2024, 14:12
bytesofman requested review of D15968: [Cashtab] Add function to get target outputs for NFT1 parent genesis tx.
Apr 13 2024, 13:48
bytesofman closed D15971: [Cashtab] Fix svg icons.
Apr 13 2024, 13:37
bytesofman committed rABCcb8c60771483: [Cashtab] Fix svg icons (authored by bytesofman).
[Cashtab] Fix svg icons
Apr 13 2024, 13:37
bytesofman closed D15970: [Cashtab] After importing a wallet, automatically close the import wallet modal.
Apr 13 2024, 13:35
bytesofman committed rABC22c8b896b373: [Cashtab] After importing a wallet, automatically close the import wallet modal (authored by bytesofman).
[Cashtab] After importing a wallet, automatically close the import wallet modal
Apr 13 2024, 13:35
emack accepted D15971: [Cashtab] Fix svg icons.
Apr 13 2024, 10:16
emack accepted D15970: [Cashtab] After importing a wallet, automatically close the import wallet modal.
Apr 13 2024, 10:12
Fabien closed D15965: [explorer] Show block finalization on blocks page.
Apr 13 2024, 10:12
Fabien committed rABC4ded4d52b68f: [explorer] Show block finalization on blocks page (authored by Fabien).
[explorer] Show block finalization on blocks page
Apr 13 2024, 10:12
emack requested changes to D15968: [Cashtab] Add function to get target outputs for NFT1 parent genesis tx.
Apr 13 2024, 10:03
tobias_ruck updated the diff for D15956: [ecash-lib] Add `UnsignedTx` and `UnsignedTxInput`.

fix sighash hashSequences for SINGLE and NONE without ANYONECANPAY

Apr 13 2024, 08:34
PiRK accepted D15965: [explorer] Show block finalization on blocks page.
Apr 13 2024, 07:44
teamcity closed T3536: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Apr 13 2024, 04:21
bytesofman closed D15969: [Cashtab] Get token info from cache in airdrop calc screen.
Apr 13 2024, 04:05
bytesofman committed rABC0fa38e98935e: [Cashtab] Get token info from cache in airdrop calc screen (authored by bytesofman).
[Cashtab] Get token info from cache in airdrop calc screen
Apr 13 2024, 04:05
teamcity closed T3533: Build Bitcoin-ABC / Master / Coverage is broken. as Resolved.
Apr 13 2024, 03:54
teamcity triaged T3536: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Apr 13 2024, 03:21
bytesofman published D15971: [Cashtab] Fix svg icons for review.
Apr 13 2024, 02:56