Page MenuHomePhabricator
Feed Advanced Search

Jun 5 2024

PiRK accepted D16284: univalue: Remove unused and confusing set*() return value.
Jun 5 2024, 14:06
PiRK accepted D16283: univalue: Return more detailed type check error messages.
Jun 5 2024, 12:16
PiRK accepted D16282: refactor: univalue test cleanups.
Jun 5 2024, 11:53
PiRK accepted D16281: univalue: Avoid brittle, narrowing and verbose integral type confusions.
Jun 5 2024, 11:46
PiRK accepted D16280: univalue: Throw exception on invalid pushes over silent ignore.
Jun 5 2024, 11:42
PiRK updated the diff for D16278: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py.

fix typo

Jun 5 2024, 11:34
PiRK added inline comments to D16278: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py.
Jun 5 2024, 11:32
PiRK closed D16269: [avalanche] pass the processor to Chainstate::PreciousBlock.
Jun 5 2024, 08:35
PiRK committed rABCbce200942978: [avalanche] pass the processor to Chainstate::PreciousBlock (authored by PiRK).
[avalanche] pass the processor to Chainstate::PreciousBlock
Jun 5 2024, 08:35
PiRK closed D16268: [avalanche] pass the processor to Chainstate::ProcessNewBlock.
Jun 5 2024, 08:35
PiRK closed D16267: [avalanche] pass the avalanche processor to Chainstate::LoadExternalBlockFile and ThreadImport.
Jun 5 2024, 08:35
PiRK committed rABCd8dfe18db234: [avalanche] pass the processor to Chainstate::ProcessNewBlock (authored by PiRK).
[avalanche] pass the processor to Chainstate::ProcessNewBlock
Jun 5 2024, 08:35
PiRK committed rABCf7b37e5b553d: [avalanche] pass the avalanche processor to Chainstate::LoadExternalBlockFile… (authored by PiRK).
[avalanche] pass the avalanche processor to Chainstate::LoadExternalBlockFile…
Jun 5 2024, 08:35
PiRK closed D16266: [avalanche] pass the processor to Chainstate::ActivateBestChain[Step].
Jun 5 2024, 08:35
PiRK committed rABCf3bc78e54ff0: [avalanche] pass the processor to Chainstate::ActivateBestChain[Step] (authored by PiRK).
[avalanche] pass the processor to Chainstate::ActivateBestChain[Step]
Jun 5 2024, 08:35
PiRK accepted D16276: rpc: Reduce Univalue push_backV peak memory usage in listtransactions.
Jun 5 2024, 08:34
PiRK updated the summary of D16278: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py.
Jun 5 2024, 08:27
PiRK updated the summary of D16279: [electrum] move-only: split bip32 from bitcoin.py.
Jun 5 2024, 08:23
PiRK requested review of D16279: [electrum] move-only: split bip32 from bitcoin.py.
Jun 5 2024, 08:22
PiRK requested review of D16278: [electrum] move-only: extract more crypto code from bitcoin.py into ecc.py.
Jun 5 2024, 08:19
PiRK requested review of D16277: [electrum] move-only: split part of bitcoin.py into crypto.py.
Jun 5 2024, 08:16
PiRK added inline comments to D16267: [avalanche] pass the avalanche processor to Chainstate::LoadExternalBlockFile and ThreadImport.
Jun 5 2024, 07:13

Jun 4 2024

PiRK accepted D16275: Unsubtree Univalue.
Jun 4 2024, 18:54
PiRK accepted D16272: Update the univalue subtree.
Jun 4 2024, 18:50
PiRK accepted D16274: Bump univalue subtree.
Jun 4 2024, 18:40
PiRK accepted D16273: scripted-diff: Use getInt<T> over get_int/get_int64.
Jun 4 2024, 18:33
PiRK abandoned D16263: [avalanche] don't use global g_avalanche in Chainstate code.

this was split into multiple diffs: D16265-D16270

Jun 4 2024, 15:21
PiRK closed D16265: [avalanche] pass the processor to Chainstate::ConnectTip.
Jun 4 2024, 15:20
PiRK committed rABCd1aed6b0b789: [avalanche] pass the processor to Chainstate::ConnectTip (authored by PiRK).
[avalanche] pass the processor to Chainstate::ConnectTip
Jun 4 2024, 15:20
PiRK updated the diff for D16267: [avalanche] pass the avalanche processor to Chainstate::LoadExternalBlockFile and ThreadImport.

pass a pointer to the processor in ThreadImport

Jun 4 2024, 15:05
PiRK planned changes to D16267: [avalanche] pass the avalanche processor to Chainstate::LoadExternalBlockFile and ThreadImport.
Jun 4 2024, 14:59
PiRK added a comment to D16267: [avalanche] pass the avalanche processor to Chainstate::LoadExternalBlockFile and ThreadImport.

we can pass a pointer to ThreadImport in anticipation of not initializing the avalanche processor when avalanche is not needed (see review D16224)

Jun 4 2024, 14:59
PiRK updated the diff for D16269: [avalanche] pass the processor to Chainstate::PreciousBlock.

make it possible to run the RPC when the processor is not initialized

Jun 4 2024, 14:55
PiRK updated the diff for D16268: [avalanche] pass the processor to Chainstate::ProcessNewBlock.

don't use EnsureAvalanche in the RPC calls, make it possible to use the RPCs with the processor not initialized

Jun 4 2024, 14:40
PiRK updated the diff for D16266: [avalanche] pass the processor to Chainstate::ActivateBestChain[Step].

don't use EnsureAvalanche in the RPC code, just assume that the processor can be uninitialized.

Jun 4 2024, 14:29
PiRK added inline comments to D16224: remove g_avalanche global.
Jun 4 2024, 14:18
PiRK added inline comments to D16270: [avalanche] pass the processor to Chainstate::AvalancheFinalizeBlock.
Jun 4 2024, 14:15
PiRK requested review of D16267: [avalanche] pass the avalanche processor to Chainstate::LoadExternalBlockFile and ThreadImport.
Jun 4 2024, 14:12
PiRK added inline comments to D16266: [avalanche] pass the processor to Chainstate::ActivateBestChain[Step].
Jun 4 2024, 14:09
teamcity awarded D16224: remove g_avalanche global a Piece of Eight token.
Jun 4 2024, 10:19
PiRK added a comment to D16224: remove g_avalanche global.

@bot build-asan

Jun 4 2024, 10:19
PiRK updated the diff for D16224: remove g_avalanche global.

rebase and fix summary

Jun 4 2024, 10:19
PiRK requested review of D16270: [avalanche] pass the processor to Chainstate::AvalancheFinalizeBlock.
Jun 4 2024, 10:15
PiRK requested review of D16269: [avalanche] pass the processor to Chainstate::PreciousBlock.
Jun 4 2024, 10:14
PiRK requested review of D16268: [avalanche] pass the processor to Chainstate::ProcessNewBlock.
Jun 4 2024, 10:13
PiRK requested review of D16267: [avalanche] pass the avalanche processor to Chainstate::LoadExternalBlockFile and ThreadImport.
Jun 4 2024, 10:11
PiRK requested review of D16266: [avalanche] pass the processor to Chainstate::ActivateBestChain[Step].
Jun 4 2024, 10:11
PiRK requested review of D16265: [avalanche] pass the processor to Chainstate::ConnectTip.
Jun 4 2024, 10:08
PiRK planned changes to D16263: [avalanche] don't use global g_avalanche in Chainstate code.

This can be split into smaller diffs

Jun 4 2024, 08:20
PiRK updated the diff for D16263: [avalanche] don't use global g_avalanche in Chainstate code.

pass avalanche down to all the ActivateBestChain callsites in non-test code

Jun 4 2024, 07:53
PiRK planned changes to D16224: remove g_avalanche global.
Jun 4 2024, 06:14

Jun 3 2024

PiRK planned changes to D16263: [avalanche] don't use global g_avalanche in Chainstate code.
Jun 3 2024, 16:29
PiRK updated the diff for D16263: [avalanche] don't use global g_avalanche in Chainstate code.

call ActiveBestChain in net_processing, improve FindMostWorkChain
still a WIP

Jun 3 2024, 16:29
teamcity awarded D16263: [avalanche] don't use global g_avalanche in Chainstate code a Haypence token.
Jun 3 2024, 15:11
PiRK added a comment to D16263: [avalanche] don't use global g_avalanche in Chainstate code.

@bot build-tsan

Jun 3 2024, 15:11
PiRK planned changes to D16263: [avalanche] don't use global g_avalanche in Chainstate code.

This is not ready. I'm getting test failures.

Jun 3 2024, 15:03
PiRK updated the diff for D16263: [avalanche] don't use global g_avalanche in Chainstate code.

try passing the processor to chainstate functions that need it

Jun 3 2024, 15:02
teamcity awarded D16224: remove g_avalanche global a Haypence token.
Jun 3 2024, 13:38
PiRK closed D16260: [avalanche] pass a reference to the avalanche processor to StakingRewardsPolicy.
Jun 3 2024, 13:32
PiRK committed rABCd60453241bf6: [avalanche] pass a reference to the avalanche processor to StakingRewardsPolicy (authored by PiRK).
[avalanche] pass a reference to the avalanche processor to StakingRewardsPolicy
Jun 3 2024, 13:32
PiRK closed D16259: validation: deduplicate forward declaration of Consensus::Params.
Jun 3 2024, 13:31
PiRK committed rABC8e839c67d4b9: validation: deduplicate forward declaration of Consensus::Params (authored by PiRK).
validation: deduplicate forward declaration of Consensus::Params
Jun 3 2024, 13:31
PiRK added inline comments to D16224: remove g_avalanche global.
Jun 3 2024, 07:04
PiRK updated the diff for D16224: remove g_avalanche global.

rebase after splitting the diff into smaller diffs. This is now just the g_avalanche -> node.avalanche part of the original diff

Jun 3 2024, 07:00
PiRK requested review of D16263: [avalanche] don't use global g_avalanche in Chainstate code.
Jun 3 2024, 06:38

May 31 2024

PiRK requested review of D16260: [avalanche] pass a reference to the avalanche processor to StakingRewardsPolicy.
May 31 2024, 16:10
PiRK added inline comments to D16259: validation: deduplicate forward declaration of Consensus::Params.
May 31 2024, 15:48
PiRK updated the summary of D16259: validation: deduplicate forward declaration of Consensus::Params.
May 31 2024, 15:47
PiRK requested review of D16259: validation: deduplicate forward declaration of Consensus::Params.
May 31 2024, 15:45
PiRK accepted D16258: [Cashtab] Update Dockerfile to support ecash-lib as dependency.
May 31 2024, 12:03
PiRK closed D16256: [avalanche] don't use global g_avalanche in net_processing.
May 31 2024, 06:15
PiRK closed D16257: [avalanche] remove unnecessary nullptr checks for g_avalanche.
May 31 2024, 06:15
PiRK committed rABCc8fabc010fdc: [avalanche] don't use global g_avalanche in net_processing (authored by PiRK).
[avalanche] don't use global g_avalanche in net_processing
May 31 2024, 06:15
PiRK committed rABC5f63acb96dca: [avalanche] remove unnecessary nullptr checks for g_avalanche (authored by PiRK).
[avalanche] remove unnecessary nullptr checks for g_avalanche
May 31 2024, 06:15
PiRK closed D16255: [avalanche] add additional safety checks before dereferencing g_avalanche in net_processing.
May 31 2024, 06:15
PiRK committed rABC13ae56ec5ede: [avalanche] add additional safety checks before dereferencing g_avalanche in… (authored by PiRK).
[avalanche] add additional safety checks before dereferencing g_avalanche in…
May 31 2024, 06:15

May 30 2024

PiRK accepted D16254: refactor: Run type check against RPCArgs (1/2).
May 30 2024, 16:16
PiRK added inline comments to D16256: [avalanche] don't use global g_avalanche in net_processing.
May 30 2024, 15:28
PiRK added a comment to D16256: [avalanche] don't use global g_avalanche in net_processing.

I confirm that I cannot make the processor const here. It fails to compile.

May 30 2024, 15:27
PiRK updated the diff for D16256: [avalanche] don't use global g_avalanche in net_processing.

review

May 30 2024, 15:26
PiRK updated the diff for D16255: [avalanche] add additional safety checks before dereferencing g_avalanche in net_processing.

use return; instead of assert in code that responds to remote messages
Remove a couple of asserts in functions that are now only called by code that verifies that the function exists.

May 30 2024, 15:17
PiRK closed D16250: [avalanche] don't use global g_avalanche in BlockAssember.
May 30 2024, 13:42
PiRK closed D16249: [avalanche] introduce EnsureAvalanche helper for RPC calls.
May 30 2024, 13:42
PiRK committed rABC7b05328dd000: [avalanche] don't use global g_avalanche in BlockAssember (authored by PiRK).
[avalanche] don't use global g_avalanche in BlockAssember
May 30 2024, 13:42
PiRK committed rABCf60e3bb66851: [avalanche] introduce EnsureAvalanche helper for RPC calls (authored by PiRK).
[avalanche] introduce EnsureAvalanche helper for RPC calls
May 30 2024, 13:42
PiRK closed D16223: [avalanche] initialize avalanche before node.peerman.
May 30 2024, 13:42
PiRK committed rABC8c9c1fdcba2e: [avalanche] initialize avalanche before node.peerman (authored by PiRK).
[avalanche] initialize avalanche before node.peerman
May 30 2024, 13:42
PiRK added inline comments to D16256: [avalanche] don't use global g_avalanche in net_processing.
May 30 2024, 13:37
PiRK requested review of D16257: [avalanche] remove unnecessary nullptr checks for g_avalanche.
May 30 2024, 13:08
PiRK planned changes to D16224: remove g_avalanche global.
May 30 2024, 12:50
PiRK updated the diff for D16224: remove g_avalanche global.

rebase after splitting out a lot of the changes. Still a WIP, we can probably extract more smaller diffs from this.

May 30 2024, 12:47
PiRK updated the diff for D16256: [avalanche] don't use global g_avalanche in net_processing.

remove the now redundant assertion

May 30 2024, 12:41
PiRK accepted D16253: RPC: make RPCResult::MatchesType return useful errors.
May 30 2024, 12:38
PiRK requested review of D16256: [avalanche] don't use global g_avalanche in net_processing.
May 30 2024, 12:37
PiRK added inline comments to D16255: [avalanche] add additional safety checks before dereferencing g_avalanche in net_processing.
May 30 2024, 12:25
PiRK updated the summary of D16255: [avalanche] add additional safety checks before dereferencing g_avalanche in net_processing.
May 30 2024, 12:24
PiRK requested review of D16255: [avalanche] add additional safety checks before dereferencing g_avalanche in net_processing.
May 30 2024, 12:23
PiRK requested changes to D16253: RPC: make RPCResult::MatchesType return useful errors.
May 30 2024, 11:26
PiRK accepted D16252: rpc: Fail to return undocumented or misdocumented JSON.
May 30 2024, 11:06
PiRK accepted D16251: test: Fix feature_config_args.py intermittent issue.
May 30 2024, 10:58