Page MenuHomePhabricator
Feed Advanced Search

Jul 17 2024

PiRK accepted D16485: test: Run feature_bip68_sequence.py with MiniWallet.
Jul 17 2024, 12:29
PiRK requested changes to D16485: test: Run feature_bip68_sequence.py with MiniWallet.
Jul 17 2024, 09:42
PiRK closed D16481: [electrum] bump dependencies.
Jul 17 2024, 04:11
PiRK committed rABCc1a152598f7b: [electrum] bump dependencies (authored by PiRK).
[electrum] bump dependencies
Jul 17 2024, 04:11

Jul 16 2024

PiRK updated the diff for D16481: [electrum] bump dependencies.

rebase on D16482 to unbreak CI

Jul 16 2024, 15:47
PiRK accepted D16482: [CI] Update the sha256 sum for the nodejs setup script.
Jul 16 2024, 15:44
PiRK accepted D16480: Fix style nits in p2p_compactblocks, make it easier to debug.
Jul 16 2024, 14:40
PiRK updated the diff for D16481: [electrum] bump dependencies.

revert bumping of pip for now. The corresponding alert (CVE-2023-5752) does not affect us, we don't install anything from a Mercurial VCS URL

Jul 16 2024, 14:11
PiRK planned changes to D16481: [electrum] bump dependencies.
Jul 16 2024, 14:00
PiRK added a comment to D16481: [electrum] bump dependencies.

There are still issues related to btchip-python==0.1.32 metadata with the wine build

Jul 16 2024, 13:58
PiRK requested review of D16481: [electrum] bump dependencies.
Jul 16 2024, 13:53
PiRK accepted D16474: Properly cache policy rejected transactions for compact block reconstruction.
Jul 16 2024, 12:28
PiRK accepted D16472: Add HashWriter without ser-type and ser-version and use it where possible.
Jul 16 2024, 12:18
PiRK closed D16473: Seeder: make sure nStartingHeight is initialized.
Jul 16 2024, 09:27
PiRK committed rABCca55ad7ecea2: Seeder: make sure nStartingHeight is initialized (authored by PiRK).
Seeder: make sure nStartingHeight is initialized
Jul 16 2024, 09:27
PiRK added inline comments to D16473: Seeder: make sure nStartingHeight is initialized.
Jul 16 2024, 08:04
PiRK updated the summary of D16473: Seeder: make sure nStartingHeight is initialized.
Jul 16 2024, 08:02
PiRK requested review of D16473: Seeder: make sure nStartingHeight is initialized.
Jul 16 2024, 08:01
PiRK closed D16467: Seeder: handle empty HEADERS messages more gracefully.
Jul 16 2024, 06:02
PiRK committed rABC1fac2f8fc7f7: Seeder: handle empty HEADERS messages more gracefully (authored by PiRK).
Seeder: handle empty HEADERS messages more gracefully
Jul 16 2024, 06:02

Jul 15 2024

PiRK updated the diff for D16467: Seeder: handle empty HEADERS messages more gracefully.

remove debugging print

Jul 15 2024, 16:22
PiRK requested review of D16467: Seeder: handle empty HEADERS messages more gracefully.
Jul 15 2024, 16:20
PiRK closed D16465: Seeder: Verify that nodes are on the correct chain.
Jul 15 2024, 15:18
PiRK committed rABC74baf6484f44: Seeder: Verify that nodes are on the correct chain (authored by PiRK).
Seeder: Verify that nodes are on the correct chain
Jul 15 2024, 15:18
PiRK added inline comments to D16465: Seeder: Verify that nodes are on the correct chain.
Jul 15 2024, 15:11
PiRK updated the diff for D16465: Seeder: Verify that nodes are on the correct chain.

no need to disable the range_check, the error is caught in main.cpp::ThreadCrawler

Jul 15 2024, 13:17
PiRK added inline comments to D16465: Seeder: Verify that nodes are on the correct chain.
Jul 15 2024, 13:15
PiRK planned changes to D16465: Seeder: Verify that nodes are on the correct chain.
Jul 15 2024, 13:10
PiRK updated the diff for D16465: Seeder: Verify that nodes are on the correct chain.

add tests

Jul 15 2024, 13:09
PiRK planned changes to D16465: Seeder: Verify that nodes are on the correct chain.

This one should be relatively easy to test (but hopefully without having to add a dependency to the main unit test framework like the source material does)

Jul 15 2024, 10:02
PiRK updated the diff for D16465: Seeder: Verify that nodes are on the correct chain.

doc layout

Jul 15 2024, 10:01
PiRK updated the diff for D16465: Seeder: Verify that nodes are on the correct chain.

improve comment, set range_check=false when calling ReadCompactSize to prevent the function from throwing if the net message is intentionnaly bad, don't duplicate MAX_HEADERS_RESULTS but include it via net_processing.h.

Jul 15 2024, 09:59
PiRK added inline comments to D16466: Seeder: Fix getaddr interval to actually query address lists once a day.
Jul 15 2024, 09:21
PiRK requested review of D16466: Seeder: Fix getaddr interval to actually query address lists once a day.
Jul 15 2024, 07:46
PiRK added inline comments to D16465: Seeder: Verify that nodes are on the correct chain.
Jul 15 2024, 07:42
PiRK requested review of D16465: Seeder: Verify that nodes are on the correct chain.
Jul 15 2024, 07:39

Jul 12 2024

PiRK closed D16457: net_processing: move avalanche related args to PeerManager::Options.
Jul 12 2024, 14:30
PiRK committed rABC020c3c10290b: net_processing: move avalanche related args to PeerManager::Options (authored by PiRK).
net_processing: move avalanche related args to PeerManager::Options
Jul 12 2024, 14:30
PiRK closed D16456: net processing: clamp PeerManager::Options user input.
Jul 12 2024, 14:30
PiRK committed rABC83352fab4390: net processing: clamp PeerManager::Options user input (authored by stickies-v <stickies-v@protonmail.com>).
net processing: clamp PeerManager::Options user input
Jul 12 2024, 14:30
PiRK updated the summary of D16456: net processing: clamp PeerManager::Options user input.
Jul 12 2024, 11:43
PiRK updated the summary of D16456: net processing: clamp PeerManager::Options user input.
Jul 12 2024, 11:43
PiRK updated the summary of D16456: net processing: clamp PeerManager::Options user input.
Jul 12 2024, 11:43
PiRK accepted D16458: bugfix, Change up submitpackage results to return results for all transactions.
Jul 12 2024, 11:41
PiRK retitled D16457: net_processing: move avalanche related args to PeerManager::Options from net_processing: move related args to PeerManager::Options to net_processing: move avalanche related args to PeerManager::Options.
Jul 12 2024, 10:57
PiRK requested review of D16457: net_processing: move avalanche related args to PeerManager::Options.
Jul 12 2024, 10:56
PiRK closed D16455: net processing, refactor: Decouple PeerManager from gArgs.
Jul 12 2024, 10:28
PiRK committed rABCcdd9740bd3c3: net processing, refactor: Decouple PeerManager from gArgs (authored by dergoegge <n.goeggi@gmail.com>).
net processing, refactor: Decouple PeerManager from gArgs
Jul 12 2024, 10:28
PiRK requested review of D16456: net processing: clamp PeerManager::Options user input.
Jul 12 2024, 10:04
PiRK accepted D16447: validation: fix coins disappearing mid-package evaluation.
Jul 12 2024, 09:40
PiRK updated the summary of D16455: net processing, refactor: Decouple PeerManager from gArgs.
Jul 12 2024, 09:35
PiRK requested changes to D16447: validation: fix coins disappearing mid-package evaluation.
Jul 12 2024, 09:31
PiRK requested review of D16455: net processing, refactor: Decouple PeerManager from gArgs.
Jul 12 2024, 08:57

Jul 11 2024

PiRK accepted D16444: rpc: Return coinbase flag in scantxoutset.
Jul 11 2024, 15:53
PiRK accepted D16443: test: use MiniWallet for mining_prioritisetransaction.py.
Jul 11 2024, 15:51
PiRK accepted D16445: Bump version to 0.29.9.
Jul 11 2024, 15:35
PiRK accepted D16442: [Chronik] Add `get_block_header` to FFI.

OK, that looks like something I can use.

Jul 11 2024, 15:34

Jul 10 2024

PiRK accepted D16437: [Cashtab] Update comment and TODO in sendXec function.
Jul 10 2024, 06:24

Jul 9 2024

PiRK accepted D16434: upnp: add compatibility for miniupnpc 2.2.8.
Jul 9 2024, 14:59
PiRK accepted D16433: mempool: disallow txns under min relay fee, even in packages.
Jul 9 2024, 12:42

Jul 8 2024

PiRK accepted D16431: test: Move tx creation to create_self_transfer_multi.
Jul 8 2024, 13:27
PiRK accepted D16430: Fix a data race that could prevent the staking reward to be added to the block template when longpoll is used.
Jul 8 2024, 06:37

Jul 6 2024

PiRK accepted D16426: [Cashtab] Replace magic number with const.
Jul 6 2024, 07:57
PiRK requested changes to D16429: Test Commit.

Clearing the review queue
For testing, it is best to use arc diff --draft so that the diff does not appear in the review queue for other contributors.

Jul 6 2024, 07:56

Jul 5 2024

PiRK accepted D16424: test: refactor RPCPackagesTest to use MiniWallet.
Jul 5 2024, 08:27

Jul 4 2024

PiRK closed D16423: [electrum] notify users about release v5.2.14.
Jul 4 2024, 15:32
PiRK committed rABCc27541d024a4: [electrum] notify users about release v5.2.14 (authored by PiRK).
[electrum] notify users about release v5.2.14
Jul 4 2024, 15:32
PiRK requested review of D16423: [electrum] notify users about release v5.2.14.
Jul 4 2024, 13:56
PiRK accepted D16420: test: Return new_utxos from create_self_transfer_multi in MiniWallet.
Jul 4 2024, 11:05
PiRK closed D16422: [electrum] bump the version to 5.2.14 and add release notes.
Jul 4 2024, 09:29
PiRK committed rABCb4d854344b74: [electrum] bump the version to 5.2.14 and add release notes (authored by PiRK).
[electrum] bump the version to 5.2.14 and add release notes
Jul 4 2024, 09:29
PiRK updated the diff for D16422: [electrum] bump the version to 5.2.14 and add release notes.

adjust the release note to match D16421 more closely

Jul 4 2024, 09:24
PiRK accepted D16421: Add a release note for the payment request download bugfix.
Jul 4 2024, 09:21
PiRK requested review of D16422: [electrum] bump the version to 5.2.14 and add release notes.
Jul 4 2024, 09:21
PiRK accepted D16419: test: use MiniWallet for feature_dbcrash.py.
Jul 4 2024, 08:52
PiRK closed D16415: [electrum] add a timeout and max data size when downloading a payment request.
Jul 4 2024, 06:28
PiRK closed D16417: [electrum] move the trivial RequestHandler out of the test case.
Jul 4 2024, 06:28
PiRK committed rABCcd50851eb621: [electrum] add a timeout and max data size when downloading a payment request (authored by PiRK).
[electrum] add a timeout and max data size when downloading a payment request
Jul 4 2024, 06:28
PiRK committed rABCe1eeaedaad51: [electrum] move the trivial RequestHandler out of the test case (authored by PiRK).
[electrum] move the trivial RequestHandler out of the test case
Jul 4 2024, 06:28
PiRK closed D16414: [electrum] remove indentation levels in get_payment_request.
Jul 4 2024, 06:28
PiRK committed rABC6526cf57055d: [electrum] remove indentation levels in get_payment_request (authored by PiRK).
[electrum] remove indentation levels in get_payment_request
Jul 4 2024, 06:28

Jul 3 2024

PiRK accepted D16418: Prevent downloading the payment request if it's larger than the max allowed.
Jul 3 2024, 22:42
PiRK accepted D16413: test: Add diamond-shape prioritisetransaction test.
Jul 3 2024, 19:18
PiRK updated the diff for D16415: [electrum] add a timeout and max data size when downloading a payment request.

use MAX_PAYMENTREQUEST_SIZE = 50000

Jul 3 2024, 19:09
PiRK published D16415: [electrum] add a timeout and max data size when downloading a payment request for review.
Jul 3 2024, 18:43
PiRK requested review of D16417: [electrum] move the trivial RequestHandler out of the test case.
Jul 3 2024, 18:38
PiRK requested review of D16414: [electrum] remove indentation levels in get_payment_request.
Jul 3 2024, 15:12
PiRK accepted D16412: Use a single node in mining_prioritisetransaction.
Jul 3 2024, 13:12
PiRK accepted D16388: [Chronik] Add `ParseChronikParams` and use it in chronik::Start.
Jul 3 2024, 13:07
PiRK accepted D16411: test: MiniWallet: fix fee calculation for P2PK and check tx size.
Jul 3 2024, 09:25
PiRK closed D16393: [electrum] remove server.relay_fee API call.
Jul 3 2024, 06:56
PiRK committed rABC35c39faff542: [electrum] remove server.relay_fee API call (authored by PiRK).
[electrum] remove server.relay_fee API call
Jul 3 2024, 06:56

Jul 2 2024

PiRK updated the diff for D16393: [electrum] remove server.relay_fee API call.

rebase

Jul 2 2024, 20:03
PiRK closed D16406: [electrum] support trezor==0.13.9.
Jul 2 2024, 20:03
PiRK committed rABC9fe5201a05d3: [electrum] support trezor==0.13.9 (authored by PiRK).
[electrum] support trezor==0.13.9
Jul 2 2024, 20:03
PiRK accepted D16408: test: MiniWallet: introduce enum type for output mode.
Jul 2 2024, 20:01
PiRK added inline comments to D16408: test: MiniWallet: introduce enum type for output mode.
Jul 2 2024, 15:57
PiRK accepted D16409: test: use MiniWallet (P2PK mode) for feature_dersig.py.
Jul 2 2024, 14:42
PiRK requested changes to D16408: test: MiniWallet: introduce enum type for output mode.
Jul 2 2024, 14:40
PiRK accepted D16407: test: add P2PK support to MiniWallet.
Jul 2 2024, 14:37