Page MenuHomePhabricator
Feed Advanced Search

Aug 14 2024

emack updated the diff for D16624: [ecash-herald] Update parseOpReturn to recognize authentication txs.

Updated rendered messages

Aug 14 2024, 01:04
emack updated the diff for D16626: [Explorer] Update readme with additional dependency.

Updated dependency

Aug 14 2024, 00:53
emack updated the summary of D16625: Add dust tx authentication prefix to standards doc.
Aug 14 2024, 00:52
emack updated the diff for D16625: Add dust tx authentication prefix to standards doc.

Updated author and payload labelling

Aug 14 2024, 00:46
emack added a comment to D16625: Add dust tx authentication prefix to standards doc.

is there any expected byte length here? what makes it unique? what happens if someone starts broadcasting clones of these txs ... there's no way to guarantee this is unique since it is public.

Aug 14 2024, 00:46

Aug 12 2024

emack requested review of D16626: [Explorer] Update readme with additional dependency.
Aug 12 2024, 15:03
emack accepted D16606: [explorer] Add copy paste button for addresses on transaction page.
Aug 12 2024, 14:59
emack requested review of D16625: Add dust tx authentication prefix to standards doc.
Aug 12 2024, 14:47
emack updated the diff for D16624: [ecash-herald] Update parseOpReturn to recognize authentication txs.

Updated authentication tx msg and added reference to spec

Aug 12 2024, 14:41
emack added inline comments to D16623: [ecash-herald] Update parseOpReturn to recognize paywall payments.
Aug 12 2024, 14:30
emack updated the diff for D16623: [ecash-herald] Update parseOpReturn to recognize paywall payments.

Updated article paywall render to be an explorer link, removed invalid article id renders and added reference to spec.

Aug 12 2024, 14:29
emack requested review of D16624: [ecash-herald] Update parseOpReturn to recognize authentication txs.
Aug 12 2024, 05:33
emack requested review of D16623: [ecash-herald] Update parseOpReturn to recognize paywall payments.
Aug 12 2024, 05:11
emack closed D16620: [Cashtab] Update tx history to parse eCashChat authentication txs.
Aug 12 2024, 04:06
emack committed rABCdd17b5dae543: [Cashtab] Update tx history to parse eCashChat authentication txs (authored by emack).
[Cashtab] Update tx history to parse eCashChat authentication txs
Aug 12 2024, 04:06
emack updated the diff for D16620: [Cashtab] Update tx history to parse eCashChat authentication txs.

version bump

Aug 12 2024, 04:01
emack added inline comments to D16620: [Cashtab] Update tx history to parse eCashChat authentication txs.
Aug 12 2024, 03:59
emack accepted D16621: Update Telegram link on apps/examples/readme.
Aug 12 2024, 01:49

Aug 11 2024

emack added inline comments to D16620: [Cashtab] Update tx history to parse eCashChat authentication txs.
Aug 11 2024, 14:48
emack updated the diff for D16620: [Cashtab] Update tx history to parse eCashChat authentication txs.

Updated comments

Aug 11 2024, 14:48
emack requested changes to D16606: [explorer] Add copy paste button for addresses on transaction page.

Clicking the copy icon for txid at the top gives this

image.png (103×527 px, 9 KB)

Aug 11 2024, 12:31
emack added a comment to D16606: [explorer] Add copy paste button for addresses on transaction page.

@bot preview-explorer

Aug 11 2024, 12:27
emack published D16620: [Cashtab] Update tx history to parse eCashChat authentication txs for review.
Aug 11 2024, 12:26
emack accepted D16618: [mock-chronik-client] Add diff to change log.
Aug 11 2024, 12:20

Aug 9 2024

emack requested changes to D16606: [explorer] Add copy paste button for addresses on transaction page.
Aug 9 2024, 04:37
emack accepted D16555: [token-server] Implement ecash-lib for tx building.
Aug 9 2024, 04:30

Aug 2 2024

emack closed D16512: [Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat.
Aug 2 2024, 05:00
emack committed rABC9975eba9a1ed: [Cashtab] Update TxHistory to recognize article post and article reply txs from… (authored by emack).
[Cashtab] Update TxHistory to recognize article post and article reply txs from…
Aug 2 2024, 05:00

Jul 31 2024

emack planned changes to D16558: [Cashtab] Render paywall id directly as hex.
Jul 31 2024, 09:56
emack published D16558: [Cashtab] Render paywall id directly as hex for review.
Jul 31 2024, 09:49

Jul 30 2024

emack updated the diff for D16512: [Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat.

version bump

Jul 30 2024, 14:12
emack closed D16553: [Cashtab] Reinstate paywall article link.
Jul 30 2024, 14:08
emack committed rABC838ac730812e: [Cashtab] Reinstate paywall article link (authored by emack).
[Cashtab] Reinstate paywall article link
Jul 30 2024, 14:08
emack updated the diff for D16553: [Cashtab] Reinstate paywall article link.

version bump

Jul 30 2024, 14:04
emack updated the diff for D16512: [Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat.

Added stackArray size check and updated int tests

Jul 30 2024, 14:00
emack published D16553: [Cashtab] Reinstate paywall article link for review.
Jul 30 2024, 13:34
emack accepted D16328: [Cashtab] Support NFT trading.

Accepted subject to a decision on plugin use vs current implementation

Jul 30 2024, 06:00

Jul 26 2024

emack requested changes to D16328: [Cashtab] Support NFT trading.

On a semi related note, not for this diff, but if you try to use a non-jpg/png file (e.g. webp) for the NFT collection it crashes the app (blank white screen), with the console spitting out TypeError: Cannot read properties of undefined (reading 'size').

Jul 26 2024, 15:27

Jul 25 2024

emack added inline comments to D16328: [Cashtab] Support NFT trading.
Jul 25 2024, 23:55

Jul 22 2024

emack abandoned D16516: [Cashtab] Add maintenance mode with config toggle.
Jul 22 2024, 21:32
emack planned changes to D16516: [Cashtab] Add maintenance mode with config toggle.
Jul 22 2024, 13:45
emack added inline comments to D16516: [Cashtab] Add maintenance mode with config toggle.
Jul 22 2024, 13:34
emack updated the diff for D16516: [Cashtab] Add maintenance mode with config toggle.

Moved maintenance toggle to .env, removed ETA in messaging and the unnecessary reference to funds

Jul 22 2024, 13:33
emack planned changes to D16516: [Cashtab] Add maintenance mode with config toggle.
Jul 22 2024, 12:23
emack updated the diff for D16516: [Cashtab] Add maintenance mode with config toggle.

Updated message

Jul 22 2024, 12:22
emack published D16516: [Cashtab] Add maintenance mode with config toggle for review.
Jul 22 2024, 12:17
emack closed D16514: [Cashtab] version bump for D16513.
Jul 22 2024, 08:59
emack committed rABC699f81ab9e63: [Cashtab] version bump for D16513 (authored by emack).
[Cashtab] version bump for D16513
Jul 22 2024, 08:59
emack requested review of D16514: [Cashtab] version bump for D16513.
Jul 22 2024, 08:52
emack closed D16513: [Cashtab] Remove article hyperlink.
Jul 22 2024, 08:21
emack committed rABC8477ea119600: [Cashtab] Remove article hyperlink (authored by emack).
[Cashtab] Remove article hyperlink
Jul 22 2024, 08:21
emack published D16513: [Cashtab] Remove article hyperlink for review.
Jul 22 2024, 08:20

Jul 21 2024

emack published D16512: [Cashtab] Update TxHistory to recognize article post and article reply txs from eCashChat for review.
Jul 21 2024, 16:12
emack accepted D16511: [Cashtab] Update README to reflect current deployment requirements.
Jul 21 2024, 03:32
emack added a comment to D16510: [Cashtab] Patch dockerfile to build ecash-agora correctly.

Semi-related nit: Update CONTRIBUTING.md to run this docker build -f cashtab.Dockerfile -t cashtab_local . before you can hop into the Cashtab repo and run docker-compose build, otherwise it will fail due to no config files. Alternatively just add this step to Cashtab README's dependency paragraph in the Development section.

Jul 21 2024, 01:58
emack accepted D16510: [Cashtab] Patch dockerfile to build ecash-agora correctly.

Semi-related nit: Update CONTRIBUTING.md to run this docker build -f cashtab.Dockerfile -t cashtab_local . before you can hop into the Cashtab repo and run docker-compose build, otherwise it will fail due to no config files. Alternatively just add this step to Cashtab README's dependency paragraph in the Development section.

Jul 21 2024, 01:55

Jul 20 2024

emack accepted D16509: [Cashtab] Show option to claim token reward from Home page if wallet is new.

Accepted with minor nit

Jul 20 2024, 15:09
emack accepted D16496: [Cashtab] Add ecash-agora lib and helper methods.
Jul 20 2024, 14:41

Jul 18 2024

emack accepted D16495: [Cashtab] New validation function for user input NFT list price.
Jul 18 2024, 17:13
emack requested changes to D16496: [Cashtab] Add ecash-agora lib and helper methods.
Jul 18 2024, 09:53
emack added inline comments to D16495: [Cashtab] New validation function for user input NFT list price.
Jul 18 2024, 09:22
emack requested changes to D16495: [Cashtab] New validation function for user input NFT list price.
Jul 18 2024, 09:19
emack accepted D16492: [Cashtab] Add chronik method to get all tx history by lokad id.

minor nit

Jul 18 2024, 09:12

Jul 15 2024

emack requested changes to D16462: [Cashtab] Copy amounts on clikc.

The actual change itself is not as described, you're merely fixing a typo - then title it as such.
You need to fix the linting errors before pushing. Do an arc lint locally.
Test plan needs to be something the reviewer can follow easily easily e.g.

  1. npm test
  2. click here, check blah...
Jul 15 2024, 05:14

Jul 13 2024

emack accepted D16461: [Cashtab] Special handling for tx inputs that are required and do not require wallet signature.
Jul 13 2024, 07:15
emack closed D16459: [Cashtab] Update paywall article link.
Jul 13 2024, 07:02
emack committed rABC0f69d70a11ba: [Cashtab] Update paywall article link (authored by emack).
[Cashtab] Update paywall article link
Jul 13 2024, 07:02
emack added inline comments to D16459: [Cashtab] Update paywall article link.
Jul 13 2024, 06:58
emack updated the diff for D16459: [Cashtab] Update paywall article link.

Version bump

Jul 13 2024, 06:57

Jul 12 2024

emack published D16459: [Cashtab] Update paywall article link for review.
Jul 12 2024, 14:44

Jul 11 2024

emack accepted D16440: [Cashtab] Replace 546 magic number with dust const.
Jul 11 2024, 00:09

Jul 10 2024

emack accepted D16436: [Cashtab] Only add inputs to a tx if you need them.
Jul 10 2024, 12:53
emack added inline comments to D16436: [Cashtab] Only add inputs to a tx if you need them.
Jul 10 2024, 11:45
emack requested changes to D16436: [Cashtab] Only add inputs to a tx if you need them.
Jul 10 2024, 11:38
emack added a comment to D16437: [Cashtab] Update comment and TODO in sendXec function.

@bot cashtab-tests

Jul 10 2024, 03:05

Jul 9 2024

emack accepted D16427: [Cashtab] Build all targetOutputs with script instead of address key.
Jul 9 2024, 13:53

Jun 12 2024

emack accepted D16325: [Cashtab] Link backup wallet warning to wallet backup screen.
Jun 12 2024, 01:46
emack accepted D16324: [Cashtab] Remove "webapp tx request" warning.
Jun 12 2024, 01:43

Jun 8 2024

emack accepted D16287: [Cashtab] Support copying full amount.
Jun 8 2024, 00:20

Jun 7 2024

emack requested changes to D16287: [Cashtab] Support copying full amount.

Tested all ok but I think the icon should be available even in uncollapsed state, otherwise if the user/merchant needs to copy a large number of txs for book keeping then that extra click to reveal the copy icon adds up.

Jun 7 2024, 00:27

Jun 4 2024

emack accepted D16271: [Cashtab] Update README to advise of local dependencies.
Jun 4 2024, 14:45
emack added a comment to D16261: [Cashtab] Modify extension manifest to support wasm.

The above build order should probably be in one of the 3 module's README, given how the dependencies are relative now.

Jun 4 2024, 07:37
emack accepted D16261: [Cashtab] Modify extension manifest to support wasm.
cd modules/ecash-lib-wasm
./dockerbuild.sh
cd ../ecash-lib
npm run build
cd ../../cashtab
npm run extension

Yup it was this order of build that fixed the issue. Loaded extension manually and works fine.

Jun 4 2024, 07:23

Jun 1 2024

emack requested changes to D16261: [Cashtab] Modify extension manifest to support wasm.

The local extension build fails as it can't find ecash-lib, even after I've npm ci'ed already. I assume this is likely to be a relative path issue?

image.png (599×854 px, 83 KB)

Jun 1 2024, 02:13

May 30 2024

emack accepted D16247: [website] Change title on landing page copy.

Clarified on tg, duplicated text found in https://e.cash/wealth-redefined

May 30 2024, 13:09
emack requested changes to D16247: [website] Change title on landing page copy.

The reason why I removed the last sentence is because it will be retained in the "about" page

May 30 2024, 03:43

May 29 2024

emack accepted D16237: [Cashtab] Show full-height screen with no nav footer for onboarding page.
May 29 2024, 02:21

May 27 2024

emack closed D16218: [Cashtab] Update tx history to recognize paywall payments.
May 27 2024, 00:16
emack committed rABC9ae5f3a3ac7d: [Cashtab] Update tx history to recognize paywall payments (authored by emack).
[Cashtab] Update tx history to recognize paywall payments
May 27 2024, 00:16

May 26 2024

emack updated the diff for D16218: [Cashtab] Update tx history to recognize paywall payments.

Removed redundant utf8 param and added integration test for invalid paywall transaction.

May 26 2024, 13:32

May 25 2024

emack updated the summary of D16218: [Cashtab] Update tx history to recognize paywall payments.
May 25 2024, 13:18
emack updated the diff for D16218: [Cashtab] Update tx history to recognize paywall payments.

Updated paywall description to render an explorer link to the paywalled article

May 25 2024, 12:45

May 24 2024

emack updated the summary of D16218: [Cashtab] Update tx history to recognize paywall payments.
May 24 2024, 04:41
emack requested review of D16218: [Cashtab] Update tx history to recognize paywall payments.
May 24 2024, 04:39

May 21 2024

emack closed D16188: [OP_RETURN Prefix] Paywall payment prefix.
May 21 2024, 12:47
emack committed rABCd953088e8a8e: [OP_RETURN Prefix] Paywall payment prefix (authored by emack).
[OP_RETURN Prefix] Paywall payment prefix
May 21 2024, 12:47

May 20 2024

emack updated the summary of D16188: [OP_RETURN Prefix] Paywall payment prefix.
May 20 2024, 13:45
emack requested review of D16188: [OP_RETURN Prefix] Paywall payment prefix.
May 20 2024, 13:33

May 8 2024

emack accepted D16119: [chronik-client] Support websocket subscriptions to tokenId.
May 8 2024, 21:31
emack accepted D16123: [Cashtab] Debounce wallet select.

Debounces all ok on mobile and desktop 👍

May 8 2024, 03:02