Fix a typo and update the summary to better explain the rationale

Rename to gettransactionstatus

In D16645#377217, @tobias_ruck wrote:

Another possible name would be gettransactionstatus; you already say this in the release notes: "retrieve the status of a non-mined transaction". It would (kinda) imply that the RPC should return "mined" for mined txs (which we can't do in the general case because the -txindex can be disabled). So either it looks that up (and returns "unknown" if the txindex is off), or the name could also be gettransactionstatusinmemory, which is I think the most precise, albeit a bit long.

Note I might change the RPC name if I can find a better one

Fix the README and remove the confusing FIXME comment

Sum of nits, globally ok

Fix a typo

Let's update the message with better usability in another diff, that's already an improvement

In D16627#376909, @bytesofman wrote:

In D16627#376897, @Fabien wrote:

Update ecash-herald, token-server, and Cashtab to handle this new type.

Because you aliased ChronikNodeClient this can (and should) be done in subsequent diffs.

Backed out the ChronikClientNode to ChronikClient name change in associated apps -- however some code changes are still required due to changes in the type names.

...These could also be aliasesd but imo not worth it. I don't think keeping a handful of types clean is worth supporting "Everything has two names" for some indefinite period of time.

This change will be caught by linters by anyone who upgrades chronik-client.

@bot preview-explorer

Update ecash-herald, token-server, and Cashtab to handle this new type.

Is this specific to some screen size ? On my monitor it just makes the animation appear slightly off center offset to the bottom. I have no issue with the current version also.

@bot preview-e.cash

I think some of these examples can still be useful to maintain but not as part of the functional tests nor independently, but as part of chronik-docs (like a minimal wallet).

In D16629#376598, @bytesofman wrote:

In D16629#376587, @teamcity wrote:

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

test failure related to tests no longer existing. this is removed in the yml but not picked up by existing CI

I mostly agree with the deprecation plan except for 1 thing: you should alias ChronikClientNode to ChronikClient. This makes it so that you don't need to update the libs that use ChronikClientNode (can be moved in their own diff). It also release pressure on devs to update as their current in-node chronik code will keep working with the new version.

I think such a small change should just be inlined, it doesn't bring any value on its own.

Look at your own test, is that really what you would expect to be printed by the herald ? Start with what it should look like first

In D16611#376298, @bytesofman wrote:

In D16611#376253, @Fabien wrote:

Any chance we can have the icon also on transactions page (or is there any reason why you didn't do it) ?

added to the Address page

I looked at also adding it to the transactions table -- e.g. on the block page -- this though requires a different implementation. I don't think it would be that complicated, but might need to repeat the url constant as this table is built by a JS file and not the template. I don't think we really need it there though.

In D16606#376385, @bytesofman wrote:

In D16606#376342, @emack wrote:

Clicking the copy icon for txid at the top gives this

Whilst clicking the copy icon for the addresses triggers the tooltip but no response. Have verified address has not been copied to clipboard.

Ok I was able to repeat this in a diff that makes no changes from master except a token test text change

D16622

So -- there is some issue where the JS does not work on explorer previews, prob related to not being https, would have to troubleshoot -- anyway not related to this diff

test with cargo run locally

@bot preview-explorer

This doesn't work for me. I see the icon and the tooltip but on click I get TypeError: navigator.clipboard is undefined (Firefox on linux)

@bot preview-explorer

Any chance we can have the icon also on transactions page (or is there any reason why you didn't do it) ?

I don't think this is a good change. It seems more useful and more the expected behavior for a token transaction to show the token address, and the simplification is not a big gain in this case. I get the point that you can select your address format in the address page but I don't think it compensates for the annoyance.

@bot preview-explorer

@bot preview-explorer

See another approach in D16596. This avoids nicknames for miners that are anonymous and also prevent the need for maintenance/special casing entirely.