Feedback

Feedback

Feedback + remove the 18th block in the test, this is confusing for no reason as block[0] is the previous block as per the GetNextRTTWorkRequired call.

Crazy this went unnoticed for so long

@bot preview-e.cash

In D16724#379426, @johnkuney wrote:

Well yeah I havent added any rust code yet cause I dont know it!
I did try messing with the config.toml and the templating, but was guessing my way through. Base.html doesnt use a template currently afaict
How can you do it without using the templating? Is there a simple way to access a config variable in base.html that I'm missing?

EDA -> DAA

Improve comment on the windows selection

Rebase, return all 4 header times in gbt, return the RTT as compact since the previous rationale no longer holds

Rebase, feedback and minor adaptation to accomodate the new algo

Typo

Update the algorithm

That's not our standard copyright

In D16724#379417, @johnkuney wrote:

Any specific tips how to make that? I'm still not up to speed on any rust programming

In D16724#379415, @johnkuney wrote:

Okay made some adjustments.
Im not to sure how to execute your second point though, to have it be in the config...The idea there is to only have it show if someone explicitly says so in the config and runs it themselves? but for the normal user this will not be shown?

Got offline feedback that deserves looking at a design update

Ideally would add to the testnet page as well...Im not sure where that one is maintained

Guess what: this is the same explorer code :) So the selection should reflect whether it's mainnet or testnet. You can look at the url or use the config file which has an chain parameter (see server.rs).
I suggest also that this feature is behind a config flag or an environment variable, because it makes it more convenient to reuse if it's off by default. This is quite specialized for our needs.

Fix react live scope

In D16710#378972, @bytesofman wrote:

In D16710#378970, @Fabien wrote:

Is it semver compatible to remove the alias without a major version bump ? If yes then it's fine and we can remove it with a minor version change. Otherwise we should remove the alias when publishing this major version.

semver is pretty loosely defined, and we are still at an early stage in this repo. "technically" it should be a major version change. but we have already neglected a major version bump for a breaking change before in the chronik-client module.

"1.0.0" is more like "ok, we are now starting to add features exclusively for the in-node version" -- so, a potential opportunity to bump.

if we keep ChronikClientNode alias here, it will probably stay for years, then unexpectedly break something down the line when another dev removes the "dead" code...so I am open to just taking it out and dealing with the handful of impacted parties rightnow.

decision to major or minor bump is more aesthetic at this point. chronik-client has 11 weekly downloads on npm.

In D16710#378968, @bytesofman wrote:

In D16710#378964, @teamcity wrote:

Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Tail of the build log:

    os.makedirs(tmpdir)
  File "/usr/lib/python3.9/os.py", line 225, in makedirs
    mkdir(name, mode)
FileExistsError: [Errno 17] File exists: '/work/abc-ci-builds/ecash-lib-integration-tests/test/tmp/test_runner_₿₵_🏃_20240904_175710'
Test runner completed with code 1
----------------------------|---------|----------|---------|---------|------------------------------
File                        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s            
----------------------------|---------|----------|---------|---------|------------------------------
All files                   |   62.22 |    52.47 |   62.44 |    62.2 |                              
 ecash-lib                  |       0 |        0 |       0 |       0 |                              
  eslint.config.js          |       0 |        0 |       0 |       0 |                              
 ecash-lib/src              |    71.5 |    54.71 |    72.5 |    71.1 |                              
  consts.ts                 |       0 |      100 |     100 |       0 | 6-8                          
  ecc.ts                    |   57.14 |    83.33 |      40 |   57.14 | 23-31                        
  hash.ts                   |   88.88 |    83.33 |      80 |   88.88 | 14                           
  index.ts                  |       0 |        0 |       0 |       0 |                              
  indexBrowser.ts           |       0 |        0 |       0 |       0 |                              
  indexNodeJs.ts            |       0 |        0 |       0 |       0 |                              
  initBrowser.ts            |       0 |      100 |       0 |       0 | 11-13                        
  initNodeJs.ts             |     100 |      100 |     100 |     100 |                              
  op.ts                     |      40 |    44.44 |   66.66 |      40 | ...4,107,109,117-122,133-161 
  opcode.ts                 |     100 |    83.33 |     100 |     100 | 1                            
  script.ts                 |   52.63 |    38.09 |      60 |    50.9 | ...4-135,146,156,166,188-199 
  sigHashType.ts            |   77.77 |       44 |   85.71 |   77.77 | 26-38                        
  tx.ts                     |   93.47 |    79.16 |    90.9 |   93.18 | 123-125                      
  txBuilder.ts              |   56.17 |    48.14 |   69.23 |   54.65 | ...3-107,139-183,206,236-240 
  unsignedTx.ts             |    73.8 |    57.14 |   78.57 |   74.07 | ...3,151,159,184,192,198-201 
 ecash-lib/src/ffi          |   28.26 |    15.94 |   16.98 |   28.98 |                              
  ecash_lib_wasm_browser.js |       0 |        0 |       0 |       0 | 3-336                        
  ecash_lib_wasm_nodejs.js  |    61.9 |       55 |   39.13 |   62.75 | ...1,197-215,237,250-251,255 
 ecash-lib/src/io           |   59.55 |    60.29 |   70.58 |   58.77 |                              
  bytes.ts                  |     7.4 |    71.42 |    12.5 |     7.4 | 13-64                        
  hex.ts                    |   82.05 |     62.5 |      80 |   82.35 | 41-45,50,58                  
  int.ts                    |       0 |        0 |       0 |       0 |                              
  str.ts                    |   85.71 |    83.33 |   66.66 |   85.71 | 15                           
  varsize.ts                |      32 |    36.36 |   66.66 |      32 | 14-24,40-47                  
  writer.ts                 |       0 |        0 |       0 |       0 |                              
  writerbytes.ts            |   83.33 |    68.42 |     100 |   83.33 | 33,43,53,63,79               
  writerlength.ts           |     100 |    83.33 |     100 |     100 | 1                            
 ecash-lib/src/test         |   87.67 |    54.34 |    87.5 |   88.23 |                              
  testRunner.ts             |   87.67 |    54.34 |    87.5 |   88.23 | 71-73,86-87,110,121,164      
 ecash-lib/src/token        |   87.15 |    72.85 |   93.33 |   87.07 |                              
  alp.ts                    |   82.92 |    89.47 |   83.33 |   82.92 | 110-123,142                  
  common.ts                 |     100 |    83.33 |     100 |     100 | 1                            
  empp.ts                   |    92.3 |       75 |     100 |   91.66 | 12                           
  slp.ts                    |   89.74 |    62.16 |     100 |   89.74 | ...9,161,167,175,178,197,202 
----------------------------|---------|----------|---------|---------|------------------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='776']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='1247']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='244']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='465']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='133']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='213']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='757']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='1217']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/ecash-lib-integration-tests-junit.xml': No such file or directory
Build ecash-lib-integration-tests failed with exit code 1

flakiness here looks potentially CI related, tho I am not sure really. Re-running to test.

Is it semver compatible to remove the alias without a major version bump ? If yes then it's fine and we can remove it with a minor version change. Otherwise we should remove the alias when publishing this major version.

This memory is important so that nodes can reply to stake contender avalanche requests of recent past blocks (we cannot guarantee the entire network has finalized the same block in lock step).

Is it really ? If a block has finalized for some nodes but not others, what is the point of voting on past block rewards ? If the node votes idk the block will eventually be finalized by the poller anyway so the outcome of this stake vote doesn't matter. The only case I think it is helpful is if you get a bunch of blocks in a row, faster than finalization time. But as soon as a block is final you can forget about winners for it and past blocks.

@bot electrum-functional-tests

Use local chronik

Make sure the index has synced in test

string layout

mined_in_block -> block

Rebase and rename gettransactionpool -> gettransactionstatus