Page MenuHomePhabricator
Feed Advanced Search

Sep 23 2024

Fabien requested review of D16803: [chronik] Add an avalanche invalidated block ws message.
Sep 23 2024, 15:59
Fabien requested review of D16802: [avalanche] Add a block invalidated validation callback.
Sep 23 2024, 14:35
Fabien accepted D16800: [chronik] better use the merkle tree cache.
Sep 23 2024, 14:34
Fabien requested review of D16801: Lock cs_main when calling the block finalized validation interface.
Sep 23 2024, 14:24
Fabien accepted D16798: p2p: Ensure transaction announcements are only queued for fully connected peers.
Sep 23 2024, 08:16
Fabien accepted D16796: net: Set relay in version msg to peers with relay permission.
Sep 23 2024, 08:10
Fabien accepted D16797: net: Avoid SetTxRelay for feeler connections.
Sep 23 2024, 08:10
Fabien accepted D16795: refactor: Introduce PeerManagerImpl::RejectIncomingTxs.
Sep 23 2024, 08:05
Fabien updated the diff for D16791: Store the last 20 headers reception time to a file.

Rebase and fix typo

Sep 23 2024, 07:34

Sep 21 2024

Fabien updated the diff for D16791: Store the last 20 headers reception time to a file.

Document -persistrecentheaderstime

Sep 21 2024, 07:52

Sep 20 2024

Fabien planned changes to D16791: Store the last 20 headers reception time to a file.

The option should not be hidden

Sep 20 2024, 20:22
teamcity awarded D16791: Store the last 20 headers reception time to a file a Piece of Eight token.
Sep 20 2024, 14:46
Fabien added a comment to D16791: Store the last 20 headers reception time to a file.

@bot build-diff

Sep 20 2024, 14:46
Fabien closed D16794: Interleave the debug.log with the unit test log when run via ninja.
Sep 20 2024, 11:36
Fabien committed rABCa7ca07264935: Interleave the debug.log with the unit test log when run via ninja (authored by Fabien).
Interleave the debug.log with the unit test log when run via ninja
Sep 20 2024, 11:36
teamcity awarded D16791: Store the last 20 headers reception time to a file a Haypence token.
Sep 20 2024, 11:34
Fabien added a comment to D16791: Store the last 20 headers reception time to a file.

@bot build-diff

Sep 20 2024, 11:34
Fabien requested changes to D16782: [avalanche] Implement cleanup for stake contender cache.

I see your test doesn't check for contiguous heights, you should add that

Sep 20 2024, 09:52
Fabien accepted D16793: [avalanche] Use block index instead of blockhash for adding contenders to the cache.
Sep 20 2024, 09:47
Fabien accepted D16792: [avalanche] Cleanup unneeded variable in contender cache test.
Sep 20 2024, 09:45
Fabien updated the diff for D16791: Store the last 20 headers reception time to a file.

Rebase on top of D16794, hopefully to test will fail

Sep 20 2024, 09:44
Fabien requested review of D16794: Interleave the debug.log with the unit test log when run via ninja.
Sep 20 2024, 09:23
Fabien added inline comments to D16791: Store the last 20 headers reception time to a file.
Sep 20 2024, 08:22
Fabien updated the diff for D16791: Store the last 20 headers reception time to a file.

Improve logging + feedback

Sep 20 2024, 08:09

Sep 19 2024

Fabien requested review of D16791: Store the last 20 headers reception time to a file.
Sep 19 2024, 23:41
Fabien accepted D16724: [explorer] add testnet toggle in menu bar.
Sep 19 2024, 23:33
Fabien requested changes to D16724: [explorer] add testnet toggle in menu bar.
Sep 19 2024, 19:33
Fabien closed D16785: [chronik-doc] Use the local node for the examples.
Sep 19 2024, 12:27
Fabien committed rABC346a6701a008: [chronik-doc] Use the local node for the examples (authored by Fabien).
[chronik-doc] Use the local node for the examples
Sep 19 2024, 12:27
Fabien requested review of D16785: [chronik-doc] Use the local node for the examples.

The dir goes into baseUrl

Sep 19 2024, 12:25
Fabien requested changes to D16724: [explorer] add testnet toggle in menu bar.
Sep 19 2024, 12:00
Fabien accepted D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint.
Sep 19 2024, 11:44
Fabien updated the diff for D16785: [chronik-doc] Use the local node for the examples.

Update the URLs scheme

Sep 19 2024, 11:38
Fabien updated the summary of D16785: [chronik-doc] Use the local node for the examples.
Sep 19 2024, 11:37
Fabien accepted D16787: [net processing] Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started.
Sep 19 2024, 09:42

Sep 18 2024

Fabien added a comment to D16724: [explorer] add testnet toggle in menu bar.

Regarding the config this looks good at first glance

Sep 18 2024, 21:24
Fabien added a comment to D16724: [explorer] add testnet toggle in menu bar.

Would it be possible to actually switch between testnet and mainnet instead of just urls?
Like what makes it run testnet? you need to change the chain parameter and the chronik instance in the config? But I guess it would require a recompile so maybe not doable?

Also how useful will this actually be, if we are not going to have it on explorer.e.cash? The scenario would be you are on texplorer.fabien.cash and then hit the switch and go to explorer.e.cash with no switcher....what is it solving?

Sep 18 2024, 21:22
Fabien planned changes to D16785: [chronik-doc] Use the local node for the examples.

let's use a more user friendly url

Sep 18 2024, 20:01
Fabien requested review of D16785: [chronik-doc] Use the local node for the examples.
Sep 18 2024, 19:46
Fabien requested changes to D16782: [avalanche] Implement cleanup for stake contender cache.
Sep 18 2024, 19:05
Fabien accepted D16779: [avalanche] Add missing const to getWinners.
Sep 18 2024, 18:54
Fabien abandoned D16699: Update chronik documentation after NNG deprecation.

imo D16750 is closer to landing now -- are ok with the approach used in D16750? If so, abandon here and I'll land there.

Sep 18 2024, 13:11
Fabien closed D16776: [avalanche] Fix a lock-order issue when adding a tx to the poll.
Sep 18 2024, 11:57
Fabien committed rABC6051840145d7: [avalanche] Fix a lock-order issue when adding a tx to the poll (authored by Fabien).
[avalanche] Fix a lock-order issue when adding a tx to the poll
Sep 18 2024, 11:57
Fabien requested review of D16776: [avalanche] Fix a lock-order issue when adding a tx to the poll.
Sep 18 2024, 09:12
Fabien closed D16757: [avalanche] Vote on conflicting txs.
Sep 18 2024, 07:46
Fabien committed rABC6e61b8cf6581: [avalanche] Vote on conflicting txs (authored by Fabien).
[avalanche] Vote on conflicting txs
Sep 18 2024, 07:46

Sep 17 2024

Fabien committed rABC3740a55a700d: Return the RTT parameters in the block template (authored by Fabien).
Return the RTT parameters in the block template
Sep 17 2024, 20:34
Fabien closed D16730: Return the RTT parameters in the block template.
Sep 17 2024, 20:34
Fabien closed D16729: Reject blocks that violate the real time target policy.
Sep 17 2024, 20:34
Fabien committed rABC8356480e591e: Reject blocks that violate the real time target policy (authored by Fabien).
Reject blocks that violate the real time target policy
Sep 17 2024, 20:34
Fabien closed D16773: Compute the real-time hash target for the next block.
Sep 17 2024, 20:34
Fabien committed rABCc40a40c05424: Compute the real-time hash target for the next block (authored by Fabien).
Compute the real-time hash target for the next block
Sep 17 2024, 20:34
Fabien updated the summary of D16757: [avalanche] Vote on conflicting txs.
Sep 17 2024, 19:57
Fabien updated the diff for D16730: Return the RTT parameters in the block template.

Rebase

Sep 17 2024, 19:43
Fabien updated the diff for D16729: Reject blocks that violate the real time target policy.

Move difftime where it's used, rebase

Sep 17 2024, 19:42
Fabien updated the summary of D16729: Reject blocks that violate the real time target policy.
Sep 17 2024, 19:41
Fabien requested review of D16773: Compute the real-time hash target for the next block.
Sep 17 2024, 19:38
Fabien closed D16772: Revert "Compute the real-time hash target for the next block".
Sep 17 2024, 19:33
Fabien added a reverting change for D16728: Compute the real-time hash target for the next block: rABCc116e0e02b0c: Revert "Compute the real-time hash target for the next block".
Sep 17 2024, 19:33
Fabien added a reverting change for rABCccfbdd5df5fe: Compute the real-time hash target for the next block: rABCc116e0e02b0c: Revert "Compute the real-time hash target for the next block".
Sep 17 2024, 19:33
Fabien committed rABCc116e0e02b0c: Revert "Compute the real-time hash target for the next block" (authored by Fabien).
Revert "Compute the real-time hash target for the next block"
Sep 17 2024, 19:33
Fabien requested review of D16772: Revert "Compute the real-time hash target for the next block".
Sep 17 2024, 19:24
Fabien added a reverting change for D16728: Compute the real-time hash target for the next block: D16772: Revert "Compute the real-time hash target for the next block".
Sep 17 2024, 19:24
Fabien added a reverting change for rABCccfbdd5df5fe: Compute the real-time hash target for the next block: D16772: Revert "Compute the real-time hash target for the next block".
Sep 17 2024, 19:24
Fabien closed D16728: Compute the real-time hash target for the next block.
Sep 17 2024, 19:17
Fabien committed rABCccfbdd5df5fe: Compute the real-time hash target for the next block (authored by Fabien).
Compute the real-time hash target for the next block
Sep 17 2024, 19:17
Fabien accepted D16770: [Cashtab] NFT token loading syntax patch.

TIL

Sep 17 2024, 19:16
Fabien requested changes to D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint.
Sep 17 2024, 19:14
Fabien accepted D16759: [Cashtab] Toggle "buy nfts" and "manage nfts" for better user presentation.
Sep 17 2024, 13:40
Fabien accepted D16733: [Iguana] Add `ScriptInterpreter` class, make `EvalScript` use it.
Sep 17 2024, 10:06
Fabien requested changes to D16745: [ecash-agora] Partial Agora offers: Add SLP support to plugin, `Agora` and `AgoraOffer`.
Sep 17 2024, 10:04
Fabien requested changes to D16733: [Iguana] Add `ScriptInterpreter` class, make `EvalScript` use it.
Sep 17 2024, 09:42
Fabien requested changes to D16733: [Iguana] Add `ScriptInterpreter` class, make `EvalScript` use it.
Sep 17 2024, 08:24
Fabien added a comment to D16733: [Iguana] Add `ScriptInterpreter` class, make `EvalScript` use it.

@bot build-bench build-fuzzer

Sep 17 2024, 07:42
Fabien closed D16767: Add methods to get a transaction and the conflicting ones from the tx pool.
Sep 17 2024, 07:23
Fabien committed rABC6ca16802c0e0: Add methods to get a transaction and the conflicting ones from the tx pool (authored by Fabien).
Add methods to get a transaction and the conflicting ones from the tx pool
Sep 17 2024, 07:23
Fabien updated the diff for D16757: [avalanche] Vote on conflicting txs.

Updated the summary to avoid confusion, fixed the typo and added a comment about the rejected finalized tx being a safety net

Sep 17 2024, 07:08
Fabien updated the summary of D16757: [avalanche] Vote on conflicting txs.
Sep 17 2024, 07:04

Sep 16 2024

Fabien updated the diff for D16757: [avalanche] Vote on conflicting txs.

Remove unecessary header

Sep 16 2024, 19:00
Fabien updated the summary of D16757: [avalanche] Vote on conflicting txs.
Sep 16 2024, 18:58
Fabien updated the diff for D16757: [avalanche] Vote on conflicting txs.

Rebase on D16767

Sep 16 2024, 18:58
Fabien requested review of D16767: Add methods to get a transaction and the conflicting ones from the tx pool.
Sep 16 2024, 18:57
Fabien accepted D16756: [test framework] add a python implementation for merkle trees.
Sep 16 2024, 17:53
Fabien planned changes to D16757: [avalanche] Vote on conflicting txs.

Will add unit tests for GetTx and GetConflictTx, and maybe split this out

Sep 16 2024, 13:01
Fabien closed D16765: Bump version to 0.29.13.
Sep 16 2024, 12:57
Fabien committed rABCc6f626334aff: Bump version to 0.29.13 (authored by Fabien).
Bump version to 0.29.13
Sep 16 2024, 12:57
Fabien accepted D16766: [Iguana] Move ConditionStack to conditionstack.h.
Sep 16 2024, 12:29
Fabien requested changes to D16766: [Iguana] Move ConditionStack to conditionstack.h.
Sep 16 2024, 12:08
Fabien requested changes to D16756: [test framework] add a python implementation for merkle trees.
Sep 16 2024, 12:04
Fabien requested changes to D16756: [test framework] add a python implementation for merkle trees.
Sep 16 2024, 08:09
Fabien requested review of D16765: Bump version to 0.29.13.
Sep 16 2024, 07:53

Sep 13 2024

Fabien accepted D16758: [Cashtab] Extension version bump.
Sep 13 2024, 18:36
Fabien updated the diff for D16757: [avalanche] Vote on conflicting txs.

Fix the bitcoin-chainstate build, and fix python f-string fol older python versions

Sep 13 2024, 16:05
Fabien requested review of D16757: [avalanche] Vote on conflicting txs.
Sep 13 2024, 12:42
Fabien accepted D16754: [ecash-agora] Limit token truncation level to 5 (SLP) and 3 (ALP).
Sep 13 2024, 10:06
Fabien accepted D16752: [ecash-herald] Organize token send txs by token.
Sep 13 2024, 10:05
Fabien requested review of D16729: Reject blocks that violate the real time target policy.
Sep 13 2024, 07:12

Sep 12 2024

Fabien updated the diff for D16730: Return the RTT parameters in the block template.

Remove unnecessary list access and comment on get_ava_p2p_interface mining a block

Sep 12 2024, 14:32
Fabien updated the diff for D16728: Compute the real-time hash target for the next block.

Fix typo

Sep 12 2024, 14:30